Re: RFR: JDK-8325148: Enable restricted javac warning in java.base [v2]

2024-02-02 Thread Magnus Ihse Bursie
On Thu, 1 Feb 2024 22:19:26 GMT, Joe Darcy wrote: >> The restricted javac warning is disabled for java.base, but could be enabled >> by suppressing the warning in a handful of files. > > Joe Darcy has updated the pull request incrementally with one additional > commit since the last revision:

Re: RFR: JDK-8325148: Enable restricted javac warning in java.base [v2]

2024-02-01 Thread Per Minborg
On Thu, 1 Feb 2024 22:19:26 GMT, Joe Darcy wrote: >> The restricted javac warning is disabled for java.base, but could be enabled >> by suppressing the warning in a handful of files. > > Joe Darcy has updated the pull request incrementally with one additional > commit since the last revision:

Re: RFR: JDK-8325148: Enable restricted javac warning in java.base [v2]

2024-02-01 Thread Maurizio Cimadamore
On Thu, 1 Feb 2024 22:19:26 GMT, Joe Darcy wrote: >> The restricted javac warning is disabled for java.base, but could be enabled >> by suppressing the warning in a handful of files. > > Joe Darcy has updated the pull request incrementally with one additional > commit since the last revision:

Re: RFR: JDK-8325148: Enable restricted javac warning in java.base [v2]

2024-02-01 Thread Joe Darcy
On Thu, 1 Feb 2024 22:01:49 GMT, Jorn Vernee wrote: > This looks good to me. It will be easier to find where we are doing > restricted operations like this. Right; follows the recommended approach of minimizing the scope of the SuppressWarnings annotations too. Thanks. - PR

Re: RFR: JDK-8325148: Enable restricted javac warning in java.base [v2]

2024-02-01 Thread Joe Darcy
> The restricted javac warning is disabled for java.base, but could be enabled > by suppressing the warning in a handful of files. Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: Add comment highlighting restricted method calls.