Re: RFR: 8329596: Add test for virtual threads invoking synchronized native methods

2024-04-16 Thread Jaikiran Pai
On Wed, 3 Apr 2024 10:52:10 GMT, Alan Bateman wrote: > This is a test-only addition to add a test for virtual threads invoking a > synchronized native method and invoking a native method that enter/exits a > monitor with JNI MonitorEnter/MonitorExit. The test has been in the loom repo > for

Re: RFR: 8329596: Add test for virtual threads invoking synchronized native methods

2024-04-07 Thread ExE Boss
On Wed, 3 Apr 2024 10:52:10 GMT, Alan Bateman wrote: > This is a test-only addition to add a test for virtual threads invoking a > synchronized native method and invoking a native method that enter/exits a > monitor with JNI MonitorEnter/MonitorExit. The test has been in the loom repo > for

Re: RFR: 8329596: Add test for virtual threads invoking synchronized native methods

2024-04-04 Thread David Holmes
On Fri, 5 Apr 2024 05:17:44 GMT, Alan Bateman wrote: >> test/jdk/java/lang/Thread/virtual/libSynchronizedNative.c line 29: >> >>> 27: Java_SynchronizedNative_runWithSynchronizedNative(JNIEnv *env, jobject >>> obj, jobject task) { >>> 28: jclass clazz = (*env)->GetObjectClass(env, obj); >>>

Re: RFR: 8329596: Add test for virtual threads invoking synchronized native methods

2024-04-04 Thread Alan Bateman
On Fri, 5 Apr 2024 01:11:49 GMT, David Holmes wrote: > Does this generate a warning with `-Xcheck:jni` due to exceptions not being > checked for? I run with`TEST_OPTS_JAVA_OPTIONS=-Xcheck:jni` and don't see any warnings. Are you asking about the usage of GetObjectClass (which is not

Re: RFR: 8329596: Add test for virtual threads invoking synchronized native methods

2024-04-04 Thread David Holmes
On Wed, 3 Apr 2024 10:52:10 GMT, Alan Bateman wrote: > This is a test-only addition to add a test for virtual threads invoking a > synchronized native method and invoking a native method that enter/exits a > monitor with JNI MonitorEnter/MonitorExit. The test has been in the loom repo > for