> The cache named `signerToCodeSource` in `JarVerifier` is never used now.
pandaapo has updated the pull request incrementally with one additional commit
since the last revision:
Modify as reviews.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/11072/files
- new:
On Fri, 18 Nov 2022 14:54:52 GMT, Jorn Vernee wrote:
>> Pull in linker implementation changes, that include non-trivial changes to
>> VM code, from the panama-foreign repo into the main JDK.
>>
>> This is split off from the main JEP integration to make reviewing easier.
>>
>> This includes
On Thu, 10 Nov 2022 01:02:00 GMT, pandaapo wrote:
> The cache named `signerToCodeSource` in `JarVerifier` is never used now.
This pull request has now been integrated.
Changeset: f0e99c63
Author:pandaapo <1052156...@qq.com>
Committer: Weijun Wang
URL:
On Sat, 19 Nov 2022 21:36:56 GMT, Markus KARG wrote:
> There is no need to use a temporary Vector within the constructor of
> SynchronizedInputStream, as more efficient (non-synchronized) alternative
> code (like List.of) will do the same in possibly less time. While the
> optimization is not
On Tue, 15 Nov 2022 15:05:45 GMT, Dongxu Wang wrote:
> 8297385: Remove duplicated null typos in javadoc
good catch, do you need a JBS issue for this?
-
PR: https://git.openjdk.org/jdk/pull/11169
> [JDK-8290036](https://bugs.openjdk.org/browse/JDK-8290036) documented the
> shutdown sequence, noting that calling Runtime.halt() skips the shutdown
> sequence and immediately terminates the VM. Thus, "threads' current methods
> do not complete normally or abruptly; no finally clause of any
On Tue, 22 Nov 2022 00:45:00 GMT, pandaapo wrote:
>> The cache named `signerToCodeSource` in `JarVerifier` is never used now.
>
> pandaapo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Modify as reviews.
Everything looks fine now.
On Tue, 22 Nov 2022 01:44:29 GMT, Weijun Wang wrote:
> Everything looks fine now. Thanks so much for the cleanup. It's always nice
> to see unused lines removed.
Thank you for your review.
-
PR: https://git.openjdk.org/jdk/pull/11072
On Tue, 22 Nov 2022 02:22:20 GMT, Dongxu Wang wrote:
> > good catch, do you need a JBS issue for this?
>
> Thank you if you can help with that.
I filed https://bugs.openjdk.org/browse/JDK-8297385 for this, you can change
your PR title and commit message to [8297385: Remove duplicated null
8297385: Remove duplicated null typos in javadoc
-
Commit messages:
- Minor remove duplicate null typo
Changes: https://git.openjdk.org/jdk/pull/11169/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=11169=00
Issue: https://bugs.openjdk.org/browse/JDK-8297385
Stats: 3 lines
On Mon, 21 Nov 2022 15:16:14 GMT, Yi Yang wrote:
> good catch, do you need a JBS issue for this?
Thank you if you can help with that.
-
PR: https://git.openjdk.org/jdk/pull/11169
> Pull in linker implementation changes, that include non-trivial changes to VM
> code, from the panama-foreign repo into the main JDK.
>
> This is split off from the main JEP integration to make reviewing easier.
>
> This includes the following patches:
>
> 1.
On Fri, 18 Nov 2022 14:54:52 GMT, Jorn Vernee wrote:
>> Pull in linker implementation changes, that include non-trivial changes to
>> VM code, from the panama-foreign repo into the main JDK.
>>
>> This is split off from the main JEP integration to make reviewing easier.
>>
>> This includes
On Mon, 21 Nov 2022 17:43:23 GMT, Markus KARG wrote:
>> There is no need to use a temporary Vector within the constructor of
>> SynchronizedInputStream, as more efficient (non-synchronized) alternative
>> code (like List.of) will do the same in possibly less time. While the
>> optimization is
On Fri, 11 Nov 2022 13:00:06 GMT, Claes Redestad wrote:
>> Continuing the work initiated by @luhenry to unroll and then intrinsify
>> polynomial hash loops.
>>
>> I've rewired the library changes to route via a single `@IntrinsicCandidate`
>> method. To make this work I've harmonized how they
> This PR introduces an option to output stable names for the lambda classes in
> the JDK. A stable name consists of two parts: The first part is the
> predefined value `$$Lambda$` appended to the lambda capturing class, and the
> second is a 64-bit hash part of the name. Thus, it looks like
>
> This PR proposes the introduction of **guarding** of the use of
> `DirectBuffer::address` within the JDK. With the introduction of the Foreign
> Function and Memory access, it is possible to derive Buffer instances that
> are backed by native memory that, in turn, can be closed asynchronously
On Mon, 21 Nov 2022 00:29:34 GMT, pandaapo wrote:
>> The cache named `signerToCodeSource` in `JarVerifier` is never used now.
>
> pandaapo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Modify as review and update copyright.
Looks almost
On Mon, 7 Nov 2022 17:07:01 GMT, Coleen Phillimore wrote:
> This patch moves the acquisition of the boot class loader lock out of the JVM
> and into the Java function.
> Tested with tier1-4, and jvmti and jdi tests locally.
This pull request has now been integrated.
Changeset: 5c334540
On Mon, 21 Nov 2022 13:02:48 GMT, Per Minborg wrote:
>> This PR proposes the introduction of **guarding** of the use of
>> `DirectBuffer::address` within the JDK. With the introduction of the Foreign
>> Function and Memory access, it is possible to derive Buffer instances that
>> are backed
> This PR proposes the introduction of **guarding** of the use of
> `DirectBuffer::address` within the JDK. With the introduction of the Foreign
> Function and Memory access, it is possible to derive Buffer instances that
> are backed by native memory that, in turn, can be closed asynchronously
On Mon, 21 Nov 2022 13:32:43 GMT, ExE Boss wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Rename methods
>
> src/java.base/share/classes/sun/nio/ch/DirectBuffer.java line 41:
>
>> 39: // An example of a
On Mon, 21 Nov 2022 13:43:56 GMT, Per Minborg wrote:
>> src/java.base/share/classes/sun/nio/ch/DirectBuffer.java line 41:
>>
>>> 39: // An example of a guarded use of a memory address is shown here:
>>> 40: //
>>> 41: // try (var guard = NIO_ACCESS.acquireSessionAsAutoCloseable(bb))
> This PR proposes the introduction of **guarding** of the use of
> `DirectBuffer::address` within the JDK. With the introduction of the Foreign
> Function and Memory access, it is possible to derive Buffer instances that
> are backed by native memory that, in turn, can be closed asynchronously
On Mon, 21 Nov 2022 13:02:48 GMT, Per Minborg wrote:
>> This PR proposes the introduction of **guarding** of the use of
>> `DirectBuffer::address` within the JDK. With the introduction of the Foreign
>> Function and Memory access, it is possible to derive Buffer instances that
>> are backed
On Mon, 21 Nov 2022 14:02:38 GMT, Per Minborg wrote:
>> This PR proposes the introduction of **guarding** of the use of
>> `DirectBuffer::address` within the JDK. With the introduction of the Foreign
>> Function and Memory access, it is possible to derive Buffer instances that
>> are backed
> This PR introduces an option to output stable names for the lambda classes in
> the JDK. A stable name consists of two parts: The first part is the
> predefined value `$$Lambda$` appended to the lambda capturing class, and the
> second is a 64-bit hash part of the name. Thus, it looks like
>
On Mon, 21 Nov 2022 12:52:42 GMT, Jim Laskey wrote:
>> src/java.base/share/classes/java/lang/template/StringTemplate.java line 35:
>>
>>> 33: /**
>>> 34: * {@link StringTemplate} is the run-time representation of a string
>>> template or
>>> 35: * text block template in a template
On Fri, 18 Nov 2022 14:10:11 GMT, Jim Laskey wrote:
>> Enhance the Java programming language with string templates, which are
>> similar to string literals but contain embedded expressions. A string
>> template is interpreted at run time by replacing each expression with the
>> result of
> This PR proposes the introduction of **guarding** of the use of
> `DirectBuffer::address` within the JDK. With the introduction of the Foreign
> Function and Memory access, it is possible to derive Buffer instances that
> are backed by native memory that, in turn, can be closed asynchronously
On Mon, 7 Nov 2022 20:40:33 GMT, Coleen Phillimore wrote:
>> This patch moves the acquisition of the boot class loader lock out of the
>> JVM and into the Java function.
>> Tested with tier1-4, and jvmti and jdi tests locally.
>
> Coleen Phillimore has updated the pull request incrementally
> This PR introduces an option to output stable names for the lambda classes in
> the JDK. A stable name consists of two parts: The first part is the
> predefined value `$$Lambda$` appended to the lambda capturing class, and the
> second is a 64-bit hash part of the name. Thus, it looks like
>
On Fri, 18 Nov 2022 22:25:22 GMT, Roger Riggs wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Typo
>
> src/java.base/share/classes/java/lang/template/package-info.java line 27:
>
>> 25:
>> 26: /**
>> 27: *
On Mon, 21 Nov 2022 10:53:07 GMT, Per Minborg wrote:
> This PR proposes the introduction of **guarding** of the use of
> `DirectBuffer::address` within the JDK. With the introduction of the Foreign
> Function and Memory access, it is possible to derive Buffer instances that
> are backed by
On Mon, 21 Nov 2022 11:29:07 GMT, Alan Bateman wrote:
>> This PR proposes the introduction of **guarding** of the use of
>> `DirectBuffer::address` within the JDK. With the introduction of the Foreign
>> Function and Memory access, it is possible to derive Buffer instances that
>> are backed
> This PR proposes the introduction of **guarding** of the use of
> `DirectBuffer::address` within the JDK. With the introduction of the Foreign
> Function and Memory access, it is possible to derive Buffer instances that
> are backed by native memory that, in turn, can be closed asynchronously
On Mon, 21 Nov 2022 11:32:35 GMT, Alan Bateman wrote:
>> This PR proposes the introduction of **guarding** of the use of
>> `DirectBuffer::address` within the JDK. With the introduction of the Foreign
>> Function and Memory access, it is possible to derive Buffer instances that
>> are backed
On Mon, 21 Nov 2022 11:36:44 GMT, Per Minborg wrote:
>> src/java.base/share/classes/sun/nio/ch/NioSocketImpl.java line 252:
>>
>>> 250: try {
>>> 251: // 'dst' is guaranteed not to be associated with a
>>> closeable session.
>>> 252: // Hence, there is no need
On Mon, 21 Nov 2022 12:16:01 GMT, Maurizio Cimadamore
wrote:
>> Eventually, I hope most of them will be named `_`.
>
> maybe just `bufferLock` and and just `acquireBuffer` ?
Would it be possible to re-examine acquireSession returning Runnable and
acquireSessionAsAutoCloseable returning
> This PR proposes the introduction of **guarding** of the use of
> `DirectBuffer::address` within the JDK. With the introduction of the Foreign
> Function and Memory access, it is possible to derive Buffer instances that
> are backed by native memory that, in turn, can be closed asynchronously
On Mon, 21 Nov 2022 12:03:35 GMT, Per Minborg wrote:
>> src/java.base/share/classes/java/util/zip/Adler32.java line 102:
>>
>>> 100: return;
>>> 101: if (buffer.isDirect()) {
>>> 102: try (var sessionAcquisition =
>>>
On Mon, 21 Nov 2022 12:19:21 GMT, Alan Bateman wrote:
>> maybe just `bufferLock` and and just `acquireBuffer` ?
>
> Would it be possible to re-examine acquireSession returning Runnable and
> acquireSessionAsAutoCloseable returning AutoCloseable. The naming is bit
> awkward at most of the use
On Mon, 21 Nov 2022 10:53:07 GMT, Per Minborg wrote:
> This PR proposes the introduction of **guarding** of the use of
> `DirectBuffer::address` within the JDK. With the introduction of the Foreign
> Function and Memory access, it is possible to derive Buffer instances that
> are backed by
On Fri, 18 Nov 2022 23:00:49 GMT, Roger Riggs wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Typo
>
> src/java.base/share/classes/java/lang/template/StringTemplate.java line 35:
>
>> 33: /**
>> 34: * {@link
This PR proposes the introduction of **guarding** of the use of
`DirectBuffer::address` within the JDK. With the introduction of the Foreign
Function and Memory access, it is possible to derive Buffer instances that are
backed by native memory that, in turn, can be closed asynchronously by the
On Fri, 18 Nov 2022 23:05:30 GMT, Roger Riggs wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Typo
>
> src/java.base/share/classes/java/lang/template/StringProcessor.java line 49:
>
>> 47: * @implNote
On Mon, 21 Nov 2022 01:11:55 GMT, David Holmes wrote:
> > tools/launcher/ArgsFileTest.java was working because it didn't contain any
> > test with --disable-@files option verifying VM really starts
>
> What about the killswitch test ??
KillSwitch test did not construct valid command line, it
On 21/11/2022 01:02, Ethan McCue wrote:
There are some modules like jdk.internal.le which contain no
publicly exported packages. In some of the experimentation we are
doing, We want to use the
jdk.internal.org.jline.utils.Levenshtien class from jdk.compiler.
Mechanically, we can do this
On Mon, 21 Nov 2022 16:08:20 GMT, Per Minborg wrote:
> Although this looks much simpler and concise, it means "a new object is
> created for each invocation"
My comment was actually to see if DirectBuffer could extend AutoCloseable so
that the acquire returns "this" for the non-session case.
On Mon, 21 Nov 2022 16:35:46 GMT, Weibing Xiao wrote:
>> print warning message for java.io.tmpdir when it is set through the command
>> line and the value is not good for creating file folder.
>
> Weibing Xiao has updated the pull request incrementally with one additional
> commit since the
On Mon, 21 Nov 2022 16:34:46 GMT, Alan Bateman wrote:
> > Although this looks much simpler and concise, it means "a new object is
> > created for each invocation"
>
> My comment was actually to see if DirectBuffer could extend AutoCloseable so
> that the acquire returns "this" for the
On Mon, 21 Nov 2022 14:14:14 GMT, Alan Bateman wrote:
>> Per Minborg has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Update src/java.base/share/classes/jdk/internal/access/JavaNioAccess.java
>>
>>Co-authored-by: ExE Boss
On Fri, 18 Nov 2022 18:36:51 GMT, Weibing Xiao wrote:
>> print warning message for java.io.tmpdir when it is set through the command
>> line and the value is not good for creating file folder.
>
> Weibing Xiao has updated the pull request incrementally with one additional
> commit since the
> print warning message for java.io.tmpdir when it is set through the command
> line and the value is not good for creating file folder.
Weibing Xiao has updated the pull request incrementally with one additional
commit since the last revision:
update according to the review comments
On Wed, 16 Nov 2022 15:06:14 GMT, Roger Riggs wrote:
>> Weibing Xiao has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> the change according to review comment
>
> src/java.base/share/classes/jdk/internal/util/SystemProps.java line 52:
>
> Enhance the Java programming language with string templates, which are
> similar to string literals but contain embedded expressions. A string
> template is interpreted at run time by replacing each expression with the
> result of evaluating that expression, possibly after further validation
> This PR introduces an option to output stable names for the lambda classes in
> the JDK. A stable name consists of two parts: The first part is the
> predefined value `$$Lambda$` appended to the lambda capturing class, and the
> second is a 64-bit hash part of the name. Thus, it looks like
>
> This PR proposes the introduction of **guarding** of the use of
> `DirectBuffer::address` within the JDK. With the introduction of the Foreign
> Function and Memory access, it is possible to derive Buffer instances that
> are backed by native memory that, in turn, can be closed asynchronously
On Fri, 18 Nov 2022 22:34:35 GMT, Roger Riggs wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Typo
>
> src/java.base/share/classes/java/lang/template/StringTemplate.java line 300:
>
>> 298: * {@link
On Mon, 21 Nov 2022 14:07:38 GMT, Alan Bateman wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Rename methods
>
> src/java.base/share/classes/java/util/zip/Adler32.java line 105:
>
>> 103: adler =
> Enhance the Java programming language with string templates, which are
> similar to string literals but contain embedded expressions. A string
> template is interpreted at run time by replacing each expression with the
> result of evaluating that expression, possibly after further validation
On Mon, 21 Nov 2022 13:38:58 GMT, Claes Redestad wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Typo
>
> src/java.base/share/classes/java/util/Digits.java line 39:
>
>> 37: */
>> 38:
> There is no need to use a temporary Vector within the constructor of
> SynchronizedInputStream, as more efficient (non-synchronized) alternative
> code (like List.of) will do the same in possibly less time. While the
> optimization is not dramatic, it still makes sense to replace Vector
On Mon, 21 Nov 2022 17:39:24 GMT, Markus KARG wrote:
>> There is no need to use a temporary Vector within the constructor of
>> SynchronizedInputStream, as more efficient (non-synchronized) alternative
>> code (like List.of) will do the same in possibly less time. While the
>> optimization is
> Please review an update for the troff man pages, following the recent update
> to upgrade to use pandoc 2.19.2
> (See https://bugs.openjdk.org/browse/JDK-8297165)
>
> In conjunction with this, one javadoc test also needs to be updated, to work
> with the new form of output generated by the
On Mon, 21 Nov 2022 07:42:35 GMT, Alan Bateman wrote:
>> N.B.: Regarding usage numbers, I will do a quick poll on Twitter.
>
>> Indeed my intention solely is to get rid of `Vector`, so I am fine with
>> keeping a low profile and being full backwards compatible. I assume SIS is
>> seldomly
On Mon, 21 Nov 2022 17:54:15 GMT, Jonathan Gibbons wrote:
>> Please review an update for the troff man pages, following the recent update
>> to upgrade to use pandoc 2.19.2
>> (See https://bugs.openjdk.org/browse/JDK-8297165)
>>
>> In conjunction with this, one javadoc test also needs to be
On Mon, 21 Nov 2022 17:00:52 GMT, Maurizio Cimadamore
wrote:
>>> Although this looks much simpler and concise, it means "a new object is
>>> created for each invocation"
>>
>> My comment was actually to see if DirectBuffer could extend AutoCloseable so
>> that the acquire returns "this" for
This PR copies the `CommandLine.java` file from module `jdk.compiler` (package
`com.sun.tools.javac.main`) into the `jdk.internal.opt` module, creating a new
package with name `jdk.internal.opt`. That new `jdk.internal.opt` package is
then exported to the following modules:
- `jdk.jartool`
-
On Mon, 21 Nov 2022 07:48:01 GMT, Markus KARG wrote:
> While we are at it, would you be willing to change the member variables `e`
> to `private final` and the `in` to `private`? From what I can see, I don't
> see any other class accessing these package private fields.
Fixed in 8d29831 :-)
On Mon, 21 Nov 2022 06:31:47 GMT, Jaikiran Pai wrote:
>> Markus KARG has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR. The pull request contains one
>> new
On Mon, 21 Nov 2022 17:43:58 GMT, Markus KARG wrote:
> I think the public visibility of my Twitter account is not wide enough to get
> really robust answers, unfortunately.
One alternative is to search GitHub. It's amazing how fast they can search such
a huge code corpus.
Example:
On Thu, 17 Nov 2022 22:23:53 GMT, Jonathan Gibbons wrote:
> Please review an update for the troff man pages, following the recent update
> to upgrade to use pandoc 2.19.2
> (See https://bugs.openjdk.org/browse/JDK-8297165)
>
> In conjunction with this, one javadoc test also needs to be
> This PR contains the API and implementation changes for JEP-434 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.org/jeps/434
Maurizio Cimadamore has updated the pull request
On Mon, 21 Nov 2022 15:40:19 GMT, Christian Stein wrote:
> This PR copies the `CommandLine.java` file from module `jdk.compiler`
> (package `com.sun.tools.javac.main`) into the `jdk.internal.opt` module,
> creating a new package with name `jdk.internal.opt`. That new
> `jdk.internal.opt`
75 matches
Mail list logo
