Re: RFR: JDK-8327474 Review use of java.io.tmpdir in jdk tests [v3]

2024-03-26 Thread Andrey Turbanov
On Thu, 21 Mar 2024 17:13:46 GMT, Bill Huang wrote: >> This task addresses an essential aspect of our testing infrastructure: the >> proper handling and cleanup of temporary files and socket files created >> during test execution. The motivation behind these changes is to prevent the >>

RFR: JDK-8327875: ChoiceFormat should advise throwing UnsupportedOperationException for unused methods

2024-03-26 Thread Justin Lu
Please review this PR which advises ChoiceFormat subclasses throw `UnsupportedOperationException` for unused inherited methods. The CSR covers the proposed wording, and the reasons as to why this is a specification and not an implementation update. In addition, the `api/implNote` tags have

Re: RFR: JDK-8319516 - Native library suffix impact on the library loading in AIX- Java Class Loader [v5]

2024-03-26 Thread Mandy Chung
On Tue, 26 Mar 2024 20:59:54 GMT, Martin Doerr wrote: >> Suchismith Roy has updated the pull request incrementally with four >> additional commits since the last revision: >> >> - coding style >> - set false >> - restore fil >> - remove member check code > >

Re: RFR: JDK-8327875: ChoiceFormat should advise throwing UnsupportedOperationException for unused methods

2024-03-26 Thread Naoto Sato
On Tue, 26 Mar 2024 20:50:10 GMT, Justin Lu wrote: > Please review this PR which advises ChoiceFormat subclasses throw > `UnsupportedOperationException` for unused inherited methods. > > The CSR covers the proposed wording, and the reasons as to why this is a > specification and not an

Re: RFR: JDK-8327474 Review use of java.io.tmpdir in jdk tests [v4]

2024-03-26 Thread Bill Huang
> This task addresses an essential aspect of our testing infrastructure: the > proper handling and cleanup of temporary files and socket files created > during test execution. The motivation behind these changes is to prevent the > accumulation of unnecessary files in the default temporary

Re: InetAddress API extension proposal

2024-03-26 Thread Bernd Eckenfels
Would be helpful to point to the posix standard/requirement which mandates this. Do you mean a single Unix api description or a posix command spec? I don’t think I know of any such things. Wikipedia claims A POSIX-conforming variant of inet_aton, the inet_pton() function, supports only the

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v17]

2024-03-26 Thread Brent Christian
> Classes in the `java.lang.ref` package would benefit from an update to bring > the spec in line with how the VM already behaves. The changes would focus on > _happens-before_ edges at some key points during reference processing. > > A couple key things we want to be able to say are: > -

Re: RFR: JDK-8319516 - Native library suffix impact on the library loading in AIX- Java Class Loader [v5]

2024-03-26 Thread Mandy Chung
On Mon, 25 Mar 2024 09:46:50 GMT, Suchismith Roy wrote: >> Allow support for both .a and .so files in AIX. >> If .so file is not found, allow fallback to .a extension. >> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516) > > Suchismith Roy has updated the pull request

RFR: 8328995: launcher can't open jar files where the offset of the manifest is >4GB

2024-03-26 Thread Liam Miller-Cushon
This change fixes a zip64 bug in the launcher that is prevent it from reading the manifest of jars where the 'relative offset of local header' field in the central directory entry is >4GB. As described in APPNOTE.TXT 4.5.3, the offset is too large to be stored in the central directory it is

RFR: JDK-8329118: Run MessageFormat additional subformat pattern tests under en_US locale

2024-03-26 Thread Justin Lu
Please review this PR which updates two MessageFormat sub format related tests to be guaranteed to run under the `en_US` locale. There exists locale that do not provide distinct instances for separate styles. For example, the `en_IN` locale provides the same LONG and SHORT compact number

Re: RFR: JDK-8319516 - Native library suffix impact on the library loading in AIX- Java Class Loader [v5]

2024-03-26 Thread Martin Doerr
On Mon, 25 Mar 2024 09:46:50 GMT, Suchismith Roy wrote: >> Allow support for both .a and .so files in AIX. >> If .so file is not found, allow fallback to .a extension. >> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516) > > Suchismith Roy has updated the pull request

InetAddress API extension proposal

2024-03-26 Thread Sergey Chernyshev
Hello Core Libs Dev team, I would like to propose a PR to extend the InetAddress API in JDK 23, namely to provide interface to constructing InetAddress objects from literal addresses in POSIX/BSD form (please see the discussion [1]), to the Apps that need to mimic the behavior of POSIX

Re: RFR: JDK-8329118: Run MessageFormat additional subformat pattern tests under en_US locale

2024-03-26 Thread Naoto Sato
On Tue, 26 Mar 2024 20:49:48 GMT, Justin Lu wrote: > Please review this PR which updates two MessageFormat sub format related > tests to be guaranteed to run under the `en_US` locale. > > There exists locale that do not provide distinct instances for separate > styles. For example, the

Re: RFR: 8328995: launcher can't open jar files where the offset of the manifest is >4GB

2024-03-26 Thread Jiangli Zhou
On Mon, 25 Mar 2024 21:37:03 GMT, Liam Miller-Cushon wrote: > This change fixes a zip64 bug in the launcher that is prevent it from reading > the manifest of jars where the 'relative offset of local header' field in the > central directory entry is >4GB. As described in APPNOTE.TXT 4.5.3, the

Re: RFR: JDK-8329118: Run MessageFormat additional subformat pattern tests under en_US locale [v2]

2024-03-26 Thread Justin Lu
On Tue, 26 Mar 2024 21:56:48 GMT, Naoto Sato wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> implement suggestions > > test/jdk/java/text/Format/MessageFormat/CompactSubFormats.java line 29: > >> 27: * @summary

Re: RFR: JDK-8329118: Run MessageFormat additional subformat pattern tests under en_US locale [v2]

2024-03-26 Thread Justin Lu
> Please review this PR which updates two MessageFormat sub format related > tests to be guaranteed to run under the `en_US` locale. > > There exists locale that do not provide distinct instances for separate > styles. For example, the `en_IN` locale provides the same LONG and SHORT > compact

Re: RFR: JDK-8329118: Run MessageFormat additional subformat pattern tests under en_US locale [v2]

2024-03-26 Thread Naoto Sato
On Tue, 26 Mar 2024 22:23:45 GMT, Justin Lu wrote: >> test/jdk/java/text/Format/MessageFormat/CompactSubFormats.java line 29: >> >>> 27: * @summary Test MessageFormatPattern ability to recognize and produce >>> 28: * appropriate FormatType and FormatStyle for >>>

Re: RFR: JDK-8329074: AIX build fails after JDK-8328824

2024-03-26 Thread Magnus Ihse Bursie
On Tue, 26 Mar 2024 09:21:20 GMT, Matthias Baesken wrote: > After [JDK-8328824](https://bugs.openjdk.org/browse/JDK-8328824), we run in > the AIX build into this failure : > > /opt/freeware/bin/bash: -c: line 1: syntax error near unexpected token `(' > gmake[3]: *** [lib/CoreLibraries.gmk:194:

Re: RFR: JDK-8329118: Run MessageFormat additional subformat pattern tests under en_US locale [v4]

2024-03-26 Thread Naoto Sato
On Tue, 26 Mar 2024 23:32:34 GMT, Justin Lu wrote: >> Please review this PR which updates two MessageFormat sub format related >> tests to be guaranteed to run under the `en_US` locale. >> >> There exists locale that do not provide distinct instances for separate >> styles. For example, the

Re: RFR: JDK-8323760 clarify specification of Map::putIfAbsent return value [v3]

2024-03-26 Thread Stuart Marks
On Wed, 14 Feb 2024 20:46:17 GMT, John Hendrikx wrote: >> Update the documentation for `@return` tag of `putIfAbsent` to match the >> main description. `putIfAbsent` uses the same wording as `put` for its >> `@return` tag, but that is incorrect. `putIfAbsent` never returns the >>

Re: RFR: JDK-8329118: Run MessageFormat additional subformat pattern tests under en_US locale [v3]

2024-03-26 Thread Justin Lu
On Tue, 26 Mar 2024 22:32:08 GMT, Naoto Sato wrote: >> Thanks for the review and suggestions, PR should be updated. (I presume you >> meant the 2-arg Locale.of() method, not the constructor) > > I meant using `new MessageFormat(String, Locale.US)`, instead of `new > MessageFormat(String)`.

Re: RFR: JDK-8329118: Run MessageFormat additional subformat pattern tests under en_US locale [v4]

2024-03-26 Thread Justin Lu
> Please review this PR which updates two MessageFormat sub format related > tests to be guaranteed to run under the `en_US` locale. > > There exists locale that do not provide distinct instances for separate > styles. For example, the `en_IN` locale provides the same LONG and SHORT > compact

Re: RFR: JDK-8329118: Run MessageFormat additional subformat pattern tests under en_US locale [v3]

2024-03-26 Thread Justin Lu
> Please review this PR which updates two MessageFormat sub format related > tests to be guaranteed to run under the `en_US` locale. > > There exists locale that do not provide distinct instances for separate > styles. For example, the `en_IN` locale provides the same LONG and SHORT > compact

Re: RFR: JDK-8329118: Run MessageFormat additional subformat pattern tests under en_US locale [v3]

2024-03-26 Thread Naoto Sato
On Tue, 26 Mar 2024 23:02:34 GMT, Justin Lu wrote: >> Please review this PR which updates two MessageFormat sub format related >> tests to be guaranteed to run under the `en_US` locale. >> >> There exists locale that do not provide distinct instances for separate >> styles. For example, the

Re: InetAddress API extension proposal

2024-03-26 Thread Alan Bateman
On 27/03/2024 01:51, Sergey Chernyshev wrote: Hello Core Libs Dev team, I would like to propose a PR to extend the InetAddress API in JDK 23, namely to provide interface to constructing InetAddress objects from literal addresses in POSIX/BSD form (please see the discussion [1]), to the Apps

Re: RFR: JDK-8327474 Review use of java.io.tmpdir in jdk tests [v3]

2024-03-26 Thread Michael McMahon
On Thu, 21 Mar 2024 17:13:46 GMT, Bill Huang wrote: >> This task addresses an essential aspect of our testing infrastructure: the >> proper handling and cleanup of temporary files and socket files created >> during test execution. The motivation behind these changes is to prevent the >>

Re: RFR: 8327964: Simplify BigInteger.implMultiplyToLen intrinsic [v3]

2024-03-26 Thread Damon Fenacci
On Tue, 19 Mar 2024 21:09:31 GMT, Yudi Zheng wrote: >> Moving array construction within BigInteger.implMultiplyToLen intrinsic >> candidate to its caller simplifies the intrinsic implementation in JIT >> compiler. > > Yudi Zheng has updated the pull request incrementally with one additional >

RFR: JDK-8329074: AIX build fails after JDK-8328824

2024-03-26 Thread Matthias Baesken
After [JDK-8328824](https://bugs.openjdk.org/browse/JDK-8328824), we run in the AIX build into this failure : /opt/freeware/bin/bash: -c: line 1: syntax error near unexpected token `(' gmake[3]: *** [lib/CoreLibraries.gmk:194:

Re: RFR: JDK-8319516 - Native library suffix impact on the library loading in AIX- Java Class Loader [v5]

2024-03-26 Thread Suchismith Roy
On Mon, 25 Mar 2024 20:02:16 GMT, Mandy Chung wrote: > dcstartup fails because it fails to load an agent library specified via > `-agentlib:am_ibm_16` that was fixed by JDK-8320005. I assume that's what you > referred to "J9 had for a long time". This does not use > `System::loadLibrary`.

Re: RFR: JDK-8329074: AIX build fails after JDK-8328824

2024-03-26 Thread Christoph Langer
On Tue, 26 Mar 2024 09:21:20 GMT, Matthias Baesken wrote: > After [JDK-8328824](https://bugs.openjdk.org/browse/JDK-8328824), we run in > the AIX build into this failure : > > /opt/freeware/bin/bash: -c: line 1: syntax error near unexpected token `(' > gmake[3]: *** [lib/CoreLibraries.gmk:194:

Re: RFR: 8327791: Optimization for new BigDecimal(String) [v16]

2024-03-26 Thread Claes Redestad
On Wed, 20 Mar 2024 22:56:38 GMT, Shaojin Wen wrote: >> The current BigDecimal(String) constructor calls String#toCharArray, which >> has a memory allocation. >> >> >> public BigDecimal(String val) { >> this(val.toCharArray(), 0, val.length()); // allocate char[] >> } >> >> >> When the

Integrated: JDK-8329074: AIX build fails after JDK-8328824

2024-03-26 Thread Matthias Baesken
On Tue, 26 Mar 2024 09:21:20 GMT, Matthias Baesken wrote: > After [JDK-8328824](https://bugs.openjdk.org/browse/JDK-8328824), we run in > the AIX build into this failure : > > /opt/freeware/bin/bash: -c: line 1: syntax error near unexpected token `(' > gmake[3]: *** [lib/CoreLibraries.gmk:194:

Re: RFR: JDK-8329074: AIX build fails after JDK-8328824

2024-03-26 Thread Matthias Baesken
On Tue, 26 Mar 2024 09:21:20 GMT, Matthias Baesken wrote: > After [JDK-8328824](https://bugs.openjdk.org/browse/JDK-8328824), we run in > the AIX build into this failure : > > /opt/freeware/bin/bash: -c: line 1: syntax error near unexpected token `(' > gmake[3]: *** [lib/CoreLibraries.gmk:194:

Re: RFR: JDK-8329074: AIX build fails after JDK-8328824

2024-03-26 Thread Goetz Lindenmaier
On Tue, 26 Mar 2024 09:21:20 GMT, Matthias Baesken wrote: > After [JDK-8328824](https://bugs.openjdk.org/browse/JDK-8328824), we run in > the AIX build into this failure : > > /opt/freeware/bin/bash: -c: line 1: syntax error near unexpected token `(' > gmake[3]: *** [lib/CoreLibraries.gmk:194:

Integrated: 8327998: Enable java/lang/ProcessBuilder/JspawnhelperProtocol.java on Mac

2024-03-26 Thread Elif Aslan
On Tue, 12 Mar 2024 21:52:31 GMT, Elif Aslan wrote: > This change enables to run JspawnhelperProtocol.java on MacOS. > > In addition to GHA , the test has been run on macos and linux. > > > Test report is stored in >