On Mon, 1 Apr 2024 21:30:19 GMT, Scott Gibbons wrote:
>> This code makes an intrinsic stub for `Unsafe::setMemory`. See [this
>> PR](https://github.com/openjdk/jdk/pull/16760) for discussion around this
>> change.
>>
>> Overall, making this an intrinsic improves overall performance of
>>
On Mon, 1 Apr 2024 21:30:19 GMT, Scott Gibbons wrote:
>> This code makes an intrinsic stub for `Unsafe::setMemory`. See [this
>> PR](https://github.com/openjdk/jdk/pull/16760) for discussion around this
>> change.
>>
>> Overall, making this an intrinsic improves overall performance of
>>
On Thu, 28 Mar 2024 15:55:12 GMT, Sean Coffey wrote:
> Calling extra logging calls during initialization of Logger libraries can
> cause recursion leading to StackOverflowError
> This patch adds logic to the EventHelper class to detect recursion and
> prevent it.
Thanks for taking a look at
`IllegalArgumentException` thrown by some static factory methods of the
following `java.lang.classfile.instruction` interfaces are not documented:
- `ArrayLoadInstruction`
- `ArrayStoreInstruction`
- `BranchInstruction`
- `ConvertInstruction`
- `DiscontinuedInstruction`
- `FieldInstruction`
-
On Thu, 28 Mar 2024 15:55:12 GMT, Sean Coffey wrote:
> Calling extra logging calls during initialization of Logger libraries can
> cause recursion leading to StackOverflowError
> This patch adds logic to the EventHelper class to detect recursion and
> prevent it.
Hello Sean, from what I
On Mon, 1 Apr 2024 18:27:45 GMT, Mandy Chung wrote:
> I adjust the comments which also answer your question. Please add an AIX-only
> test to verify this behavior.
By test you mean provide the use case for pure .a files ?
-
PR Comment:
On Tue, 2 Apr 2024 08:14:25 GMT, Suchismith Roy wrote:
>> I adjust the comments which also answer your question. Please add an
>> AIX-only test to verify this behavior.
>
>> I adjust the comments which also answer your question. Please add an
>> AIX-only test to verify this behavior.
>
> By
On Fri, 29 Mar 2024 20:48:09 GMT, Brent Christian wrote:
>> Classes in the `java.lang.ref` package would benefit from an update to bring
>> the spec in line with how the VM already behaves. The changes would focus on
>> _happens-before_ edges at some key points during reference processing.
>>
On Thu, 28 Mar 2024 14:08:44 GMT, Jan Lahoda wrote:
>> This is a patch for javac, that adds the Derived Record Creation
>> expressions. The current draft specification for the feature is:
>> https://cr.openjdk.org/~gbierman/jep468/jep468-20240326/specs/derived-record-creation-jls.html
>>
>>
On Tue, 26 Mar 2024 18:18:39 GMT, Bill Huang wrote:
>> This task addresses an essential aspect of our testing infrastructure: the
>> proper handling and cleanup of temporary files and socket files created
>> during test execution. The motivation behind these changes is to prevent the
>>
On Tue, 2 Apr 2024 11:16:55 GMT, Jaikiran Pai wrote:
>> Calling extra logging calls during initialization of Logger libraries can
>> cause recursion leading to StackOverflowError
>> This patch adds logic to the EventHelper class to detect recursion and
>> prevent it.
>
> You are right, turns
> This code makes an intrinsic stub for `Unsafe::setMemory`. See [this
> PR](https://github.com/openjdk/jdk/pull/16760) for discussion around this
> change.
>
> Overall, making this an intrinsic improves overall performance of
> `Unsafe::setMemory` by up to 4x for all buffer sizes.
>
>
`GZIPInputStream` supports reading data from multiple concatenated GZIP data
streams since [JDK-4691425](https://bugs.openjdk.org/browse/JDK-4691425). In
order to do this, after a GZIP trailer frame is read, it attempts to read a
GZIP header frame and, if successful, proceeds onward to
Performance. Before:
Benchmark(algorithm) (dataSize) (keyLength)
(provider) Mode Cnt ScoreError Units
SignatureBench.ECDSA.signSHA256withECDSA1024 256
thrpt3 6443.934 ± 6.491 ops/s
SignatureBench.ECDSA.sign
On Tue, 26 Mar 2024 18:18:39 GMT, Bill Huang wrote:
>> This task addresses an essential aspect of our testing infrastructure: the
>> proper handling and cleanup of temporary files and socket files created
>> during test execution. The motivation behind these changes is to prevent the
>>
On Tue, 2 Apr 2024 14:59:33 GMT, Sean Coffey wrote:
>> Calling extra logging calls during initialization of Logger libraries can
>> cause recursion leading to StackOverflowError
>> This patch adds logic to the EventHelper class to detect recursion and
>> prevent it.
>
> Sean Coffey has updated
On Tue, 2 Apr 2024 15:01:15 GMT, Sean Coffey wrote:
> I guess the question is what sort of Logger and LoggerFinder would you return
> in cases where recursion is detected ? Extra issues might arise from the
> System.getLogger method being public and widely used. Additional issues might
> stem
> Calling extra logging calls during initialization of Logger libraries can
> cause recursion leading to StackOverflowError
> This patch adds logic to the EventHelper class to detect recursion and
> prevent it.
Sean Coffey has updated the pull request incrementally with one additional
commit
> This task addresses an essential aspect of our testing infrastructure: the
> proper handling and cleanup of temporary files and socket files created
> during test execution. The motivation behind these changes is to prevent the
> accumulation of unnecessary files in the default temporary
On Tue, 2 Apr 2024 15:42:05 GMT, Volodymyr Paprotski wrote:
> Performance. Before:
>
> Benchmark(algorithm) (dataSize) (keyLength)
> (provider) Mode Cnt ScoreError Units
> SignatureBench.ECDSA.signSHA256withECDSA1024 256
>
This PR proposes to make empty immutable lists always throw UOE on
`removeFirst` and `removeLast`.
-
Commit messages:
- Make empty immutable lists always throw UOE on remove(F|L)
Changes: https://git.openjdk.org/jdk/pull/18581/files
Webrev:
On Thu, 28 Mar 2024 15:55:12 GMT, Sean Coffey wrote:
> Calling extra logging calls during initialization of Logger libraries can
> cause recursion leading to StackOverflowError
> This patch adds logic to the EventHelper class to detect recursion and
> prevent it.
You are right, turns out the
On Thu, 28 Mar 2024 15:55:12 GMT, Sean Coffey wrote:
> Calling extra logging calls during initialization of Logger libraries can
> cause recursion leading to StackOverflowError
> This patch adds logic to the EventHelper class to detect recursion and
> prevent it.
The code changes LGTM. Some
On Tue, 19 Mar 2024 16:55:14 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>>
On Tue, 2 Apr 2024 14:59:33 GMT, Sean Coffey wrote:
>> Calling extra logging calls during initialization of Logger libraries can
>> cause recursion leading to StackOverflowError
>> This patch adds logic to the EventHelper class to detect recursion and
>> prevent it.
>
> Sean Coffey has updated
On Tue, 2 Apr 2024 14:59:33 GMT, Sean Coffey wrote:
>> Calling extra logging calls during initialization of Logger libraries can
>> cause recursion leading to StackOverflowError
>> This patch adds logic to the EventHelper class to detect recursion and
>> prevent it.
>
> Sean Coffey has updated
On Tue, 2 Apr 2024 18:05:43 GMT, Joe Darcy wrote:
> For the `javax.lang.model` changes, as a new ElementKind is being introduced,
> there should be a matching layer of new concrete visitors and selected
> updates to existing visitor implementations, etc.
I can help develop the visitor changes
On Tue, 2 Apr 2024 13:38:00 GMT, Daniel Fuchs wrote:
>> Sean Coffey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> incorporate testcase feedback from Daniel
>
> test/jdk/jdk/security/logging/RecursiveEventHelper.java line 56:
>
>> 54:
On Thu, 28 Mar 2024 15:55:12 GMT, Sean Coffey wrote:
> Calling extra logging calls during initialization of Logger libraries can
> cause recursion leading to StackOverflowError
> This patch adds logic to the EventHelper class to detect recursion and
> prevent it.
This pull request has now
> Performance. Before:
>
> Benchmark(algorithm) (dataSize) (keyLength)
> (provider) Mode Cnt ScoreError Units
> SignatureBench.ECDSA.signSHA256withECDSA1024 256
> thrpt3 6443.934 ± 6.491 ops/s
>
On Tue, 2 Apr 2024 16:29:07 GMT, Alan Bateman wrote:
>> Volodymyr Paprotski has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> remove use of jdk.crypto.ec
>
> src/java.base/share/classes/module-info.java line 265:
>
>> 263:
On Thu, 28 Mar 2024 14:08:44 GMT, Jan Lahoda wrote:
>> This is a patch for javac, that adds the Derived Record Creation
>> expressions. The current draft specification for the feature is:
>> https://cr.openjdk.org/~gbierman/jep468/jep468-20240326/specs/derived-record-creation-jls.html
>>
>>
On Thu, 14 Mar 2024 17:35:22 GMT, Mandy Chung wrote:
> Trivial fix. Improve the error message to print the cause of the module
> resolution failure if present.
This pull request has now been integrated.
Changeset: 044f4ed5
Author:Mandy Chung
URL:
On Tue, 2 Apr 2024 23:43:24 GMT, Joe Darcy wrote:
> Happened to notice a semantic typo in the description of
> MathContext.DECIMAL128, use of "decimal64" where "decimal128" was intended,
> and added some additional information to make the related descriptions more
> informative.
Marked as
Happened to notice a semantic typo in the description of
MathContext.DECIMAL128, use of "decimal64" where "decimal128" was intended, and
added some additional information to make the related descriptions more
informative.
-
Commit messages:
- JDK-8329557: Fix statement around
On Tue, 2 Apr 2024 16:29:21 GMT, Bill Huang wrote:
>> This task addresses an essential aspect of our testing infrastructure: the
>> proper handling and cleanup of temporary files and socket files created
>> during test execution. The motivation behind these changes is to prevent the
>>
> Add notes for `HashMap::putAll()` conservative resizing.
>
> Note: everything below this line is from the original change. After
> discussion, we decided to keep the conservative resizing, but we should add
> an `@implNote` for the decision.
>
> ---
>
> This change mirrors what we did for
On Fri, 9 Feb 2024 14:05:56 GMT, Volker Simonis wrote:
>> Joshua Cao has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> extract msize variable
>
> I agree that a comment would be helpful but I'm afraid that it will not be of
> much help
On Tue, 2 Apr 2024 23:43:24 GMT, Joe Darcy wrote:
> Happened to notice a semantic typo in the description of
> MathContext.DECIMAL128, use of "decimal64" where "decimal128" was intended,
> and added some additional information to make the related descriptions more
> informative.
Looks fine.
39 matches
Mail list logo
