Integrated: 8321387: SegmentAllocator:allocateFrom(AddressLayout, MemorySegment) does not throw stated UnsupportedOperationException

2023-12-10 Thread Per Minborg
On Wed, 6 Dec 2023 13:52:37 GMT, Per Minborg wrote: > This PR proposes to change the exception type for exceptions thrown for > certain methods with a parameter of type `MemorySegment` when it is > `MemorySegment::isReadOnly`. Previously an `UnsupportedOperationException` > was specified but

Re: RFR: JDK-8319626: Override toString() for ZipFile [v8]

2023-12-10 Thread Justin Lu
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8319982) > which overrides and provides an implementation of `toString()` in > _java.util.zip.ZipFile_ (and by extension, _java.util.jar.JarFile_). Justin Lu has updated the pull request with a new target base due to a merge

Re: RFR: JDK-8319626: Override toString() for ZipFile [v7]

2023-12-10 Thread Justin Lu
On Fri, 8 Dec 2023 10:18:18 GMT, Jaikiran Pai wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> drop additional specification > > src/java.base/share/classes/java/util/zip/ZipFile.java line 494: > >> 492:

Re: RFR: 8321206: Make Locale related system properties `StaticProperty` [v2]

2023-12-10 Thread David Holmes
On Fri, 8 Dec 2023 21:11:57 GMT, Naoto Sato wrote: >> Naoto Sato has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains four additional >> commits

Re: RFR: JDK-8266431: Dual-Pivot Quicksort improvements (Radix sort) [v11]

2023-12-10 Thread Srinivas Vamsi Parasa
On Fri, 8 Dec 2023 20:08:22 GMT, Vladimir Yaroslavskiy wrote: >> Hi Vladimir (@iaroslavski), >> >> Please see the data below. >> >> Thanks, >> Vamsi >> >> > xmlns:o="urn:schemas-microsoft-com:office:office" >> xmlns:x="urn:schemas-microsoft-com:office:excel" >>

RFR: 8321688: Build on linux with GCC 7.5.0 fails after 8319577

2023-12-10 Thread Guoxiong Li
Hi all, This patch fixes the building failure introduced by [JDK-8319577](https://bugs.openjdk.org/browse/JDK-8319577) in old GCC version (linux & GCC 7.5.0 locally). Thanks for the review. Best Regards, -- Guoxiong - Commit messages: - JDK-8321688 Changes:

Re: RFR: 8321480: ISO 4217 Amendment 176 Update [v2]

2023-12-10 Thread Justin Lu
On Thu, 7 Dec 2023 22:20:29 GMT, Naoto Sato wrote: >> Justin Lu has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains five additional commits >>

Re: RFR: 8321480: ISO 4217 Amendment 176 Update [v2]

2023-12-10 Thread Justin Lu
> Please review this PR which incorporates the ISO 4217 Amendment 176 Update. > As the replacement of `ANG` to `XCG` won't occur until 2025, this change does > not need to go into JDK22. `HR` was also updated to remove the past cutover > dates. > > An existing test in _ValidateISO4217.java_

Re: RFR: 8320971: Use BufferedInputStream.buf directly when param of implTransferTo() is trusted [v8]

2023-12-10 Thread Sergey Tsypanov
> It looks like we can skip copying of `byte[]` in > `BufferedInputStream.implTransferTo()` for `OutputStreams` residing in > `java.io`. > > See comment by @vlsi in > https://github.com/openjdk/jdk/pull/10525/files#diff-e19c508d1bb6ee78697ecca66947c395adda0d9c49a85bf696e677ecbd977af1R612

Re: RFR: 8321637: Simplify if statement in ArraysSupport::hugeLength

2023-12-10 Thread John Jiang
On Sun, 10 Dec 2023 03:57:00 GMT, Jie Fu wrote: >> It looks the `else-if` and `else` clauses in method >> `ArraysSupport::hugeLength` could be simplified by `Math::max`. > > The JBS should be an enhancement, not a bug, right? @DamonFool > The JBS should be an enhancement, not a bug, right?