On Tue, 5 Sep 2023 16:05:14 GMT, Qing Xiao wrote:
>> `/test/jdk/tools/lib/tests/JImageValidator.java`, tests in
>> `/test/jdk/tools/jlink`, and `/test/jdk/tools/jimage`,
>> `/test/jdk/java/time/nontestng/java/time/chrono/HijrahConfigTest.java` use
>> on com.sun.tools.classfile and should be
On Tue, 5 Sep 2023 02:46:21 GMT, 温绍锦 wrote:
>> [PR 14578 ](https://github.com/openjdk/jdk/pull/14578) still has unresolved
>> discussions, continue to make improvements.
>>
>> # Benchmark Result
>>
>>
>> sh make/devkit/createJMHBundle.sh
>> bash configure --with-jmh=build/jmh/jars
>> make
On Mon, 4 Sep 2023 04:58:08 GMT, 温绍锦 wrote:
> BigDecimal is a commonly used class in business development, It is often
> necessary to perform toString or toPlainString operations on BigDecimal.
>
> The current version uses StringBuilder resulting in multiple memory
> allocations, I made a
On Wed, 6 Sep 2023 18:34:29 GMT, Mandy Chung wrote:
> This reimplements
> `sun.reflect.ReflectionFactory::newConstructorForSerialization` with method
> handles.
>
> This API currently generates the bytecode which fails the verification
> because `new C; invokespecial A()` where the given
On Mon, 11 Sep 2023 13:32:07 GMT, Martin Doerr wrote:
>> 温绍锦 has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> lo | hi => hi | lo
>
> I have run a couple of tests on linux Big Endian. They have passed. So, it's
> probably correct.
On Mon, 11 Sep 2023 12:12:17 GMT, 温绍锦 wrote:
> improve date toString performance, includes:
>
> java.util.Date.toString
> java.util.Date.toGMTString
> java.time.Instant.toString
> java.time.LocalDate.toString
> java.time.LocalDateTime.toString
> java.time.LocalTime.toString
I think you should
On Mon, 11 Sep 2023 12:23:36 GMT, 温绍锦 wrote:
>> Some codes in core libs are duplicated, including:
>> java.util.DecimalDigits::DIGITS -> java.lang.StringLatin1.PACKED_DIGITS
>> java.util.DecimalDigits::size -> java.lang.Long.stringSize
>>
>> We can reduce duplication through JavaLangAccess,
On Mon, 11 Sep 2023 13:45:43 GMT, 温绍锦 wrote:
> After PR #15651 is merged, changes will be made based on the new API. Until
> then, you can help review other changes.
I mean, OpenJDK's GitHub bots has a special handling system that allows you to
include code from #15651 in this PR:
1. Merge
On Tue, 12 Sep 2023 00:06:41 GMT, 温绍锦 wrote:
>> Some codes in core libs are duplicated, including:
>> java.util.DecimalDigits::DIGITS -> java.lang.StringLatin1.PACKED_DIGITS
>> java.util.DecimalDigits::size -> java.lang.Long.stringSize
>>
>> We can reduce duplication through JavaLangAccess,
On Sun, 17 Sep 2023 06:57:46 GMT, ExE Boss wrote:
>> Mandy Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix @Param due to the rename from default to class+method
>
> src/java.base/share/classes/java/lang/StackFrameInfo.java
On Fri, 1 Sep 2023 08:21:13 GMT, Per Minborg wrote:
> This PR proposes adding a new method to BitSet that provides an immutable
> snapshot of the set in the form of an `IntPredicate`.
>
> The predicate is eligible for constant folding.
>
> Here are some classes in the JDK that would benefit
On Tue, 12 Sep 2023 13:27:29 GMT, 温绍锦 wrote:
>> Some codes in core libs are duplicated, including:
>> java.util.DecimalDigits::DIGITS -> java.lang.StringLatin1.PACKED_DIGITS
>> java.util.DecimalDigits::size -> java.lang.Long.stringSize
>>
>> We can reduce duplication through JavaLangAccess,
On Tue, 12 Sep 2023 21:57:31 GMT, Justin Lu wrote:
> JDK .properties files still use ISO-8859-1 encoding with escape sequences. It
> would improve readability to see the native characters instead of escape
> sequences (especially for the L10n process). The majority of files changed
> are
On Wed, 13 Sep 2023 01:12:52 GMT, Mandy Chung wrote:
> This PR improves IllegalAccessException message thrown by `Lookup::findXXX`
> APIs if the method's variable arity modifier bit is set and
> `asVarargsCollector` fails. It will increase the exception message thrown by
>
On Wed, 13 Sep 2023 02:17:00 GMT, 温绍锦 wrote:
>> 1. Reduce duplicate stringSize code
>> 2. Move java.lang.StringLatin1.getChars to
>> jdk.internal.util.DecimalDigits::getCharLatin1，not only java.lang, other
>> packages also need to use this method
>
> 温绍锦 has updated the pull request
On Fri, 8 Sep 2023 15:34:16 GMT, 温绍锦 wrote:
>> src/java.base/share/classes/java/lang/String.java line 699:
>>
>>> 697: }
>>> 698:
>>> 699: static String newStringLatin1NoRepl(byte[] bytes) {
>>
>> How much does this help compared to calling `jla.newStringNoRepl(bytes,
>>
On Fri, 8 Sep 2023 21:06:25 GMT, ExE Boss wrote:
>> 温绍锦 has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> lo | hi => hi | lo
>
> src/java.base/share/classes/java/util/HexDigits.java line 66:
>
>> 64: */
>> 65: @Stable
>> 66:
On Thu, 31 Aug 2023 11:09:05 GMT, Adam Sotona wrote:
> Classfile API suppose to throw IllegalArgumentException in situations where
> bytecode offset is out of allowed range. Such situation includes invalid
> offset parsed from a TypeAnnotation as well as from other CodeAttribute
> attributes.
On Tue, 1 Aug 2023 20:21:11 GMT, Naoto Sato wrote:
>> This is stemming from the PR: https://github.com/openjdk/jdk/pull/14211
>> where aggressive GC can cause NPE in `BaseLocale$Key` class. I refactored
>> the in-house cache with WeakHashMap, and removed the Key class as it is no
>> longer
On Fri, 13 Oct 2023 17:01:11 GMT, Shaojin Wen wrote:
>> I submitted PR #1 before, and there were too many changes. I split it
>> into multiple PRs with small changes. This one is one of them.
>>
>> this PR removed the duplicate code for getChars in
>> BigDecimal#StringBuilderHelper, i
On Wed, 13 Sep 2023 01:24:05 GMT, Shaojin Wen wrote:
> 1. Reduce duplicate stringSize code
> 2. Move java.lang.StringLatin1.getChars to
> jdk.internal.util.DecimalDigits::getCharLatin1，not only java.lang, other
> packages also need to use this method
Changes requested by liach (Author).
> VarHandle implementations have many static fields and methods that can be
> pulled to the common superclass to avoid repeated initialization and code
> duplication.
>
> In addition, the Unsafe-based Buffer field access are replaced by usage of
> public methods or JavaNioA
On Mon, 16 Oct 2023 22:27:34 GMT, Shaojin Wen wrote:
> When calling String::newStringNoRepl and String::getBytesNoRepl, we need to
> use try...catch to handle CharacterCodingException and throw
> IllegalArgumentException instead of CharacterCodingException to make the
> calling code cleaner.
On Tue, 17 Oct 2023 14:30:26 GMT, Shaojin Wen wrote:
> @wenshao The proposal changes the exception types for seemingly no reason.
> What concrete problem does this enhancement PR address?
@rgiulietti The API was exposed to create a String without duplicating an array
in compatible encoding.
On Wed, 25 Oct 2023 12:36:40 GMT, Mourad Abbay wrote:
>> test/jdk/java/lang/invoke/common/test/java/lang/invoke/lib/InstructionHelper.java
>> line 71:
>>
>>> 69: for (int i = 0; i <
>>> type.parameterCount(); i++) {
>>> 70:
On Fri, 3 Nov 2023 16:26:49 GMT, Jan Lahoda wrote:
> For code like:
>
> enum E {A {}, B {} }
> Object o = E.A;
> switch (o) {
> case E.A -> System.err.println(o);
> default -> System.err.println("default");
> }
>
>
> The result is `default`, not `A`, due to incorrect classes being
On Mon, 25 Sep 2023 12:28:40 GMT, Chen Liang wrote:
> In the constructor of String, many locations the user-supplied byte or char
> arrays are read multiple times with a plain memory access; if a user
> previously wrote to one of such locations out of happens-before order,
> di
On Mon, 25 Sep 2023 12:28:40 GMT, Chen Liang wrote:
> In the constructor of String, many locations the user-supplied byte or char
> arrays are read multiple times with a plain memory access; if a user
> previously wrote to one of such locations out of happens-before order,
> di
On Thu, 19 Oct 2023 14:37:06 GMT, Mourad Abbay wrote:
> early experimental version of the bytecode library is bundled under:
> test/jdk/lib/testlibrary/bytecode
>
> following tests reference it:
> test/jdk/java/lang/invoke/common/test/java/lang/invoke/lib/InstructionHelper.java
>
On Fri, 3 Nov 2023 08:41:12 GMT, Jan Lahoda wrote:
> Consider code like:
>
> void test(Object o) {
> switch (o) {
> case X1 -> {}
> case X2 -> {}
> ...(about 100 cases)
> ```
>
> javac will compile the switch into a switch whose selector is an indy
> invocation to
Please review a patch that migrates `Class::getEnclosingMethod` and
`Class::getEnclosingConstructor`'s descriptor parsing from old generic
utilities to more simple utilities from java.lang.invoke implementation. This
will help migrate away from the old generic repositories in the future.
The
On Mon, 6 Nov 2023 19:26:26 GMT, Mandy Chung wrote:
> `jdk.lambda.vm.InterfaceAccessFlagsTest` uses `ClassToInterfaceConverter` to
> mechanically convert a classfile for a Class into an in-memory class
> representation of an equivalent Interface. `testPrivateMethodCall` tests to
> invoke a
On Mon, 6 Nov 2023 06:00:20 GMT, Chen Liang wrote:
> Observed this erroneous implementation while browsing, and included a quick
> test against javac output class file to confirm the correct implementation.
> @asotona Please take a look.
This pull request has now been integrated.
On Tue, 7 Nov 2023 19:10:18 GMT, ExE Boss wrote:
>> Mandy Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Simplify the transformation code and easier to read
>
> test/jdk/jdk/lambda/separate/ClassToInterfaceConverter.java line 53:
On Tue, 7 Nov 2023 18:34:42 GMT, Mandy Chung wrote:
>> `jdk.lambda.vm.InterfaceAccessFlagsTest` uses `ClassToInterfaceConverter` to
>> mechanically convert a classfile for a Class into an in-memory class
>> representation of an equivalent Interface. `testPrivateMethodCall` tests
>> to
On Tue, 7 Nov 2023 18:34:42 GMT, Mandy Chung wrote:
>> `jdk.lambda.vm.InterfaceAccessFlagsTest` uses `ClassToInterfaceConverter` to
>> mechanically convert a classfile for a Class into an in-memory class
>> representation of an equivalent Interface. `testPrivateMethodCall` tests
>> to
> VarHandle implementations have many static fields and methods that can be
> pulled to the common superclass to avoid repeated initialization and code
> duplication.
>
> In addition, the Unsafe-based Buffer field access are replaced by usage of
> public methods or JavaNioA
Observed this erroneous implementation while browsing, and included a quick
test against javac output class file to confirm the correct implementation.
@asotona Please take a look.
-
Commit messages:
- 8319462: Signature.ClassTypeSig::classDesc() incorrect for inner class types
Discovered while writing a test for #16513 that
`ClassSignature.superclassSignature()` does not return a `ClassTypeSig`, yet
[JVM
Spec](https://docs.oracle.com/javase/specs/jvms/se21/html/jvms-4.html#jvms-4.7.9.1-4100)
requires it to be one. This patch adds such a requirement to the accessors,
On Sun, 8 Oct 2023 17:01:37 GMT, Joe Darcy wrote:
>> @liach , thank you for working on this fix. I've given the changes an
>> initial skim, but will need to do a more thorough review before approving or
>> offering suggestions for changes. My top priority for the next few weeks
>> will be JDK
On Mon, 30 Oct 2023 18:34:44 GMT, Roger Riggs wrote:
> Strings, after construction, are immutable but may be constructed from
> mutable arrays of bytes, characters, or integers.
> The string constructors should guard against the effects of mutating the
> arrays during construction that might
On Wed, 18 Oct 2023 11:56:14 GMT, Claes Redestad wrote:
> In #16006 using `StringConcatFactory` seem to induce a run-to-run variance.
> One idea to reduce this is to generate expression trees with fewer branches
> by looking up and using the prefix-less `prepend` methods directly for cases
>
On Mon, 16 Oct 2023 15:00:42 GMT, Shaojin Wen wrote:
>> I submitted PR #1 before, and there were too many changes. I split it
>> into multiple PRs with small changes. This one is one of them.
>>
>> this PR removed the duplicate code for getChars in
>> BigDecimal#StringBuilderHelper, i
Please review a patch that renames `JavaLangAccess::newStringUTF8NoRepl` and
`getBytesUTF8NoRepl` to `newStringUTF8FailFast` and `getBytesUTF8FailFast` to
accurately describe these APIs. This also renames other associated methods.
NoRepl means "no replication", which is not what these APIs are
On Mon, 18 Sep 2023 04:11:25 GMT, 温绍锦 wrote:
>> # Benchmark Result
>>
>>
>> sh make/devkit/createJMHBundle.sh
>> bash configure --with-jmh=build/jmh/jars
>> make test TEST="micro:java.lang.StringUpperLower.*"
>>
>>
>>
>> ## 1.
>>
On Thu, 7 Sep 2023 11:13:44 GMT, Per Minborg wrote:
> This PR outlines a solution for making immutable maps `@ValueBased` by
> removing cacheing of certain values in `AbstractMap`.
>
> By removing these caching fields in `AbstractMap`, we can make the immutable
> maps `@ValueBased` and at the
On Tue, 19 Sep 2023 09:03:35 GMT, 温绍锦 wrote:
>> In the improvement of @cl4es PR #15591, the advantages of non-lookup-table
>> were discussed.
>>
>> But if the input is byte[], using lookup table can improve performance.
>>
>> For HexFormat#formatHex(Appendable, byte[]) and
On Thu, 7 Sep 2023 07:15:06 GMT, Qing Xiao wrote:
>> Modified all tests under lib-test/jdk to use JUnit
>
> Qing Xiao has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Change test static method to instance method
On Mon, 18 Sep 2023 02:53:18 GMT, 温绍锦 wrote:
>> # Benchmark Result
>>
>>
>> sh make/devkit/createJMHBundle.sh
>> bash configure --with-jmh=build/jmh/jars
>> make test TEST="micro:java.lang.StringUpperLower.*"
>>
>>
>>
>> ## 1.
>>
On Thu, 14 Sep 2023 08:58:56 GMT, Andrey Turbanov wrote:
> A few classes in `sun.util` package have non-final fields which could easily
> be marked `final`.
src/java.base/share/classes/sun/util/PropertyResourceBundleCharset.java line 71:
> 69: private final class PropertiesFileDecoder
On Mon, 26 Jun 2023 14:14:54 GMT, Lance Andersen wrote:
> @LanceAndersen This one is going to require checking that startup isn't
> impacted.
Now that `ByteArrayLittleEndian` is used in Integer toString, don't think this
patch will affect the startup class loading sequence.
-
PR
On Tue, 19 Sep 2023 18:38:06 GMT, ExE Boss wrote:
>> This PR outlines a solution for making immutable maps `@ValueBased` by
>> removing cacheing of certain values in `AbstractMap`.
>>
>> By removing these caching fields in `AbstractMap`, we can make the immutable
>> maps `@ValueBased` and at
On Thu, 7 Sep 2023 11:13:44 GMT, Per Minborg wrote:
> This PR outlines a solution for making immutable maps `@ValueBased` by
> removing cacheing of certain values in `AbstractMap`.
>
> By removing these caching fields in `AbstractMap`, we can make the immutable
> maps `@ValueBased` and at the
On Wed, 20 Sep 2023 09:12:48 GMT, Claes Redestad wrote:
> This patch reverts the use of `ByteArrayLittleEndian` in `StringLatin1`.
>
> This use is the cause of a small (~1.5ms) startup regression in 22-b15. While
> a manageable startup regression in and of itself, the use of `VarHandles` in
On Thu, 29 Jun 2023 09:59:30 GMT, Chen Liang wrote:
> 5 Constant Pool entries, namely ConstantDynamicEntry, InvokeDynamicEntry,
> FieldRefEntry, MethodRefEntry, and InterfaceMethodRefEntry should have a
> typeSymbol() API to return the nominal/symbolic descriptor (
> VarHandle implementations have many static fields and methods that can be
> pulled to the common superclass to avoid repeated initialization and code
> duplication.
>
> In addition, the Unsafe-based Buffer field access are replaced by usage of
> public methods or JavaNioA
On Thu, 21 Sep 2023 02:38:08 GMT, Chen Liang wrote:
>> Like #12077, this uses JDK's internal utilities to speed up ASCII reading in
>> Class files, where most identifiers, from conventions to attribute names,
>> are ASCII. See the JBS issue for more in-depth explanati
> VarHandle implementations have many static fields and methods that can be
> pulled to the common superclass to avoid repeated initialization and code
> duplication.
>
> In addition, the Unsafe-based Buffer field access are replaced by usage of
> public methods or JavaNioA
On Sat, 23 Sep 2023 07:39:59 GMT, 温绍锦 wrote:
>> 1. Reduce duplicate stringSize code
>> 2. Move java.lang.StringLatin1.getChars to
>> jdk.internal.util.DecimalDigits::getCharLatin1，not only java.lang, other
>> packages also need to use this method
>
> 温绍锦 has updated the pull request
> VarHandle implementations have many static fields and methods that can be
> pulled to the common superclass to avoid repeated initialization and code
> duplication.
>
> In addition, the Unsafe-based Buffer field access are replaced by usage of
> public methods or JavaNioA
On Wed, 13 Sep 2023 14:22:35 GMT, 温绍锦 wrote:
>> improve date toString performance, includes:
>>
>> java.util.Date.toString
>> java.util.Date.toGMTString
>> java.time.Instant.toString
>> java.time.LocalDate.toString
>> java.time.LocalDateTime.toString
>> java.time.LocalTime.toString
>
> 温绍锦 has
> VarHandle implementations have many static fields and methods that can be
> pulled to the common superclass to avoid repeated initialization and code
> duplication.
>
> In addition, the Unsafe-based Buffer field access are replaced by usage of
> public methods or JavaNioA
On Sun, 24 Sep 2023 02:11:50 GMT, Chen Liang wrote:
>> VarHandle implementations have many static fields and methods that can be
>> pulled to the common superclass to avoid repeated initialization and code
>> duplication.
>>
>> In addition, the Unsafe-based Bu
On Mon, 18 Sep 2023 18:09:57 GMT, Mourad Abbay wrote:
> Fix Javadoc links for Stream.mapMulti, Stream.MapMultiInt,
> Stream.mapMultiToInt, Stream.mapMultiToLong and Stream.mapMultiToDouble.
Then it's a bug with Intellij IDEA not able to parse these links correctly. It
should be fixed in their
On Thu, 21 Sep 2023 16:40:59 GMT, Per Minborg wrote:
>> This PR outlines a solution for making immutable maps `@ValueBased` by
>> removing cacheing of certain values in `AbstractMap`.
>>
>> By removing these caching fields in `AbstractMap`, we can make the immutable
>> maps `@ValueBased` and
On Fri, 22 Sep 2023 09:22:04 GMT, 温绍锦 wrote:
>> 1. Reduce duplicate stringSize code
>> 2. Move java.lang.StringLatin1.getChars to
>> jdk.internal.util.DecimalDigits::getCharLatin1，not only java.lang, other
>> packages also need to use this method
>
> 温绍锦 has updated the pull request
Like #12077, this uses JDK's internal utilities to speed up ASCII reading in
Class files, where most identifiers, from conventions to attribute names, are
ASCII. See the JBS issue for more in-depth explanations.
Before: (Master)
Benchmark Mode CntScore Error
o NameAndTypeEntry itself, for a NameAndTypeEntry only
> knows if its type should be a field or method type from the other entries
> that refer to it.
>
> This is one of the issues discussed in this mailing list thread:
> https://mail.openjdk.org/pipermail/classfile-api-dev/2023
On Wed, 20 Sep 2023 06:04:26 GMT, Per Minborg wrote:
>> This PR outlines a solution for making immutable maps `@ValueBased` by
>> removing cacheing of certain values in `AbstractMap`.
>>
>> By removing these caching fields in `AbstractMap`, we can make the immutable
>> maps `@ValueBased` and
On Fri, 30 Jun 2023 02:42:08 GMT, Chen Liang wrote:
>> 5 Constant Pool entries, namely ConstantDynamicEntry, InvokeDynamicEntry,
>> FieldRefEntry, MethodRefEntry, and InterfaceMethodRefEntry should have a
>> typeSymbol() API to return the nominal/symbolic des
eBuilder`'s original use
> sites; the old `b.canWriteDirect` branch is redundant, as `writeIndex`'s
> implementation already performs such an optimization.
Chen Liang has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains four commit
On Fri, 15 Sep 2023 18:04:29 GMT, 温绍锦 wrote:
> In the improvement of @cl4es PR #15591, the advantages of non-lookup-table
> were discussed.
>
> But if the input is byte[], using lookup table can improve performance.
>
> For HexFormat#formatHex(Appendable, byte[]) and
On Thu, 21 Sep 2023 13:43:30 GMT, Adam Sotona wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix logical bug with char array filling
>
> src/java.base/share/class
On Thu, 21 Sep 2023 08:50:00 GMT, Chen Liang wrote:
>> VarHandle implementations have many static fields and methods that can be
>> pulled to the common superclass to avoid repeated initialization and code
>> duplication.
>>
>> In addition, the Unsafe-based Bu
> VarHandle implementations have many static fields and methods that can be
> pulled to the common superclass to avoid repeated initialization and code
> duplication.
>
> In addition, the Unsafe-based Buffer field access are replaced by usage of
> public methods or JavaNioA
On Fri, 22 Sep 2023 04:10:26 GMT, 温绍锦 wrote:
>> 1. Reduce duplicate stringSize code
>> 2. Move java.lang.StringLatin1.getChars to
>> jdk.internal.util.DecimalDigits::getCharLatin1，not only java.lang, other
>> packages also need to use this method
>
> 温绍锦 has updated the pull request with a new
On Fri, 22 Sep 2023 04:10:26 GMT, 温绍锦 wrote:
>> 1. Reduce duplicate stringSize code
>> 2. Move java.lang.StringLatin1.getChars to
>> jdk.internal.util.DecimalDigits::getCharLatin1，not only java.lang, other
>> packages also need to use this method
>
> 温绍锦 has updated the pull request with a new
On Mon, 18 Sep 2023 18:09:57 GMT, Mourad Abbay wrote:
> Fix Javadoc links for Stream.mapMulti, Stream.MapMultiInt,
> Stream.mapMultiToInt, Stream.mapMultiToLong and Stream.mapMultiToDouble.
What is this patch looking to fix? The link is not broken in the first place.
This `#mapMulti mapMulti`
On Mon, 25 Sep 2023 12:28:40 GMT, Chen Liang wrote:
> In the constructor of String, many locations the user-supplied byte or char
> arrays are read multiple times with a plain memory access; if a user
> previously wrote to one of such locations out of happens-before order,
> di
On Mon, 25 Sep 2023 12:28:40 GMT, Chen Liang wrote:
> In the constructor of String, many locations the user-supplied byte or char
> arrays are read multiple times with a plain memory access; if a user
> previously wrote to one of such locations out of happens-before order,
> di
On Tue, 26 Sep 2023 14:19:55 GMT, Technici4n wrote:
> Fixes the issue (hopefully) by resolving automatic modules and automatic
> module dependencies after propagation of non-automatic transitive
> dependencies. The module tests run.
>
> I also added a few asserts to validate that the
On Tue, 26 Sep 2023 12:32:37 GMT, Adam Sotona wrote:
>> Classfile API is an internal library under package `jdk.internal.classfile`
>> in JDK 21.
>> This pull request turns the Classfile API into a preview feature and moves
>> it into `java.lang.classfile`.
>> It repackages all uses across JDK
On Thu, 27 Apr 2023 23:42:54 GMT, Joe Darcy wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix assuming match without MethodParameters for type annotations, move
&
Mode CntScore Error Units
> ReadMetadata.jdkReadMemberNames thrpt4 167.623 ± 8.522 ops/s
>
>
> After: (This patch, first revision)
>
> Benchmark Mode CntScore Error Units
> ReadMetadata.jdkReadMemberNames thrpt4 175.
On Fri, 8 Sep 2023 16:13:16 GMT, Per Minborg wrote:
>> This PR proposes to slightly improve some iterators of `AbstractMap`:
>>
>> * Declare two fields `final`
>> * Use distinct classes rather than anonymous classes
>
> Per Minborg has updated the pull request incrementally with two additional
VarHandle implementations have many static fields and methods that can be
pulled to the common superclass to avoid repeated initialization and code
duplication.
In addition, the Unsafe-based Buffer field access are replaced by usage of
public methods or JavaNioAccess.
-
Commit
On Mon, 18 Sep 2023 18:09:57 GMT, Mourad Abbay wrote:
> Fix Javadoc links for Stream.mapMulti, Stream.MapMultiInt,
> Stream.mapMultiToInt, Stream.mapMultiToLong and Stream.mapMultiToDouble.
I recommend just work in the same PR and change all `@see #mapMulti` to `@see
#mapMulti mapMulti` and
On Wed, 13 Sep 2023 17:52:22 GMT, Mandy Chung wrote:
>> This PR improves IllegalAccessException message thrown by `Lookup::findXXX`
>> APIs if the method's variable arity modifier bit is set and
>> `asVarargsCollector` fails. It will increase the exception message thrown
>> by
On Wed, 28 Jun 2023 07:02:17 GMT, Chen Liang wrote:
>> Summaries:
>> 1. A few recommendations about updating the constant API is made at
>> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-March/000233.html
>> and I may update this patch shall the API changes b
On Mon, 25 Sep 2023 09:53:47 GMT, Glavo wrote:
>> UTF8 decoder does not perform any internal state mutation during decoding;
>> in addition, if this field is static final, the decoder's error actions are
>> published when the class is initialized, while publishing in a final field
>> does not
On Mon, 25 Sep 2023 09:40:00 GMT, Andrey Turbanov wrote:
>> src/java.base/share/classes/sun/util/PropertyResourceBundleCharset.java line
>> 71:
>>
>>> 69: private final class PropertiesFileDecoder extends CharsetDecoder {
>>> 70:
>>> 71: private final CharsetDecoder cdUTF_8 =
>>>
On Fri, 22 Sep 2023 15:20:05 GMT, Jorn Vernee wrote:
>> This patch contains the implementation of the foreign linker & memory API
>> JEP for Java 22. The initial patch is composed of commits brought over
>> directly from the [panama-foreign
>> repo](https://github.com/openjdk/panama-foreign).
On Fri, 22 Sep 2023 14:44:11 GMT, Glavo wrote:
>> Per Minborg has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> commits since
On Fri, 22 Sep 2023 16:02:49 GMT, Mourad Abbay wrote:
>> Fix Javadoc links for Stream.mapMulti, Stream.MapMultiInt,
>> Stream.mapMultiToInt, Stream.mapMultiToLong and Stream.mapMultiToDouble.
>
> Mourad Abbay has updated the pull request incrementally with one additional
> commit since the
In the constructor of String, many locations the user-supplied byte or char
arrays are read multiple times with a plain memory access; if a user previously
wrote to one of such locations out of happens-before order, distinct plain
memory reads may result in different unanticipated values.
The
On Tue, 10 Oct 2023 08:32:28 GMT, Sean Coffey wrote:
> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
> objects aren't created for the same zip file.
src/java.base/share/classes/java/util/zip/ZipFile.java line 1418:
> 1416:
> 1417:
On Sun, 8 Oct 2023 21:02:25 GMT, Claes Redestad wrote:
> Alternative to #16082
>
> Name (unchanged) Cnt Base Error Test Error
> Unit Change
> URLEncodeDecode.testEncodeLatin1 0 15 2,066 ± 0,104 1,899 ± 0,007
> ms/op 1,09x (p = 0,000*)
>
On Tue, 10 Oct 2023 10:03:52 GMT, Shaojin Wen wrote:
>> src/java.base/share/classes/java/lang/Integer.java line 682:
>>
>>> 680: */
>>> 681: public static int parseInt(String s) throws NumberFormatException {
>>> 682: if (s != null && s.coder() == String.LATIN1) {
>>
>> Does
On Thu, 12 Oct 2023 00:06:30 GMT, Shaojin Wen wrote:
>> src/java.base/share/classes/java/lang/Integer.java line 560:
>>
>>> 558: if (radix > Character.MAX_RADIX) {
>>> 559: throw NumberFormatException.forMaxRadix(radix);
>>> 560: }
>>
>> It sounds like these methods
On Tue, 10 Oct 2023 02:54:05 GMT, Shaojin Wen wrote:
> By extracting the code that creates the exception, the CodeSize of these
> methods is less than the default FreqInlineSize 325. and for the scenario
> where the most commonly used radix is not specified and the String coder is
> LATIN1,
1 - 100 of 1002 matches
Mail list logo
