Re: Java 21 clinit deadlock

2023-09-10 Thread David Holmes
On 8/09/2023 12:38 am, Simone Bordet wrote: Hello, We switched the Jetty builds to Java 21 a while ago, and they randomly fail with a hard deadlock during class initialization. We tried to understand if we were doing something wrong, but the code compiles fine, and at first glance there seems

Re: RFR: 8267174: Many test files have the wrong Copyright header

2023-09-11 Thread David Holmes
On Tue, 5 Sep 2023 22:49:41 GMT, Erik Joelsson wrote: > There are a number of files in the `test` directory that have an incorrect > copyright header, which includes the "classpath" exception text. This patch > removes that text from all test files that I could find it in. I did this > using

Re: RFR: JDK-8314194: Reusing CyclicBarrier, it should be possible to change the barrierCommand

2023-09-11 Thread David Holmes
On Thu, 31 Aug 2023 10:02:45 GMT, chenggwang wrote: >> Sorry, my description in Issue JDK-8314194(which I submitted) is ambiguous >> and makes you think of Phaser. My intention is that each generation of >> CyclicBarrier barrierCommand can change. Let me give you a scenario >> For example, the

Re: Java 21 clinit deadlock

2023-09-13 Thread David Holmes
Hi Simone, On 13/09/2023 4:16 pm, Simone Bordet wrote: Hi, On Tue, Sep 12, 2023 at 11:44 PM David Holmes wrote: Hi Simone, Thanks for the logs. Unfortunately they shed no light on what is happening. There is no sign of the MutableHttpFields class starting actual initialization, though we

Re: Java 21 clinit deadlock

2023-09-15 Thread David Holmes
On 15/09/2023 5:00 pm, Simone Bordet wrote: David, On Thu, Sep 14, 2023 at 4:33 AM David Holmes wrote: I've created a draft PR here: https://github.com/openjdk/jdk/pull/15732 can you apply that patch, build and re-test? Hopefully that will show which thread is doing the missing

Re: Java 21 clinit deadlock

2023-09-12 Thread David Holmes
? Cheers, David On 12/09/2023 6:35 pm, Simone Bordet wrote: David, On Mon, Sep 11, 2023 at 9:29 AM Simone Bordet wrote: Hi, On Mon, Sep 11, 2023 at 7:22 AM David Holmes wrote: I've looked at the dump and there is no sign that the MutableHttpFields is actively in use. It suggests to me that class

Re: RFR: JDK-8314194: Reusing CyclicBarrier, it should be possible to change the barrierCommand

2023-08-31 Thread David Holmes
On Fri, 11 Aug 2023 02:33:05 GMT, chenggwang wrote: > Sorry, my description in Issue JDK-8314194(which I submitted) is ambiguous > and makes you think of Phaser. My intention is that each generation of > CyclicBarrier barrierCommand can change. Let me give you a scenario > For example, the

Re: RFR: 8315097: Rename createJavaProcessBuilder [v3]

2023-08-30 Thread David Holmes
On Wed, 30 Aug 2023 11:31:20 GMT, Mark Sheppard wrote: > So you could create a single createJavaProcessBuilder with add an additional > parameter boolean addTestOpts e.g. createJavaProcessBuilder(List command, boolean addTestOpts) { ... } @msheppar that is actually where we started, and it was

Re: RFR: 8313718: make container at requires command configurable

2023-08-29 Thread David Holmes
On Tue, 29 Aug 2023 22:01:22 GMT, Mikhailo Seledtsov wrote: > Container ecosystem is growing. It would be beneficial to define custom > command to figure out whether a specific test host or environment allows for > container testing. This enhancement seeks to make the command used by jtreg >

Re: RFR: 8312498: Thread::getState and JVM TI GetThreadState should return TIMED_WAITING virtual thread is timed parked [v3]

2023-09-14 Thread David Holmes
On Thu, 14 Sep 2023 13:29:48 GMT, Alan Bateman wrote: >> Yes but TIMED and SUSPENDED are not alike. I assume SUSPENDED is a >> stand-alone bit because you can be in various states and suspended at the >> same time. But TIMED isn't like that. > >> Yes but TIMED and SUSPENDED are not alike. I

Re: RFR: 8315097: Rename createJavaProcessBuilder [v2]

2023-08-30 Thread David Holmes
On Tue, 29 Aug 2023 16:45:12 GMT, Roger Riggs wrote: >> I don't think this is the best change across so many files. >> It gives a very ugly name to a common test function and affects a very large >> number of tests. > >> @RogerRiggs If it is only the name you want changed, maybe you can offer a

Re: RFR: 8313718: make container at requires command configurable

2023-08-30 Thread David Holmes
On Wed, 30 Aug 2023 03:15:18 GMT, Mikhailo Seledtsov wrote: >> Container ecosystem is growing. It would be beneficial to define custom >> command to figure out whether a specific test host or environment allows for >> container testing. This enhancement seeks to make the command used by jtreg

Re: RFR: 8318126: Refresh manpages

2023-10-16 Thread David Holmes
On Mon, 16 Oct 2023 06:02:02 GMT, Alan Bateman wrote: >> The open nroff manpage files are out of sync with their closed markdown >> sources and need to be refreshed. >> >> The changes to apply are coming from: >> >> - [JDK-8288158](https://bugs.openjdk.org/browse/JDK-8288158): Add an anchor

Re: RFR: 8318586: Explicitly handle upcall stub allocation failure [v3]

2023-10-26 Thread David Holmes
On Thu, 26 Oct 2023 18:07:24 GMT, Jorn Vernee wrote: >> Jorn Vernee has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Throw OOME for allocation failures > > src/java.base/share/classes/java/lang/foreign/Linker.java line 532: > >> 530:

Re: RFR: 8318839: Update test thread factory to catch all exceptions

2023-10-26 Thread David Holmes
On Wed, 25 Oct 2023 21:08:01 GMT, Leonid Mesnik wrote: > The jtreg starts the main thread in a separate ThreadGroup and checks > unhandled exceptions for this group. However, it doesn't catch all unhandled > exceptions. There is a jtreg issue for this >

Re: RFR: 8318839: Update test thread factory to catch all exceptions

2023-10-26 Thread David Holmes
On Thu, 26 Oct 2023 22:34:24 GMT, Leonid Mesnik wrote: >> test/jtreg_test_thread_factory/src/share/classes/Virtual.java line 37: >> >>> 35: // The virtual threads don't belong to any group and need >>> global handler. >>> 36:

Re: RFR: 8318737: Fallback linker passes bad JNI handle [v3]

2023-10-26 Thread David Holmes
On Thu, 26 Oct 2023 15:02:46 GMT, Jorn Vernee wrote: >> The result of `FindClass` is a local JNI handle (in >> `find_class_from_class_loader`, called from `jni_FindClass` [1]). As such, >> we need to wrap the return value of `FindClass` in a global reference when >> storing it inside

Re: RFC: 8318776: Require supports_cx8 to always be true

2023-10-25 Thread David Holmes
Adding in porters-dev On 25/10/2023 5:12 pm, David Holmes wrote: From  https://bugs.openjdk.org/browse/JDK-8318776 Regardless of platform size (32-bit or 64-bit) the Java language has always required that the underlying platform (or the VM) provides a means of performing atomic load

Re: RFR: 8319200: Don't use test thread factory in ProcessTools.createLimitedTestJavaProcessBuilder()

2023-10-31 Thread David Holmes
On Wed, 1 Nov 2023 00:06:35 GMT, Leonid Mesnik wrote: > Test thread factory is a mode similar to VM flags and should not be used in > ProcessTools.createLimitedTestJavaProcessBuilder(). I'm not sure I agree with that. I think the test factory is a separate testing dimension, independent of

Re: RFR: 8318839: Update test thread factory to catch all exceptions [v2]

2023-11-02 Thread David Holmes
On Fri, 3 Nov 2023 03:44:31 GMT, Leonid Mesnik wrote: >> The jtreg starts the main thread in a separate ThreadGroup and checks >> unhandled exceptions for this group. However, it doesn't catch all unhandled >> exceptions. There is a jtreg issue for this >>

Re: RFR: 8319153: Fix: Class is a raw type in ProcessTools

2023-10-31 Thread David Holmes
On Tue, 31 Oct 2023 07:43:43 GMT, Leo Korinth wrote: > Changing from `Class c` to `Class c` removes two warnings. Looks fine and trivial. Thanks - Marked as reviewed by dholmes (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/16431#pullrequestreview-1705674609

Re: RFR: 8318839: Update test thread factory to catch all exceptions

2023-10-30 Thread David Holmes
On Mon, 30 Oct 2023 18:29:30 GMT, Leonid Mesnik wrote: >> Hello Leonid, in order to understand what exactly we are trying to solve >> here, I ran a few tests to see how things work without the changes being >> proposed in this PR. Here's my findings. >> >> A bit of background first. When

Re: RFR: 8318839: Update test thread factory to catch all exceptions

2023-10-30 Thread David Holmes
On Sun, 29 Oct 2023 14:10:32 GMT, Jaikiran Pai wrote: >> The jtreg starts the main thread in a separate ThreadGroup and checks >> unhandled exceptions for this group. However, it doesn't catch all unhandled >> exceptions. There is a jtreg issue for this >>

Re: RFR: 8318737: Fallback linker passes bad JNI handle [v3]

2023-10-30 Thread David Holmes
On Fri, 27 Oct 2023 09:09:05 GMT, Jorn Vernee wrote: > Do you want me to create a separate PR to remove the comment? No not necessary. Thanks - PR Comment: https://git.openjdk.org/jdk/pull/16349#issuecomment-1784664238

Re: RFR: 8318586: Explicitly handle upcall stub allocation failure [v2]

2023-10-26 Thread David Holmes
On Wed, 25 Oct 2023 10:10:57 GMT, Jorn Vernee wrote: >> Explicitly handle UpcallStub allocation failures by terminating. We >> currently might try to use the returned `nullptr` which would fail sooner or >> later. This patch just makes the termination explicit. > > Jorn Vernee has updated the

RFC: 8318776: Require supports_cx8 to always be true

2023-10-25 Thread David Holmes
From https://bugs.openjdk.org/browse/JDK-8318776 Regardless of platform size (32-bit or 64-bit) the Java language has always required that the underlying platform (or the VM) provides a means of performing atomic load and store of 64-bit values, for volatile long and double support. Since

Re: RFR: 8254693: Add Panama feature to pass heap segments to native code [v7]

2023-10-18 Thread David Holmes
On Wed, 18 Oct 2023 17:38:24 GMT, Jorn Vernee wrote: >> Add the ability to pass heap segments to native code. This requires using >> `Linker.Option.critical(true)` as a linker option. It has the same >> limitations as normal critical calls, namely: upcalls into Java are not >> allowed, and

Re: RFR: 8312498: Thread::getState and JVM TI GetThreadState should return TIMED_WAITING virtual thread is timed parked [v3]

2023-09-17 Thread David Holmes
On Fri, 15 Sep 2023 06:34:52 GMT, Alan Bateman wrote: >> What is TIMED PINNING? >> >> To me TIMED_X are a specific set of states and there are not enough of them >> to consider TIMED to be a bit that can be applied to any state X. > >> What is TIMED PINNING? > > LockSupport.parkNanos when

Re: ReservedStackAccess in ThreadLocal

2023-09-28 Thread David Holmes
On 29/09/2023 6:33 am, Егор Зиборов wrote: Hello, Alan I’ve experienced SO in ThreadLocal#set on my production instance (more than that it‘s happened in Spring’s ExposeInvocationInterceptor that uses TL as context storage)As a result of SO in ThreadLocal we’ve experienced unexpected errors with

Re: An error will be reported when compiling the master on OrangeP5 Plus

2023-10-02 Thread David Holmes
Moving to hotspot-runtime-dev as this is a VM crash with compressed Oops. David On 1/10/2023 10:49 am, 温绍锦(高铁) wrote: An error will be reported when compiling the master on OrangeP5 Plus (http://www.orangepi.org/html/hardWare/computerAndMicrocontrollers/details/Orange-Pi-5-plus.html

Re: RFR: 8316946: jtreg failure handler pages are mislabelling the jcmd/thread/dump_to_file results.

2023-09-27 Thread David Holmes
On Wed, 27 Sep 2023 07:11:59 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which addresses the issue noted in > https://bugs.openjdk.org/browse/JDK-8316946? > > Failure handler actions can specify a "successArtifacts" property value, > which are file name(s) for which

Integrated: 8318126: Refresh manpages

2023-10-17 Thread David Holmes
On Mon, 16 Oct 2023 01:18:52 GMT, David Holmes wrote: > The open nroff manpage files are out of sync with their closed markdown > sources and need to be refreshed. > > The changes to apply are coming from: > > - [JDK-8288158](https://bugs.openjdk.org/browse/JDK-82881

Re: RFR: JDK-8313764: Offer JVM HS functionality to shared lib load operations done by the JDK codebase [v2]

2023-10-17 Thread David Holmes
On Mon, 16 Oct 2023 15:04:51 GMT, Matthias Baesken wrote: >> Matthias Baesken has updated the pull request incrementally with one >> additional commit since the last revision: >> >> windows aarch64 build issues > > Hello, any comments about the idea of calling into 'os::dll_load' instead ?

Re: RFR: 8318126: Refresh manpages

2023-10-17 Thread David Holmes
On Mon, 16 Oct 2023 23:55:01 GMT, Iris Clark wrote: >> The open nroff manpage files are out of sync with their closed markdown >> sources and need to be refreshed. >> >> The changes to apply are coming from: >> >> - [JDK-8288158](https://bugs.openjdk.org/browse/JDK-8288158): Add an anchor >>

RFR: 8318126: Refresh manpages

2023-10-15 Thread David Holmes
The open nroff manpage files are out of sync with their closed markdown sources and need to be refreshed. The changes to apply are coming from: - [JDK-8288158](https://bugs.openjdk.org/browse/JDK-8288158): Add an anchor to each subcommand option on jfr html page -

Re: RFR: JDK-8314272: Improve java.util.prefs.BackingStoreException: Couldn't get file lock.

2023-08-20 Thread David Holmes
On Fri, 18 Aug 2023 12:30:45 GMT, Matthias Baesken wrote: > errno 11 seems to be EAGAIN. Sounds like the native code should be retrying in this case. - PR Comment: https://git.openjdk.org/jdk/pull/15308#issuecomment-1685653886

Re: RFR: 8314491: Linux: jexec launched via PATH fails to find java

2023-08-20 Thread David Holmes
On Fri, 18 Aug 2023 10:06:19 GMT, Vladimir Petko wrote: > 8314491: Linux: jexec launched via PATH fails to find java I get the sense from the comment in jexec.c that it is only intended to be launched via a full path, so having it in the $PATH seems like a usage error to me. That said this

Re: RFR: JDK-8314272: Improve java.util.prefs.BackingStoreException: Couldn't get file lock.

2023-08-21 Thread David Holmes
On Mon, 21 Aug 2023 06:15:07 GMT, Jaikiran Pai wrote: > if multiple tests are running and try to acquire this file lock, then they > might end up interfering with each other, but it's surprising that in some > cases even after multiple attempts the file lock doesn't become available. How long

Re: RFR: 8314491: Linux: jexec launched via PATH fails to find java [v2]

2023-08-21 Thread David Holmes
On Mon, 21 Aug 2023 06:18:15 GMT, Vladimir Petko wrote: > realpath call in getJavaPath() function translates the symbolic link into the > binary path. Okay so a specific API makes this work as intended. What I can't determine is whether this may have an adverse effect on anyone using an

Re: RFR: 8314491: Linux: jexec launched via PATH fails to find java [v3]

2023-08-21 Thread David Holmes
On Mon, 21 Aug 2023 07:14:44 GMT, Vladimir Petko wrote: >> 8314491: Linux: jexec launched via PATH fails to find java > > Vladimir Petko has updated the pull request incrementally with one additional > commit since the last revision: > > Review comment: use /proc/self/exe as the backup

Re: RFR: 8314491: Linux: jexec launched via PATH fails to find java [v3]

2023-08-21 Thread David Holmes
On Mon, 21 Aug 2023 20:30:54 GMT, Vladimir Petko wrote: >> src/java.base/unix/native/launcher/jexec.c line 162: >> >>> 160: int argi = 0; /* index into old array */ >>> 161: size_talen = 0; /* length of new array */ >>> 162: int

Re: RFR: 8314483: Optionally override copyright header in generated source

2023-08-23 Thread David Holmes
On Fri, 18 Aug 2023 14:22:49 GMT, Erik Joelsson wrote: > In the JDK build we have various build tools that generate source code from > data files. For most of these tools, the source files are based on template > files, which already have copyright headers, but for some, the complete > source

Re: RFR: 8313949: Missing word in GPLv2 license text in StackMapTableAttribute.java

2023-08-14 Thread David Holmes
On Mon, 14 Aug 2023 12:47:46 GMT, Dmitry Cherepanov wrote: > The PR suggests updating copyright headers in two files so that they are the > same as in other files. Looks good. I'm very surprised our header validation process did not pick this up. Thanks. - PR Review:

Re: RFR: 8314495: Update to use jtreg 7.3.1

2023-08-18 Thread David Holmes
On Thu, 17 Aug 2023 07:24:14 GMT, Christian Stein wrote: > Please review the change to update to using jtreg 7.3,1. > > The primary change is to the `jib-profiles.js` file, which specifies the > version of jtreg to use, for those systems that rely on this file. In > addition, the

Re: RFR: JDK-8313764: Offer JVM HS functionality to shared lib load operations done by the JDK codebase [v2]

2023-08-27 Thread David Holmes
On Wed, 23 Aug 2023 15:18:03 GMT, Matthias Baesken wrote: >> Currently there is a number of functionality that would be interesting to >> have for shared lib load operations in the JDK C code. >> Some examples : >> Events::log_dll_message for hs-err files reporting >> JFR event

Re: RFR: 8314491: Linux: jexec launched via PATH fails to find java [v6]

2023-08-27 Thread David Holmes
On Fri, 25 Aug 2023 07:04:50 GMT, Vladimir Petko wrote: >> 8314491: Linux: jexec launched via PATH fails to find java > > Vladimir Petko has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the

Re: RFR: 8315097: Rename createJavaProcessBuilder

2023-08-28 Thread David Holmes
On Mon, 28 Aug 2023 15:54:08 GMT, Leo Korinth wrote: > Rename createJavaProcessBuilder so that it is not used by mistake instead of > createTestJvm. > > I have used the following sed script: `find -name "*.java" | xargs -n 1 sed > -i -e >

Re: Enrich the Lock interface

2023-08-21 Thread David Holmes
On 21/08/2023 11:56 pm, Albert Attard wrote: Hello. Thank you very much Pavel for helping me find more information about this. After some research (mainly by Pavel) we found a thread, with subject "/Default Functions for Lock Interface/", from October 2013 that discussed this exact thing.  I

Re: RFR: 8314483: Optionally override copyright header in generated source [v2]

2023-08-24 Thread David Holmes
On Thu, 24 Aug 2023 17:36:46 GMT, Erik Joelsson wrote: >> In the JDK build we have various build tools that generate source code from >> data files. For most of these tools, the source files are based on template >> files, which already have copyright headers, but for some, the complete >>

Re: RFR: 8319200: Don't use test thread factory in ProcessTools.createLimitedTestJavaProcessBuilder() [v5]

2023-11-09 Thread David Holmes
On Fri, 10 Nov 2023 01:49:17 GMT, Leonid Mesnik wrote: >> Test thread factory is a mode similar to VM flags and should not be used in >> ProcessTools.createLimitedTestJavaProcessBuilder(). Only >> createTestJavaProcessBuilder() should use it like jtreg VM options. >> >> Adding the test thread

Re: RFR: 8319200: Don't use test thread factory in ProcessTools.createLimitedTestJavaProcessBuilder() [v5]

2023-11-09 Thread David Holmes
On Fri, 10 Nov 2023 01:49:17 GMT, Leonid Mesnik wrote: >> Test thread factory is a mode similar to VM flags and should not be used in >> ProcessTools.createLimitedTestJavaProcessBuilder(). Only >> createTestJavaProcessBuilder() should use it like jtreg VM options. >> >> Adding the test thread

Re: RFR: 8319200: Don't use test thread factory in ProcessTools.createLimitedTestJavaProcessBuilder() [v4]

2023-11-08 Thread David Holmes
On Wed, 8 Nov 2023 19:13:25 GMT, Leonid Mesnik wrote: >> Test thread factory is a mode similar to VM flags and should not be used in >> ProcessTools.createLimitedTestJavaProcessBuilder(). Only >> createTestJavaProcessBuilder() should use it like jtreg VM options. >> >> Adding the test thread

Re: RFR: 8319200: Don't use test thread factory in ProcessTools.createLimitedTestJavaProcessBuilder() [v4]

2023-11-08 Thread David Holmes
On Wed, 8 Nov 2023 19:13:25 GMT, Leonid Mesnik wrote: >> Test thread factory is a mode similar to VM flags and should not be used in >> ProcessTools.createLimitedTestJavaProcessBuilder(). Only >> createTestJavaProcessBuilder() should use it like jtreg VM options. >> >> Adding the test thread

Re: RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols

2023-11-08 Thread David Holmes
On Mon, 30 Oct 2023 10:54:48 GMT, suchismith1993 wrote: > 1. Adding required compiler flags. > 2. Adding required symbols. > > JBS-ISSUE : [JDK-8317799](https://bugs.openjdk.org/browse/JDK-8317799) I agree with Magnus that we need to understand the problem first, and then review the solution.

Re: RFR: 8319574: Exec/process tests should be marked as flagless

2023-11-08 Thread David Holmes
On Thu, 9 Nov 2023 06:43:12 GMT, Jaikiran Pai wrote: >> Tests that directly use ProcessBuilder to spawn processes and do not pass >> the standard test command line arguments should be marked as `vm.flagless` >> to indicate to the testing infrastructure that they do not accept them and >>

Re: RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols

2023-11-08 Thread David Holmes
On Wed, 8 Nov 2023 21:14:41 GMT, Magnus Ihse Bursie wrote: > Also, please don't ever force push once you have published a PR. Now it makes > Martin's comment just dangling in the air. @magicus I think the force-push happened whilst the PR was still in draft (skara bot did not complain), which

Re: RFR: 8319374: JFR: Remove instrumentation for exception events [v3]

2023-11-07 Thread David Holmes
On Tue, 7 Nov 2023 11:11:31 GMT, Erik Gahlin wrote: >> Could I have a review of a PR that removes the bytecode instrumentation for >> the exception events. >> >> Testing: jdk/jdk/jfr + tier1 + tier2 > > Erik Gahlin has updated the pull request incrementally with one additional > commit since

Re: RFR: 8287982: Concurrent implicit attach from native threads crashes VM

2022-06-22 Thread David Holmes
On Tue, 21 Jun 2022 08:13:29 GMT, Alan Bateman wrote: > One thing that I'm wondering for the test is whether to move it to > test/hotspot/jtreg/runtime/jni/ so it lives with the other tests for JNI. I > had expected to find other tests for AttachCurrentThread in that location but > we don't.

Re: DirectBufferAllocTest fails after replacement of Thread.sleep() with Thread.onSpinWait()

2022-06-22 Thread David Holmes
On 21/06/2022 9:35 pm, Сергей Цыпанов wrote: The takeaway from this exercise is that loops with sleeps can't always be replaced by loops that busy-wait. Functionally the logic is the same, but you can't just ignore the concurrency aspects. Thanks for explanation! Which indicates yielding

Re: RFR: 8288984: Simplification in Shutdown.exit [v2]

2022-07-07 Thread David Holmes
On Tue, 5 Jul 2022 04:51:50 GMT, Ryan Ernst wrote: >> YAO (Yet Another Opinion)! But I think we're actually converging. >> >> David's wording: >>>Invocations of this method are serialized such that only one invocation will >>>actually proceed with the shutdown sequence and terminate the VM

Re: RFR: 8288984: Simplification in Shutdown.exit [v3]

2022-07-05 Thread David Holmes
On Mon, 4 Jul 2022 16:17:27 GMT, Ryan Ernst wrote: >> This is a followup to simplify Shutdown.exit after the removal of >> finalizers (https://bugs.openjdk.org/browse/JDK-8198250). Once agreement >> on the approach has been reached in this PR, a CSR will be filed to >> propose the spec change to

Re: RFR: 8288984: Simplification in java.lang.Runtime::exit [v2]

2022-07-07 Thread David Holmes
On Tue, 5 Jul 2022 21:56:27 GMT, Kim Barrett wrote: > I think that isn't true. If a hook doesn't terminate then VM.shutdown doesn't > get called, so the window never gets cracked opened to call halt directly. @kimbarrett Any thread can call halt() directly while the attempted shutdown is in

Re: RFR: 8288984: Simplification in Shutdown.exit [v3]

2022-07-05 Thread David Holmes
On Mon, 4 Jul 2022 16:17:27 GMT, Ryan Ernst wrote: >> This is a followup to simplify Shutdown.exit after the removal of >> finalizers (https://bugs.openjdk.org/browse/JDK-8198250). Once agreement >> on the approach has been reached in this PR, a CSR will be filed to >> propose the spec change to

Re: RFR: 8288984: Simplification in Shutdown.exit [v2]

2022-07-03 Thread David Holmes
On Sat, 2 Jul 2022 21:21:37 GMT, Ryan Ernst wrote: >> This is a followup to simplify Shutdown.exit after the removal of >> finalizers (https://bugs.openjdk.org/browse/JDK-8198250). Once agreement >> on the approach has been reached in this PR, a CSR will be filed to >> propose the spec change to

Re: RFR: 8288984: Simplification in Shutdown.exit [v2]

2022-07-04 Thread David Holmes
On Mon, 4 Jul 2022 08:07:25 GMT, Chris Hegarty wrote: >> src/java.base/share/classes/java/lang/Runtime.java line 89: >> >>> 87: * of the first invocation will be used; the status codes from >>> other invocations >>> 88: * will be ignored. If this method is invoked from a shutdown

Re: RFR: 8288984: Simplification in Shutdown.exit [v2]

2022-07-04 Thread David Holmes
On Sat, 2 Jul 2022 21:21:37 GMT, Ryan Ernst wrote: >> This is a followup to simplify Shutdown.exit after the removal of >> finalizers (https://bugs.openjdk.org/browse/JDK-8198250). Once agreement >> on the approach has been reached in this PR, a CSR will be filed to >> propose the spec change to

Re: RFR: 8288984: Simplification in Shutdown.exit

2022-07-02 Thread David Holmes
On Fri, 1 Jul 2022 20:01:48 GMT, Ryan Ernst wrote: > This is a followup to simplify Shutdown.exit after the removal of > finalizers (https://bugs.openjdk.org/browse/JDK-8198250). Once agreement > on the approach has been reached in this PR, a CSR will be filed to > propose the spec change to

Re: RFR: 8289534: Change 'uncomplicated' hotspot runtime options

2022-07-01 Thread David Holmes
On Thu, 30 Jun 2022 18:39:58 GMT, Harold Seigel wrote: > Please review this small fix to change range constrained JVM runtime options > from 64 bits to 32 bits. This fix was tested with Mach5 tiers 1-2 on Linux, > Mac OS, and Windows, and Mach5 tiers 3-5 on Linux x64. > > Thanks, Harold The

Re: RFR: 8288984: Simplification in Shutdown.exit

2022-07-02 Thread David Holmes
On Fri, 1 Jul 2022 20:01:48 GMT, Ryan Ernst wrote: > This is a followup to simplify Shutdown.exit after the removal of > finalizers (https://bugs.openjdk.org/browse/JDK-8198250). Once agreement > on the approach has been reached in this PR, a CSR will be filed to > propose the spec change to

Re: RFR: 8271707: migrate tests to use jdk.test.whitebox.WhiteBox

2022-07-08 Thread David Holmes
On Thu, 7 Jul 2022 20:43:09 GMT, Coleen Phillimore wrote: > This change uses sed to change sun.hotspot.WhiteBox to > jdk.test.whitebox.Whitebox, and sun/hotspot/Whitebox similarly. Due to > indirect inclusions of some of the test libraries, changing a few wasn't a > reliable option, and I

Re: [jdk19] Integrated: 8289251: ProblemList java/lang/ref/OOMEInReferenceHandler.java

2022-06-27 Thread David Holmes
On Mon, 27 Jun 2022 21:16:29 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList java/lang/ref/OOMEInReferenceHandler.java. Marked as reviewed by dholmes (Reviewer). - PR: https://git.openjdk.org/jdk19/pull/80

Re: RFR: 8066859: java/lang/ref/OOMEInReferenceHandler.java failed with java.lang.Exception: Reference Handler thread died

2022-07-11 Thread David Holmes
On Fri, 8 Jul 2022 11:44:53 GMT, Doug Lea wrote: > 8066859 : java/lang/ref/OOMEInReferenceHandler.java failed with > java.lang.Exception: Reference Handler thread died src/java.base/share/classes/java/util/concurrent/locks/AbstractQueuedLongSynchronizer.java line 296: > 294: byte

Re: RFR: 8066859: java/lang/ref/OOMEInReferenceHandler.java failed with java.lang.Exception: Reference Handler thread died

2022-07-11 Thread David Holmes
On Mon, 11 Jul 2022 04:16:44 GMT, David Holmes wrote: >> 8066859 : java/lang/ref/OOMEInReferenceHandler.java failed with >> java.lang.Exception: Reference Handler thread died > > src/java.base/share/classes/java/util/concurrent/locks/LockSupport.java line > 463: > >

Re: RFR: 8288984: Simplification in Shutdown.exit [v3]

2022-07-06 Thread David Holmes
On Tue, 5 Jul 2022 03:24:28 GMT, Ryan Ernst wrote: >> src/java.base/share/classes/java/lang/Runtime.java line 88: >> >>> 86: * Shutdown is serialized such that only one invocation will run >>> 87: * shutdown hooks and terminate the VM with the given status code. >>> That >>> 88:

Re: RFR: 8288984: Simplification in Shutdown.exit [v3]

2022-07-06 Thread David Holmes
On Tue, 5 Jul 2022 04:47:40 GMT, Ryan Ernst wrote: >> First, the signal handlers actually invoke Shutdown.exit, not >> Shutdown.shutdown - see Terminator.setup(). (If they did the latter, like >> DestroyJavaVM, then an exit(status) call from another thread could still do >> the final VM

Re: RFR: 8288984: Simplification in java.lang.Runtime::exit [v5]

2022-07-06 Thread David Holmes
On Tue, 5 Jul 2022 18:43:26 GMT, Ryan Ernst wrote: >> This is a followup to simplify Shutdown.exit after the removal of >> finalizers (https://bugs.openjdk.org/browse/JDK-8198250). Once agreement >> on the approach has been reached in this PR, a CSR will be filed to >> propose the spec change to

Re: RFR: 8288495: [test] Make OutputAnalyzer exception more informative [v3]

2022-06-23 Thread David Holmes
On Thu, 23 Jun 2022 19:01:47 GMT, Roger Riggs wrote: >> The RuntimeException from OutputAnalyzer for expected and unexpected exit >> values should include both the actual and expected values. >> The method `shouldHaveExitvalue` and `shouldNotHaveExitValue` include the >> value expected and the

Re: Handling of USR2 signal in JVM on Linux

2022-06-16 Thread David Holmes
On 16/06/2022 12:09 am, Thomas Stüfe wrote: On Wed 15. Jun 2022 at 15:06, David Holmes <mailto:david.hol...@oracle.com>> wrote: On 15/06/2022 8:45 pm, Thomas Stüfe wrote: > More specifically, I propose to gracefully ignore SIGUSR2 in release > builds if the r

Re: DirectBufferAllocTest fails after replacement of Thread.sleep() with Thread.onSpinWait()

2022-06-20 Thread David Holmes
On 20/06/2022 7:43 pm, Сергей Цыпанов wrote: Hello, while playing with Thread.onSpinWait() in busy-wait loops I've replaced Thread.sleep() with preferable (at least as it appears from the JavaDoc) Thread.onSpinWait() in java.nio.Bits. Immediately after that DirectBufferAllocTest started to

Re: DirectBufferAllocTest fails after replacement of Thread.sleep() with Thread.onSpinWait()

2022-06-20 Thread David Holmes
On 21/06/2022 12:49 am, Сергей Цыпанов wrote: Do you get the OOME using Thread.yield() or just a busy-wait? I reproduce it with busy-wait involving Thread.onSpinWait() and only when the test is run with -XX:MaxDirectMemorySize=128m -XX:-ExplicitGCInvokesConcurrent If I either drop

Re: jvm crash on memmove_ssse3_back

2022-06-20 Thread David Holmes
. Cheers, David Holmes (0 bytes) @ 0x7fd609f881fd [0x7fd609f88180+0x7d] J 4832 C1 org.fusesource.leveldbjni.internal.NativeDB.put(Lorg/fusesource/leveldbjni/internal/NativeWriteOptions;[B[B)V (76 bytes) @ 0x7fd609f9f70c [0x7fd609f9ed20+0x9ec] J 4831 C1

Re: RFR: 8287982: Concurrent implicit attach from native threads crashes VM

2022-06-21 Thread David Holmes
On Thu, 16 Jun 2022 13:34:18 GMT, Alan Bateman wrote: > If several native threads attach to the VM at around the same time, and > before any threads get an automatically generated name are created, then the > VM may crash attempting to access the thread status. The issue exists for > native

Re: [jdk19] RFR: 8278274: Update nroff pages in JDK 19 before RC

2022-07-19 Thread David Holmes
On Mon, 18 Jul 2022 23:27:58 GMT, David Holmes wrote: >> src/java.base/share/man/keytool.1 line 456: >> >>> 454: \f[CB]PrivateKeyEntry\f[R] for the signer that already exists in the >>> 455: keystore. >>> 456: This option is used to sign th

[jdk19] Integrated: 8278274: Update nroff pages in JDK 19 before RC

2022-07-19 Thread David Holmes
On Sun, 17 Jul 2022 22:44:02 GMT, David Holmes wrote: > Please review these changes to the nroff manpage files so that they match > their markdown sources that Oracle maintains. > > All pages at a minimum have 19-ea replaced with 19, and copyright set to 2022 > if needed

RFR: 8290489: Initial nroff manpage generation for JDK 20

2022-07-20 Thread David Holmes
The version will be 20-ea and the copyright year 2023 (for March 2023 release date). Thanks. - Commit messages: - 8290489: Initial nroff manpage generation for JDK 20 Changes: https://git.openjdk.org/jdk/pull/9581/files Webrev: https://webrevs.openjdk.org/?repo=jdk=9581=00

Re: [jdk19] RFR: 8278274: Update nroff pages in JDK 19 before RC

2022-07-18 Thread David Holmes
On Mon, 18 Jul 2022 15:26:23 GMT, Jonathan Gibbons wrote: >> Please review these changes to the nroff manpage files so that they match >> their markdown sources that Oracle maintains. >> >> All pages at a minimum have 19-ea replaced with 19, and copyright set to >> 2022 if needed.

Re: RFR: JDK-8290460: Alpine: disable some panama tests that rely on std::thread

2022-07-19 Thread David Holmes
On Mon, 18 Jul 2022 14:21:19 GMT, Thomas Stuefe wrote: > Until [JDK-8290059](https://bugs.openjdk.org/browse/JDK-8290059) is solved, > I'd like to disable > > - java/foreign/TestUpcallAsync.java > - java/foreign/enablenativeaccess/TestEnableNativeAccess.java > > on muslc to take load from our

Re: RFR: 8290264 : java/util/concurrent/locks/Lock/OOMEInAQS.java fails with "exit code: 0"

2022-07-14 Thread David Holmes
On Thu, 14 Jul 2022 11:57:37 GMT, Doug Lea wrote: > This test now conforms to jtreg rules about not using System.exit to cover > untested OutOfMemoryErrors Hi Doug, One pre-existing style nit but otherwise the termination logic seems okay. Thanks.

Re: RFR: 8066859: java/lang/ref/OOMEInReferenceHandler.java failed with java.lang.Exception: Reference Handler thread died [v4]

2022-07-13 Thread David Holmes
On Wed, 13 Jul 2022 16:58:21 GMT, Doug Lea wrote: >> 8066859 : java/lang/ref/OOMEInReferenceHandler.java failed with >> java.lang.Exception: Reference Handler thread died > > Doug Lea has updated the pull request incrementally with one additional > commit since the last revision: > >

Re: Unused static field AbstractWatchKey#OVERFLOW_EVENT

2022-07-22 Thread David Holmes
On 22/07/2022 5:42 pm, Andrey Turbanov wrote: Hello. I noticed unused field sun.nio.fs.AbstractWatchKey#OVERFLOW_EVENT https://github.com/openjdk/jdk/blob/e9f97b2e8cf301ba6b69101e5efc5c71d26bc87b/src/java.base/share/classes/sun/nio/fs/AbstractWatchKey.java#L45 As I can see, it was already

Integrated: 8290489: Initial nroff manpage generation for JDK 20

2022-07-21 Thread David Holmes
On Thu, 21 Jul 2022 00:34:53 GMT, David Holmes wrote: > The version will be 20-ea and the copyright year 2023 (for March 2023 release > date). > > Thanks. This pull request has now been integrated. Changeset: e9f97b2e Author:David Holmes URL: https://git.openjdk.or

Re: RFR: 8290059: Do not use std::thread in panama tests [v2]

2022-07-23 Thread David Holmes
On Fri, 22 Jul 2022 16:45:55 GMT, Jorn Vernee wrote: >> This patch removes the use of std::thread from the `java.lang.foreign` >> tests, and switches to the OS specific thread APIs, in order to change >> things such as the stack size on some platforms where this is required in >> the future

RFR: Merge jdk19

2022-07-26 Thread David Holmes
Forward port JDK 19 -> JDK 20 - Commit messages: - Merge remote-tracking branch 'jdk19/master' into Merge_jdk19 - 8290455: jck test api/java_lang/foreign/VaList/Empty.html fails on some platforms - 8290460: Alpine: disable some panama tests that rely on std::thread The merge

Re: RFR: 8290059: Do not use std::thread in panama tests [v2]

2022-07-27 Thread David Holmes
On Tue, 26 Jul 2022 13:10:00 GMT, Jorn Vernee wrote: > Does run_in_new_thread seem good enough? No, sorry, the fact it both runs and joins is a critical aspect. `run_async` in `CompleteableFuture` just does the "run in new thread" part, whereas the `get()` on the returned `FutureTask`

Re: RFR: Merge jdk19

2022-07-27 Thread David Holmes
On Wed, 27 Jul 2022 05:29:09 GMT, David Holmes wrote: > Forward port JDK 19 -> JDK 20 Need to pull in a follow up test fix so closing this MR. - PR: https://git.openjdk.org/jdk/pull/9651

Withdrawn: Merge jdk19

2022-07-27 Thread David Holmes
On Wed, 27 Jul 2022 05:29:09 GMT, David Holmes wrote: > Forward port JDK 19 -> JDK 20 This pull request has been closed without being integrated. - PR: https://git.openjdk.org/jdk/pull/9651

Integrated: Merge jdk19

2022-07-27 Thread David Holmes
On Wed, 27 Jul 2022 12:59:36 GMT, David Holmes wrote: > Forward port JDK 19 -> JDK 20 This pull request has now been integrated. Changeset: 92346246 Author: David Holmes URL: https://git.openjdk.org/jdk/commit/923462467e52eda359249a4fb61d654f56182603 Stats: 134 lines in 4

Integrated: Merge jdk19

2022-07-27 Thread David Holmes
Forward port JDK 19 -> JDK 20 - Commit messages: - Merge remote-tracking branch 'jdk19/master' into Merge_jdk19 - 8291006: java/foreign/TestUnsupportedPlatform fails after JDK-8290455 - 8290455: jck test api/java_lang/foreign/VaList/Empty.html fails on some platforms - 8290460:

Re: RFR: 8290059: Do not use std::thread in panama tests [v2]

2022-07-27 Thread David Holmes
On Wed, 27 Jul 2022 14:29:26 GMT, Jorn Vernee wrote: > startThread and joinThread is not the functionality that the tests need. But it is the functionality the tests are already using. > now the context passed to CreateThread and pthread_create has to outlive the > function That's not an

[jdk19] RFR: 8278274: Update nroff pages in JDK 19 before RC

2022-07-17 Thread David Holmes
Please review these changes to the nroff manpage files so that they match their markdown sources that Oracle maintains. All pages at a minimum have 19-ea replaced with 19, and copyright set to 2022 if needed. Additionally: The Java manpage was missing updates from: -

  1   2   3   4   5   6   >