> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8315558)
> which is a conformance change to document some exceptions in the
> specification of java.text.StringCharacterIterator.
Justin Lu has updated the pull request incrementally with one additional commit
since
On Fri, 1 Sep 2023 22:26:00 GMT, Justin Lu wrote:
>> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8315720)
>> which refines the spec of `equals()` and `hashCode()` in `java.text.Format`
>> related classes.
>>
>> The current spec for m
te_ or any inheritors
> and can be removed.
>
> As a result, _ImmutableGregorianDate_ no longer needs to override the
> _setLocale_ method and throw UnsupportedOperationException.
Justin Lu has updated the pull request incrementally with one additional commit
since the last re
On Fri, 15 Sep 2023 18:54:19 GMT, Justin Lu wrote:
>> Please review this PR which is a continuation of
>> [JDK-6453901](https://bugs.openjdk.org/browse/JDK-6453901) to remove unused
>> code from the _sun.util.Calendar_ classes.
>>
>> `forceStandardTime` is al
te_ or any inheritors
> and can be removed.
>
> As a result, _ImmutableGregorianDate_ no longer needs to override the
> _setLocale_ method and throw UnsupportedOperationException.
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision
On Thu, 24 Aug 2023 21:39:39 GMT, Justin Lu wrote:
> Please review this PR and [CSR
> ](https://bugs.openjdk.org/browse/JDK-8314974)which clarifies behavior for
> BreakIterator instances when text has not been set.
>
> For example, calling `BreakIterator.getWordInstance
On Tue, 29 Aug 2023 16:53:29 GMT, Justin Lu wrote:
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8315148)
> which is a conformance change to specify exceptions in java.text.ChoiceFormat.
>
> Makes `IllegalArgumentException` apparent for `applyPattern` and
&
t;
> DecimalFormat df = new DecimalFormat("000.000");
> df.getMaximumIntegerDigits(); // ==> 2147483647
> DecimalFormat df = new DecimalFormat("000.000E0");
> df.getMaximumIntegerDigits(); // ==> 3
>
>
> Method descriptions should be fixed, and the relevant c
fix adjusts the spec to provide a consistent definition for the
> overridden methods and specify what is being compared/used to generate a hash
> code value.
>
> For implementations that use at most a few fields, the values are stated,
> otherwise a more general term is used as a substitu
the constructor.
>
> The pattern syntax may be easier to view ->
> https://cr.openjdk.org/~jlu/api/java.base/java/text/ChoiceFormat.html
Justin Lu has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains ten commits:
- merge ma
fix adjusts the spec to provide a consistent definition for the
> overridden methods and specify what is being compared/used to generate a hash
> code value.
>
> For implementations that use at most a few fields, the values are stated,
> otherwise a more general term is used as a substitu
Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8315558)
which is a conformance change to document some exceptions in the specification
of java.text.StringCharacterIterator.
-
Commit messages:
- copyright year
- init
Changes:
On Fri, 8 Sep 2023 23:02:02 GMT, Justin Lu wrote:
> Please review this change which adjusts the pattern syntax specification for
> the two classes to represent the actual behavior. That is, U+FFFE and U+
> are allowed in the suffix/prefix. (Additionally; 'Unicode' is dro
JDK .properties files still use ISO-8859-1 encoding with escape sequences. It
would improve readability to see the native characters instead of escape
sequences (especially for the L10n process). The majority of files changed are
localized resource files.
This change converts the Unicode
the constructor.
>
> The pattern syntax may be easier to view ->
> https://cr.openjdk.org/~jlu/api/java.base/java/text/ChoiceFormat.html
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
Use description tags to create synta
Please review this PR which is a continuation of
[JDK-6453901](https://bugs.openjdk.org/browse/JDK-6453901) to remove unused
code from the _sun.util.Calendar_ classes.
`forceStandardTime` is always false.
In addition, `locale` is never by used by _CalendarDate_ or any inheritors and
can be
or .properties files need
> to be updated to UTF-8. (IntelliJ IDEA locks .properties files as ISO-8859-1
> unless manually changed).
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
Replace InputStreamReader with BufferedReader
---
ated,
> otherwise a more general term is used as a substitution (i.e. see
> `DecimalFormat`).
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
Adjust spec to not spec ALL, prevent potential maintenance/peformance issue
-
On Wed, 13 Sep 2023 19:40:04 GMT, Justin Lu wrote:
>> Please review this PR which is a continuation of
>> [JDK-6453901](https://bugs.openjdk.org/browse/JDK-6453901) to remove unused
>> code from the _sun.util.Calendar_ classes.
>>
>> `forceStandardTime` is al
ated,
> otherwise a more general term is used as a substitution (i.e. see
> `DecimalFormat`).
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
Replace non-static with instance
-
Changes:
- all: https:/
On Wed, 13 Sep 2023 18:12:15 GMT, Naoto Sato wrote:
> Looks good to me, although I did not look at each l10n file, but sampled
> some. Thanks for tackling this conversion.
Thanks for the review; (In addition to testing), I ran a script to verify only
white space escape sequences exist in JDK
te_ or any inheritors
> and can be removed.
>
> As a result, _ImmutableGregorianDate_ no longer needs to override the
> _setLocale_ method and throw UnsupportedOperationException.
Justin Lu has updated the pull request incrementally with one additional commit
since the last r
On Tue, 22 Aug 2023 19:18:35 GMT, Justin Lu wrote:
> Please review this PR and associated
> [CSR](https://bugs.openjdk.org/browse/JDK-8314546) which expands on the
> `java.text.ChoiceFormat` specification regarding its pattern.
>
> `j.text.ChoiceFormat` provides an
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8315558)
> which is a conformance change to document some exceptions in the
> specification of java.text.StringCharacterIterator.
Justin Lu has updated the pull request incrementally with one additional commit
since
On Wed, 6 Sep 2023 23:04:59 GMT, Naoto Sato wrote:
> Could the first choice be more specific?
Updated with a more syntactical definition. Please let me know if you think
this is _too_ specific.
> Also, do SubPatterns need to be sorted with Limits?
If I am interpreting the question right,
the constructor.
>
> The pattern syntax may be easier to view ->
> https://cr.openjdk.org/~jlu/api/java.base/java/text/ChoiceFormat.html
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
Reflect Naoto's comments fro
the constructor.
>
> The pattern syntax may be easier to view ->
> https://cr.openjdk.org/~jlu/api/java.base/java/text/ChoiceFormat.html
Justin Lu has updated the pull request incrementally with three additional
commits since the last revision:
- Make starting sentence consisten
On Thu, 7 Sep 2023 19:35:06 GMT, Naoto Sato wrote:
> This should be excluded from the pattern syntax
I presume you meant that the syntax should _include_ the required ascending
order of limits. Updated to make this apparent, I also adjusted the syntax a
little bit to be more accurate. The
the constructor.
>
> The pattern syntax may be easier to view ->
> https://cr.openjdk.org/~jlu/api/java.base/java/text/ChoiceFormat.html
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
Review: Make ascending format cl
Please review this change which adjusts the pattern syntax specification for
the two classes to represent the actual behavior. That is, U+FFFE and U+
are allowed in the suffix/prefix. (Additionally; 'Unicode' is dropped from the
definitions, as a Java character is composed of Unicode code
On Fri, 8 Sep 2023 20:21:56 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - Make starting sentence consistent with other Format classes. Improve
>> wording
the constructor.
>
> The pattern syntax may be easier to view ->
> https://cr.openjdk.org/~jlu/api/java.base/java/text/ChoiceFormat.html
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
Drop Unicode from definition, im
On Fri, 1 Sep 2023 23:12:28 GMT, Justin Lu wrote:
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8315558)
> which is a conformance change to document some exceptions in the
> specification of java.text.StringCharacterIterator.
This pull request has now been i
On Tue, 29 Aug 2023 16:40:07 GMT, Naoto Sato wrote:
> I think the same wording changes are needed in the test, as it checks the
> error messages word by word.
You're totally right, just fixed.
-
PR Comment: https://git.openjdk.org/jdk/pull/15458#issuecomment-1697803949
Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8315148)
which is a conformance change to specify exceptions in java.text.ChoiceFormat.
Makes `IllegalArgumentException` apparent for `applyPattern` and `setChoices`,
as well as for the associated constructors that call the
On Tue, 29 Aug 2023 16:53:29 GMT, Justin Lu wrote:
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8315148)
> which is a conformance change to specify exceptions in java.text.ChoiceFormat.
>
> Makes `IllegalArgumentException` apparent for `applyPattern` and
&
> Please review this PR which updates some exceptions in j.util.Currency to
> have an explicit error message (as opposed to nothing).
>
> The exceptions are thrown when the ISO 4217/3166 currency/country codes are
> in an invalid form, or do not exist.
Justin Lu has updated t
On Tue, 29 Aug 2023 18:02:51 GMT, Naoto Sato wrote:
>> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8314607)
>> which clarifies the behavior of patterns in regards to the max integer
>> digits in j.text.DecimalFormat.
>>
>> The current specification (of `applyPattern`)
t;
> DecimalFormat df = new DecimalFormat("000.000");
> df.getMaximumIntegerDigits(); // ==> 2147483647
> DecimalFormat df = new DecimalFormat("000.000E0");
> df.getMaximumIntegerDigits(); // ==> 3
>
>
> Method descriptions should be fixed, and the relevant cons
On Tue, 29 Aug 2023 18:02:51 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reflect review comments: Non sci notation first. Link to Scientific
>> Notation section
&
> BreakIterator instance to default to a `StringCharacterIterator` with an
> empty string (equivalent to calling setText("")).
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
Use implNote tag
-
Changes:
On Mon, 28 Aug 2023 21:14:53 GMT, Justin Lu wrote:
> Please review this PR which updates some exceptions in j.util.Currency to
> have an explicit error message (as opposed to nothing).
>
> The exceptions are thrown when the ISO 4217/3166 currency/country codes are
> in an inva
On Tue, 12 Sep 2023 21:57:31 GMT, Justin Lu wrote:
> JDK .properties files still use ISO-8859-1 encoding with escape sequences. It
> would improve readability to see the native characters instead of escape
> sequences (especially for the L10n process). The majority of file
te_ or any inheritors
> and can be removed.
>
> As a result, _ImmutableGregorianDate_ no longer needs to override the
> _setLocale_ method and throw UnsupportedOperationException.
Justin Lu has updated the pull request incrementally with one additional commit
since the last rev
On Fri, 18 Aug 2023 21:28:34 GMT, Justin Lu wrote:
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8314607)
> which clarifies the behavior of patterns in regards to the max integer
> digits in j.text.DecimalFormat.
>
> The current specification (o
ated,
> otherwise a more general term is used as a substitution (i.e. see
> `DecimalFormat`).
Justin Lu has updated the pull request incrementally with two additional
commits since the last revision:
- CSR review: Adjust equals wording, improve correctness of hashCode
defin
On Tue, 3 Oct 2023 22:23:11 GMT, Justin Lu wrote:
> Please review this PR which refactors a number of tests under
> `test/text/NumberFormat` to use JUnit.
>
> During the switch to JUnit, the tests had the following updates (to improve
> readability)
> - separate the test da
Please review this PR which adjusts the specification of
`DateFormat.Field::getCalendarField` to conform to the implementation.
`getCalendarField()` claims that it will return -1 if there is no corresponding
`Calendar` constant.
Although the built-in DateFormat.Fields with no associated
On Tue, 17 Oct 2023 20:06:03 GMT, Justin Lu wrote:
> This change updates the IANA subtag registry to the update released on
> 2023-10-16.
>
> Announcement ->
> https://mm.icann.org/pipermail/ietf-languages-announcements/2023-October/89.html
This pull request has n
On Fri, 29 Sep 2023 20:46:44 GMT, Justin Lu wrote:
> Please review this PR and which adjusts the pattern section of
> java.text.ChoiceFormat to specify the single quote behavior within a String
> pattern.
>
> The other Format classes that take a String pattern such a
On Mon, 23 Oct 2023 17:16:08 GMT, Justin Lu wrote:
> Please review this PR which clarifies inconsistency between
> `ChoiceFormat::applyPattern` and `ChoiceFormat::setChoices`.
>
> A `ChoiceFormat` is composed of limits and formats. `applyPattern()` will
> throw an exce
On Mon, 23 Oct 2023 21:15:44 GMT, Justin Lu wrote:
> Please review this PR which adds a test for ChoiceFormat intended to test a
> wide range of ChoiceFormat patterns.
>
> The existing test _Bug4387255_ only tests a singular basic pattern and does
> not test for incorrect
On Fri, 27 Oct 2023 18:00:38 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - additional cleanup/wording changes
>> - replace spec fix with private methods
>
> s
mat::applyPattern_. The code should be updated so that both the
> methods and constructors call a separate private method. Some other drive-by
> cleanup changes were included in the change as well.
Justin Lu has updated the pull request incrementally with one additional commit
since the last revi
both ChoiceFormat and MessageFormat call the
> public and non-final applyPattern method; any changes in the applyPattern of
> a subclass will be reflected in the constructors as well.
Justin Lu has updated the pull request incrementally with two additional
commits since the last revision
On Thu, 5 Oct 2023 20:44:55 GMT, Justin Lu wrote:
> Please review this PR which updates ChoiceFormat and MessageFormat to no
> longer call overridable methods in their constructors.
>
> The overridable methods called in the constructors are:
> _ChoiceFormat::applyPattern_
Please review this simple change which refines the specification of some
NumberFormat methods (with unsupported operations) to separate the API and
implementation specification.
-
Commit messages:
- cleanup setRoundingMode()
- Merge branch 'master' into
Please review this PR which clarifies the definition of a _cancelled_ task in
_j.util.Timer::purge_ and _j.util.Timer::cancel_.
Timer::purge claims that its return value is the number of tasks in the queue
that were cancelled. This can be misleading, as a user can call Timer::cancel,
thinking
On Wed, 1 Nov 2023 21:27:57 GMT, Justin Lu wrote:
> Please review this simple change which refines the specification of some
> NumberFormat methods (with unsupported operations) to separate the API and
> implementation specification.
This pull request has now been integrated.
On Fri, 3 Nov 2023 20:40:11 GMT, Justin Lu wrote:
> Please review this PR which clarifies the definition of a _cancelled_ task in
> _j.util.Timer::purge_ and _j.util.Timer::cancel_.
>
> Timer::purge claims that its return value is the number of tasks in the queue
> that
Please review this PR which adds a test for ChoiceFormat intended to test a
wide range of ChoiceFormat patterns.
The existing test _Bug4387255_ only tests a singular basic pattern and does not
test for incorrect patterns either.
The new test checks
- both correct and incorrect patterns
- the
On Mon, 23 Oct 2023 22:19:15 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> implement feedback
>
> test/jdk/java/text/Format/ChoiceFormat/Patte
>
> - both correct and incorrect patterns
> - the behavior of incorrect patterns that either throw an
> IllegalArgumentException or discard the incorrect portion
> - the case of formatting with an empty pattern (that leads to empty limits
> and formats)
Justin Lu has updated the pull re
On Tue, 19 Sep 2023 16:48:54 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request with a new target base due to a merge
>> or a rebase. The pull request now contains 15 commits:
>>
>> - Re-import Locale after merge for Formatter
>> - Merge
ended by
> (`Gregorian, JulianCalendar, LocalGregorianCalendar`)
>
> `CalendarDate` extended by `BaseCalendar.Date` extended by
> (`Gregorian.Date, ImmutableGregorianDate, JulianCalendar.Date,
> LocalGregorianCalendar.Date`)
>
> Additionally, CalendarUtils was made `final`, as it is a
ended by
> (`Gregorian, JulianCalendar, LocalGregorianCalendar`)
>
> `CalendarDate` extended by `BaseCalendar.Date` extended by
> (`Gregorian.Date, ImmutableGregorianDate, JulianCalendar.Date,
> LocalGregorianCalendar.Date`)
>
> Additionally, CalendarUtils was made `final`, as it is a
ended by
> (`Gregorian, JulianCalendar, LocalGregorianCalendar`)
>
> `CalendarDate` extended by `BaseCalendar.Date` extended by
> (`Gregorian.Date, ImmutableGregorianDate, JulianCalendar.Date,
> LocalGregorianCalendar.Date`)
>
> Additionally, CalendarUtils was made `final`, as it is a
On Tue, 19 Sep 2023 01:01:14 GMT, Naoto Sato wrote:
> Fixed the failing (well, false-positive) test case. Made the following
> changes to the test:
>
> - Corrected the path to the mapping files directory
> - Made sure to fail if the directory path is incorrect
> - Took care of `GB18030` alias,
> Please review this PR which converts some tests under _Calendar_ to use
> JUnit. These tests either previously used the internal _IntlTest_, or used no
> framework at all.
>
> Any files named BugXXX.java will be renamed after review.
Justin Lu has updated the pull reques
On Fri, 22 Sep 2023 06:44:16 GMT, Andrey Turbanov wrote:
>> Justin Lu has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Review: revert removal of SupressWarnings annotation
>> - Reflect review comments
&
On Thu, 21 Sep 2023 22:18:04 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Review: revert removal of SupressWarnings annotation
>> - Reflect review comments
&
> Please review this PR which converts some tests under _Calendar_ to use
> JUnit. These tests either previously used the internal _IntlTest_, or used no
> framework at all.
>
> Any files named BugXXX.java will be renamed after review.
Justin Lu has updated the pull reques
> Please review this PR which converts some tests under _Calendar_ to use
> JUnit. These tests either previously used the internal _IntlTest_, or used no
> framework at all.
>
> Any files named BugXXX.java will be renamed after review.
Justin Lu has updated the pull reques
On Fri, 22 Sep 2023 20:45:39 GMT, Lance Andersen wrote:
> Overall, this is fine.
>
> I would like to suggest comments to introduce all tests and DataProviders.
> Extra credit for helper methods.
>
> From a future maintainers Point of view, having more info in the tests is
> beneficial.
On Wed, 20 Sep 2023 22:10:16 GMT, Justin Lu wrote:
> Please review this PR, which updates the exception message for
> java.text.DateFormatSymbols.setZoneStrings
>
> `setZoneStrings()` takes a multi dimensional array as input. If any row does
> not have a lengt
On Mon, 18 Sep 2023 22:42:09 GMT, Justin Lu wrote:
> Please review this PR which restricts sub-classing of the internal calendar
> system in sun.util.calendar to only the existing implementations. Drive by
> cleanup included.
>
> As the implementation is long-standi
manually adjusted
> - Also clarified some tests that had optional argument setup in the main
> method (now removed)
>
> removal of IntlTest and CollatorTest -
> [8ee9f9c](https://github.com/openjdk/jdk/commit/8ee9f9c79f79210ee6244186970d87a1cac05556)
> - Removes both the test
manually adjusted
> - Also clarified some tests that had optional argument setup in the main
> method (now removed)
>
> removal of IntlTest and CollatorTest -
> [8ee9f9c](https://github.com/openjdk/jdk/commit/8ee9f9c79f79210ee6244186970d87a1cac05556)
> - Removes both the test cla
ated,
> otherwise a more general term is used as a substitution (i.e. see
> `DecimalFormat`).
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
Implement CSR review and WS fix in CompactNumberFormat
-
Changes:
- all:
> Please review this PR which converts some tests under _Calendar_ to use
> JUnit. These tests either previously used the internal _IntlTest_, or used no
> framework at all.
>
> Any files named BugXXX.java will be renamed after review.
Justin Lu has updated the pull reques
On Wed, 20 Sep 2023 23:20:43 GMT, Justin Lu wrote:
> Please review this PR which converts some tests under _Calendar_ to use
> JUnit. These tests either previously used the internal _IntlTest_, or used no
> framework at all.
>
> Any files named BugXXX.java will be renam
On Mon, 28 Aug 2023 21:24:18 GMT, Justin Lu wrote:
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8315720)
> which refines the spec of `equals()` and `hashCode()` in `java.text.Format`
> related classes.
>
> The current spec for most of these me
> Please review this PR which converts some tests under _Calendar_ to use
> JUnit. These tests either previously used the internal _IntlTest_, or used no
> framework at all.
>
> Any files named BugXXX.java will be renamed after review.
Justin Lu has updated the pull reques
Please review this PR which removes the i18n related testing base classes
`IntlTest` and `CollatorTest` and converts all the tests that use them,
IntlTest and CollatorTest are testing classes which are extended by tests in
`text/`, `util/Locale`, `util/TimeZone`, and `util/Calendar`. The
s://github.com/openjdk/jdk/pull/15954/commits/f90266f4f019c031c5f985dd658f62a02cc8b422)
>
> [3c67679](https://github.com/openjdk/jdk/pull/15954/commits/3c676794dd0c703db066a346c36e213d113d9acc)
> - Removes IntlTest in both the testlib and under TimeZone/
> - Replaces CollatorTest with Colla
On Thu, 28 Sep 2023 01:02:46 GMT, Justin Lu wrote:
> Please review this PR which removes the i18n related testing base classes
> `IntlTest` and `CollatorTest` and converts all the tests that use them,
>
> IntlTest and CollatorTest are testing classes which are extended by tests
ended by
> (`Gregorian, JulianCalendar, LocalGregorianCalendar`)
>
> `CalendarDate` extended by `BaseCalendar.Date` extended by
> (`Gregorian.Date, ImmutableGregorianDate, JulianCalendar.Date,
> LocalGregorianCalendar.Date`)
>
> Additionally, CalendarUtils was made `final`, as it is a
Please review this PR, which updates the exception message for
java.text.DateFormatSymbols.setZoneStrings
`setZoneStrings()` takes a multi dimensional array as input. If any row does
not have a length of at least 5, an _IllegalArgumentException_ is thrown. The
exception should indicate why it
On Wed, 13 Sep 2023 17:52:13 GMT, Justin Lu wrote:
> Please review this PR which is a continuation of
> [JDK-6453901](https://bugs.openjdk.org/browse/JDK-6453901) to remove unused
> code from the _sun.util.Calendar_ classes.
>
> `forceStandardTime` is always false.
>
>
Please review this PR which restricts sub-classing of the internal calendar
system in sun.util.calendar to only the existing implementations.
As the implementation is long-standing and complete with no intent for future
sub-classing, the CalendarSystem should be made sealed. Modifiers adjusted
Please review this PR which converts some tests under _Calendar_ to use JUnit.
These tests either previously used the internal _IntlTest_, or used no
framework at all.
Any files named BugXXX.java will be renamed after review.
-
Commit messages:
- Separate data generation and
On Wed, 20 Sep 2023 16:12:36 GMT, Naoto Sato wrote:
>> Fixing a test case that fails in some time zones. Making sure the test is
>> run in `UTC` zone will fix the issue. Confirmed the fix by manually setting
>> machine's time zone to Europe/Dublin.
>
> Naoto Sato has updated the pull request
Please review this PR and which adjusts the pattern section of
java.text.ChoiceFormat to specify the single quote behavior within a String
pattern.
The other Format classes that take a String pattern such as DecimalFormat,
CompactNumberFormat, and MessageFormat all provide specification on
s://github.com/openjdk/jdk/pull/15954/commits/f90266f4f019c031c5f985dd658f62a02cc8b422)
>
> [3c67679](https://github.com/openjdk/jdk/pull/15954/commits/3c676794dd0c703db066a346c36e213d113d9acc)
> - Removes IntlTest in both the testlib and under TimeZone/
> - Replaces CollatorTest with Co
On Fri, 29 Sep 2023 17:30:42 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> cleanup util classes in text/testlib
>
> test/jdk/java/text/BreakIterator/BreakIterato
s://github.com/openjdk/jdk/pull/15954/commits/f90266f4f019c031c5f985dd658f62a02cc8b422)
>
> [3c67679](https://github.com/openjdk/jdk/pull/15954/commits/3c676794dd0c703db066a346c36e213d113d9acc)
> - Removes IntlTest in both the testlib and under TimeZone/
> - Replaces CollatorTest with Colla
On Fri, 29 Sep 2023 22:00:23 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request with a new target base due to a merge
>> or a rebase. The pull request now contains seven commits:
>>
>> - merge master and resolve conflicts
>> - implement feedb
gt; - create distinct test methods so that all the tests aren't just run under
> one big method (e.g. main)
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
Reflect review comments
-
Changes:
- all: https://git.openjdk.
On Mon, 9 Oct 2023 20:13:39 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reflect review comments
>
> test/jdk/java/text/Format/NumberFormat/BigDecimalCompatibilityTe
gt; - create distinct test methods so that all the tests aren't just run under
> one big method (e.g. main)
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
Swap grouping and decimal separator
-
Changes:
- all: https://
1 - 100 of 776 matches
Mail list logo
