ed for reading environmental variables.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Add extra test run with no SecutityManager
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15564/files
- new: https://git.openjdk.org/j
On Tue, 5 Sep 2023 09:36:59 GMT, ExE Boss wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add a SecurityManager for TestLinker
>
> test/jdk/java/foreign/TestLinker.java line 30:
&
EncodeDecode.testEncodeUTF8 61024 75 15
> 1,772 ± 0,013 1,387 ± 0,032 ms/op 21,8% (p = 0,000*)
> URLEncodeDecode.testEncodeUTF8 61024 100 15
> 1,230 ± 0,009 1,140 ± 0,011 ms/op 7,3% (p = 0,000*)
Per Minborg has updated the
EncodeDecode.testEncodeUTF8 61024 75 15
> 1,772 ± 0,013 1,387 ± 0,032 ms/op 21,8% (p = 0,000*)
> URLEncodeDecode.testEncodeUTF8 61024 100 15
> 1,230 ± 0,009 1,140 ± 0,011 ms/op 7,3% (p = 0,000*)
Per Minborg has updated the p
This PR proposes to read the system environment variable "SystemRoot" using a
privileged operation so it will work in the event a default SecurityManager is
in place.
As the `SecurityManager` is deprecated for removal, no support methods were
added for reading environmental variables.
On Fri, 1 Sep 2023 08:21:13 GMT, Per Minborg wrote:
> This PR proposes adding a new method to BitSet that provides an immutable
> snapshot of the set in the form of an `IntPredicate`.
>
> The predicate is eligible for constant folding.
>
> Here are some classes in the JDK
ed for reading environmental variables.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Add a SecurityManager for TestLinker
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15564/files
- new: https://git.openjdk.org/j
On Fri, 8 Sep 2023 15:54:05 GMT, Alan Bateman wrote:
> There are several methods defined by sun.misc.Unsafe that have standard API
> equivalents for many years and releases. The change proposed here is to
> deprecate, for removal, the park, unpark, getLoadAverage, loadFence,
> storeFence, and
This PR proposes to slightly improve some iterators of `AbstractMap`:
* Code reuse
* A field declared `final`
* Add missing `@Override` annotations
-
Commit messages:
- Improve AbstractMap anonymous Iterator classes
Changes: https://git.openjdk.org/jdk/pull/15615/files
Webrev:
ed for reading environmental variables.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Add privilidged action and restrict grants
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15564/files
- new: https://git.openjdk.org/j
On Tue, 5 Sep 2023 08:52:50 GMT, Per Minborg wrote:
> This PR proposes to read the system environment variable "SystemRoot" using a
> privileged operation so it will work in the event a default SecurityManager
> is in place.
>
> As the `SecurityManager` is deprecate
This PR proposes to use hexadecimal representation for a memory segment address
rather than a decimal one.
-
Commit messages:
- Use hexadecimal encoding in MemorySegment::toString
Changes: https://git.openjdk.org/jdk/pull/15670/files
Webrev:
On Thu, 14 Sep 2023 13:45:30 GMT, Per Minborg wrote:
> This PR proposes to use hexadecimal formatting for raw addresses in
> `VarHandleSegmentViewBase`.
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jdk/pull/15742
On Fri, 15 Sep 2023 06:06:18 GMT, Per Minborg wrote:
>> This PR proposes to use hexadecimal formatting for raw addresses in
>> `VarHandleSegmentViewBase`.
>
> Per Minborg has updated the pull request with a new target base due to a
> merge or a rebase. The increm
On Thu, 14 Sep 2023 12:01:29 GMT, Per Minborg wrote:
> This PR proposes to improve the MemorySegment::toString to reduce cluttering
> and add missing comas.
src/java.base/share/classes/jdk/internal/foreign/Utils.java line 277:
> 275: }
> 276:
> 277: public static Str
This PR proposes to improve the MemorySegment::toString to reduce cluttering
and add missing comas.
-
Commit messages:
- Improve MemorySegment::toString
Changes: https://git.openjdk.org/jdk/pull/15740/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=15740=00
Issue:
This PR proposes adding a new method to BitSet that provides an immutable
snapshot of the set in the form of an `IntPredicate`.
The predicate is eligible for constant folding.
Here are some classes in the JDK that would benefit directly from
constant-folding of BitSets:
PoolReader (6)
On Fri, 1 Sep 2023 09:00:32 GMT, Hannes Greule wrote:
> Maybe it would make sense to start with a JDK-internal variant before
> exploring potential public API?
This is certainly one alternative.
-
PR Comment: https://git.openjdk.org/jdk/pull/15530#issuecomment-1702421871
On Fri, 1 Sep 2023 08:50:42 GMT, Chen Liang wrote:
> What about the missing functionalities, such as ranged get, cardinality,
> next/previousSet/ClearBit?
This was explored in https://github.com/openjdk/jdk/pull/15493
-
PR Comment:
EncodeDecode.testEncodeUTF8 61024 75 15
> 1,772 ± 0,013 1,387 ± 0,032 ms/op 21,8% (p = 0,000*)
> URLEncodeDecode.testEncodeUTF8 61024 100 15
> 1,230 ± 0,009 1,140 ± 0,011 ms/op 7,3% (p = 0,000*)
Per Minborg has updated the
EncodeDecode.testEncodeUTF8 61024 75 15
> 1,772 ± 0,013 1,387 ± 0,032 ms/op 21,8% (p = 0,000*)
> URLEncodeDecode.testEncodeUTF8 61024 100 15
> 1,230 ± 0,009 1,140 ± 0,011 ms/op 7,3% (p = 0,000*)
Per Minborg has updated the pul
> This PR proposes to use hexadecimal representation for a memory segment
> address rather than a decimal one.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Change from limit to byteSize in MS::toString
-
C
On Mon, 11 Sep 2023 21:17:27 GMT, Per Minborg wrote:
> This PR proposes to use hexadecimal representation for a memory segment
> address rather than a decimal one.
This pull request has now been integrated.
Changeset: f9ab115a
Author: Per Minborg
URL:
https://git.openjdk.o
> This PR proposes to slightly improve some iterators of `AbstractMap`:
>
> * Code reuse
> * A field declared `final`
> * Add missing `@Override` annotations
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
R
> This PR proposes to slightly improve some iterators of `AbstractMap`:
>
> * Code reuse
> * A field declared `final`
> * Add missing `@Override` annotations
Per Minborg has updated the pull request incrementally with two additional
commits since the last revision:
- Fix addit
On Fri, 8 Sep 2023 10:52:06 GMT, Maurizio Cimadamore
wrote:
>> This PR adds a privileged block surrounding the request to load the fallback
>> linker library in LibFallback.
>> The lack of this block is causing test failures when platforms using the
>> fallback linker are tested using a
On Thu, 14 Sep 2023 13:45:30 GMT, Per Minborg wrote:
> This PR proposes to use hexadecimal formatting for raw addresses in
> `VarHandleSegmentViewBase`.
src/java.base/share/classes/jdk/internal/foreign/Utils.java line 277:
> 275: }
> 276:
> 277: public static String t
This PR proposes to use hexadecimal formatting for raw addresses in
`VarHandleSegmentViewBase`.
-
Commit messages:
- VarHandleSegmentViewBase::newIllegalArg... to use hexadecimal form
Changes: https://git.openjdk.org/jdk/pull/15742/files
Webrev:
On Thu, 14 Sep 2023 12:01:29 GMT, Per Minborg wrote:
> This PR proposes to improve the MemorySegment::toString to reduce cluttering
> and add missing comas.
This pull request has now been integrated.
Changeset: 8dc2d928
Author: Per Minborg
URL:
https://git.openjdk.org/jdk/
> This PR proposes to use hexadecimal formatting for raw addresses in
> `VarHandleSegmentViewBase`.
Per Minborg has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull r
On Wed, 11 Oct 2023 08:07:31 GMT, Per Minborg wrote:
> This PR proposes to Add @sealedGraph to `StringTemplate.Processor.Linkage`
This pull request has now been integrated.
Changeset: 2d46b297
Author: Per Minborg
URL:
https://git.openjdk.org/jdk/com
On Fri, 13 Oct 2023 17:31:15 GMT, Maurizio Cimadamore
wrote:
>> This PR makes sure that `MemorySegment` is initialized *before* any of its
>> subclasses.
>> This is done by centralizing all the memory segment factories in a single
>> implementation class (`SegmentFactories`).
>> Doing so
On Tue, 17 Oct 2023 08:05:09 GMT, Per Minborg wrote:
> This PR proposes to add a number of "capturing factories" in classes in the
> `java.util.function` package.
>
> The PR additionally (an optionally) proposes to add a new function
> `UnaryOperator::andThenUnary` t
This PR proposes to add a number of "capturing factories" in classes in the
`java.util.function` package.
The PR additionally (an optionally) proposes to add a new function
`UnaryOperator::andThenUnary` to allow composition while retaining the
`UnaryOperator` type.
With the new change, it is
On Tue, 17 Oct 2023 08:05:09 GMT, Per Minborg wrote:
> This PR proposes to add a number of "capturing factories" in classes in the
> `java.util.function` package.
>
> The PR additionally (an optionally) proposes to add a new function
> `UnaryOperator::andThenUnary` t
This PR proposes removing the restriction that only heap `MemorySegment`
wrapping a `byte` array can be accessed by Vectors. Now any array type can be
used provided the element alignment constraints are respected.
-
Commit messages:
- Vector access on heap MemorySegments for all
On Tue, 17 Oct 2023 08:05:09 GMT, Per Minborg wrote:
> This PR proposes to add a number of "capturing factories" in classes in the
> `java.util.function` package.
>
> The PR additionally (an optionally) proposes to add a new function
> `UnaryOperator::andThenUnary` t
> This PR proposes removing the restriction that only heap `MemorySegment`
> wrapping a `byte` array can be accessed by Vectors. Now any array type can be
> used provided the element alignment constraints are respected.
Per Minborg has updated the pull request incrementally with one a
This PR proposes to fix a number of JavaDoc typos in the
`MemorySegment::getAtIndex` and `::setAtIndex`.
-
Commit messages:
- Fix typos in the JavaDocs for MemorySegment
Changes: https://git.openjdk.org/jdk/pull/16469/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=16469=00
On Thu, 2 Nov 2023 07:40:52 GMT, Per Minborg wrote:
> This PR proposes to fix a number of JavaDoc typos in the
> `MemorySegment::getAtIndex` and `::setAtIndex`.
src/java.base/share/classes/java/lang/foreign/MemorySegment.java line 2014:
> 2012: * @throws IllegalArgument
On Thu, 2 Nov 2023 07:40:52 GMT, Per Minborg wrote:
> This PR proposes to fix a number of JavaDoc typos in the
> `MemorySegment::getAtIndex` and `::setAtIndex`.
This pull request has now been integrated.
Changeset: cb20a3e7
Author: Per Minborg
URL:
https://git.openjdk.o
This PR proposes to harmonize the @throws tags in the javadocs for the FFM API.
The @throws tags are using a bit different principles with respect to
formatting and ending with a period or not.
Looking at some prominent Java classes like `List` and `Stream`, they:
1) Indent such that
On Thu, 2 Nov 2023 14:46:49 GMT, Per Minborg wrote:
> This PR proposes to harmonize the @throws tags in the javadocs for the FFM
> API.
>
> The @throws tags are using a bit different principles with respect to
> formatting and ending with a period or not.
>
> Looking a
This PR proposes to improve the language used in the FFM specification. There
is a relatively small number of corrections.
One peculiarity with the English language is the distinction between "that" (to
be used in a restrictive clause) and "which" (to be used in a non-restrictive
clause). Here
On Wed, 25 Oct 2023 13:08:06 GMT, Per Minborg wrote:
> This PR proposes removing the restriction that only heap `MemorySegment`
> wrapping a `byte` array can be accessed by Vectors. Now any array type can be
> used provided the element alignment constraints are respected.
This pul
This PR proposes to fix a compilation error in the TestLoadSegmentVarious class
-
Commit messages:
- Fix compiler error in benchmark
Changes: https://git.openjdk.org/jdk/pull/16537/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=16537=00
Issue:
On Tue, 7 Nov 2023 10:36:00 GMT, Per Minborg wrote:
> This PR proposes to fix a compilation error in the TestLoadSegmentVarious
> class
This pull request has now been integrated.
Changeset: ac0ee20a
Author: Per Minborg
URL:
https://git.openjdk.org/jdk/
(to be used in a
> non-restrictive clause). Here is a reference:
> https://preply.com/en/blog/when-to-use-which-or-that-the-most-common-cases
>
> Another source for updates is the difference between BE and AE where most of
> us Europeans were taught BE but we should use AE in the
ked but I think it nice to get
> consistency across the API now that we go final.
Per Minborg has updated the pull request incrementally with two additional
commits since the last revision:
- Remove redundandt space
- Use permits reformatting only when needed
-
Chang
On Mon, 6 Nov 2023 21:07:22 GMT, Per Minborg wrote:
> This PR proposes to reformat a small number of code line for better
> appearance.
This pull request has now been integrated.
Changeset: 42f43c52
Author: Per Minborg
URL:
https://git.openjdk.org/jdk/
ked but I think it nice to get
> consistency across the API now that we go final.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Revert some foramtting
-
Changes:
- all: https://git.openjdk.org/jdk/pull/16528/fi
On Mon, 6 Nov 2023 21:00:10 GMT, Per Minborg wrote:
> This PR proposes to reformat some method parameters in the FFM API. The
> proposed changes are a bit opinion based eve though there are some underlying
> principles.
This pull request has now been integrated.
Changeset: 134c38
On Tue, 7 Nov 2023 09:31:11 GMT, Per Minborg wrote:
> This PR proposes to improve the language used in the FFM specification. There
> is a relatively small number of corrections.
>
> One peculiarity with the English language is the distinction between "that"
> (to
> This PR proposes to reformat some method parameters in the FFM API. The
> proposed changes are a bit opinion based eve though there are some underlying
> principles.
Per Minborg has updated the pull request with a new target base due to a merge
or a rebase. The pull request now con
On Tue, 7 Nov 2023 11:41:06 GMT, Per Minborg wrote:
>> This PR proposes to remove two `permits` declarations where the line
>> overflows the stipulated maximum column with. Also, it proposes to harmonize
>> the layout of `permit` formatting so they are the the same thro
> This PR proposes removing the restriction that only heap `MemorySegment`
> wrapping a `byte` array can be accessed by Vectors. Now any array type can be
> used provided the element alignment constraints are respected.
Per Minborg has updated the pull request incrementally with one a
On Wed, 25 Oct 2023 16:35:30 GMT, Chris Hegarty wrote:
>> test/jdk/jdk/incubator/vector/AbstractVectorLoadStoreTest.java line 118:
>>
>>> 116: private static boolean canBeConverted(IntFunction
>>> function, ValueLayout elementLayout) {
>>> 117: // Create a sample to analyze
>>>
ngth of 90 characters.
>
> The FFM API currently has javadoc lines that exceed 135 characters per line.
> It is also customary to use double spaces when starting a new sentence.
Per Minborg has updated the pull request with a new target base due to a merge
or a rebase. The increment
This PR proposes to reformat all the JavaDocs for the FFM API. This would bring
the FFM API docs more in line with the existing Java documentation (see below).
Occasional drive-by fixes are also included in this PR (such as spelling and
capitalization).
I am aware this PR will (if approved)
On Fri, 3 Nov 2023 18:16:17 GMT, Jorn Vernee wrote:
>> - Add linker note about packed structs.
>> - Relax language a bit to avoid implying that only listed layouts are
>> supported.
>
> Jorn Vernee has updated the pull request incrementally with one additional
> commit since the last revision:
ngth of 90 characters.
>
> The FFM API currently has javadoc lines that exceed 135 characters per line.
> It is also customary to use double spaces when starting a new sentence.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Upda
ngth of 90 characters.
>
> The FFM API currently has javadoc lines that exceed 135 characters per line.
> It is also customary to use double spaces when starting a new sentence.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revisi
On Mon, 6 Nov 2023 13:27:40 GMT, Jorn Vernee wrote:
> FWIW, I've been sticking to a soft 120 character limit per line when writing
> javadoc. Why should we use 90 columns specifically?
>
> > It is also customary to use double spaces when starting a new sentence.
>
> I thought this was the
On Mon, 6 Nov 2023 11:41:23 GMT, Maurizio Cimadamore
wrote:
> You might also want to look into the MethodHandles XYZCoordinates combinators
> (as they have also been added as part of FFM). And, also,
> `ModuleLayer::Controller::enableNativeAccess`,
> `Module::isNativeAccessEnabled` and
ngth of 90 characters.
>
> The FFM API currently has javadoc lines that exceed 135 characters per line.
> It is also customary to use double spaces when starting a new sentence.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Update
ngth of 90 characters.
>
> The FFM API currently has javadoc lines that exceed 135 characters per line.
> It is also customary to use double spaces when starting a new sentence.
Per Minborg has updated the pull request incrementally with one additional
commit since the last rev
ngth of 90 characters.
>
> The FFM API currently has javadoc lines that exceed 135 characters per line.
> It is also customary to use double spaces when starting a new sentence.
Per Minborg has updated the pull request incrementally with one additional
commit since the last re
ngth of 90 characters.
>
> The FFM API currently has javadoc lines that exceed 135 characters per line.
> It is also customary to use double spaces when starting a new sentence.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revi
ngth of 90 characters.
>
> The FFM API currently has javadoc lines that exceed 135 characters per line.
> It is also customary to use double spaces when starting a new sentence.
Per Minborg has updated the pull request with a new target base due to a merge
or a rebase. The pull request now
This PR proposes to reformat some method parameters in the FFM API. The
proposed changes are a bit opinion based eve though there are some underlying
principles.
-
Commit messages:
- Harmonize method parameter layouts
Changes: https://git.openjdk.org/jdk/pull/16527/files
Webrev:
This PR proposes to remove two `permits` declarations where the line overflows
the stipulated maximum column with. Also, it proposes to harmonize the layout
of `permit` formatting so they are the the same throughout the API.
This PR might be perceived as over worked but I think it nice to get
This PR proposes to reformat a small number of code line for better appearance.
-
Commit messages:
- Reformat some code
Changes: https://git.openjdk.org/jdk/pull/16529/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=16529=00
Issue: https://bugs.openjdk.org/browse/JDK-8319563
On Thu, 26 Oct 2023 09:17:25 GMT, Per Minborg wrote:
>> This PR proposes removing the restriction that only heap `MemorySegment`
>> wrapping a `byte` array can be accessed by Vectors. Now any array type can
>> be used provided the element alignment constraints are respecte
> This PR proposes removing the restriction that only heap `MemorySegment`
> wrapping a `byte` array can be accessed by Vectors. Now any array type can be
> used provided the element alignment constraints are respected.
Per Minborg has updated the pull request incrementally with one a
This PR suggests a fix for a failing test on platforms with big endian.
The PR also contains a drive-by removal of an unused import.
-
Commit messages:
- Remove unused imports
- Fix problem with endianness
Changes: https://git.openjdk.org/jdk/pull/16259/files
Webrev:
On Wed, 18 Oct 2023 09:00:09 GMT, Per Minborg wrote:
>> This PR proposes to add a number of "capturing factories" in classes in the
>> `java.util.function` package.
>>
>> The PR additionally (an optionally) proposes to add a new function
>> `UnaryOper
On Thu, 21 Sep 2023 16:40:59 GMT, Per Minborg wrote:
>> This PR outlines a solution for making immutable maps `@ValueBased` by
>> removing cacheing of certain values in `AbstractMap`.
>>
>> By removing these caching fields in `AbstractMap`, we can make the immutab
oved
> because the JVM is probably able to optimize away object creation anyway via
> escape analysis. Also, all maps will occupy less space as we get rid of a
> number of objects and references stored for each map.
>
> We need to benchmark this solution to better understand its
On Mon, 25 Sep 2023 08:11:48 GMT, Per Minborg wrote:
> This PR proposes to add the @sealedGraph tag to
> `java.lang.reflect.Executable`.
This pull request has now been integrated.
Changeset: 9e6cb620
Author: Per Minborg
URL:
https://git.openjdk.org/jdk/
> This PR proposes to add the @sealedGraph tag to
> `java.lang.reflect.Executable`.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Update copyright year
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15897
oved
> because the JVM is probably able to optimize away object creation anyway via
> escape analysis. Also, all maps will occupy less space as we get rid of a
> number of objects and references stored for each map.
>
> We need to benchmark this solution to better understand its
This PR outlines a solution for making immutable maps `@ValueBased` by removing
cacheing of certain values in `AbstractMap`.
By removing these caching fields in `AbstractMap`, we can make the immutable
maps `@ValueBased` and at the same time, performance is likely improved because
the JVM is
On Thu, 7 Sep 2023 11:13:44 GMT, Per Minborg wrote:
> This PR outlines a solution for making immutable maps `@ValueBased` by
> removing cacheing of certain values in `AbstractMap`.
>
> By removing these caching fields in `AbstractMap`, we can make the immutable
> ma
This PR proposes to add the @sealedGraph tag to `java.lang.reflect.Executable`.
-
Commit messages:
- Add @SealedGraph to Executable
Changes: https://git.openjdk.org/jdk/pull/15897/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=15897=00
Issue:
On Sun, 8 Oct 2023 21:02:25 GMT, Claes Redestad wrote:
> Alternative to #16082
>
> Name (unchanged) Cnt Base Error Test Error
> Unit Change
> URLEncodeDecode.testEncodeLatin1 0 15 2,066 ± 0,104 1,899 ± 0,007
> ms/op 1,09x (p = 0,000*)
>
On Wed, 11 Oct 2023 07:59:24 GMT, Per Minborg wrote:
> This PR proposes to add @sealedGraph to `IllegalFormatException`
This pull request has now been integrated.
Changeset: eca6ea43
Author: Per Minborg
URL:
https://git.openjdk.org/jdk/commit/eca6ea43d085a68b9b9760e732275175cb1b0
> This PR proposes to slightly improve some iterators of `AbstractMap`:
>
> * Declare two fields `final`
> * Use distinct classes rather than anonymous classes
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Re
On Thu, 7 Sep 2023 11:48:51 GMT, Per Minborg wrote:
> This PR proposes to slightly improve some iterators of `AbstractMap`:
>
> * Declare two fields `final`
> * Use distinct classes rather than anonymous classes
This pull request has now been integrated.
Changeset: d95b548c
Au
On Wed, 11 Oct 2023 11:18:41 GMT, Per Minborg wrote:
>> This PR proposes to add @sealedGraph to MethodHandleDesc and descendants.
>
> Per Minborg has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Update copyright ye
real code. Users that prefers having a
> normal type declaration can still do that.
>
> Note: Functional interfaces of primitives have not been considered (in this
> round). Otherwise, functional interfaces that might be ambiguous or that
> supports composition have been included. Hence,
real code. Users that prefers having a
> normal type declaration can still do that.
>
> Note: Functional interfaces of primitives have not been considered (in this
> round). Otherwise, functional interfaces that might be ambiguous or that
> supports composition have been included. Hence,
real code. Users that prefers having a
> normal type declaration can still do that.
>
> Note: Functional interfaces of primitives have not been considered (in this
> round). Otherwise, functional interfaces that might be ambiguous or that
> supports composition have been included. Hence,
On Wed, 11 Oct 2023 15:00:03 GMT, Alan Bateman wrote:
>> This PR proposes to Add @sealedGraph to `Thread.Builder`.
>
> @pron Do you have any comment on this one? I remember we decided not to do
> this in JDK 21.
@AlanBateman and @pron : Should we drop this PR? I will lazily do that in a
week
real code. Users that prefers having a
> normal type declaration can still do that.
>
> Note: Functional interfaces of primitives have not been considered (in this
> round). Otherwise, functional interfaces that might be ambiguous or that
> supports composition have been included. Hence,
On Tue, 17 Oct 2023 13:22:29 GMT, Raffaello Giulietti
wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update naming and javadocs
>
> src/java.base/share/classes/java/util/fun
On Wed, 18 Oct 2023 09:12:23 GMT, Chen Liang wrote:
>> src/java.base/share/classes/java/util/function/UnaryOperator.java line 68:
>>
>>> 66: * @see Function#andThen(Function)
>>> 67: */
>>> 68: default UnaryOperator andThenUnary(UnaryOperator after) {
>>
>> What are your comments
oved
> because the JVM is probably able to optimize away object creation anyway via
> escape analysis. Also, all maps will occupy less space as we get rid of a
> number of objects and references stored for each map.
>
> We need to benchmark this solution to better understand its
oved
> because the JVM is probably able to optimize away object creation anyway via
> escape analysis. Also, all maps will occupy less space as we get rid of a
> number of objects and references stored for each map.
>
> We need to benchmark this solution to better understand its
On Tue, 19 Sep 2023 23:48:07 GMT, Chen Liang wrote:
>> src/java.base/share/classes/java/util/AbstractMap.java line 375:
>>
>>> 373: */
>>> 374: public Collection values() {
>>> 375: return new AbstractCollection<>() {
>>
>> Note that this causes `m.values().equals(m.values())`
On Fri, 22 Sep 2023 15:31:13 GMT, Chen Liang wrote:
>> src/java.base/share/classes/java/util/AbstractMap.java line 524:
>>
>>> 522: protected Object clone() throws CloneNotSupportedException {
>>> 523: AbstractMap result = (AbstractMap)super.clone();
>>> 524: return result;
1 - 100 of 677 matches
Mail list logo
