On Fri, 8 Sep 2023 05:33:49 GMT, Alan Bateman wrote:
> Would it be possible to provide a clear summary on why libx86_64_sort is
> being added? I'm trying to understand why these weren't linked into libjvm.
Hello Alan,
Initially, the reason behind adding libx86_64 (now renamed to libsimdsort
raysSort.longSort | 100 | 0.76| 0.58
> | 1.3 |
> | ArraysSort.longSort | 1000| 10.449 | 6.239
> | 1.7 |
> | ArraysSort.longSort | 1 | 307.074 | 70.284
> |
On Wed, 13 Sep 2023 23:00:23 GMT, Srinivas Vamsi Parasa
wrote:
>> The goal is to develop faster sort routines for x86_64 CPUs by taking
>> advantage of AVX512 instructions. This enhancement provides an order of
>> magnitude speedup for Arrays.sort() using int, long, float
raysSort.longSort | 100 | 0.76| 0.58
> | 1.3 |
> | ArraysSort.longSort | 1000| 10.449 | 6.239
> | 1.7 |
> | ArraysSort.longSort | 1 | 307.074 | 70.284
> | **4.
On Tue, 29 Aug 2023 17:00:33 GMT, Srinivas Vamsi Parasa
wrote:
>> make/modules/java.base/Lib.gmk line 240:
>>
>>> 238:
>>> 239: ifeq ($(call isTargetOs, linux)+$(call isTargetCpu,
>>> x86_64)+$(INCLUDE_COMPILER2), true+true+true)
>>> 240:
On Mon, 28 Aug 2023 23:29:43 GMT, Erik Joelsson wrote:
>> Srinivas Vamsi Parasa has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Clean up parameters passed to arrayPartition; update the check to load
>
raysSort.longSort | 100 | 0.76| 0.58
> | 1.3 |
> | ArraysSort.longSort | 1000| 10.449 | 6.239
> | 1.7 |
> | ArraysSort.longSort | 1 | 307.074 | 70.284
> | **4.4** |
>
raysSort.longSort | 100 | 0.76| 0.58
> | 1.3 |
> | ArraysSort.longSort | 1000| 10.449 | 6.239
> | 1.7 |
> | ArraysSort.longSort | 1 | 307.074 | 70.284
> | **4.4** |
> |
On Wed, 30 Aug 2023 08:48:09 GMT, Alan Bateman wrote:
> > Hi Vladimir, Just verified that the test/jdk/java/util/Arrays/Sorting.java
> > is triggering the intrinsic without additional flags
>
> Just to add that Sorting.java has short and long run modes. The default when
> running with jtreg
On Tue, 29 Aug 2023 20:23:24 GMT, Vladimir Kozlov wrote:
>> The shared library approach is being followed currently as an initial
>> implementation to demonstrate the value of AVX512 sorting. This will be
>> followed up in future with support for Windows as well.
>> If it is ok with you, the
raysSort.longSort | 100 | 0.76| 0.58
> | 1.3 |
> | ArraysSort.longSort | 1000| 10.449 | 6.239
> | 1.7 |
> | ArraysSort.longSort | 1 | 307.074 | 70.284
> | **4
On Mon, 11 Sep 2023 18:17:41 GMT, Jatin Bhateja wrote:
>> Srinivas Vamsi Parasa has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix regression when intrinsics are disabled; enable insertion sort in
>>
raysSort.longSort | 100 | 0.76| 0.58
> | 1.3 |
> | ArraysSort.longSort | 1000| 10.449 | 6.239
> | 1.7 |
> | ArraysSort.longSort | 1 | 307.074 | 70.284
> |
On Wed, 13 Sep 2023 23:00:23 GMT, Srinivas Vamsi Parasa
wrote:
>> The goal is to develop faster sort routines for x86_64 CPUs by taking
>> advantage of AVX512 instructions. This enhancement provides an order of
>> magnitude speedup for Arrays.sort() using int, long, float
On Fri, 8 Sep 2023 18:10:33 GMT, Srinivas Vamsi Parasa wrote:
>> The goal is to develop faster sort routines for x86_64 CPUs by taking
>> advantage of AVX512 instructions. This enhancement provides an order of
>> magnitude speedup for Arrays.sort() using int, long, float
raysSort.longSort | 100 | 0.76| 0.58
> | 1.3 |
> | ArraysSort.longSort | 1000| 10.449 | 6.239
> | 1.7 |
> | ArraysSort.longSort | 1 | 307.074 | 70.284
> | **
On Fri, 1 Sep 2023 10:57:57 GMT, iaroslavski wrote:
>>> @AlanBateman If it helps, the changes made by @vamsi-parasa to
>>> DualPivotQuickSort.java don't change the logic as written in Java. They
>>> only carve out the functionality into separate Java methods retaining the
>>> meaning exactly
On Fri, 8 Sep 2023 18:10:33 GMT, Srinivas Vamsi Parasa wrote:
>> The goal is to develop faster sort routines for x86_64 CPUs by taking
>> advantage of AVX512 instructions. This enhancement provides an order of
>> magnitude speedup for Arrays.sort() using int, long, float
On Thu, 31 Aug 2023 21:31:40 GMT, Srinivas Vamsi Parasa
wrote:
>> The goal is to develop faster sort routines for x86_64 CPUs by taking
>> advantage of AVX512 instructions. This enhancement provides an order of
>> magnitude speedup for Arrays.sort() using int, long, float
On Wed, 30 Aug 2023 08:48:09 GMT, Alan Bateman wrote:
>>> > > Hi, We already have correctness tests. See
>>> > > test/jdk/java/util/Arrays/Sorting.java
>>> > > The latest version you can find in PR
>>> > > https://github.com/openjdk/jdk/pull/13568/files
>>> >
>>> >
>>> > Does
On Mon, 28 Aug 2023 23:35:56 GMT, Erik Joelsson wrote:
>> Srinivas Vamsi Parasa has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Clean up parameters passed to arrayPartition; update the check to load
>
On Tue, 29 Aug 2023 16:04:58 GMT, Vladimir Kozlov wrote:
> My testing passed. But I am not sure correctness of code is fully tested. For
> now we have only JMH benchmark for this new code. Do we have JDK test which
> can check correctness of this code?
Hi Vladimir, will add the JDK tests to
On Tue, 29 Aug 2023 16:02:57 GMT, Vladimir Kozlov wrote:
>> If it's tied to GCC as well, then we should probably include that in the
>> condition here unless it's also expected to work with Clang.
>> (`TOOLCHAIN_TYPE` = `gcc`)
>
>> The reason this PR is focused on Linux is because the AVX512
On Tue, 29 Aug 2023 20:36:04 GMT, Vladimir Kozlov wrote:
> Hi, We already have correctness tests. See
> test/jdk/java/util/Arrays/Sorting.java
>
> The latest version you can find in PR
> https://github.com/openjdk/jdk/pull/13568/files
Hello Vladimir (@iaroslavski),
Thank you for providing
On Tue, 29 Aug 2023 20:36:04 GMT, Vladimir Kozlov wrote:
> > Hi, We already have correctness tests. See
> > test/jdk/java/util/Arrays/Sorting.java
> > The latest version you can find in PR
> > https://github.com/openjdk/jdk/pull/13568/files
>
> Does test/jdk/java/util/Arrays/Sorting.java
On Tue, 29 Aug 2023 20:44:32 GMT, Srinivas Vamsi Parasa
wrote:
> > > Hi, We already have correctness tests. See
> > > test/jdk/java/util/Arrays/Sorting.java
> > > The latest version you can find in PR
> > > https://github.com/openjdk/jdk/pull/13568/files
&
On Wed, 30 Aug 2023 15:10:45 GMT, Srinivas Vamsi Parasa
wrote:
>>> Hi Vladimir, Just verified that the test/jdk/java/util/Arrays/Sorting.java
>>> is triggering the intrinsic without additional flags
>>
>> Just to add that Sorting.java has short and long run modes
On Wed, 11 Oct 2023 17:28:12 GMT, Srinivas Vamsi Parasa
wrote:
>> The goal of this PR is to address the follow-up comments to the SIMD
>> accelerated sort PR (#14227) which implemented AVX512 intrinsics for
>> Arrays.sort() methods.
>> The proposed changes ar
show_bug.cgi?id=105593
> 3) Minor changes in Javadoc strings
Srinivas Vamsi Parasa has updated the pull request incrementally with one
additional commit since the last revision:
Add @ForceInline annotation to insertion and mixedInsertion sort
-
Changes:
- all: https://git.open
On Wed, 11 Oct 2023 06:59:47 GMT, iaroslavski wrote:
> Also @forceinline in these changes only works for case when new intrinsics
> are not used. I would suggest to adapt/update JMH benchmark to cover all
> cases and see effect @forceinline without intrinsics. That will tell us which
>
raysSort.longSort | 100 | 0.76| 0.58
> | 1.3 |
> | ArraysSort.longSort | 1000| 10.449 | 6.239
> | 1.7 |
> | ArraysSort.longSort | 1 | 307.074 | 70.284
> | **4.4** |
>
On Thu, 21 Sep 2023 09:32:18 GMT, Magnus Ihse Bursie wrote:
>> Srinivas Vamsi Parasa has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> change variable names of indexPivot* to pivotIndex*
>
> make/modu
On Mon, 18 Sep 2023 18:54:07 GMT, Srinivas Vamsi Parasa
wrote:
>> The goal is to develop faster sort routines for x86_64 CPUs by taking
>> advantage of AVX512 instructions. This enhancement provides an order of
>> magnitude speedup for Arrays.sort() using int, long, float
On Fri, 15 Sep 2023 22:17:42 GMT, Srinivas Vamsi Parasa
wrote:
>> The goal is to develop faster sort routines for x86_64 CPUs by taking
>> advantage of AVX512 instructions. This enhancement provides an order of
>> magnitude speedup for Arrays.sort() using int, long, float
raysSort.longSort | 100 | 0.76| 0.58
> | 1.3 |
> | ArraysSort.longSort | 1000| 10.449 | 6.239
> | 1.7 |
> | ArraysSort.longSort | 1 | 307.074 | 70.284
> | **4.4** |
&
On Sat, 16 Sep 2023 22:49:14 GMT, iaroslavski wrote:
>> Hello Paul,
>>
>> As suggested, the functional interfaces were moved next to the associated
>> methods and also added a `@ForceInline` for `arraySort` in the latest commit.
>>
>>> I recommend embedding the functional interfaces next to
On Thu, 21 Sep 2023 07:43:47 GMT, iaroslavski wrote:
>> Laurent Bourgès has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> updated comments (v23.08)
>
>> Hi Vladimir,
>>
>> Just trying to understand: is there a reason to use
>>
On Thu, 21 Sep 2023 16:44:52 GMT, Paul Sandoz wrote:
>> Srinivas Vamsi Parasa has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> change variable names of indexPivot* to pivotIndex*
>
> test/jdk/java/ut
On Tue, 19 Sep 2023 01:57:44 GMT, Srinivas Vamsi Parasa
wrote:
>> The goal is to develop faster sort routines for x86_64 CPUs by taking
>> advantage of AVX512 instructions. This enhancement provides an order of
>> magnitude speedup for Arrays.sort() using int, long, float
On Wed, 20 Sep 2023 07:18:55 GMT, iaroslavski wrote:
> ... and suggestion to improve naming: there are inconsistent new names:
> pivotIndices, indexPivot1 and indexPivot2. I think names pivotIndices,
> pivotIndex1 and pivotIndex2 will be better. Do you agree?
Please see the variable names
raysSort.longSort | 100 | 0.76| 0.58
> | 1.3 |
> | ArraysSort.longSort | 1000| 10.449 | 6.239
> | 1.7 |
> | ArraysSort.longSort | 1 | 307.074 | 70.284
> | **4.4** |
>
raysSort.longSort | 100 | 0.76| 0.58
> | 1.3 |
> | ArraysSort.longSort | 1000| 10.449 | 6.239
> | 1.7 |
> | ArraysSort.longSort | 1 | 307.074 | 70.284
> | **4.4**
On Mon, 18 Sep 2023 20:08:31 GMT, iaroslavski wrote:
>> Srinivas Vamsi Parasa has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove the unnecessary exception in single pivot partitioning fallback
>> m
On Tue, 19 Sep 2023 01:57:44 GMT, Srinivas Vamsi Parasa
wrote:
>> The goal is to develop faster sort routines for x86_64 CPUs by taking
>> advantage of AVX512 instructions. This enhancement provides an order of
>> magnitude speedup for Arrays.sort() using int, long, float
On Wed, 20 Sep 2023 17:19:42 GMT, Srinivas Vamsi Parasa
wrote:
>> The goal is to develop faster sort routines for x86_64 CPUs by taking
>> advantage of AVX512 instructions. This enhancement provides an order of
>> magnitude speedup for Arrays.sort() using int, long, float
show_bug.cgi?id=105593
> 3) Minor changes in Javadoc strings
Srinivas Vamsi Parasa has updated the pull request incrementally with one
additional commit since the last revision:
Revert @ForceInline annotations for small array sort methods
-
Changes:
- all: https://git.open
On Wed, 11 Oct 2023 20:31:05 GMT, Srinivas Vamsi Parasa
wrote:
>> Hi @vamsi-parasa,
>>
>> Both methods mixedInsertionSort and insertionSort are covered by intrinsics.
>> But insertionSort is run on leftmnost (one) part only and on small ( <
>> MAX_INSERTION
On Wed, 11 Oct 2023 07:10:57 GMT, iaroslavski wrote:
> To have clear picture could you please run benchmarking to compare both
> cases: current implementation and implementation with Java insertionSort only?
>
> see changes `sort(int.class, a, Unsafe.ARRAY_INT_BASE_OFFSET, low, high,
>
On Thu, 12 Oct 2023 04:41:37 GMT, Vladimir Kozlov wrote:
> My tier1-3,xcomp testing for v04 passed. I am integrating these changes. Lets
> continue discussion about changes for AMD in
> https://bugs.openjdk.org/browse/JDK-8317976.
Thank you, Vladimir!
-
PR Comment:
On Wed, 11 Oct 2023 20:48:06 GMT, Erik Joelsson wrote:
>> Srinivas Vamsi Parasa has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add @ForceInline annotation to insertion and mixedInsertion sort
>
> make/modu
On Tue, 10 Oct 2023 16:44:03 GMT, Srinivas Vamsi Parasa
wrote:
> The goal of this PR is to address the follow-up comments to the SIMD
> accelerated sort PR (#14227) which implemented AVX512 intrinsics for
> Arrays.sort() methods.
> The proposed changes are:
>
> 1) Restric
On Tue, 30 May 2023 18:54:50 GMT, Srinivas Vamsi Parasa
wrote:
> The goal is to develop faster sort routines for x86_64 CPUs by taking
> advantage of AVX512 instructions. This enhancement provides an order of
> magnitude speedup for Arrays.sort() using int, long, float and doub
On Fri, 6 Oct 2023 18:28:21 GMT, Vladimir Kozlov wrote:
> My tier1-7 testing passed. Good.
Thank you, Vladimir!
-
PR Comment: https://git.openjdk.org/jdk/pull/14227#issuecomment-1751254526
On Thu, 5 Oct 2023 18:46:46 GMT, Vladimir Kozlov wrote:
> In general it looks good. I have some code style comments and file name
> change request. After you fix that I will need to rerun testing for it before
> approval.
Hello Vladimir (@vnkozlov),
Thank you for the suggestions related to
raysSort.longSort | 100 | 0.76| 0.58
> | 1.3 |
> | ArraysSort.longSort | 1000| 10.449 | 6.239
> | 1.7 |
> | ArraysSort.longSort | 1 | 307.074 | 70.284
> | **4.4** |
>
The goal of this PR is to restrict the availability of AVX512 accelerated
Arrays.sort() methods to only Intel CPUs as a performance regression (due to
hardware issues) was reported for AMD Zen4 CPUs in the comments section of
#14227.
-
Commit messages:
- 8317763:Restrict AVX512
On Tue, 10 Oct 2023 18:01:59 GMT, Vladimir Kozlov wrote:
> What is change for "Addressing the build failure due to a bug in GCC 12"?
Hello Vladimir,
The change for addressing the build failure will be pushed shortly.
Thanks,
Vamsi
-
PR Comment:
On Thu, 5 Oct 2023 23:36:48 GMT, Srinivas Vamsi Parasa wrote:
>> The goal is to develop faster sort routines for x86_64 CPUs by taking
>> advantage of AVX512 instructions. This enhancement provides an order of
>> magnitude speedup for Arrays.sort() using int, long, float
On Sun, 8 Oct 2023 06:18:13 GMT, Danny Thomas wrote:
> A [discussion on
> Reddit](https://www.reddit.com/r/java/comments/171t5sj/heads_up_openjdk_implementation_of_avx512_based/)
> raised that this had the potential to regress sort performance on AMD Zen 4.
> The poster didn't have access to
On Mon, 9 Oct 2023 18:15:12 GMT, Paul Sandoz wrote:
> > _Mailing list message from [Florian Weimer](mailto:f...@deneb.enyo.de) on
> > [hotspot-runtime-dev](mailto:hotspot-runtime-...@mail.openjdk.org):_
> > I believe this has introduced a build failure with GCC 12.2 on Debian 12.1:
>
> I
On Tue, 10 Oct 2023 17:55:43 GMT, Vladimir Kozlov wrote:
>> Srinivas Vamsi Parasa has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> pragma workround for GCC12 bug
>
> src/hotspot/cpu/x86/stubGenerator_x8
On Tue, 10 Oct 2023 18:01:59 GMT, Vladimir Kozlov wrote:
>> Srinivas Vamsi Parasa has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> pragma workround for GCC12 bug
>
> What is change for "Addressing the b
On Tue, 10 Oct 2023 19:48:50 GMT, Magnus Ihse Bursie wrote:
> In #14227, you inadvertently added an extra space at line 230 in
> make/modules/java.base/Lib.gmk
Hi Magnus (@magicus), please see the extra space fixed in the latest commit.
Thanks,
Vamsi
-
PR Comment:
show_bug.cgi?id=105593
> 3) Minor changes in Javadoc strings
Srinivas Vamsi Parasa has updated the pull request incrementally with one
additional commit since the last revision:
fix whitespace in build script
-
Changes:
- all: https://git.openjdk.org/jdk/pull/16124/files
- n
show_bug.cgi?id=105593
> 3) Minor changes in Javadoc strings
Srinivas Vamsi Parasa has updated the pull request incrementally with one
additional commit since the last revision:
pragma workround for GCC12 bug
-
Changes:
- all: https://git.openjdk.org/jdk/pull/16124/files
- n
On Fri, 13 Oct 2023 10:31:14 GMT, himichael wrote:
> my question is that this feature should improve performance several times,
> but it doesn't look like there's much difference between open jdk 22.19 and
> jdk 8. is there a problem with my configuration ?
Hello @himichael,
Using your code
On Sat, 14 Oct 2023 03:21:52 GMT, himichael wrote:
>>> my question is that this feature should improve performance several times,
>>> but it doesn't look like there's much difference between open jdk 22.19 and
>>> jdk 8. is there a problem with my configuration ?
>>
>> Hello @himichael,
>>
On Fri, 25 Aug 2023 02:07:54 GMT, Sandhya Viswanathan
wrote:
>> Srinivas Vamsi Parasa has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Decomposed DPQS using AVX512 partitioning and AVX512 sort (for small
>
On Thu, 24 Aug 2023 06:23:29 GMT, Srinivas Vamsi Parasa
wrote:
>>> Improvements are nice but it would not pay off if you have big regressions.
>>> I can accept 0.9x but 0.4x - 0.8x regressions should be investigated and
>>> implementation adjusted to avo
On Fri, 25 Aug 2023 13:20:09 GMT, Erik Joelsson wrote:
>> Srinivas Vamsi Parasa has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove unnecessary import in Arrays.java
>
> make/modules/java.ba
raysSort.longSort | 100 | 0.76| 0.58
> | 1.3 |
> | ArraysSort.longSort | 1000| 10.449 | 6.239
> | 1.7 |
> | ArraysSort.longSort | 1 | 307.074 | 70.284
> | **4.4** |
&g
On Fri, 25 Aug 2023 01:52:32 GMT, Sandhya Viswanathan
wrote:
>> pivotIndices array is being passed as a parameter to the partition intrinsic
>> as it is updated in-place with the new pivot indices after partitioning. The
>> Unsafe.ARRAY_INT_BASE_OFFSET is being used in libary_call.cpp to get
On Fri, 25 Aug 2023 22:04:45 GMT, Vladimir Kozlov wrote:
>> Srinivas Vamsi Parasa has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove unnecessary import in Arrays.java
>
> src/hotspot/cpu/x86/stub
On Fri, 27 Oct 2023 13:26:33 GMT, Vladimir Yaroslavskiy
wrote:
>>> Hi Paul (@PaulSandoz), Alan (@AlanBateman), Any update? Do you agree with
>>> Radix sort in parallel case only?
>>
>> I think its definitely a better fit, but another aspect of my previous
>> comment was wondering if we need
On Thu, 15 Jun 2023 09:21:13 GMT, Laurent Bourgès wrote:
>> * improved mixed insertion sort (makes whole sorting faster)
>> * introduced Radix which sort shows several times boost of performance and
>> has linear complexity instead of n*ln(n)
>> * improved merging sort for almost sorted data
On Thu, 8 Feb 2024 20:04:20 GMT, Vladimir Yaroslavskiy wrote:
>> Hi Vladimir (@iaroslavski),
>>
>> The new ArraysSortNew.Java has compilation issues:
>>
>>
>> error: DualPivotQuicksort is not public in java.util; cannot be accessed
>> from outside package
>>
On Mon, 5 Feb 2024 21:31:36 GMT, Vladimir Yaroslavskiy wrote:
>> Hi Vladimir (@iaroslavski),
>>
>> Please see the data below. All tests were run after putting the DPQS code in
>> java.util package and recompiling the JDK for each case.
>>
>> > xmlns:o="urn:schemas-microsoft-com:office:office"
On Tue, 5 Dec 2023 19:37:34 GMT, Jatin Bhateja wrote:
>> Srinivas Vamsi Parasa has updated the pull request with a new target base
>> due to a merge or a rebase. The incremental webrev excludes the unrelated
>> changes brought in by the merge/rebase. The pull request contains
75 | 5.7
> ArraysSort.floatSort | 10 | 4299.519 | 862.63 | 5.0
> ArraysSort.floatSort | 100 | 50889.4 | 10972.19 | 4.6
>
>
>
>
>
> xmlns:o="urn:schemas-microsoft-com:office:office"
> xmlns:x="urn:schemas-microsoft-com:office:excel"
>
On Wed, 6 Dec 2023 11:59:19 GMT, Magnus Ihse Bursie wrote:
>> Hi Magnus (@magicus),
>>
>>> Are you saying that when compiling with GCC 6, it will just silently ignore
>>> `-std=c++17`? I'd have assumed that it printed a warning or error about an
>>> unknown or invalid option, if C++17 is not
On Tue, 5 Dec 2023 19:19:23 GMT, Jatin Bhateja wrote:
>> Srinivas Vamsi Parasa has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> remove unused avx2 64 bit sort functions; add assertions
>
> src/java.base
On Wed, 6 Dec 2023 17:42:39 GMT, Jatin Bhateja wrote:
> LGTM, thanks!
Thanks Jatin!
-
PR Comment: https://git.openjdk.org/jdk/pull/16534#issuecomment-1843372385
75 | 5.7
> ArraysSort.floatSort | 10 | 4299.519 | 862.63 | 5.0
> ArraysSort.floatSort | 100 | 50889.4 | 10972.19 | 4.6
>
>
>
>
>
> xmlns:o="urn:schemas-microsoft-com:office:office"
> xmlns:x="urn:schemas-microsoft-com:office:excel"
> xm
On Tue, 5 Dec 2023 19:33:48 GMT, Jatin Bhateja wrote:
>> Srinivas Vamsi Parasa has updated the pull request with a new target base
>> due to a merge or a rebase. The incremental webrev excludes the unrelated
>> changes brought in by the merge/rebase. The pull request contains
On Tue, 12 Dec 2023 15:42:09 GMT, Magnus Ihse Bursie wrote:
>> Thank you Magnus!
>
> @vamsi-parasa You said:
>> Made sure that OpenJDK builds without errors using both GCC 7.5 and GCC 6.4.
>
> but now we have https://bugs.openjdk.org/browse/JDK-8321688. Did you
> introduce any changes after
On Fri, 8 Dec 2023 20:08:22 GMT, Vladimir Yaroslavskiy wrote:
>> Hi Vladimir (@iaroslavski),
>>
>> Please see the data below.
>>
>> Thanks,
>> Vamsi
>>
>> > xmlns:o="urn:schemas-microsoft-com:office:office"
>> xmlns:x="urn:schemas-microsoft-com:office:excel"
>>
On Fri, 8 Dec 2023 20:08:22 GMT, Vladimir Yaroslavskiy wrote:
>> Hi Vladimir (@iaroslavski),
>>
>> Please see the data below.
>>
>> Thanks,
>> Vamsi
>>
>> > xmlns:o="urn:schemas-microsoft-com:office:office"
>> xmlns:x="urn:schemas-microsoft-com:office:excel"
>>
On Fri, 8 Dec 2023 22:37:26 GMT, Vladimir Kozlov wrote:
> I pushed closed changes.
Thanks Vladimir!
-
PR Comment: https://git.openjdk.org/jdk/pull/16534#issuecomment-1847939767
On Tue, 7 Nov 2023 00:12:41 GMT, Srinivas Vamsi Parasa wrote:
> The goal is to develop faster sort routines for x86_64 CPUs by taking
> advantage of AVX2 instructions. This enhancement provides an order of
> magnitude speedup for Arrays.sort() using int, long, float and doub
75 | 5.7
> ArraysSort.floatSort | 10 | 4299.519 | 862.63 | 5.0
> ArraysSort.floatSort | 100 | 50889.4 | 10972.19 | 4.6
>
>
>
>
>
> xmlns:o="urn:schemas-microsoft-com:office:office"
> xmlns:x="urn:schemas-microsoft-com:office:excel"
> xmlns=&
On Tue, 28 Nov 2023 12:25:57 GMT, Jatin Bhateja wrote:
>> src/hotspot/share/opto/library_call.cpp line 5448:
>>
>>> 5446: BasicType bt = elem_type->basic_type();
>>> 5447: // Disable the intrinsic for 64-bit types with AVX2
>>> 5448: if ((bt == T_LONG || bt == T_DOUBLE) && UseAVX == 2) {
On Tue, 28 Nov 2023 00:08:00 GMT, Srinivas Vamsi Parasa
wrote:
>> src/hotspot/share/opto/library_call.cpp line 5391:
>>
>>> 5389: BasicType bt = elem_type->basic_type();
>>> 5390: // Disable the intrinsic for 64-bit types with AVX2
>>> 539
On Tue, 28 Nov 2023 12:23:00 GMT, Jatin Bhateja wrote:
>> Srinivas Vamsi Parasa has updated the pull request with a new target base
>> due to a merge or a rebase. The incremental webrev excludes the unrelated
>> changes brought in by the merge/rebase. The pull r
On Mon, 27 Nov 2023 23:44:25 GMT, Sandhya Viswanathan
wrote:
>> Not listed here: https://oca.opensource.oracle.com/?ojr=contributors
>
> Yes, Vamsi is part of Intel Java team. He also has the author status
> (https://openjdk.org/census#sparasa).
> @sviswa7 I am asking about the copyright
75 | 5.7
> ArraysSort.floatSort | 10 | 4299.519 | 862.63 | 5.0
> ArraysSort.floatSort | 100 | 50889.4 | 10972.19 | 4.6
>
>
>
>
>
> xmlns:o="urn:schemas-microsoft-com:office:office"
> xmlns:x="urn:schemas-microsoft-com:office:exce
On Tue, 5 Dec 2023 11:19:00 GMT, Magnus Ihse Bursie wrote:
>> Hi Marcus (@magicus), please see the updated code which added guards to
>> check for GCC version >= 7.5 in
>> `src/java.base/linux/native/libsimdsort/{avx2-linux-qsort.cpp,
>> avx512-linux-qsort.cpp}`. GCC >= 7.5 is needed to
75 | 5.7
> ArraysSort.floatSort | 10 | 4299.519 | 862.63 | 5.0
> ArraysSort.floatSort | 100 | 50889.4 | 10972.19 | 4.6
>
>
>
>
>
> xmlns:o="urn:schemas-microsoft-com:office:office"
> xmlns:x="urn:schemas-microsoft-com:office:excel"
>
On Mon, 4 Dec 2023 11:48:44 GMT, Magnus Ihse Bursie wrote:
>>> But you are saying that you want to skip building this library unless you
>>> have a gcc version that supports c++17?
>>>
>> Yes, the request is to skip building the simdsort library if GCC version is
>> < 8 as only GCC >= 8
75 | 5.7
> ArraysSort.floatSort | 10 | 4299.519 | 862.63 | 5.0
> ArraysSort.floatSort | 100 | 50889.4 | 10972.19 | 4.6
>
>
>
>
>
> xmlns:o="urn:schemas-microsoft-com:office:office"
> xmlns:x="urn:schemas-microsoft-com:office:excel"
>
On Mon, 4 Dec 2023 22:15:24 GMT, Srinivas Vamsi Parasa wrote:
>> The goal is to develop faster sort routines for x86_64 CPUs by taking
>> advantage of AVX2 instructions. This enhancement provides an order of
>> magnitude speedup for Arrays.sort() using int, long, float
1 - 100 of 134 matches
Mail list logo
