On Fri, 26 Apr 2024 08:08:25 GMT, Viktor Klang wrote:
> This PR adds the exception documentation as per the ExecutorService API
> contract. I also took the liberty of adding @Override-annotations to be clear
> about intent.
Marked as reviewed by alanb (Reviewer).
I think this is okay. The
On Fri, 26 Apr 2024 08:08:25 GMT, Viktor Klang wrote:
> This PR adds the exception documentation as per the ExecutorService API
> contract. I also took the liberty of adding @Override-annotations to be clear
> about intent.
Both markup and generated documentation look good.
-
On Fri, 26 Apr 2024 11:54:15 GMT, Doug Lea wrote:
> This seems OK, but could someone read the generated javadoc to make sure
> there are no surprises? Sometimes inheritDocs don't come out as expected.
I'll make sure it's as expected.
-
PR Comment:
On Fri, 26 Apr 2024 08:08:25 GMT, Viktor Klang wrote:
> This PR adds the exception documentation as per the ExecutorService API
> contract. I also took the liberty of adding @Override-annotations to be clear
> about intent.
This seems OK, but could someone read the generated javadoc to make
This PR adds the exception documentation as per the ExecutorService API
contract. I also took the liberty of adding @Override-annotations to be clear
about intent.
-
Commit messages:
- 8296543 - adding javadoc for thrown exceptions from AbstractExecutorService
methods
Changes:
On Fri, 26 Apr 2024 08:08:25 GMT, Viktor Klang wrote:
> This PR adds the exception documentation as per the ExecutorService API
> contract. I also took the liberty of adding @Override-annotations to be clear
> about intent.
@pavelrappo @DougLea Looks good?
-
PR Comment:
