On Wed, 23 Nov 2022 06:58:09 GMT, Dongxu Wang wrote:
> 8297385: Remove duplicated null typos in javadoc
Looks good.
-
Marked as reviewed by rriggs (Reviewer).
PR: https://git.openjdk.org/jdk/pull/11311
On Wed, 23 Nov 2022 06:58:09 GMT, Dongxu Wang wrote:
> 8297385: Remove duplicated null typos in javadoc
LGTM
-
Marked as reviewed by dfuchs (Reviewer).
PR: https://git.openjdk.org/jdk/pull/11311
8297385: Remove duplicated null typos in javadoc
-
Commit messages:
- 8297385: Remove duplicated null typo in javadoc
Changes: https://git.openjdk.org/jdk/pull/11311/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=11311=00
Issue: https://bugs.openjdk.org/browse/JDK-8297385
On Wed, 23 Nov 2022 06:49:56 GMT, Dongxu Wang wrote:
>> 8297385: Remove duplicated null typos in javadoc
>
> Dongxu Wang has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the merge/rebase. The
On Wed, 23 Nov 2022 06:43:56 GMT, Yi Yang wrote:
> This looks good, but I'm not a Reviewer, you still need an approval from
> Reviewer.
Thanks
-
PR: https://git.openjdk.org/jdk/pull/11169
> 8297385: Remove duplicated null typos in javadoc
Dongxu Wang has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains two additional commits since the
last
On Wed, 23 Nov 2022 06:45:26 GMT, Dongxu Wang wrote:
>> 8297385: Remove duplicated null typos in javadoc
>
> Dongxu Wang has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the merge/rebase. The
On Tue, 15 Nov 2022 15:05:45 GMT, Dongxu Wang wrote:
> 8297385: Remove duplicated null typos in javadoc
The source of this PR is the "master" branch of your fork. Note the Comment
from the bot at the top.
The conventional usage is to create a branch specific to the change you are
making and
On Tue, 22 Nov 2022 03:33:55 GMT, Yi Yang wrote:
> > > good catch, do you need a JBS issue for this?
> >
> >
> > Thank you if you can help with that.
>
> I filed https://bugs.openjdk.org/browse/JDK-8297385 for this, you can change
> your PR title and commit message to [8297385: Remove
On Tue, 15 Nov 2022 15:05:45 GMT, Dongxu Wang wrote:
> 8297385: Remove duplicated null typos in javadoc
good catch, do you need a JBS issue for this?
-
PR: https://git.openjdk.org/jdk/pull/11169
On Tue, 22 Nov 2022 02:22:20 GMT, Dongxu Wang wrote:
> > good catch, do you need a JBS issue for this?
>
> Thank you if you can help with that.
I filed https://bugs.openjdk.org/browse/JDK-8297385 for this, you can change
your PR title and commit message to [8297385: Remove duplicated null
On Mon, 21 Nov 2022 15:16:14 GMT, Yi Yang wrote:
> good catch, do you need a JBS issue for this?
Thank you if you can help with that.
-
PR: https://git.openjdk.org/jdk/pull/11169
8297385: Remove duplicated null typos in javadoc
-
Commit messages:
- Minor remove duplicate null typo
Changes: https://git.openjdk.org/jdk/pull/11169/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=11169=00
Issue: https://bugs.openjdk.org/browse/JDK-8297385
Stats: 3 lines
13 matches
Mail list logo
