Re: RFR: 8329787: Fix typo in CLDRConverter

2024-04-08 Thread Naoto Sato
On Fri, 5 Apr 2024 17:22:36 GMT, Naoto Sato wrote: > Fix a file/class name in the `CLDRConverter` build tool, with some clean-up > for a switch statement. Thanks for the reviews! - PR Comment: https://git.openjdk.org/jdk/pull/18662#issuecomment-2043177032

Re: RFR: 8329787: Fix typo in CLDRConverter

2024-04-05 Thread Brian Burkhalter
On Fri, 5 Apr 2024 17:22:36 GMT, Naoto Sato wrote: > Fix a file/class name in the `CLDRConverter` build tool, with some clean-up > for a switch statement. +1 - Marked as reviewed by bpb (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/18662#pullrequestreview-1984005299

Re: RFR: 8329787: Fix typo in CLDRConverter

2024-04-05 Thread Lance Andersen
On Fri, 5 Apr 2024 17:22:36 GMT, Naoto Sato wrote: > Fix a file/class name in the `CLDRConverter` build tool, with some clean-up > for a switch statement. Marked as reviewed by lancea (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/18662#pullrequestreview-1983860994

Re: RFR: 8329787: Fix typo in CLDRConverter

2024-04-05 Thread Iris Clark
On Fri, 5 Apr 2024 17:22:36 GMT, Naoto Sato wrote: > Fix a file/class name in the `CLDRConverter` build tool, with some clean-up > for a switch statement. I like the new switch! - Marked as reviewed by iris (Reviewer). PR Review:

Re: RFR: 8329787: Fix typo in CLDRConverter

2024-04-05 Thread Justin Lu
On Fri, 5 Apr 2024 17:22:36 GMT, Naoto Sato wrote: > Fix a file/class name in the `CLDRConverter` build tool, with some clean-up > for a switch statement. LGTM - Marked as reviewed by jlu (Committer). PR Review: https://git.openjdk.org/jdk/pull/18662#pullrequestreview-1983814332

RFR: 8329787: Fix typo in CLDRConverter

2024-04-05 Thread Naoto Sato
Fix a file/class name in the `CLDRConverter` build tool, with some clean-up for a switch statement. - Commit messages: - initial commit Changes: https://git.openjdk.org/jdk/pull/18662/files Webrev: https://webrevs.openjdk.org/?repo=jdk=18662=00 Issue: