[coreboot] Re: Do we have a rule that code should be build tested?

2020-01-28 Thread Patrick Georgi via coreboot
Am Di., 28. Jan. 2020 um 08:03 Uhr schrieb David Hendricks < david.hendri...@gmail.com>: > Please correct me if I'm way off base with that example. The stubs > Patrick proposed in the other thread might help address the issue, > however it can also mean adding code which exists only to satisfy

[coreboot] Re: Do we have a rule that code should be build tested?

2020-01-27 Thread David Hendricks
> I'm not so sure what we argue about here. The hypothetical case that > it's hard to hook things up for build testing early, right? I've haven't > seen that yet. Let's step back for a moment. The proposal as I understand is that all code that lands in the tree must be hooked up so it's built by

[coreboot] Re: Do we have a rule that code should be build tested?

2020-01-27 Thread Nico Huber
Hi David, I'm not so sure what we argue about here. The hypothetical case that it's hard to hook things up for build testing early, right? I've haven't seen that yet. On 26.01.20 23:49, David Hendricks wrote: >> On 26.01.20 19:46, David Hendricks wrote: >> Of course, there'll always be a gap

[coreboot] Re: Do we have a rule that code should be build tested?

2020-01-26 Thread David Hendricks
> On 26.01.20 19:46, David Hendricks wrote: > Of course, there'll always be a gap when a new platform is added. We > could make it a rule, though, that no commit should be merged to the > master branch, before the one that hooks the build test up is reviewed. > > >>> This means

[coreboot] Re: Do we have a rule that code should be build tested?

2020-01-26 Thread Nico Huber
Hi David, I'm a bit confused by some of your arguments, it just seems weird. So my apologies in advance if I misinterpreted you. On 26.01.20 19:46, David Hendricks wrote: Of course, there'll always be a gap when a new platform is added. We could make it a rule, though, that no commit

[coreboot] Re: Do we have a rule that code should be build tested?

2020-01-26 Thread David Hendricks
> >> Of course, there'll always be a gap when a new platform is added. We > >> could make it a rule, though, that no commit should be merged to the > >> master branch, before the one that hooks the build test up is reviewed. > >> > > This means that such code isn't build tested for even longer,

[coreboot] Re: Do we have a rule that code should be build tested?

2020-01-26 Thread Nico Huber
Hi Patrick, On 26.01.20 10:48, Patrick Georgi wrote: > Nico Huber via coreboot schrieb am So., 26. Jan. > 2020, 02:07: >> I've recently seen how much trouble it can cause when a whole new >> platform directory isn't hooked up for build tests. One has to double >> check every patch touching a

[coreboot] Re: Do we have a rule that code should be build tested?

2020-01-26 Thread Patrick Georgi via coreboot
Nico Huber via coreboot schrieb am So., 26. Jan. 2020, 02:07: > Hello again, > > so, we have Jenkins that runs build tests on our master branch. That > makes working together on a huge project much easier. However, do we > have a rule that all the code should be build tested? and if not, >