Re: HTTP Pipelining Contributions

2012-07-27 Thread Fabian Keil
George Rizkalla grizka...@rim.com wrote: On 7/26/12 6:13 AM, Fabian Keil wrote: Or apply the standard host blacklist to the proxy as well (unless that's already what you are referring to). Do you see any advantages in having two separate blacklists? I don't feel too strongly about

Re: HTTP Pipelining Contributions

2012-07-26 Thread Fabian Keil
George Rizkalla grizka...@rim.com wrote: On 7/25/12 11:44 AM, Fabian Keil wrote: How do you intend to deal with HTTP proxies? If an HTTP proxy is used, the socket isn't directly connected to the server and may be used for requests to different servers. curl already does that. It's

RE: HTTP Pipelining Contributions

2012-07-26 Thread Joe Mason
From: curl-library-boun...@cool.haxx.se [curl-library-boun...@cool.haxx.se] on behalf of Dan Fandrich [d...@coneharvesters.com] Sent: Wednesday, July 25, 2012 5:30 PM To: curl-library@cool.haxx.se Subject: Re: HTTP Pipelining Contributions This is set of proposals sounds really useful

Re: HTTP Pipelining Contributions

2012-07-26 Thread George Rizkalla
On 7/26/12 6:13 AM, Fabian Keil wrote: Or apply the standard host blacklist to the proxy as well (unless that's already what you are referring to). Do you see any advantages in having two separate blacklists? I don't feel too strongly about either option :). It seems like we might get some

RE: HTTP Pipelining Contributions

2012-07-25 Thread Joe Mason
From: curl-library-boun...@cool.haxx.se [curl-library-boun...@cool.haxx.se] on behalf of Vladimir Grishchenko [vlad...@hotmail.com] Assuming this new option (CURLMOPT_MAXCONNECTS_HARD) will be supported when not using pipelining, will the client be able to prioritize queued requests or

RE: HTTP Pipelining Contributions

2012-07-25 Thread Joe Mason
From: curl-library-boun...@cool.haxx.se [curl-library-boun...@cool.haxx.se] on behalf of Daniel Stenberg [dan...@haxx.se] On Tue, 24 Jul 2012, George Rizkalla wrote: We are currently looking at contributing to libcurl's pipelining implementation, and we were hoping to get your feedback

Re: HTTP Pipelining Contributions

2012-07-25 Thread Fabian Keil
Joe Mason jma...@rim.com wrote: From: curl-library-boun...@cool.haxx.se [curl-library-boun...@cool.haxx.se] on behalf of Daniel Stenberg [dan...@haxx.se] If the first response to a request on a socket is marked as HTTP/1.0, or an older IIS server version is used, or the site is

Re: HTTP Pipelining Contributions

2012-07-25 Thread Vladimir Grishchenko
FIFO to start, but we should consider expandability. Can you suggest an interface that would let the client prioritize queued requests? I can think of a couple off the top of my head: 1. Allow the client to provide a sort function for requests. If one is set, then requests are stored in a

Re: HTTP Pipelining Contributions

2012-07-25 Thread George Rizkalla
On 7/24/12 6:13 PM, Daniel Stenberg wrote: Awesome. You are most welcome here and I'm sure I'm not the only one who will appreciate this! Thanks! We're certainly looking forward to the opportunity to work on this :). 1. MAX SOCKETS CHANGES I know this has been requested by others in the

Re: HTTP Pipelining Contributions

2012-07-25 Thread George Rizkalla
On 7/25/12 11:44 AM, Fabian Keil wrote: How do you intend to deal with HTTP proxies? If an HTTP proxy is used, the socket isn't directly connected to the server and may be used for requests to different servers. curl already does that. It's also possible that the server supports pipelining

Re: HTTP Pipelining Contributions

2012-07-25 Thread Dan Fandrich
On Tue, Jul 24, 2012 at 03:01:26PM +, George Rizkalla wrote: The proposed algorithm involves balancing HTTP requests over multiple TCP sockets, while avoiding use of HTTP pipelining in instances where we believe errors are likely to occur, or where it is likely that there would be a

HTTP Pipelining Contributions

2012-07-24 Thread George Rizkalla
Hi all, We are currently looking at contributing to libcurl's pipelining implementation, and we were hoping to get your feedback on some areas we'd like to help with. Joe Mason will be contributing the bulk of the code changes (after he wraps up the authentication changes he has been discussing

RE: HTTP Pipelining Contributions

2012-07-24 Thread Vladimir Grishchenko
1. MAX SOCKETS CHANGES While CURLMOPT_MAXCONNECTS imposes a limit on the number of sockets persisted, it does not regulate the maximum number of sockets that are in use at a given point in time. It is proposed that CURLMOPT_MAXCONNECTS be aliased/renamed CURLMOPT_MAXCONNECTS_SOFT, and that

Re: HTTP Pipelining Contributions

2012-07-24 Thread George Rizkalla
On 7/24/12 1:50 PM, Vladimir Grishchenko wrote: Assuming this new option (CURLMOPT_MAXCONNECTS_HARD) will be supported when not using pipelining, will the client be able to prioritize queued requests or it is going to be a FIFO implementation? I think a prioritized queue would be nice to have,

Re: HTTP Pipelining Contributions

2012-07-24 Thread Daniel Stenberg
On Tue, 24 Jul 2012, George Rizkalla wrote: We are currently looking at contributing to libcurl's pipelining implementation, and we were hoping to get your feedback on some areas we'd like to help with. Awesome. You are most welcome here and I'm sure I'm not the only one who will appreciate