Bug#1012789: Bug#1012825: Removed symbol without major SONAME bump

2022-06-26 Thread Petter Reinholdtsen
[László Böszörményi] > You are right that removing public symbols from a library interface > is an ABI break and requires a SONAME change. Per coding standards > function names starting with underscore are part of the private API > and a) not to be used outside of the library, b) if used

Bug#1012825: Removed symbol without major SONAME bump

2022-06-26 Thread GCS
Control: merge 1013877 1013878 On Sun, Jun 26, 2022 at 2:18 PM László Böszörményi (GCS) wrote: > See the attached patch, basically it's a one liner. Sergei just needs > to add it to the libtk-img package source. Then it's just one bug, sorry for the duplication. As soon as Sergei uploads this

Bug#1012789: Bug#1012825: Removed symbol without major SONAME bump

2022-06-26 Thread GCS
Control: tags 1012825 -patch Control: clone 1012789 -1 Control: reassign -1 libtk-img Control: retitle -1 libtk-img: add _TIFFsetString to its internal tiff library Control: tags -1 +patch On Sat, Jun 25, 2022 at 5:07 PM Petter Reinholdtsen wrote: > While it might sound sensible on the surface,

Bug#1012789: Bug#1012825: Removed symbol without major SONAME bump

2022-06-25 Thread Petter Reinholdtsen
[László Böszörményi] > As noted by libtiff upstream as well, this function was internal of > tiff and its declaration was in a header file that was not installed > publicly. They could change that without prior notice. While it might sound sensible on the surface, the realities is that the

Bug#1012789: Bug#1012825: Removed symbol without major SONAME bump

2022-06-25 Thread GCS
Control: tags 1012825 patch Control: severity 1012825 normal Control: unblock 1012789 by 1012825 On Fri, Jun 24, 2022 at 11:57 AM Petter Reinholdtsen wrote: > Until upstream decide to reinsert the symbol or bump the SONAME, I > suggest to carry this patch. It should get the broken packages in >

Bug#1012825: Removed symbol without major SONAME bump

2022-06-24 Thread Petter Reinholdtsen
Control: tags -1 + patch Until upstream decide to reinsert the symbol or bump the SONAME, I suggest to carry this patch. It should get the broken packages in Debian working again. diff -ur tiff-4.4.0/libtiff/tif_dir.c tiff-4.4.0-new/libtiff/tif_dir.c --- tiff-4.4.0/libtiff/tif_dir.c

Bug#1012825: Removed symbol without major SONAME bump

2022-06-24 Thread Petter Reinholdtsen
Control: severity -1 critical [Håvard F. Aasen] > It was actually a bug [1] in linuxcnc that made me look. Then it was just > to search for the library that previously had that symbol. > Should probably have reported back with my findings. Aha. I have linked the two bugs together now, to allow

Bug#1012825: Removed symbol without major SONAME bump

2022-06-23 Thread Petter Reinholdtsen
Control: forwarded -1 https://gitlab.com/libtiff/libtiff/-/issues/437 Nasty issue. I created an issue upstream about it. How did you discover the problem? Can it be automatically detected in a autopkgtest script? -- Happy hacking Petter Reinholdtsen