Package: arm-trusted-firmware
Version: 2.8.0+dfsg-1
Severity: normal
Tags: patch
Hi Vagrant,
Commit fb23b104 to TF-A introduced setting up power regulators on the
H6. Unfortunately this broke Ethernet on some H6 boards such as the
Orange Pi One Plus and the Orange Pi 3, because the Ethernet PHY
requires certain regulators to be brought up together, not the way TF-A
does it.
For that reason, commit 67412e4d introduced a build option
SUNXI_SETUP_REGULATORS to be set to 0 for those boards. In that case
TF-A leaves the regulators alone and the kernel sets them up later. It's
documented in docs/plat/allwinner.rst.
Please could we introduce a subplatform of sun50i_h6 with the regulator
setup disabled, to allow Ethernet to work on those boards? I've included
a suggested patch below.
Thanks very much,
Harold.
diff --git a/debian/rules b/debian/rules
index 10bafab74..66ecf8bab 100755
--- a/debian/rules
+++ b/debian/rules
@@ -25,6 +25,13 @@ platforms_nodebug := sun50i_a64 imx8mq
imx8mn_subplatforms := imx8mn imx8mn_uart4
imx8mn_uart4_assigns := IMX_BOOT_UART_BASE=0x30a60000
+# TF-A's regulator setup breaks Ethernet on some H6 boards,
+# so make it optional by having two subplatforms:
+# * sun50i_h6: default configuration
+# * sun50i_h6_leave_regulators: skip regulator setup
+sun50i_h6_subplatforms := sun50i_h6 sun50i_h6_leave_regulators
+sun50i_h6_leave_regulators_assigns := SUNXI_SETUP_REGULATORS=0
+
# Always set CROSS_COMPILE, which also works for native builds.
define build_platform
$(eval platform := $(1))
