Source: pd-hexloader
Version: 1.7-6
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lu...@debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

This is most likely caused by a change in dpkg 1.22.6, that enabled
-Werror=implicit-function-declaration. For more information, see
https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

Relevant part (hopefully):
> cc -I"/usr/include/pd" -DPD -DVERSION='"v1.7"' -fPIC -Wdate-time 
> -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration 
> -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong 
> -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection  
> -O6 -funroll-loops -fomit-frame-pointer -o "hexloader.o" -c "hexloader.c"
> hexloader.c: In function ‘hexloader_normalize’:
> hexloader.c:427:11: warning: return discards ‘const’ qualifier from pointer 
> target type [-Wdiscarded-qualifiers]
>   427 |   return s->s_name;
>       |          ~^~~~~~~~
> hexloader.c: In function ‘hexloader_fsnormalize’:
> hexloader.c:478:11: warning: return discards ‘const’ qualifier from pointer 
> target type [-Wdiscarded-qualifiers]
>   478 |   return s->s_name;
>       |          ~^~~~~~~~
> hexloader.c: In function ‘hexloader_deslashify’:
> hexloader.c:492:32: warning: passing argument 2 of ‘filelist_add’ discards 
> ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
>   492 |   result=filelist_add(result, s->s_name, 0);
>       |                               ~^~~~~~~~
> hexloader.c:320:55: note: expected ‘char *’ but argument is of type ‘const 
> char *’
>   320 | static filelist_t*filelist_add(filelist_t*files, char*name, 
> namelist_t*setupfun) {
>       |                                                  ~~~~~^~~~
> hexloader.c: In function ‘hexloader_getaltsetups’:
> hexloader.c:534:30: warning: passing argument 2 of ‘namelist_add’ discards 
> ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
>   534 |   names=namelist_add(names, s->s_name);
>       |                             ~^~~~~~~~
> hexloader.c:243:55: note: expected ‘char *’ but argument is of type ‘const 
> char *’
>   243 | static namelist_t*namelist_add(namelist_t*names, char*name) {
>       |                                                  ~~~~~^~~~
> hexloader.c:537:30: warning: passing argument 2 of ‘namelist_add’ discards 
> ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
>   537 |   names=namelist_add(names, s->s_name);
>       |                             ~^~~~~~~~
> hexloader.c:243:55: note: expected ‘char *’ but argument is of type ‘const 
> char *’
>   243 | static namelist_t*namelist_add(namelist_t*names, char*name) {
>       |                                                  ~~~~~^~~~
> hexloader.c: In function ‘hexloader_doload’:
> hexloader.c:608:5: error: implicit declaration of function ‘error’; did you 
> mean ‘perror’? [-Werror=implicit-function-declaration]
>   608 |     error("alas! somebody (you?) has compiled [hexloader] without 
> support for loading externals...how should i load?");
>       |     ^~~~~
>       |     perror
> hexloader.c: In function ‘hexloader_setup’:
> hexloader.c:915:24: warning: macro "__DATE__" might prevent reproducible 
> builds [-Wdate-time]
>   915 |   post("\tcompiled on "__DATE__" at "__TIME__ " ");
>       |                        ^~~~~~~~
> hexloader.c:915:38: warning: macro "__TIME__" might prevent reproducible 
> builds [-Wdate-time]
>   915 |   post("\tcompiled on "__DATE__" at "__TIME__ " ");
>       |                                      ^~~~~~~~
> hexloader.c:919:23: warning: passing argument 1 of ‘sys_register_loader’ from 
> incompatible pointer type [-Wincompatible-pointer-types]
>   919 |   sys_register_loader(hexloader_loader);
>       |                       ^~~~~~~~~~~~~~~~
>       |                       |
>       |                       int (*)(struct _glist *, char *)
> In file included from hexloader.c:30:
> /usr/include/pd/s_stuff.h:54:42: note: expected ‘loader_t’ {aka ‘int 
> (*)(struct _glist *, const char *, const char *)’} but argument is of type 
> ‘int (*)(struct _glist *, char *)’
>    54 | EXTERN void sys_register_loader(loader_t loader);
>       |                                 ~~~~~~~~~^~~~~~
> hexloader.c: In function ‘hexloader_trypatches’:
> hexloader.c:666:27: warning: ‘__builtin___sprintf_chk’ may write a 
> terminating nul past the end of the destination [-Wformat-overflow=]
>   666 |   sprintf(fullfile, "%s/%s", pathname, filename);
>       |                           ^
> In file included from /usr/include/stdio.h:906,
>                  from /usr/include/pd/m_pd.h:82,
>                  from hexloader.c:21:
> In function ‘sprintf’,
>     inlined from ‘hexloader_loadpatch’ at hexloader.c:666:3,
>     inlined from ‘hexloader_trypatches’ at hexloader.c:765:25:
> /usr/include/x86_64-linux-gnu/bits/stdio2.h:30:10: note: 
> ‘__builtin___sprintf_chk’ output 2 or more bytes (assuming 1001) into a 
> destination of size 1000
>    30 |   return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1,
>       |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    31 |                                   __glibc_objsize (__s), __fmt,
>       |                                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    32 |                                   __va_arg_pack ());
>       |                                   ~~~~~~~~~~~~~~~~~
> hexloader.c: In function ‘hexloader_trypatches’:
> hexloader.c:666:27: warning: ‘__builtin___sprintf_chk’ may write a 
> terminating nul past the end of the destination [-Wformat-overflow=]
>   666 |   sprintf(fullfile, "%s/%s", pathname, filename);
>       |                           ^
> In function ‘sprintf’,
>     inlined from ‘hexloader_loadpatch’ at hexloader.c:666:3,
>     inlined from ‘hexloader_trypatches’ at hexloader.c:765:25:
> /usr/include/x86_64-linux-gnu/bits/stdio2.h:30:10: note: 
> ‘__builtin___sprintf_chk’ output 2 or more bytes (assuming 1001) into a 
> destination of size 1000
>    30 |   return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1,
>       |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    31 |                                   __glibc_objsize (__s), __fmt,
>       |                                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    32 |                                   __va_arg_pack ());
>       |                                   ~~~~~~~~~~~~~~~~~
> hexloader.c: In function ‘hexloader_trylibraries’:
> hexloader.c:635:27: warning: ‘__builtin___sprintf_chk’ may write a 
> terminating nul past the end of the destination [-Wformat-overflow=]
>   635 |   sprintf(fullfile, "%s/%s", pathname, filename);
>       |                           ^
> In function ‘sprintf’,
>     inlined from ‘hexloader_loadfile’ at hexloader.c:635:3,
>     inlined from ‘hexloader_trylibraries’ at hexloader.c:732:12:
> /usr/include/x86_64-linux-gnu/bits/stdio2.h:30:10: note: 
> ‘__builtin___sprintf_chk’ output 2 or more bytes (assuming 1001) into a 
> destination of size 1000
>    30 |   return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1,
>       |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    31 |                                   __glibc_objsize (__s), __fmt,
>       |                                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    32 |                                   __va_arg_pack ());
>       |                                   ~~~~~~~~~~~~~~~~~
> cc1: some warnings being treated as errors
> make[2]: *** [Makefile:265: hexloader.o] Error 1


The full build log is available from:
http://qa-logs.debian.net/2024/03/13/pd-hexloader_1.7-6_unstable.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lu...@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240313&fusertaguser=lu...@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.

Reply via email to