Bug#1071480: libldap: sends some IPv6 addresses as server name

2024-05-20 Thread Elliott Mitchell
On Mon, May 20, 2024 at 04:25:57PM -0700, Quanah Gibson-Mount wrote: > > --On Monday, May 20, 2024 3:45 PM -0700 Elliott Mitchell > wrote: > > Side note - I did raise this issue with the rest of the OpenLDAP project, > and Howard noted: > > "DNS names are required to begin with a letter. RFC

Bug#1071480: libldap: sends some IPv6 addresses as server name

2024-05-20 Thread Quanah Gibson-Mount
--On Monday, May 20, 2024 3:45 PM -0700 Elliott Mitchell wrote: Side note - I did raise this issue with the rest of the OpenLDAP project, and Howard noted: "DNS names are required to begin with a letter. RFC 1035, sec 2.3.1. The fact that gnutls allows names that are all numeric is

Bug#1071480: libldap: sends some IPv6 addresses as server name

2024-05-20 Thread Elliott Mitchell
On Mon, May 20, 2024 at 12:46:34PM -0700, Ryan Tandy wrote: > However, I tested your patch, and I'm not sure it's correct. > > If the IPv6 address contains a letter a-f before the first colon, I > think the code you changed is never reached. On seeing the first > non-digit, we break the loop

Bug#1071480: libldap: sends some IPv6 addresses as server name

2024-05-20 Thread Quanah Gibson-Mount
--On Monday, May 20, 2024 1:46 PM -0700 Ryan Tandy wrote: Control: tag -1 upstream moreinfo Hi Elliott, thank you for investigating this issue and contributing a patch. [snip] I would appreciate if you would pursue this issue upstream. If the fix needs further review or discussion with

Bug#1071480: libldap: sends some IPv6 addresses as server name

2024-05-20 Thread Ryan Tandy
Control: tag -1 upstream moreinfo Hi Elliott, thank you for investigating this issue and contributing a patch. However, I tested your patch, and I'm not sure it's correct. If the IPv6 address contains a letter a-f before the first colon, I think the code you changed is never reached. On

Bug#1071480: libldap: sends some IPv6 addresses as server name

2024-05-19 Thread Elliott Mitchell
Seems there were two bugs in #1070033. The part for OpenLDAP is pretty simple. When detecting an IPv6 address (via ':' in the string), the function `ldap_int_tls_connect()` triggers a `break;`, but this requires `numeric=1` to still be in effect. Since IPv6 addresses are hexadecimal, this isn't