Bug#453519: [Logcheck-devel] Bug#453519: logcheck-database: amavisd-new file looks like the one shipped by amavisd-new

2009-08-24 Thread Frédéric Brière
On Sun, Aug 23, 2009 at 06:47:56PM -0700, Russ Allbery wrote: +[ -e $CONFFILE ] || return 0 It probably doesn't matter, but I'd use -f here. You're right, it would be better. I would tend to not do this and instead just leave the file in place since it does still work. I think it's

Bug#453519: [Logcheck-devel] Bug#453519: Bug#453519: logcheck-database: amavisd-new file looks like the one shipped by amavisd-new

2009-08-24 Thread Russ Allbery
Frédéric Brière fbri...@fbriere.net writes: My concern is that this would introduce a discrepancy between the two cases; why is it OK to move a modified conffile if it's been dropped out of the package today, but not if it's been dropped two years ago? (Not to mention that dpkg will probably

Bug#453519: logcheck-database: amavisd-new file looks like the one shipped by amavisd-new

2009-08-24 Thread Frédéric Brière
On Mon, Aug 24, 2009 at 03:39:06PM -0700, Russ Allbery wrote: Or are there a lot of existing cases where we know that the dropped configuration files contained bad rules? Probably not, but I'm too lazy to check. :) A non-empty cracking.d/logcheck might be problematic, though. In an ideal

Bug#453519: logcheck-database: amavisd-new file looks like the one shipped by amavisd-new

2009-08-23 Thread Frédéric Brière
On Sat, Aug 22, 2009 at 11:21:35AM -0400, Frédéric Brière wrote: There's no way to tell this manually-added file apart from another one which was left around as cruft. Actually, this doesn't bother dpkg at all, which will gladly convert such a file into a conffile when the occasion comes. If

Bug#453519: [Logcheck-devel] Bug#453519: logcheck-database: amavisd-new file looks like the one shipped by amavisd-new

2009-08-23 Thread Russ Allbery
Frédéric Brière fbri...@fbriere.net writes: +[ -e $CONFFILE ] || return 0 It probably doesn't matter, but I'd use -f here. +echo Obsolete conffile $CONFFILE has been modified by you. +echo Saving as $CONFFILE.dpkg-bak ... +mv -f $CONFFILE $CONFFILE.dpkg-bak I would tend to

Bug#453519: logcheck-database: amavisd-new file looks like the one shipped by amavisd-new

2009-08-22 Thread Frédéric Brière
On Fri, Aug 21, 2009 at 08:32:40PM -0400, Frédéric Brière wrote: (If we really want to nitpick, if the user copied the file contents from X+1 manually before upgrading to X+2, Policy might possibly require us to leave that file alone.) Here's a similar but less contrieved situation: I install

Bug#453519: logcheck-database: amavisd-new file looks like the one shipped by amavisd-new

2009-08-21 Thread Frédéric Brière
On Mon, Mar 17, 2008 at 04:13:03PM -0700, Russ Allbery wrote: Conffiles are not automatically deleted on upgrade. You have to remove It would appear that logcheck has shed many files over the years: $ git log --summary master origin/1.2 -- rulefiles/linux/ | \ grep 'delete mode'

Bug#453519: [Logcheck-devel] Bug#453519: logcheck-database: amavisd-new file looks like the one shipped by amavisd-new

2009-08-21 Thread Russ Allbery
Frédéric Brière fbri...@fbriere.net writes: On Mon, Mar 17, 2008 at 04:13:03PM -0700, Russ Allbery wrote: Conffiles are not automatically deleted on upgrade. You have to remove It would appear that logcheck has shed many files over the years: $ git log --summary master origin/1.2 --

Bug#453519: logcheck-database: amavisd-new file looks like the one shipped by amavisd-new

2009-08-21 Thread Frédéric Brière
On Fri, Aug 21, 2009 at 12:03:41PM -0700, Russ Allbery wrote: Do we have the md5 checksums of the last version that we shipped with the package anywhere? Yes, that can be easily extracted. I see two issues with this: First, there's no guarantee that the file will be the last version shipped.

Bug#453519: [Logcheck-devel] Bug#453519: logcheck-database: amavisd-new file looks like the one shipped by amavisd-new

2009-08-21 Thread Russ Allbery
Frédéric Brière fbri...@fbriere.net writes: Yes, that can be easily extracted. I see two issues with this: First, there's no guarantee that the file will be the last version shipped. If a file was included in version X, modified in X+1, and removed in X+2, it's possible that the user

Bug#453519: logcheck-database: amavisd-new file looks like the one shipped by amavisd-new

2008-03-18 Thread Frédéric Brière
On Mon, Mar 17, 2008 at 11:48:47PM +0100, Marc Bobillier wrote: Yes, with logcheck and logcheck-database 1.2.63: Yeah, I'm quite confused: [EMAIL PROTECTED]:~$ dpkg -S /etc/logcheck/violations.ignore.d/logcheck-amavisd-new logcheck-database:

Bug#453519: logcheck-database: amavisd-new file looks like the one shipped by amavisd-new

2008-03-18 Thread Marc Bobillier
* Frédéric Brière [2008-03-16 02:25:50 -0400]: tags 453519 moreinfo In article [EMAIL PROTECTED] you wrote: Version: 1.2.63 The content of the file /etc/logcheck/violations.ignore.d/logcheck-amavisd-new is contained already in /etc/logcheck/violations.ignore.d/amavisd-new (this one

Bug#453519: [Logcheck-devel] Bug#453519: logcheck-database: amavisd-new file looks like the one shipped by amavisd-new

2008-03-18 Thread Russ Allbery
Frédéric Brière [EMAIL PROTECTED] writes: In article [EMAIL PROTECTED] you wrote: Version: 1.2.63 The content of the file /etc/logcheck/violations.ignore.d/logcheck-amavisd-new is contained already in /etc/logcheck/violations.ignore.d/amavisd-new (this one shipped with amavisd-new). Both

Bug#453519: logcheck-database: amavisd-new file looks like the one shipped by amavisd-new

2008-03-16 Thread Frédéric Brière
tags 453519 moreinfo thanks In article [EMAIL PROTECTED] you wrote: Version: 1.2.63 The content of the file /etc/logcheck/violations.ignore.d/logcheck-amavisd-new is contained already in /etc/logcheck/violations.ignore.d/amavisd-new (this one shipped with amavisd-new). Both amavisd-new

Bug#453519: logcheck-database: amavisd-new file looks like the one shipped by amavisd-new

2007-11-29 Thread Marc Bobillier
Package: logcheck-database Version: 1.2.63 Severity: minor The content of the file /etc/logcheck/violations.ignore.d/logcheck-amavisd-new is contained already in /etc/logcheck/violations.ignore.d/amavisd-new (this one shipped with amavisd-new). Regards marc -- System Information: Debian