Package: gppppon Version: 0.3-1 Severity: normal Tags: upstream sid patch Hiya,
I saw gpppon in the FTBFS list on Ubuntu[0]. Here we have taken a gtk+2.0 split from experimental. This exposes a bug in the makefile of gpppon — the pkg-config file hardcodes the includes. It should use CFLAGS directly. Eventually, when the split is uploaded to sid, Debian will be affected too. The attached patch fixes the issue, and will be uploaded to Ubuntu imminently. I've also attached the buildlog. Cheers, Iain [0] http://udd.debian.org/cgi-bin/ubuntu_ftbfs.cgi -- System Information: Debian Release: squeeze/sid APT prefers maverick-updates APT policy: (500, 'maverick-updates'), (500, 'maverick-proposed'), (500, 'maverick') Architecture: amd64 (x86_64) Kernel: Linux 2.6.35-7-server (SMP w/2 CPU cores) Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to en_GB.UTF-8) Shell: /bin/sh linked to /bin/dash
diff -u gpppon-0.3/debian/changelog gpppon-0.3/debian/changelog --- gpppon-0.3/debian/changelog +++ gpppon-0.3/debian/changelog @@ -1,3 +1,9 @@ +gpppon (0.3-1ubuntu2) maverick; urgency=low + + * Makefile: Correctly use pkg-config for gtk+-2.0 CFLAGS, fixing FTBFS + + -- Iain Lane <la...@ubuntu.com> Sun, 08 Aug 2010 11:27:00 +0100 + gpppon (0.3-1ubuntu1) karmic; urgency=low * Merge with Debian unstable; remaining changes: only in patch2: unchanged: --- gpppon-0.3.orig/Makefile +++ gpppon-0.3/Makefile @@ -11,7 +11,8 @@ # gtk-config is usually installed together with gtk and it should # be used when possible: LIBS=`pkg-config --libs gtk+-2.0` -INCLUDES=-I /usr/lib/glib-2.0/include -I /usr/include/glib-2.0 -I /usr/include/gtk-2.0 -I /usr/include/gdk-2.0 -I /usr/include/cairo -I /usr/include/pango-1.0 -I /usr/lib/gtk-2.0/include -I /usr/include/atk-1.0 +INCLUDES=`pkg-config --cflags gtk+-2.0` +#INCLUDES=-I /usr/lib/glib-2.0/include -I /usr/include/glib-2.0 -I /usr/include/gtk-2.0 -I /usr/include/gdk-2.0 -I /usr/include/cairo -I /usr/include/pango-1.0 -I /usr/lib/gtk-2.0/include -I /usr/include/atk-1.0 gpppon: gpppon.o $(CC) -o gpppon $(LIBS) gpppon.o
dpkg-buildpackage -rfakeroot -D -us -uc -i -ICVS -I.svn -I_darcs -I.git -I.bzr dpkg-buildpackage: export CFLAGS from dpkg-buildflags (origin: vendor): -g -O2 dpkg-buildpackage: export CPPFLAGS from dpkg-buildflags (origin: vendor): dpkg-buildpackage: export CXXFLAGS from dpkg-buildflags (origin: vendor): -g -O2 dpkg-buildpackage: export FFLAGS from dpkg-buildflags (origin: vendor): -g -O2 dpkg-buildpackage: export LDFLAGS from dpkg-buildflags (origin: vendor): -Wl,-Bsymbolic-functions dpkg-buildpackage: source package gpppon dpkg-buildpackage: source version 0.3-1ubuntu1 dpkg-buildpackage: source changed by Siegfried-Angel Gevatter Pujals <rai...@ubuntu.com> dpkg-source -i -ICVS -I.svn -I_darcs -I.git -I.bzr --before-build gpppon-0.3 dpkg-buildpackage: host architecture amd64 fakeroot debian/rules clean dh_testdir dh_testroot rm -f build-stamp # Add here commands to clean up after the build process. [ ! -f Makefile ] || /usr/bin/make clean make[1]: Entering directory `/home/laney/temp/gpppon-0.3' rm -f gpppon *.o make[1]: Leaving directory `/home/laney/temp/gpppon-0.3' dh_clean dpkg-source -i -ICVS -I.svn -I_darcs -I.git -I.bzr -b gpppon-0.3 dpkg-source: warning: no source format specified in debian/source/format, see dpkg-source(1) dpkg-source: info: using source format `1.0' dpkg-source: info: building gpppon using existing gpppon_0.3.orig.tar.gz dpkg-source: info: building gpppon in gpppon_0.3-1ubuntu1.diff.gz dpkg-source: warning: file gpppon-0.3/gpppon.1 has no final newline (either original or modified version) dpkg-source: warning: ignoring deletion of file install-stamp dpkg-source: warning: ignoring deletion of file build-stamp dpkg-source: warning: the diff modifies the following upstream files: Makefile gpppon.1 gpppon.c dpkg-source: info: use the '3.0 (quilt)' format to have separate and documented changes to upstream files, see dpkg-source(1) dpkg-source: info: building gpppon in gpppon_0.3-1ubuntu1.dsc debian/rules build dh_testdir # Add here commands to compile the package. /usr/bin/make make[1]: Entering directory `/home/laney/temp/gpppon-0.3' gcc -c -Wall -O2 `pkg-config --cflags gtk+-2.0` gpppon.c gpppon.c: In function ‘run_cmd’: gpppon.c:187: warning: assignment discards qualifiers from pointer target type gpppon.c:188: warning: assignment discards qualifiers from pointer target type gpppon.c:189: warning: assignment discards qualifiers from pointer target type gpppon.c: In function ‘ppp_off_action’: gpppon.c:238: warning: assignment discards qualifiers from pointer target type gpppon.c: In function ‘ppp_on_action’: gpppon.c:263: warning: assignment discards qualifiers from pointer target type gpppon.c: At top level: gpppon.c:26: warning: ‘id’ defined but not used gpppon.c: In function ‘main’: gpppon.c:75: warning: ‘string’ may be used uninitialized in this function gpppon.c:75: note: ‘string’ was declared here gcc -o gpppon `pkg-config --libs gtk+-2.0` gpppon.o make[1]: Leaving directory `/home/laney/temp/gpppon-0.3' touch build-stamp fakeroot debian/rules binary dh_testdir dh_testroot dh_prep dh_installdirs # Add here commands to install the package into debian/gpppon. dh_install gpppon usr/bin dh_install debian/gpppon.desktop usr/share/applications touch install-stamp dh_testdir dh_testroot dh_installdocs dh_installmenu dh_installman gpppon.1 dh_installchangelogs dh_link dh_strip dh_compress dh_fixperms chmod 755 /home/laney/temp/gpppon-0.3/debian/gpppon/usr/bin/gpppon chown root:dip /home/laney/temp/gpppon-0.3/debian/gpppon/usr/bin/gpppon dh_installdeb dh_shlibdeps dpkg-shlibdeps: warning: dependency on libfontconfig.so.1 could be avoided if "debian/gpppon/usr/bin/gpppon" were not uselessly linked against it (they use none of its symbols). dpkg-shlibdeps: warning: dependency on libatk-1.0.so.0 could be avoided if "debian/gpppon/usr/bin/gpppon" were not uselessly linked against it (they use none of its symbols). dpkg-shlibdeps: warning: dependency on libm.so.6 could be avoided if "debian/gpppon/usr/bin/gpppon" were not uselessly linked against it (they use none of its symbols). dpkg-shlibdeps: warning: dependency on librt.so.1 could be avoided if "debian/gpppon/usr/bin/gpppon" were not uselessly linked against it (they use none of its symbols). dpkg-shlibdeps: warning: dependency on libgio-2.0.so.0 could be avoided if "debian/gpppon/usr/bin/gpppon" were not uselessly linked against it (they use none of its symbols). dpkg-shlibdeps: warning: dependency on libgdk_pixbuf-2.0.so.0 could be avoided if "debian/gpppon/usr/bin/gpppon" were not uselessly linked against it (they use none of its symbols). dpkg-shlibdeps: warning: dependency on libcairo.so.2 could be avoided if "debian/gpppon/usr/bin/gpppon" were not uselessly linked against it (they use none of its symbols). dpkg-shlibdeps: warning: dependency on libpango-1.0.so.0 could be avoided if "debian/gpppon/usr/bin/gpppon" were not uselessly linked against it (they use none of its symbols). dpkg-shlibdeps: warning: dependency on libgmodule-2.0.so.0 could be avoided if "debian/gpppon/usr/bin/gpppon" were not uselessly linked against it (they use none of its symbols). dpkg-shlibdeps: warning: dependency on libgthread-2.0.so.0 could be avoided if "debian/gpppon/usr/bin/gpppon" were not uselessly linked against it (they use none of its symbols). dpkg-shlibdeps: warning: dependency on libpangocairo-1.0.so.0 could be avoided if "debian/gpppon/usr/bin/gpppon" were not uselessly linked against it (they use none of its symbols). dpkg-shlibdeps: warning: dependency on libfreetype.so.6 could be avoided if "debian/gpppon/usr/bin/gpppon" were not uselessly linked against it (they use none of its symbols). dpkg-shlibdeps: warning: dependency on libgdk-x11-2.0.so.0 could be avoided if "debian/gpppon/usr/bin/gpppon" were not uselessly linked against it (they use none of its symbols). dpkg-shlibdeps: warning: dependency on libpangoft2-1.0.so.0 could be avoided if "debian/gpppon/usr/bin/gpppon" were not uselessly linked against it (they use none of its symbols). dh_gencontrol dh_md5sums dh_builddeb dpkg-deb: warning: 'debian/gpppon/DEBIAN/control' contains user-defined field 'Original-Maintainer' dpkg-deb: warning: ignoring 1 warnings about the control file(s) dpkg-deb: building package `gpppon' in `../gpppon_0.3-1ubuntu1_amd64.deb'. dpkg-genchanges >../gpppon_0.3-1ubuntu1_amd64.changes dpkg-genchanges: not including original source code in upload dpkg-source -i -ICVS -I.svn -I_darcs -I.git -I.bzr --after-build gpppon-0.3 dpkg-buildpackage: binary and diff upload (original source NOT included) Now running lintian... W: gpppon source: debhelper-but-no-misc-depends gpppon W: gpppon source: out-of-date-standards-version 3.8.0 (current is 3.9.1) W: gpppon: desktop-command-not-in-package /usr/share/applications/gpppon.desktop gksudo Finished running lintian. Now signing changes and any dsc files... signfile gpppon_0.3-1ubuntu1.dsc 20BFCDC7 gpg: gpg-agent is not available in this session signfile gpppon_0.3-1ubuntu1_amd64.changes 20BFCDC7 gpg: gpg-agent is not available in this session gpg: Invalid passphrase; please try again ... Successfully signed dsc and changes files
