Package: buzztard
Version: 0.5.0-4
Severity: wishlist
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu oneiric ubuntu-patch

when building with ld --as-needed libraries must be placed after object
files needing them on the command line so the symbols of the libraries
are registered as needed.
If they are placed before the symbols are dropped.

See the log in the ubuntu bug:
https://bugs.launchpad.net/ubuntu/+source/buzztard/+bug/803173

Attached patch fixes this issue by patching the Makefile.in
If the packaging changes to regenerate the autotools files the patch
should be applied in the same way to the Makefile.am files.

Description: fix build with ld --as-needed
 when building with ld --as-needed libraries must be placed
 after object files needing them on the command line so the symbols
 of the libraries are registered as needed.
Author: Julian Taylor <jtaylor.deb...@googlemail.com>
Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/buzztard/+bug/803173
Index: buzztard-0.5.0/docs/reference/bt-cmd/Makefile.in
===================================================================
--- buzztard-0.5.0.orig/docs/reference/bt-cmd/Makefile.in	2009-07-31 09:47:38.000000000 +0200
+++ buzztard-0.5.0/docs/reference/bt-cmd/Makefile.in	2011-07-07 13:34:50.473977021 +0200
@@ -332,9 +332,9 @@
 	$(BT_CFLAGS)
 
 GTKDOC_LIBS = \
+	$(top_builddir)/src/ui/cmd/libbtcmd.la \
 	$(top_builddir)/src/lib/core/libbuzztard-core.la \
 	$(top_builddir)/src/lib/ic/libbuzztard-ic.la \
-	$(top_builddir)/src/ui/cmd/libbtcmd.la \
 	$(BASE_DEPS_LIBS) \
 	$(BT_LIBS)
 
Index: buzztard-0.5.0/docs/reference/bt-edit/Makefile.in
===================================================================
--- buzztard-0.5.0.orig/docs/reference/bt-edit/Makefile.in	2009-07-31 09:47:38.000000000 +0200
+++ buzztard-0.5.0/docs/reference/bt-edit/Makefile.in	2011-07-07 13:34:50.483977021 +0200
@@ -337,9 +337,9 @@
 	$(BT_CFLAGS)
 
 GTKDOC_LIBS = \
+	$(top_builddir)/src/ui/edit/libbtedit.la \
 	$(top_builddir)/src/lib/core/libbuzztard-core.la \
 	$(top_builddir)/src/lib/ic/libbuzztard-ic.la \
-	$(top_builddir)/src/ui/edit/libbtedit.la \
 	$(BASE_DEPS_LIBS) \
 	$(GUI_DEPS_LIBS) \
         	$(BT_LIBS)
Index: buzztard-0.5.0/src/ui/edit/Makefile.in
===================================================================
--- buzztard-0.5.0.orig/src/ui/edit/Makefile.in	2009-07-31 09:47:41.000000000 +0200
+++ buzztard-0.5.0/src/ui/edit/Makefile.in	2011-07-07 13:34:50.483977021 +0200
@@ -324,10 +324,11 @@
 top_srcdir = @top_srcdir@
 with_desktop_dir = @with_desktop_dir@
 xvfb_path = @xvfb_path@
-buzztard_edit_LDADD = $(BASE_DEPS_LIBS) $(GUI_DEPS_LIBS) $(BT_LIBS) $(LIBINTL) \
+buzztard_edit_LDADD =  \
 	$(top_builddir)/src/lib/core/libbuzztard-core.la \
 	$(top_builddir)/src/lib/ic/libbuzztard-ic.la \
-	libbtedit.la
+	libbtedit.la \
+	$(BASE_DEPS_LIBS) $(GUI_DEPS_LIBS) $(BT_LIBS) $(LIBINTL)
 
 buzztard_edit_SOURCES = \
 	bt-edit.c bt-edit.h
Index: buzztard-0.5.0/src/ui/cmd/Makefile.in
===================================================================
--- buzztard-0.5.0.orig/src/ui/cmd/Makefile.in	2011-07-07 13:35:37.383977049 +0200
+++ buzztard-0.5.0/src/ui/cmd/Makefile.in	2011-07-07 13:35:48.613977057 +0200
@@ -288,9 +288,10 @@
 top_srcdir = @top_srcdir@
 with_desktop_dir = @with_desktop_dir@
 xvfb_path = @xvfb_path@
-buzztard_cmd_LDADD = $(BASE_DEPS_LIBS) $(BT_LIBS) $(LIBINTL) \
+buzztard_cmd_LDADD =  \
 	$(top_builddir)/src/lib/core/libbuzztard-core.la \
-	libbtcmd.la
+	libbtcmd.la \
+	$(BASE_DEPS_LIBS) $(BT_LIBS) $(LIBINTL)
 
 buzztard_cmd_SOURCES = \
 	bt-cmd.c bt-cmd.h

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to