Bug#636797: patch for WARN_OUT?

2011-09-06 Thread Daniel Kahn Gillmor
On 09/05/2011 11:38 PM, Ben Hutchings wrote: The code dump actually corresponds to this line in update_sg_lb_stats(), which has been compiled inline with find_busiest_group(): sgs-avg_load = (sgs-group_load * SCHED_LOAD_SCALE) / group-cpu_power; OK, i'm happy to take your word for it.

Bug#636797: patch for WARN_OUT?

2011-09-06 Thread Ben Hutchings
On Tue, Sep 06, 2011 at 10:35:32AM -0400, Daniel Kahn Gillmor wrote: On 09/05/2011 11:38 PM, Ben Hutchings wrote: The code dump actually corresponds to this line in update_sg_lb_stats(), which has been compiled inline with find_busiest_group(): sgs-avg_load = (sgs-group_load *

Bug#636797: patch for WARN_OUT?

2011-09-05 Thread Ben Hutchings
On Tue, 2011-08-30 at 14:35 -0400, Daniel Kahn Gillmor wrote: On 08/29/2011 02:40 PM, Ben Hutchings wrote: This is what I've added for 2.6.32-36. Any review would be appreciated. Thanks, Ben! Two crashes i have documentation for show the division-by-zero error happening in

Bug#636797: patch for WARN_OUT?

2011-08-30 Thread Daniel Kahn Gillmor
On 08/29/2011 02:40 PM, Ben Hutchings wrote: This is what I've added for 2.6.32-36. Any review would be appreciated. Thanks, Ben! Two crashes i have documentation for show the division-by-zero error happening in find_busiest_group, which was patched in the initial diff i submitted, but not in

Bug#636797: patch for WARN_OUT?

2011-08-29 Thread Ben Hutchings
This is what I've added for 2.6.32-36. Any review would be appreciated. Ben. From: Ben Hutchings b...@decadent.org.uk Subject: sched: Work around sched_group::cpu_power = 0 #636797 and others report a division by zero in the scheduler due to sched_group::cpu_power. Try to work out why this is

Bug#636797: patch for WARN_OUT?

2011-08-29 Thread Jonathan Nieder
Ben Hutchings wrote: This is what I've added for 2.6.32-36. Any review would be appreciated. Looks good to me. Possibly relevant upstream commits: v2.6.34-rc1~260^2~15 (sched: Fix the place where group powers are updated) v2.6.36-rc1~531^2~4 (sched: Reduce update_group_power() calls)

Bug#636797: patch for WARN_OUT?

2011-08-24 Thread Bjoern Boschman
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, I just wanted to ask if there's already some progress on this? I created a patch like suggested in bugzilla#13 Can anyone please review this patch? Would it make sense to create a patch that does the devide-by-zero workaround and also throws a

Bug#636797: patch for WARN_OUT?

2011-08-24 Thread Ben Hutchings
On Wed, 2011-08-24 at 15:26 +0200, Bjoern Boschman wrote: Hi, I just wanted to ask if there's already some progress on this? I created a patch like suggested in bugzilla#13 Can anyone please review this patch? Would it make sense to create a patch that does the devide-by-zero workaround