Bug#663522: git-daemon-sysvinit: /etc/init.d/git-daemon restart does not respect GIT_DAEMON_ENABLE

2012-03-14 Thread Jonathan Nieder
Hi Daniel, Jonathan McCrohan writes: Package: git-daemon-sysvinit Version: 1:1.7.9.1-1 The restart case of the git-daemon init script blindly enables the daemon regardless of the value of GIT_DAEMON_ENABLE. This allows administrators to inadvertently enable world access to repositories,

Bug#663522: git-daemon-sysvinit: /etc/init.d/git-daemon restart does not respect GIT_DAEMON_ENABLE

2012-03-14 Thread Daniel Baumann
On 03/14/2012 07:15 AM, Jonathan Nieder wrote: How about this patch? tested, and works. -- Address:Daniel Baumann, Donnerbuehlweg 3, CH-3012 Bern Email: daniel.baum...@progress-technologies.net Internet: http://people.progress-technologies.net/~daniel.baumann/ -- To

Bug#663522: git-daemon-sysvinit: /etc/init.d/git-daemon restart does not respect GIT_DAEMON_ENABLE

2012-03-14 Thread Jonathan Nieder
tags 663522 + pending quit Hi Daniel, Daniel Baumann wrote: tested, and works. Thanks for the quick testing. I assume that means you liked the patch ;-), so it's applied now[1]. [1] at git://git.debian.org/~jrnieder-guest/git.git debian-sid -- To UNSUBSCRIBE, email to

Bug#663522: git-daemon-sysvinit: /etc/init.d/git-daemon restart does not respect GIT_DAEMON_ENABLE

2012-03-14 Thread Daniel Baumann
On 03/14/2012 09:43 AM, Jonathan Nieder wrote: I assume that means you liked the patch ;-) correct. i'll be more precise next time. -- Address:Daniel Baumann, Donnerbuehlweg 3, CH-3012 Bern Email: daniel.baum...@progress-technologies.net Internet:

Bug#663522: git-daemon-sysvinit: /etc/init.d/git-daemon restart does not respect GIT_DAEMON_ENABLE

2012-03-11 Thread Jonathan Nieder
Package: git-daemon-sysvinit Version: 1:1.7.9.1-1 Severity: important Tags: security patch Hi, Jonathan McCrohan writes: The restart case of the git-daemon init script blindly enables the daemon regardless of the value of GIT_DAEMON_ENABLE. This allows administrators to inadvertently enable