Package: wmbiff
Version: 0.4.27-2.1
Severity: normal
Dear Maintainer,
When wmbiff is restarted, either with SIGUSR1, or with
shift+control+button1, it does not close its connections.
Since wmbiff restarts itself by a call to execvp(), setting FD_CLOEXEC
on the sockets seems to be sufficient to fix the problem.
The following patch implements it.
Regards,
Arnaud Giersch
--- wmbiff/socket.c.orig 2004-10-01 23:05:36.000000000 +0200
+++ wmbiff/socket.c 2012-03-14 18:32:19.313625507 +0100
@@ -58,6 +58,8 @@
printf("socket() failed.\n");
return (-1);
};
+ if (fcntl(fd, F_SETFD, FD_CLOEXEC) == -1)
+ perror("fcntl(FD_CLOEXEC)");
addr.sin_family = AF_INET;
addr.sin_addr.s_addr = *(u_long *) address;
@@ -122,6 +124,8 @@
fd = socket(res->ai_family, res->ai_socktype, res->ai_protocol);
if (fd < 0)
continue;
+ if (fcntl(fd, F_SETFD, FD_CLOEXEC) == -1)
+ perror("fcntl(FD_CLOEXEC)");
if (connect(fd, res->ai_addr, res->ai_addrlen) < 0) {
close(fd);
fd = -1;
-- System Information:
Debian Release: wheezy/sid
APT prefers testing
APT policy: (500, 'testing'), (50, 'unstable'), (40, 'experimental')
Architecture: amd64 (x86_64)
Kernel: Linux 3.1.0-1-amd64 (SMP w/2 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Versions of packages wmbiff depends on:
ii libc6 2.13-27
ii libgcrypt11 1.5.0-3
ii libgnutls26 2.12.16-1
ii libx11-6 2:1.4.4-4
ii libxext6 2:1.3.0-3
ii libxpm4 1:3.5.9-4
ii zlib1g 1:1.2.6.dfsg-2
wmbiff recommends no packages.
Versions of packages wmbiff suggests:
ii ruby 4.8
ii ruby1.8 [ruby] 1.8.7.352-2
ii ssh-askpass 1:1.2.4.1-9
-- no debconf information
--
http://info.iut-bm.univ-fcomte.fr/staff/giersch/
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
