Bug#808199: [Reproducible-builds] Bug#808199: diffoscope: Weird line numbering in diff output

2015-12-18 Thread Jérémy Bobbio
Control: tag -1 + pending Mike Hommey: > Attached here is two files that can be compared directly, exposing the > same problem. That's essentially the output of tar --full-time -tvf on > both tarballs from the original bug report. > > The following patch fixes the numbering issue: > […]

Bug#808199: diffoscope: Weird line numbering in diff output

2015-12-16 Thread Mike Hommey
Source: diffoscope Version: 43 Severity: normal Dear Maintainer, * What led up to the situation? Comparing https://queue.taskcluster.net/v1/task/FEXzanIjQKW_dBmv3ZmBJQ/runs/0/artifacts/public/build/target.tar.bz2 with

Bug#808199: diffoscope: Weird line numbering in diff output

2015-12-16 Thread Mike Hommey
On Thu, Dec 17, 2015 at 03:03:21PM +0900, Mike Hommey wrote: > However, there's another issue, that the diff is actually incomplete: > the right hand side stops 3 lines too early. > > (The patch is not actually changing anything here, I just figured > once the numbers looked normal, but didn't

Bug#808199: diffoscope: Weird line numbering in diff output

2015-12-16 Thread Mike Hommey
Attached here is two files that can be compared directly, exposing the same problem. That's essentially the output of tar --full-time -tvf on both tarballs from the original bug report. The following patch fixes the numbering issue: diff --git a/diffoscope/presenters/html.py