Bug#832096: lintian: please check for common typos in debian/rules target names

Hi, Updated patch attached that sorts when iterating over the Lintian::Data structure containing the debhelper commands to ensure that we deterministically output the potential suggestions. Thanks to nthykier. Regards, -- ,''`. : :' : Chris Lamb `. `'`

Bug#832096: lintian: please check for common typos in debian/rules target names

Hi Jakub, Thanks for the review. > Shouldn't it be "possible"? After all, our list of dh_* commands might > be out of date. Indeed it should; I copy-pasted from elsewhere without checking. Fixed. > This doesn't work that well if the typoed command is in close distance > to multiple existing

Bug#832096: lintian: please check for common typos in debian/rules target names

Hi Chris! Thanks for the updated patch. * Chris Lamb , 2016-07-23, 20:13: +Certainty: certain Shouldn't it be "possible"? After all, our list of dh_* commands might be out of date. +# Unknown command, so check for likely misspellings +

Bug#832096: lintian: please check for common typos in debian/rules target names

> If there's override_dh_FOO, but dh_FOO is not in > data/debhelper/dh_commands, and there's a known dh_* command that is > within close edit distance to dh_FOO, then that's probably a typo. Great idea! Updated patch attached. Regards, -- ,''`. : :' : Chris Lamb `. `'`

Bug#832096: lintian: please check for common typos in debian/rules target names

* Chris Lamb , 2016-07-22, 13:46: Lintian is already aware of existing dh_* commands (see data/debhelper/dh_commands), so maybe we could use this list instead of manually maintaining possible misspellings? Not without changing this data structure as we want multiple

Bug#832096: lintian: please check for common typos in debian/rules target names

Jakub Wilk wrote: > Lintian is already aware of existing dh_* commands (see > data/debhelper/dh_commands), so maybe we could use this list instead of > manually maintaining possible misspellings? Not without changing this data structure as we want multiple misspellings to map to the correct

Bug#832096: lintian: please check for common typos in debian/rules target names

Hi Chris! Thanks for the patch. I agree it would cool to have a check like this in Lintian. * Chris Lamb , 2016-07-22, 11:38: Misspelling an target (eg. "override_dh_install_debconf") results in that Typo: an -> a + This can result in (for example) an dh_override_-style

Bug#832096: lintian: please check for common typos in debian/rules target names

Source: lintian Version: 2.5.45 Severity: wishlist Tags: patch Hi, Attached is the following: commit 22f75ee230c6ae93e9192a663225626e73cf14c7 Author: Chris Lamb Date: Fri Jul 22 10:36:54 2016 +0100 c/rules: Check for common typos in debian/rules target names.