Bug#853855: di-utils: Kernel boot options containing a dot are not propagated to the installed system

2017-04-01 Thread Philip Hands
Cyril Brulebois writes: > Hi, > > Ben Hutchings (2017-03-30): >> Please go ahead. There may be some users that set module options at >> installation time and don't want them set in the installed system. But >> they are likely to be outnumbered by those

Bug#853855: di-utils: Kernel boot options containing a dot are not propagated to the installed system

2017-03-30 Thread Samuel Thibault
Ben Hutchings, on jeu. 30 mars 2017 15:24:03 +0100, wrote: > they are likely to be outnumbered by those who do want them set. Not only that, but the manual does document that such options *are* propagated to the installed system when placed properly. Not doing so is really unexpected behavior.

Bug#853855: di-utils: Kernel boot options containing a dot are not propagated to the installed system

2017-03-30 Thread Cyril Brulebois
Hi, Ben Hutchings (2017-03-30): > Please go ahead. There may be some users that set module options at > installation time and don't want them set in the installed system. But > they are likely to be outnumbered by those who do want them set. If > the installer can boot

Bug#853855: di-utils: Kernel boot options containing a dot are not propagated to the installed system

2017-03-30 Thread Ben Hutchings
On Thu, 2017-03-30 at 15:46 +0200, Cyril Brulebois wrote: [...] > I find it hard to decided what to do with these patches, given the amount of > options that can be passed to the kernel… The current behaviour is clearly not > good but I'm not sure what can/could break as a result… Please go

Bug#853855: di-utils: Kernel boot options containing a dot are not propagated to the installed system

2017-03-30 Thread Cyril Brulebois
Hi, Philip Hands (2017-03-20): > Philip Hands writes: > > ... > > whereas this is it succeeding: > > > > http://78.137.97.249:8080/job/lvc_debian-miniiso/337/console > > It seems that I should have waited for that to completely finish before > firing of the

Bug#853855: di-utils: Kernel boot options containing a dot are not propagated to the installed system

2017-03-21 Thread Philip Hands
BTW the jenkins tests have now been duplicated on the proper jenkins.debian.net setup. The successful run using the pu/bug-853855 branches of di-utils and rootskel is here: https://jenkins.debian.net/job/lvc_debian-miniiso/355/console and the same test failing with the current daily build is

Bug#853855: di-utils: Kernel boot options containing a dot are not propagated to the installed system

2017-03-20 Thread Philip Hands
Philip Hands writes: ... > whereas this is it succeeding: > > http://78.137.97.249:8080/job/lvc_debian-miniiso/337/console It seems that I should have waited for that to completely finish before firing of the mail ... that run had a race condition in the test. The test now

Bug#853855: di-utils: Kernel boot options containing a dot are not propagated to the installed system

2017-03-20 Thread Philip Hands
Samuel Thibault writes: > Hello, > > Philip Hands, on ven. 24 févr. 2017 11:10:55 +0100, wrote: >> I think these changes should do the trick: >> >> https://anonscm.debian.org/cgit/d-i/rootskel.git/log/?h=pu/bug-853855 >> >>

Bug#853855: di-utils: Kernel boot options containing a dot are not propagated to the installed system

2017-03-19 Thread Samuel Thibault
Hello, Philip Hands, on ven. 24 févr. 2017 11:10:55 +0100, wrote: > I think these changes should do the trick: > > https://anonscm.debian.org/cgit/d-i/rootskel.git/log/?h=pu/bug-853855 > > https://anonscm.debian.org/cgit/d-i/debian-installer-utils.git/log/?h=pu/bug-853855 > > rootskel: I

Bug#853855: di-utils: Kernel boot options containing a dot are not propagated to the installed system

2017-02-26 Thread Samuel Thibault
Philip Hands, on ven. 24 févr. 2017 11:10:55 +0100, wrote: > I think these changes should do the trick: They look good to me. Samuel

Bug#853855: di-utils: Kernel boot options containing a dot are not propagated to the installed system

2017-02-24 Thread Ben Hutchings
On Fri, 2017-02-24 at 11:10 +0100, Philip Hands wrote: > > Samuel Thibault writes: > > > Hello, > > > > Philip Hands, on lun. 13 févr. 2017 11:16:19 +0100, wrote: > > > Ben Hutchings writes: > > > > On Sun, 2017-02-12 at 12:26 +0100, Samuel Thibault

Bug#853855: di-utils: Kernel boot options containing a dot are not propagated to the installed system

2017-02-24 Thread Philip Hands
Samuel Thibault writes: > Hello, > > Philip Hands, on lun. 13 févr. 2017 11:16:19 +0100, wrote: >> Ben Hutchings writes: >> > On Sun, 2017-02-12 at 12:26 +0100, Samuel Thibault wrote: >> >> Just wondering: can't we just always do both?  I.e. remove

Bug#853855: di-utils: Kernel boot options containing a dot are not propagated to the installed system

2017-02-22 Thread Samuel Thibault
Hello, Philip Hands, on lun. 13 févr. 2017 11:16:19 +0100, wrote: > Ben Hutchings writes: > > On Sun, 2017-02-12 at 12:26 +0100, Samuel Thibault wrote: > >> Just wondering: can't we just always do both?  I.e. remove the varnodot > >> check.  Sure that's ugly because then we

Bug#853855: di-utils: Kernel boot options containing a dot are not propagated to the installed system

2017-02-13 Thread Philip Hands
Ben Hutchings writes: > On Sun, 2017-02-12 at 12:26 +0100, Samuel Thibault wrote: >> Hello, >> >> Emmanuel Kasper, on Fri 03 Feb 2017 13:13:32 +0100, wrote: >> > good catch >> > >> > virt-cat -a testing.build/testing.raw /etc/modprobe.d/local.conf >> > >> > # Local

Bug#853855: di-utils: Kernel boot options containing a dot are not propagated to the installed system

2017-02-12 Thread Ben Hutchings
On Sun, 2017-02-12 at 12:26 +0100, Samuel Thibault wrote: > Hello, > > Emmanuel Kasper, on Fri 03 Feb 2017 13:13:32 +0100, wrote: > > good catch > > > > virt-cat -a testing.build/testing.raw /etc/modprobe.d/local.conf > > > > # Local module settings > > # Created by the Debian installer > > >

Bug#853855: di-utils: Kernel boot options containing a dot are not propagated to the installed system

2017-02-12 Thread Samuel Thibault
Hello, Emmanuel Kasper, on Fri 03 Feb 2017 13:13:32 +0100, wrote: > good catch > > virt-cat -a testing.build/testing.raw /etc/modprobe.d/local.conf > > # Local module settings > # Created by the Debian installer > > options net ifnames=0 Ok... So to sum it up, there are options passed on the

Bug#853855: di-utils: Kernel boot options containing a dot are not propagated to the installed system

2017-02-03 Thread Emmanuel Kasper
Le 03/02/2017 à 12:38, Ian Campbell a écrit : > On Fri, 2017-02-03 at 12:22 +0100, Emmanuel Kasper wrote: A kernel boot param like net.ifnames=0 will be skipped when the installer parses the boot option for setting the bootloader. Found in di-utils: #

Bug#853855: di-utils: Kernel boot options containing a dot are not propagated to the installed system

2017-02-03 Thread Ian Campbell
On Fri, 2017-02-03 at 12:22 +0100, Emmanuel Kasper wrote: > > > A kernel boot param like net.ifnames=0 will be skipped when the > > > installer parses the boot option for setting the bootloader. > > > > > > Found in di-utils:  > > > > > > # Skip module-specific variables > > >    

Bug#853855: di-utils: Kernel boot options containing a dot are not propagated to the installed system

2017-02-03 Thread Emmanuel Kasper
>> A kernel boot param like net.ifnames=0 will be skipped when the >> installer parses the boot option for setting the bootloader. >> >> Found in di-utils: >> >> # Skip module-specific variables >> varnodot="${var##*.*}" >> if [ "$varnodot" = "" ];

Bug#853855: di-utils: Kernel boot options containing a dot are not propagated to the installed system

2017-02-02 Thread Ian Campbell
On Wed, 2017-02-01 at 15:30 +0100, Emmanuel Kasper wrote: > Package: di-utils > Version: 1.117 > Severity: minor > Tags: d-i > > A kernel boot param like net.ifnames=0 will be skipped when the > installer parses the boot option for setting the bootloader. > > Found in di-utils:  > >

Bug#853855: di-utils: Kernel boot options containing a dot are not propagated to the installed system

2017-02-02 Thread Samuel Thibault
Hello, Cyril Brulebois, on Thu 02 Feb 2017 17:09:01 +0100, wrote: > Emmanuel Kasper (2017-02-01): > > A kernel boot param like net.ifnames=0 will be skipped when the > > installer parses the boot option for setting the bootloader. > > > > Found in di-utils: > > > >

Bug#853855: di-utils: Kernel boot options containing a dot are not propagated to the installed system

2017-02-02 Thread Cyril Brulebois
Control: severity -1 normal Control: tag -1 - d-i Hi, Emmanuel Kasper (2017-02-01): > A kernel boot param like net.ifnames=0 will be skipped when the > installer parses the boot option for setting the bootloader. > > Found in di-utils: > > # Skip

Bug#853855: di-utils: Kernel boot options containing a dot are not propagated to the installed system

2017-02-01 Thread Emmanuel Kasper
Package: di-utils Version: 1.117 Severity: minor Tags: d-i A kernel boot param like net.ifnames=0 will be skipped when the installer parses the boot option for setting the bootloader. Found in di-utils: # Skip module-specific variables varnodot="${var##*.*}"