forwarded 891867
https://salsa.debian.org/reproducible-builds/diffoscope/issues/30
thanks
I've forwarded this upstream here:
https://salsa.debian.org/reproducible-builds/diffoscope/issues/30
Regards,
--
,''`.
: :' : Chris Lamb
`. `'` la...@debian.org /
Helmut Grohne wrote:
> > Why not .strip() them all instead, out of interest?
>
> Feel free to do so. I just felt that changing the type from str to
> List(str) would be non-trivial
(.strip() has a prototype of "str" → "str" so I am confused about all these
references to "[str]".)
Regards,
--
Mattia Rizzolo wrote:
> > > +other.deb822.get_as_string('Checksums-Sha256') + "\n",
> >
> > Why not .strip() them all instead, out of interest?
>
> Because deb822.get_as_string() returns a single string containing all of
> 'Checksums-Sha256' (in this case) with the \n embedded
Control: tags -1 - patch
On Thu, Mar 01, 2018 at 09:00:27PM +, Chris Lamb wrote:
> Why not .strip() them all instead, out of interest?
Feel free to do so. I just felt that changing the type from str to
List(str) would be non-trivial and I couldn't immediately figure out
whether that works as
On Thu, Mar 01, 2018 at 09:00:27PM +, Chris Lamb wrote:
> > differences.append(Difference.from_text(
> > -self.deb822.get_as_string('Checksums-Sha256'),
> > -other.deb822.get_as_string('Checksums-Sha256'),
> > +
Hi Helmut!
Thanks for the report with patch :)
> --- a/diffoscope/comparators/debian.py
> +++ b/diffoscope/comparators/debian.py
> @@ -142,16 +142,16 @@
> # Compare Files as string
> if self.deb822.get('Files'):
> differences.append(Difference.from_text(
> -
Package: diffoscope
Version: 91
Severity: wishlist
Tags: patch
Hi awesome reproducible team!
I'm working on adding more build profiles and diffoscope + reproducible
builds turn out to be an awesome tool in validating that my profiles
only drop packages and never change package contents. :)
Now
7 matches
Mail list logo
