Bug#920345: [Pkg-freeradius-maintainers] Bug#920345: freeradius: running freeradius with debug(-X) option breaks systemd unit

2019-01-25 Thread Mariusz Gronczewski
Now that I looked, while current 3.x stable still uses forking, they have added support for Type=notify in current development ( https://github.com/FreeRADIUS/freeradius-server/blob/master/debian/freeradius.service ) of daemon itself so that should solve it. On Fri, 25 Jan 2019 at 14:31, Mariusz

Bug#920345: [Pkg-freeradius-maintainers] Bug#920345: freeradius: running freeradius with debug(-X) option breaks systemd unit

2019-01-25 Thread Mariusz Gronczewski
Okay, I will just poke the upstream about it, seems that CentOS/RHEL package have exactly same problem so no point changing it just for Debian. On Thu, 24 Jan 2019 at 18:27, Michael Stapelberg wrote: > > Ah, why didn’t you open with that suggestion? :) > >

Bug#920345: [Pkg-freeradius-maintainers] Bug#920345: freeradius: running freeradius with debug(-X) option breaks systemd unit

2019-01-25 Thread Michael Stapelberg
Great, thank you for taking care of this! On Fri, Jan 25, 2019 at 2:32 PM Mariusz Gronczewski wrote: > Okay, I will just poke the upstream about it, seems that CentOS/RHEL > package have exactly same problem so no point changing it just for > Debian. > > > On Thu, 24 Jan 2019 at 18:27, Michael

Bug#920345: [Pkg-freeradius-maintainers] Bug#920345: freeradius: running freeradius with debug(-X) option breaks systemd unit

2019-01-24 Thread Michael Stapelberg
Ah, why didn’t you open with that suggestion? :) https://manpages.debian.org/stretch/systemd/systemd.service.5.en.html#OPTIONS outlines that switching to Type=simple (which is the consequence of your -f suggestion) means we won’t have start-up failure propagation anymore, and reverse-dependencies

Bug#920345: [Pkg-freeradius-maintainers] Bug#920345: freeradius: running freeradius with debug(-X) option breaks systemd unit

2019-01-24 Thread Mariusz Gronczewski
Well, there is, adding -f option by default means it will always run in foreground, regardless of whether -X is used or not On Thu, 24 Jan 2019 at 15:58, Michael Stapelberg wrote: > > The -X option is special in that it changes the way freeradius starts up. > > It’s expected that if your actions

Bug#920345: [Pkg-freeradius-maintainers] Bug#920345: freeradius: running freeradius with debug(-X) option breaks systemd unit

2019-01-24 Thread Michael Stapelberg
The -X option is special in that it changes the way freeradius starts up. It’s expected that if your actions break the contract with the init system (in this case by specifying -X), you’re responsible to rectify that. If there was a simple way to make the package work in any/all cases, it’d be

Bug#920345: [Pkg-freeradius-maintainers] Bug#920345: freeradius: running freeradius with debug(-X) option breaks systemd unit

2019-01-24 Thread Mariusz Gronczewski
In our case it was enough to add dropin changing execstart to include -f and type to simple: ExecStart=/usr/sbin/freeradius -f $FREERADIUS_OPTIONS Type=simple What do you mean by "it is expected" ? Currently enabling debug (by setting FREERADIUS_OPTIONS="-X") cause it to enter restart loop,

Bug#920345: [Pkg-freeradius-maintainers] Bug#920345: freeradius: running freeradius with debug(-X) option breaks systemd unit

2019-01-24 Thread Michael Stapelberg
Yes, this is expected. What change are you suggesting? On Thu, Jan 24, 2019 at 1:45 PM Mariusz Gronczewski wrote: > Package: freeradius > Version: 3.0.12+dfsg-5+deb9u1 > Severity: normal > > Currently the type of systemd service is forking. > > Adding debug to cmdline causes freeradius to run