Package: release.debian.org Severity: normal Tags: bookworm User: release.debian....@packages.debian.org Usertags: pu
[ Reason ] This is a regression relative to old stable on something that is critical for a subset of postfix users. Apparently, when I was updating the package from postfix 3.6 to 3.7 I "temporarily" removed these patches and then forgot to add them back in "later". See #1040329. I guess "now" is "later". [ Impact ] For most users, no impact, but for the subset of users that need to be able to run postfix set-permissions, the package is unusable. [ Tests ] I did test this manually and also modified the autopkgtest to fail if set-permissions fail to catch this in the future. [ Risks ] Risk is trivial. This doesn't affect anyone who doesn't run set-permissions and for those that do, the package is already broken. For them, there's no real alternative. [ Checklist ] [X] *all* changes are documented in the d/changelog [X] I reviewed all changes and I approve them [*] attach debdiff against the package in (old)stable [*] the issue is verified as fixed in unstable [ Changes ] Updated and added back in the patches that update the files that set-permissions looks for to match what Debian installs. Updated the autopkgtest [ Other info ] There is already a stable-update pending, so the debdiff is relative to that (and there's no overlap between it and this change). Unstable is not fixed yet. Given the nearness of the point release and the impact on stable users, I opted to git it sorted in stable first. I will have it uploaded to Unstable shortly.
diff -Nru postfix-3.7.6/debian/changelog postfix-3.7.6/debian/changelog --- postfix-3.7.6/debian/changelog 2023-06-17 13:34:11.000000000 -0400 +++ postfix-3.7.6/debian/changelog 2023-07-05 17:18:24.000000000 -0400 @@ -1,3 +1,13 @@ +postfix (3.7.6-0+deb12u2) bookworm; urgency=medium + + * Correct regression that caused postfix set-permissions to fail (Closes: + #1040329) + - Restore and update debian/patches/05_debian_manpage_differences.diff + - Restore and update debian/patches/05_debian_readme_differences.diff + * Update autopkgtest to test postfix set-permissions + + -- Scott Kitterman <sc...@kitterman.com> Wed, 05 Jul 2023 17:18:24 -0400 + postfix (3.7.6-0+deb12u1) bookworm; urgency=medium [Scott Kitterman] diff -Nru postfix-3.7.6/debian/patches/05_debian_manpage_differences.diff postfix-3.7.6/debian/patches/05_debian_manpage_differences.diff --- postfix-3.7.6/debian/patches/05_debian_manpage_differences.diff 1969-12-31 19:00:00.000000000 -0500 +++ postfix-3.7.6/debian/patches/05_debian_manpage_differences.diff 2023-07-05 16:51:05.000000000 -0400 @@ -0,0 +1,159 @@ +Index: postfix-dev/conf/postfix-files +=================================================================== +--- postfix-dev.orig/conf/postfix-files 2019-03-01 11:07:21.045697994 -0500 ++++ postfix-dev/conf/postfix-files 2019-03-01 11:17:55.721711534 -0500 +@@ -166,79 +166,81 @@ + #$config_directory/postfix-script-sgid:f:root:-:755:o + #$config_directory/postfix-script-nosgid:f:root:-:755:o + $config_directory/post-install:f:root:-:755:o +-$manpage_directory/man1/mailq.1:f:root:-:644 +-$manpage_directory/man1/newaliases.1:f:root:-:644 +-$manpage_directory/man1/postalias.1:f:root:-:644 +-$manpage_directory/man1/postcat.1:f:root:-:644 +-$manpage_directory/man1/postconf.1:f:root:-:644 +-$manpage_directory/man1/postdrop.1:f:root:-:644 +-$manpage_directory/man1/postfix-tls.1:f:root:-:644 +-$manpage_directory/man1/postfix.1:f:root:-:644 +-$manpage_directory/man1/postkick.1:f:root:-:644 +-$manpage_directory/man1/postlock.1:f:root:-:644 +-$manpage_directory/man1/postlog.1:f:root:-:644 +-$manpage_directory/man1/postmap.1:f:root:-:644 +-$manpage_directory/man1/postmulti.1:f:root:-:644 +-$manpage_directory/man1/postqueue.1:f:root:-:644 +-$manpage_directory/man1/postsuper.1:f:root:-:644 +-$manpage_directory/man1/sendmail.1:f:root:-:644 +-$manpage_directory/man5/access.5:f:root:-:644 +-$manpage_directory/man5/aliases.5:f:root:-:644 +-$manpage_directory/man5/body_checks.5:f:root:-:644 +-$manpage_directory/man5/bounce.5:f:root:-:644 +-$manpage_directory/man5/canonical.5:f:root:-:644 +-$manpage_directory/man5/cidr_table.5:f:root:-:644 +-$manpage_directory/man5/generics.5:f:root:-:644:o +-$manpage_directory/man5/generic.5:f:root:-:644 +-$manpage_directory/man5/header_checks.5:f:root:-:644 +-$manpage_directory/man5/ldap_table.5:f:root:-:644 +-$manpage_directory/man5/lmdb_table.5:f:root:-:644 +-$manpage_directory/man5/master.5:f:root:-:644 +-$manpage_directory/man5/memcache_table.5:f:root:-:644 +-$manpage_directory/man5/mysql_table.5:f:root:-:644 +-$manpage_directory/man5/socketmap_table.5:f:root:-:644 +-$manpage_directory/man5/sqlite_table.5:f:root:-:644 +-$manpage_directory/man5/nisplus_table.5:f:root:-:644 +-$manpage_directory/man5/pcre_table.5:f:root:-:644 +-$manpage_directory/man5/pgsql_table.5:f:root:-:644 +-$manpage_directory/man5/postconf.5:f:root:-:644 +-$manpage_directory/man5/postfix-wrapper.5:f:root:-:644 +-$manpage_directory/man5/regexp_table.5:f:root:-:644 +-$manpage_directory/man5/relocated.5:f:root:-:644 +-$manpage_directory/man5/tcp_table.5:f:root:-:644 +-$manpage_directory/man5/transport.5:f:root:-:644 +-$manpage_directory/man5/virtual.5:f:root:-:644 +-$manpage_directory/man8/bounce.8:f:root:-:644 +-$manpage_directory/man8/cleanup.8:f:root:-:644 +-$manpage_directory/man8/anvil.8:f:root:-:644 +-$manpage_directory/man8/defer.8:f:root:-:644 +-$manpage_directory/man8/discard.8:f:root:-:644 +-$manpage_directory/man8/dnsblog.8:f:root:-:644 +-$manpage_directory/man8/error.8:f:root:-:644 +-$manpage_directory/man8/flush.8:f:root:-:644 +-$manpage_directory/man8/lmtp.8:f:root:-:644 +-$manpage_directory/man8/local.8:f:root:-:644 +-$manpage_directory/man8/master.8:f:root:-:644 +-$manpage_directory/man8/nqmgr.8:f:root:-:644:o +-$manpage_directory/man8/oqmgr.8:f:root:-:644: +-$manpage_directory/man8/pickup.8:f:root:-:644 +-$manpage_directory/man8/pipe.8:f:root:-:644 +-$manpage_directory/man8/postlogd.8:f:root:-:644 +-$manpage_directory/man8/postscreen.8:f:root:-:644 +-$manpage_directory/man8/proxymap.8:f:root:-:644 +-$manpage_directory/man8/qmgr.8:f:root:-:644 +-$manpage_directory/man8/qmqpd.8:f:root:-:644 +-$manpage_directory/man8/scache.8:f:root:-:644 +-$manpage_directory/man8/showq.8:f:root:-:644 +-$manpage_directory/man8/smtp.8:f:root:-:644 +-$manpage_directory/man8/smtpd.8:f:root:-:644 +-$manpage_directory/man8/spawn.8:f:root:-:644 +-$manpage_directory/man8/tlsproxy.8:f:root:-:644 +-$manpage_directory/man8/tlsmgr.8:f:root:-:644 +-$manpage_directory/man8/trace.8:f:root:-:644 +-$manpage_directory/man8/trivial-rewrite.8:f:root:-:644 +-$manpage_directory/man8/verify.8:f:root:-:644 +-$manpage_directory/man8/virtual.8:f:root:-:644 ++$manpage_directory/man1/mailq.1.gz:f:root:-:644 ++$manpage_directory/man1/newaliases.1.gz:f:root:-:644 ++$manpage_directory/man1/postalias.1.gz:f:root:-:644 ++$manpage_directory/man1/postcat.1.gz:f:root:-:644 ++$manpage_directory/man1/postconf.1.gz:f:root:-:644 ++$manpage_directory/man1/postdrop.1.gz:f:root:-:644 ++$manpage_directory/man1/postfix-tls.1.gz:f:root:-:644 ++$manpage_directory/man1/postfix.1.gz:f:root:-:644 ++$manpage_directory/man1/postkick.1.gz:f:root:-:644 ++$manpage_directory/man1/postlock.1.gz:f:root:-:644 ++$manpage_directory/man1/postlog.1.gz:f:root:-:644 ++$manpage_directory/man1/postmap.1.gz:f:root:-:644 ++$manpage_directory/man1/postmulti.1.gz:f:root:-:644 ++$manpage_directory/man1/postqueue.1.gz:f:root:-:644 ++$manpage_directory/man1/postsuper.1.gz:f:root:-:644 ++$manpage_directory/man1/sendmail.1.gz:f:root:-:644 ++$manpage_directory/man5/access.5.gz:f:root:-:644 ++$manpage_directory/man5/aliases.5.gz:f:root:-:644 ++$manpage_directory/man5/body_checks.5.gz:f:root:-:644 ++$manpage_directory/man5/bounce.5.gz:f:root:-:644 ++$manpage_directory/man5/canonical.5.gz:f:root:-:644 ++$manpage_directory/man5/cidr_table.5.gz:f:root:-:644 ++$manpage_directory/man5/generics.5.gz:f:root:-:644:o ++$manpage_directory/man5/generic.5.gz:f:root:-:644 ++$manpage_directory/man5/header_checks.5.gz:f:root:-:644 ++$manpage_directory/man5/ldap_table.5.gz:f:root:-:644 ++$manpage_directory/man5/lmdb_table.5.gz:f:root:-:644 ++$manpage_directory/man5/master.5.gz:f:root:-:644 ++$manpage_directory/man5/memcache_table.5.gz:f:root:-:644 ++$manpage_directory/man5/mysql_table.5.gz:f:root:-:644 ++$manpage_directory/man5/socketmap_table.5.gz:f:root:-:644 ++$manpage_directory/man5/sqlite_table.5.gz:f:root:-:644 ++$manpage_directory/man5/nisplus_table.5.gz:f:root:-:644 ++$manpage_directory/man5/pcre_table.5.gz:f:root:-:644 ++$manpage_directory/man5/pgsql_table.5.gz:f:root:-:644 ++$manpage_directory/man5/postconf.5.gz:f:root:-:644 ++$manpage_directory/man5/postfix-wrapper.5.gz:f:root:-:644 ++$manpage_directory/man5/regexp_table.5.gz:f:root:-:644 ++$manpage_directory/man5/relocated.5.gz:f:root:-:644 ++$manpage_directory/man5/tcp_table.5.gz:f:root:-:644 ++$manpage_directory/man5/transport.5.gz:f:root:-:644 ++$manpage_directory/man5/virtual.5.gz:f:root:-:644 ++$manpage_directory/man8/bounce.8postfix.gz:f:root:-:644 ++$manpage_directory/man8/cleanup.8postfix.gz:f:root:-:644 ++$manpage_directory/man8/anvil.8postfix.gz:f:root:-:644 ++$manpage_directory/man8/defer.8postfix.gz:f:root:-:644 ++$manpage_directory/man8/discard.8postfix.gz:f:root:-:644 ++$manpage_directory/man8/dnsblog.8postfix.gz:f:root:-:644 ++$manpage_directory/man8/error.8postfix.gz:f:root:-:644 ++$manpage_directory/man8/flush.8postfix.gz:f:root:-:644 ++$manpage_directory/man8/lmtp.8postfix.gz:f:root:-:644 ++$manpage_directory/man8/local.8postfix.gz:f:root:-:644 ++$manpage_directory/man8/master.8postfix.gz:f:root:-:644 ++$manpage_directory/man8/nqmgr.8postfix.gz:f:root:-:644:o ++$manpage_directory/man8/oqmgr.8postfix.gz:f:root:-:644: ++$manpage_directory/man8/pickup.8postfix.gz:f:root:-:644 ++$manpage_directory/man8/pipe.8postfix.gz:f:root:-:644 ++$manpage_directory/man8/postlogd.8postfix.gz:f:root:-:644 ++$manpage_directory/man8/postfix-add-filter.8.gz:f:root:-:644 ++$manpage_directory/man8/postfix-add-policy.8.gz:f:root:-:644 ++$manpage_directory/man8/postscreen.8postfix.gz:f:root:-:644 ++$manpage_directory/man8/proxymap.8postfix.gz:f:root:-:644 ++$manpage_directory/man8/qmgr.8postfix.gz:f:root:-:644 ++$manpage_directory/man8/qmqpd.8postfix.gz:f:root:-:644 ++$manpage_directory/man8/scache.8postfix.gz:f:root:-:644 ++$manpage_directory/man8/showq.8postfix.gz:f:root:-:644 ++$manpage_directory/man8/smtp.8postfix.gz:f:root:-:644 ++$manpage_directory/man8/smtpd.8postfix.gz:f:root:-:644 ++$manpage_directory/man8/spawn.8postfix.gz:f:root:-:644 ++$manpage_directory/man8/tlsproxy.8postfix.gz:f:root:-:644 ++$manpage_directory/man8/tlsmgr.8postfix.gz:f:root:-:644 ++$manpage_directory/man8/trace.8postfix.gz:f:root:-:644 ++$manpage_directory/man8/trivial-rewrite.8postfix.gz:f:root:-:644 ++$manpage_directory/man8/verify.8postfix.gz:f:root:-:644 ++$manpage_directory/man8/virtual.8postfix.gz:f:root:-:644 + $sample_directory/sample-aliases.cf:f:root:-:644:o + $sample_directory/sample-auth.cf:f:root:-:644:o + $sample_directory/sample-canonical.cf:f:root:-:644:o diff -Nru postfix-3.7.6/debian/patches/05_debian_readme_differences.diff postfix-3.7.6/debian/patches/05_debian_readme_differences.diff --- postfix-3.7.6/debian/patches/05_debian_readme_differences.diff 1969-12-31 19:00:00.000000000 -0500 +++ postfix-3.7.6/debian/patches/05_debian_readme_differences.diff 2023-07-05 16:53:16.000000000 -0400 @@ -0,0 +1,124 @@ +Index: postfix/conf/postfix-files +=================================================================== +--- postfix.orig/conf/postfix-files ++++ postfix/conf/postfix-files +@@ -273,69 +273,68 @@ $sample_directory/sample-tls.cf:f:root:- + $sample_directory/sample-transport.cf:f:root:-:644:o + $sample_directory/sample-verify.cf:f:root:-:644:o + $sample_directory/sample-virtual.cf:f:root:-:644:o +-$readme_directory/AAAREADME:f:root:-:644 +-$readme_directory/ADDRESS_CLASS_README:f:root:-:644 +-$readme_directory/ADDRESS_REWRITING_README:f:root:-:644 +-$readme_directory/ADDRESS_VERIFICATION_README:f:root:-:644 +-$readme_directory/BACKSCATTER_README:f:root:-:644 +-$readme_directory/BASIC_CONFIGURATION_README:f:root:-:644 +-$readme_directory/BDAT_README:f:root:-:644 +-$readme_directory/BUILTIN_FILTER_README:f:root:-:644 ++$readme_directory/README.gz:f:root:-:644 ++$readme_directory/ADDRESS_CLASS_README.gz:f:root:-:644 ++$readme_directory/ADDRESS_REWRITING_README.gz:f:root:-:644 ++$readme_directory/ADDRESS_VERIFICATION_README.gz:f:root:-:644 ++$readme_directory/BACKSCATTER_README.gz:f:root:-:644 ++$readme_directory/BASIC_CONFIGURATION_README.gz:f:root:-:644 ++$readme_directory/BUILTIN_FILTER_README.gz:f:root:-:644 + $readme_directory/CDB_README:f:root:-:644 +-$readme_directory/COMPATIBILITY_README:f:root:-:644 +-$readme_directory/CONNECTION_CACHE_README:f:root:-:644 ++$readme_directory/COMPATIBILITY_README.gz:f:root:-:644 ++$readme_directory/CONNECTION_CACHE_README.gz:f:root:-:644 + $readme_directory/CONTENT_INSPECTION_README:f:root:-:644 +-$readme_directory/DATABASE_README:f:root:-:644 +-$readme_directory/DB_README:f:root:-:644 +-$readme_directory/DEBUG_README:f:root:-:644 +-$readme_directory/DSN_README:f:root:-:644 +-$readme_directory/ETRN_README:f:root:-:644 +-$readme_directory/FILTER_README:f:root:-:644 +-$readme_directory/FORWARD_SECRECY_README:f:root:-:644 +-$readme_directory/HOSTING_README:f:root:-:644:o +-$readme_directory/INSTALL:f:root:-:644 +-$readme_directory/IPV6_README:f:root:-:644 +-$readme_directory/LDAP_README:f:root:-:644 ++$readme_directory/DATABASE_README.gz:f:root:-:644 ++$readme_directory/DB_README.gz:f:root:-:644 ++$readme_directory/DEBUG_README.gz:f:root:-:644 ++$readme_directory/DSN_README.gz:f:root:-:644 ++$readme_directory/ETRN_README.gz:f:root:-:644 ++$readme_directory/FILTER_README.gz:f:root:-:644 ++$readme_directory/FORWARD_SECRECY_README.gz:f:root:-:644 ++#$readme_directory/HOSTING_README:f:root:-:644:o ++#$readme_directory/INSTALL:f:root:-:644 ++$readme_directory/IPV6_README.gz:f:root:-:644 ++$readme_directory/LDAP_README.gz:f:root:-:644 + $readme_directory/LINUX_README:f:root:-:644 +-$readme_directory/LMDB_README:f:root:-:644 +-$readme_directory/LOCAL_RECIPIENT_README:f:root:-:644 ++$readme_directory/LMDB_README.gz:f:root:-:644 ++$readme_directory/LOCAL_RECIPIENT_README.gz:f:root:-:644 + $readme_directory/MACOSX_README:f:root:-:644:o +-$readme_directory/MAILDROP_README:f:root:-:644 ++$readme_directory/MAILDROP_README.gz:f:root:-:644 + $readme_directory/MAILLOG_README:f:root:-:644 + $readme_directory/MEMCACHE_README:f:root:-:644 +-$readme_directory/MILTER_README:f:root:-:644 +-$readme_directory/MULTI_INSTANCE_README:f:root:-:644 +-$readme_directory/MYSQL_README:f:root:-:644 ++$readme_directory/MILTER_README.gz:f:root:-:644 ++$readme_directory/MULTI_INSTANCE_README.gz:f:root:-:644 ++$readme_directory/MYSQL_README.gz:f:root:-:644 + $readme_directory/SMTPUTF8_README:f:root:-:644 + $readme_directory/SQLITE_README:f:root:-:644 +-$readme_directory/NFS_README:f:root:-:644 +-$readme_directory/OVERVIEW:f:root:-:644 +-$readme_directory/PACKAGE_README:f:root:-:644 ++$readme_directory/NFS_README.gz:f:root:-:644 ++$readme_directory/OVERVIEW.gz:f:root:-:644 ++$readme_directory/PACKAGE_README.gz:f:root:-:64 + $readme_directory/PCRE_README:f:root:-:644 +-$readme_directory/PGSQL_README:f:root:-:644 ++$readme_directory/PGSQL_README.gz:f:root:-:644 + $readme_directory/POSTSCREEN_3_5_README:f:root:-:644 +-$readme_directory/POSTSCREEN_README:f:root:-:644 ++$readme_directory/POSTSCREEN_README.gz:f:root:-:644 + $readme_directory/QMQP_README:f:root:-:644:o +-$readme_directory/QSHAPE_README:f:root:-:644 +-$readme_directory/RELEASE_NOTES:f:root:-:644 +-$readme_directory/RESTRICTION_CLASS_README:f:root:-:644 +-$readme_directory/SASL_README:f:root:-:644 +-$readme_directory/SCHEDULER_README:f:root:-:644 +-$readme_directory/SMTPD_ACCESS_README:f:root:-:644 +-$readme_directory/SMTPD_POLICY_README:f:root:-:644 +-$readme_directory/SMTPD_PROXY_README:f:root:-:644 +-$readme_directory/SOHO_README:f:root:-:644 +-$readme_directory/STANDARD_CONFIGURATION_README:f:root:-:644 +-$readme_directory/STRESS_README:f:root:-:644 +-$readme_directory/TLS_LEGACY_README:f:root:-:644 +-$readme_directory/TLS_README:f:root:-:644 +-$readme_directory/TUNING_README:f:root:-:644 ++$readme_directory/QSHAPE_README.gz:f:root:-:644 ++$readme_directory/RELEASE_NOTES.gz:f:root:-:644 ++$readme_directory/RESTRICTION_CLASS_README.gz:f:root:-:644 ++$readme_directory/SASL_README.gz:f:root:-:644 ++$readme_directory/SCHEDULER_README.gz:f:root:-:644 ++$readme_directory/SMTPD_ACCESS_README.gz:f:root:-:644 ++$readme_directory/SMTPD_POLICY_README.gz:f:root:-:644 ++$readme_directory/SMTPD_PROXY_README.gz:f:root:-:644 ++$readme_directory/SOHO_README.gz:f:root:-:644 ++$readme_directory/STANDARD_CONFIGURATION_README.gz:f:root:-:644 ++$readme_directory/STRESS_README.gz:f:root:-:644 ++$readme_directory/TLS_LEGACY_README.gz:f:root:-:644 ++$readme_directory/TLS_README.gz:f:root:-:644 ++$readme_directory/TUNING_README.gz:f:root:-:644 + $readme_directory/ULTRIX_README:f:root:-:644 +-$readme_directory/UUCP_README:f:root:-:644 +-$readme_directory/VERP_README:f:root:-:644 +-$readme_directory/VIRTUAL_README:f:root:-:644 +-$readme_directory/XCLIENT_README:f:root:-:644 +-$readme_directory/XFORWARD_README:f:root:-:644 ++$readme_directory/UUCP_README.gz:f:root:-:644 ++$readme_directory/VERP_README.gz:f:root:-:644 ++$readme_directory/VIRTUAL_README.gz:f:root:-:644 ++$readme_directory/XCLIENT_README.gz:f:root:-:644 ++$readme_directory/XFORWARD_README.gz:f:root:-:644 + $html_directory/ADDRESS_CLASS_README.html:f:root:-:644 + $html_directory/ADDRESS_REWRITING_README.html:f:root:-:644 + $html_directory/ADDRESS_VERIFICATION_README.html:f:root:-:644 diff -Nru postfix-3.7.6/debian/patches/series postfix-3.7.6/debian/patches/series --- postfix-3.7.6/debian/patches/series 2023-06-17 13:34:07.000000000 -0400 +++ postfix-3.7.6/debian/patches/series 2023-07-05 16:54:52.000000000 -0400 @@ -2,6 +2,8 @@ 03_ldap3_by_default.diff 04_remove_gdbm_support.diff 05_debian_defaults.diff +05_debian_manpage_differences.diff +05_debian_readme_differences.diff 06_debian_paths.diff 07_sasl_config.diff 10_openssl_version_check.diff diff -Nru postfix-3.7.6/debian/tests/postfix postfix-3.7.6/debian/tests/postfix --- postfix-3.7.6/debian/tests/postfix 2023-06-06 11:40:28.000000000 -0400 +++ postfix-3.7.6/debian/tests/postfix 2023-07-05 17:17:01.000000000 -0400 @@ -14,3 +14,6 @@ hostname --fqdn > /etc/mailname service postfix restart 2>&1 python3 `dirname $0`/test-postfix.py 2>&1 + +# Check set-permissions +postfix set-permissions
