Bug#895864: leptonlib: needs config.guess/sub update for riscv64

[Manuel A. Fernandez Montecelo]

2018-04-24 1:59 GMT+02:00 Jeff Breidenbach :
> Okay, uploading now. Thanks for all the help!

You're welcome.

Thanks for applying!

-- 
Manuel A. Fernandez Montecelo 

Bug#895864: leptonlib: needs config.guess/sub update for riscv64

[Jeff Breidenbach]

Okay, uploading now. Thanks for all the help!

On Mon, Apr 23, 2018 at 4:06 PM, Manuel A. Fernandez Montecelo <
manuel.montez...@gmail.com> wrote:

> 2018-04-23 23:22 GMT+02:00 Manuel A. Fernandez Montecelo
> :
> >
> > This additionally runs the tests,
> > can be disabled with another override_dh_auto_test and leaving it
> > empty, but I recommend to enable them.
>
> The tests built in riscv64 successfully:
>
> 
> 
> Testsuite summary for leptonica 1.75.3
> 
> 
> # TOTAL: 111
> # PASS:  96
> # SKIP:  15
> # XFAIL: 0
> # FAIL:  0
> # XPASS: 0
> # ERROR: 0
> 
> 
>
> And:
> Build needed 00:24:24, 341376k disk space
>
> So IMO it's worth enabling them.
>
>
> Cheers.
> --
> Manuel A. Fernandez Montecelo 
>

Bug#895864: leptonlib: needs config.guess/sub update for riscv64

[Manuel A. Fernandez Montecelo]

2018-04-23 23:22 GMT+02:00 Manuel A. Fernandez Montecelo
:
>
> This additionally runs the tests,
> can be disabled with another override_dh_auto_test and leaving it
> empty, but I recommend to enable them.

The tests built in riscv64 successfully:


Testsuite summary for leptonica 1.75.3

# TOTAL: 111
# PASS:  96
# SKIP:  15
# XFAIL: 0
# FAIL:  0
# XPASS: 0
# ERROR: 0


And:
Build needed 00:24:24, 341376k disk space

So IMO it's worth enabling them.


Cheers.
-- 
Manuel A. Fernandez Montecelo 

Bug#895864: leptonlib: needs config.guess/sub update for riscv64

[Manuel A. Fernandez Montecelo]

Hi,

2018-04-23 21:12 GMT+02:00 Jeff Breidenbach :
> Is it sufficient to put Build-Depends: debhelper (>= 11.0.0) in
> debian/control and 11 in debian/compat ?

Thanks for taking care of this.

You have to un-comment the "dh_autoreconf*" lines in debian/rules too,
not sure why they are disabled, but possibly because they don't work
(there's an error from libtoolize/autoconf).  It seems to need
additionally "pkg-config" in the build-depends, when reconfguring.

To the best of my knowledge, if you were using a rule like the
following one and without the handcrafted rules, I think that it would
be part of the commands invoked by default, but with the handcrafted
rules they take precedence, so the defaults are not invoked.

=
%:
dh $@
=

The rule above covers the defaults of leptonlib quite well, since it's
not using anything contrived, only needs a minor modification for the
manpage.  Things like noopt and nostrip are supposed to be handled
automatically.

I attach 3 files:

1) the minimal conversion so dh-autoreconf works (leptonlib_1.75.3-3.1.debdiff)

2) and 3) the full conversion to simple rules, with
leptonlib_1.75.3-3.2.debdiff and debian/rules attached separate, to
see clearly the benefits.  (Obviously, by the way, the message in
d/changelog should be squashed).  This additionally runs the tests,
can be disabled with another override_dh_auto_test and leaving it
empty, but I recommend to enable them.


I tested 1 and 2/3 and it works fine, both produce binaries in amd64
that don't differ from the previous version (debdiff).


Hope that helps.  If in any doubt, please ask.


Cheers.
-- 
Manuel A. Fernandez Montecelo 


leptonlib_1.75.3-3.1.debdiff
Description: Binary data


leptonlib_1.75.3-3.2.debdiff
Description: Binary data


rules
Description: Binary data

Bug#895864: leptonlib: needs config.guess/sub update for riscv64

[Jeff Breidenbach]

Is it sufficient to put Build-Depends: debhelper (>= 11.0.0) in
debian/control and 11 in debian/compat ?

Bug#895864: leptonlib: needs config.guess/sub update for riscv64

[Manuel A. Fernandez Montecelo]

Source: leptonlib
Version: 1.75.3-3
Severity: normal
User: debian-ri...@lists.debian.org
Usertags: riscv64

Hi,

We are in the process of bootstrapping a Debian port for the riscv64
architecture (https://wiki.debian.org/RISC-V).

The files config.{guess,sub} included in this package are too old to detect this
system.

This package is quite important as it's a dependency of ffmpeg, and thus of all
of its many reverse-dependencies.

Debian Policy §4.3 recommends to update these automatically [1], one of the best
ways to achieve this is to depend on newer versions of debhelper (the current
level used by this package is deprecated) and use dh-autoreconf.

If you need help or want us to provide a patch, prefer that we NMU, etc., please
tell.


[1] https://www.debian.org/doc/debian-policy/#changes-to-the-upstream-sources

"You should make sure that the configure utility detects the correct
architecture specification string (refer to Architecture specification
strings for details).

If your package includes the scripts config.sub and config.guess, you should
arrange for the versions provided by the package autotools-dev be used
instead (see autotools-dev documentation for details how to achieve
that). This ensures that these files can be updated distribution-wide at
build time when introducing new architectures."


Thanks and cheers.
--
Manuel A. Fernandez Montecelo