Your message dated Wed, 28 Jun 2023 00:52:20 +0000
with message-id <e1qejpw-0040ra...@fasolo.debian.org>
and subject line Bug#1039625: fixed in sl-modem 2.9.11~20110321-18
has caused the Debian Bug report #1039625,
regarding sl-modem-dkms: module fails to build for Linux 6.3, 6.4
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
1039625: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1039625
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: sl-modem-dkms
Version: 2.9.11~20110321-17
Severity: serious
User: debian...@lists.debian.org
Usertags: piuparts


1.) There is an autopkgtest regression with the -cloud kernel,
preventing migration to testing (therefore severity serious):

https://ci.debian.net/data/autopkgtest/testing/amd64/s/sl-modem/34615715/log.gz

DKMS make.log for sl-modem-2.9.11~20110321 for kernel 6.1.0-9-cloud-amd64 
(x86_64)
Mon Jun 19 06:58:35 UTC 2023
make: Entering directory '/var/lib/dkms/sl-modem/2.9.11~20110321/build/drivers'
        obj-m= slusb.o 
        slamr-objs=amrmo_init.o sysdep_amr.o amrlibs.o
make modules -C /lib/modules/6.1.0-9-cloud-amd64/build 
M=/var/lib/dkms/sl-modem/2.9.11~20110321/build/drivers
make[1]: Entering directory '/usr/src/linux-headers-6.1.0-9-cloud-amd64'
  CC [M]  /var/lib/dkms/sl-modem/2.9.11~20110321/build/drivers/st7554.o
  LD [M]  /var/lib/dkms/sl-modem/2.9.11~20110321/build/drivers/slusb.o
  MODPOST /var/lib/dkms/sl-modem/2.9.11~20110321/build/drivers/Module.symvers
ERROR: modpost: "usb_alloc_urb" 
[/var/lib/dkms/sl-modem/2.9.11~20110321/build/drivers/slusb.ko] undefined!
ERROR: modpost: "usb_free_urb" 
[/var/lib/dkms/sl-modem/2.9.11~20110321/build/drivers/slusb.ko] undefined!
ERROR: modpost: "usb_register_driver" 
[/var/lib/dkms/sl-modem/2.9.11~20110321/build/drivers/slusb.ko] undefined!
ERROR: modpost: "usb_clear_halt" 
[/var/lib/dkms/sl-modem/2.9.11~20110321/build/drivers/slusb.ko] undefined!
ERROR: modpost: "usb_submit_urb" 
[/var/lib/dkms/sl-modem/2.9.11~20110321/build/drivers/slusb.ko] undefined!
ERROR: modpost: "usb_control_msg" 
[/var/lib/dkms/sl-modem/2.9.11~20110321/build/drivers/slusb.ko] undefined!
ERROR: modpost: "usb_set_interface" 
[/var/lib/dkms/sl-modem/2.9.11~20110321/build/drivers/slusb.ko] undefined!
ERROR: modpost: "usb_deregister" 
[/var/lib/dkms/sl-modem/2.9.11~20110321/build/drivers/slusb.ko] undefined!
ERROR: modpost: "usb_unlink_urb" 
[/var/lib/dkms/sl-modem/2.9.11~20110321/build/drivers/slusb.ko] undefined!
make[2]: *** 
[/usr/src/linux-headers-6.1.0-9-common/scripts/Makefile.modpost:126: 
/var/lib/dkms/sl-modem/2.9.11~20110321/build/drivers/Module.symvers] Error 1
make[1]: *** [/usr/src/linux-headers-6.1.0-9-common/Makefile:1989: modpost] 
Error 2
make[1]: Leaving directory '/usr/src/linux-headers-6.1.0-9-cloud-amd64'
make: *** [Makefile:138: all] Error 2
make: Leaving directory '/var/lib/dkms/sl-modem/2.9.11~20110321/build/drivers'
make: Entering directory 
'/var/lib/dkms/sl-modem/2.9.11~20110321/build/ungrab-winmodem'
make modules -C /lib/modules/6.1.0-9-cloud-amd64/build 
M=/var/lib/dkms/sl-modem/2.9.11~20110321/build/ungrab-winmodem
make[1]: Entering directory '/usr/src/linux-headers-6.1.0-9-cloud-amd64'
  CC [M]  
/var/lib/dkms/sl-modem/2.9.11~20110321/build/ungrab-winmodem/ungrab-winmodem.o
  MODPOST 
/var/lib/dkms/sl-modem/2.9.11~20110321/build/ungrab-winmodem/Module.symvers
  CC [M]  
/var/lib/dkms/sl-modem/2.9.11~20110321/build/ungrab-winmodem/ungrab-winmodem.mod.o
  LD [M]  
/var/lib/dkms/sl-modem/2.9.11~20110321/build/ungrab-winmodem/ungrab-winmodem.ko
  BTF [M] 
/var/lib/dkms/sl-modem/2.9.11~20110321/build/ungrab-winmodem/ungrab-winmodem.ko
Skipping BTF generation for 
/var/lib/dkms/sl-modem/2.9.11~20110321/build/ungrab-winmodem/ungrab-winmodem.ko 
due to unavailability of vmlinux
make[1]: Leaving directory '/usr/src/linux-headers-6.1.0-9-cloud-amd64'
make: Leaving directory 
'/var/lib/dkms/sl-modem/2.9.11~20110321/build/ungrab-winmodem'

You probably need to add this line to your dkms.conf:

        BUILD_EXCLUSIVE_CONFIG="CONFIG_USB"

in order to skip building the module for kernels without CONFIG_USB.

============================================================================

2.) the module fails to build for Linux 6.4

DKMS make.log for sl-modem-2.9.11~20110321 for kernel 6.4.0-0-amd64 (x86_64)
Tue Jun 27 10:00:31 UTC 2023
make: Entering directory '/var/lib/dkms/sl-modem/2.9.11~20110321/build/drivers'
        obj-m= slusb.o
        slamr-objs=amrmo_init.o sysdep_amr.o amrlibs.o
make modules -C /lib/modules/6.4.0-0-amd64/build 
M=/var/lib/dkms/sl-modem/2.9.11~20110321/build/drivers
make[1]: Entering directory '/usr/src/linux-headers-6.4.0-0-amd64'
  CC [M]  /var/lib/dkms/sl-modem/2.9.11~20110321/build/drivers/st7554.o
/var/lib/dkms/sl-modem/2.9.11~20110321/build/drivers/st7554.c:243:33: error: 
macro "DEFINE_SEMAPHORE" requires 2 arguments, but only 1 given
  243 | static DEFINE_SEMAPHORE(open_sem);
      |                                 ^
In file included from 
/usr/src/linux-headers-6.4.0-0-common/include/linux/fs.h:25,
                 from 
/usr/src/linux-headers-6.4.0-0-common/include/linux/poll.h:10,
                 from 
/var/lib/dkms/sl-modem/2.9.11~20110321/build/drivers/st7554.c:55:
/usr/src/linux-headers-6.4.0-0-common/include/linux/semaphore.h:34: note: macro 
"DEFINE_SEMAPHORE" defined here
   34 | #define DEFINE_SEMAPHORE(_name, _n)     \
      |
/var/lib/dkms/sl-modem/2.9.11~20110321/build/drivers/st7554.c:243:8: error: 
type defaults to 'int' in declaration of 'DEFINE_SEMAPHORE' 
[-Werror=implicit-int]
  243 | static DEFINE_SEMAPHORE(open_sem);
      |        ^~~~~~~~~~~~~~~~
/var/lib/dkms/sl-modem/2.9.11~20110321/build/drivers/st7554.c: In function 
'st7554_open':
/var/lib/dkms/sl-modem/2.9.11~20110321/build/drivers/st7554.c:1009:15: error: 
'open_sem' undeclared (first use in this function); did you mean 'open_exec'?
 1009 |         down(&open_sem);
      |               ^~~~~~~~
      |               open_exec
/var/lib/dkms/sl-modem/2.9.11~20110321/build/drivers/st7554.c:1009:15: note: 
each undeclared identifier is reported only once for each function it appears in
/var/lib/dkms/sl-modem/2.9.11~20110321/build/drivers/st7554.c: In function 
'st7554_probe':
/var/lib/dkms/sl-modem/2.9.11~20110321/build/drivers/st7554.c:1332:15: error: 
'open_sem' undeclared (first use in this function); did you mean 'open_exec'?
 1332 |         down(&open_sem);
      |               ^~~~~~~~
      |               open_exec
/var/lib/dkms/sl-modem/2.9.11~20110321/build/drivers/st7554.c: In function 
'st7554_disconnect':
/var/lib/dkms/sl-modem/2.9.11~20110321/build/drivers/st7554.c:1379:15: error: 
'open_sem' undeclared (first use in this function); did you mean 'open_exec'?
 1379 |         down(&open_sem);
      |               ^~~~~~~~
      |               open_exec
/var/lib/dkms/sl-modem/2.9.11~20110321/build/drivers/st7554.c: In function 
'st7554_modem_init':
/usr/src/linux-headers-6.4.0-0-common/include/linux/export.h:27:22: error: 
passing argument 1 of 'class_create' from incompatible pointer type 
[-Werror=incompatible-pointer-types]
   27 | #define THIS_MODULE (&__this_module)
      |                     ~^~~~~~~~~~~~~~~
      |                      |
      |                      struct module *
/var/lib/dkms/sl-modem/2.9.11~20110321/build/drivers/st7554.c:236:48: note: in 
definition of macro 'CLASS_CREATE'
  236 | #define CLASS_CREATE(owner, name) class_create(owner, name)
      |                                                ^~~~~
/var/lib/dkms/sl-modem/2.9.11~20110321/build/drivers/st7554.c:1409:37: note: in 
expansion of macro 'THIS_MODULE'
 1409 |         st7554_class = CLASS_CREATE(THIS_MODULE, "slusb");
      |                                     ^~~~~~~~~~~
In file included from 
/usr/src/linux-headers-6.4.0-0-common/include/linux/device.h:31,
                 from 
/usr/src/linux-headers-6.4.0-0-common/include/linux/usb.h:19,
                 from 
/var/lib/dkms/sl-modem/2.9.11~20110321/build/drivers/st7554.c:56:
/usr/src/linux-headers-6.4.0-0-common/include/linux/device/class.h:230:54: 
note: expected 'const char *' but argument is of type 'struct module *'
  230 | struct class * __must_check class_create(const char *name);
      |                                          ~~~~~~~~~~~~^~~~
/var/lib/dkms/sl-modem/2.9.11~20110321/build/drivers/st7554.c:236:35: error: 
too many arguments to function 'class_create'
  236 | #define CLASS_CREATE(owner, name) class_create(owner, name)
      |                                   ^~~~~~~~~~~~
/var/lib/dkms/sl-modem/2.9.11~20110321/build/drivers/st7554.c:1409:24: note: in 
expansion of macro 'CLASS_CREATE'
 1409 |         st7554_class = CLASS_CREATE(THIS_MODULE, "slusb");
      |                        ^~~~~~~~~~~~
/usr/src/linux-headers-6.4.0-0-common/include/linux/device/class.h:230:29: 
note: declared here
  230 | struct class * __must_check class_create(const char *name);
      |                             ^~~~~~~~~~~~
/var/lib/dkms/sl-modem/2.9.11~20110321/build/drivers/st7554.c: At top level:
/var/lib/dkms/sl-modem/2.9.11~20110321/build/drivers/st7554.c:243:8: warning: 
'DEFINE_SEMAPHORE' defined but not used [-Wunused-variable]
  243 | static DEFINE_SEMAPHORE(open_sem);
      |        ^~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
make[2]: *** [/usr/src/linux-headers-6.4.0-0-common/scripts/Makefile.build:257: 
/var/lib/dkms/sl-modem/2.9.11~20110321/build/drivers/st7554.o] Error 1
make[1]: *** [/usr/src/linux-headers-6.4.0-0-common/Makefile:2051: 
/var/lib/dkms/sl-modem/2.9.11~20110321/build/drivers] Error 2
make[1]: Leaving directory '/usr/src/linux-headers-6.4.0-0-amd64'
make: *** [Makefile:138: all] Error 2
make: Leaving directory '/var/lib/dkms/sl-modem/2.9.11~20110321/build/drivers'
make: Entering directory 
'/var/lib/dkms/sl-modem/2.9.11~20110321/build/ungrab-winmodem'
make modules -C /lib/modules/6.4.0-0-amd64/build 
M=/var/lib/dkms/sl-modem/2.9.11~20110321/build/ungrab-winmodem
make[1]: Entering directory '/usr/src/linux-headers-6.4.0-0-amd64'
  CC [M]  
/var/lib/dkms/sl-modem/2.9.11~20110321/build/ungrab-winmodem/ungrab-winmodem.o
  MODPOST 
/var/lib/dkms/sl-modem/2.9.11~20110321/build/ungrab-winmodem/Module.symvers
  CC [M]  
/var/lib/dkms/sl-modem/2.9.11~20110321/build/ungrab-winmodem/ungrab-winmodem.mod.o
  LD [M]  
/var/lib/dkms/sl-modem/2.9.11~20110321/build/ungrab-winmodem/ungrab-winmodem.ko
  BTF [M] 
/var/lib/dkms/sl-modem/2.9.11~20110321/build/ungrab-winmodem/ungrab-winmodem.ko
Skipping BTF generation for 
/var/lib/dkms/sl-modem/2.9.11~20110321/build/ungrab-winmodem/ungrab-winmodem.ko 
due to unavailability of vmlinux
make[1]: Leaving directory '/usr/src/linux-headers-6.4.0-0-amd64'
make: Leaving directory 
'/var/lib/dkms/sl-modem/2.9.11~20110321/build/ungrab-winmodem'


For the class_create change (upstream commit
1aaba11da9aa7d7d6b52a74d45b31cac118295a1 "driver core: class: remove
module * from class_create()"), the fix would be something like

        +#if LINUX_VERSION_CODE < KERNEL_VERSION(6,4,0)
               nvfs_class = class_create(THIS_MODULE, CLASS_NAME);
        +#else
        +      nvfs_class = class_create(CLASS_NAME);
        +#endif

Andreas

--- End Message ---
--- Begin Message ---
Source: sl-modem
Source-Version: 2.9.11~20110321-18
Done: أحمد المحمودي (Ahmed El-Mahmoudy) <aelmahmo...@users.sourceforge.net>

We believe that the bug you reported is fixed in the latest version of
sl-modem, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1039...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
أحمد المحمودي (Ahmed El-Mahmoudy) <aelmahmo...@users.sourceforge.net> (supplier 
of updated sl-modem package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Wed, 28 Jun 2023 02:13:47 +0200
Source: sl-modem
Architecture: source
Version: 2.9.11~20110321-18
Distribution: unstable
Urgency: low
Maintainer: أحمد المحمودي (Ahmed El-Mahmoudy) 
<aelmahmo...@users.sourceforge.net>
Changed-By: أحمد المحمودي (Ahmed El-Mahmoudy) 
<aelmahmo...@users.sourceforge.net>
Closes: 1039572 1039625
Changes:
 sl-modem (2.9.11~20110321-18) unstable; urgency=low
 .
   * d/copyright: update copyright years
   * d/sl-modem-dkms.dkms: add BUILD_EXCLUSIVE_CONFIG="CONFIG_USB"
     This is in order to skip building the module for kernels without
     CONFIG_USB.
     Thanks to Andreas Beckmann <a...@debian.org> (Closes: #1039572)
   * Add fix-linux-6.4-ftbfs.diff patch to fix FTBFS with Linux 6.4.
     Thanks to Andreas Beckmann <a...@debian.org> (Closes: #1039625)
Checksums-Sha1:
 6f649cfca688babf5213ab524e2caa48eca7903c 1972 sl-modem_2.9.11~20110321-18.dsc
 7142c01f24c0aa33a20781f576792313b299ebaf 37056 
sl-modem_2.9.11~20110321-18.debian.tar.xz
 549ddbeeeedf9cd6db53cb74faccf016914219d6 6413 
sl-modem_2.9.11~20110321-18_source.buildinfo
Checksums-Sha256:
 8f8a0596801b24eadbb28e306fcddf9190a2fd539d41cf661b48aa57cfec0f6d 1972 
sl-modem_2.9.11~20110321-18.dsc
 e2863dd628c69d8683b3d8360baa09eb4bcdda0456c142ae6aaa08ece503cf10 37056 
sl-modem_2.9.11~20110321-18.debian.tar.xz
 453928320c8b9ec67f63ea412a24c2a847242db358aae8f214bcc43950d3101b 6413 
sl-modem_2.9.11~20110321-18_source.buildinfo
Files:
 c9d239d655bf72c660ab999f8796372b 1972 non-free/misc optional 
sl-modem_2.9.11~20110321-18.dsc
 ceb9f14764ffd9e34010dba441cc45c1 37056 non-free/misc optional 
sl-modem_2.9.11~20110321-18.debian.tar.xz
 d43cd9839188212e3d362f977de92fcc 6413 non-free/misc optional 
sl-modem_2.9.11~20110321-18_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQFWBAEBCgBAFiEEggahliCEfm0N+LF2vBlqlO3dobcFAmSbe6YiHGFlbG1haG1v
dWR5QHVzZXJzLnNvdXJjZWZvcmdlLm5ldAAKCRC8GWqU7d2htwdYCACJRnwE3TzB
o5nf1UnENAIcF5MbccZeHf7aqAgt0wfrLrMN3LnrZtkgITk3fMig0DSyzF/evlNW
xx6tmE0Jh+FPLpXvQrQuhEe6ZKXFpBIV55n39jFFQugAcTKO+P5S/uj4aCuaw3F1
Z0rtLkyFt1kbUFMMPE+fZHWsDEsQM/LMChkE7hRYl54mRcE2ArRPCp43DJk2F3CM
O8AmX3UqkHNS3ZPSd0wal91Qf0usM6jV3h3WwrIJgwmbZQ704iZ6Q6XAHs2tlRZx
CMA9oVmDHW7CTdqmNNly6bwdHe0N2ZzV8evooddl+fqPOdHNjbvi10R3VrIzsk6b
ySm6YKCAoEHm
=fSBK
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to