Bug#1056780: openmsx: Source-less Windows binary in source package (and other packaging issues)

2023-12-10 Thread Aaron Rainbolt
On 12/10/23 12:08, Bas Wijnen wrote: On Sun, Dec 03, 2023 at 02:18:38AM -0600, Aaron Rainbolt wrote: [Catch 2] While it is definitely possible to port the openMSX tests to use catch2 v3, we will be departing from what upstream supports, and that seems like it could lead to way more work than

Bug#1056780: openmsx: Source-less Windows binary in source package (and other packaging issues)

2023-12-10 Thread Bas Wijnen
On Sun, Dec 03, 2023 at 02:18:38AM -0600, Aaron Rainbolt wrote: > > [Catch 2] > While it is definitely possible to port the > openMSX tests to use catch2 v3, we will be departing from what > upstream supports, and that seems like it could lead to way more work > than necessary (for instance, what

Bug#1056780: openmsx: Source-less Windows binary in source package (and other packaging issues)

2023-12-07 Thread Aaron Rainbolt
Alright, so apparently I can't read. I totally missed that you had mentioned there was already a bug report against Lintian about this problem. I think we probably should override the errors anyway for now since I am not an experienced Lintian or Perl developer and it will take me some time to

Bug#1056780: openmsx: Source-less Windows binary in source package (and other packaging issues)

2023-12-07 Thread Aaron Rainbolt
Is this bug something we're still actively working on? It's been a few days. If I missed something, feel free to let me know. -- Aaron Rainbolt Lubuntu Developer Matrix: @arraybolt3:matrix.org IRC: arraybolt3 on irc.libera.chat GitHub: https://github.com/ArrayBolt3

Bug#1056780: openmsx: Source-less Windows binary in source package (and other packaging issues)

2023-12-03 Thread Aaron Rainbolt
On Sun, Dec 3, 2023 at 2:04 AM Dr. Bas Wijnen wrote: > > Hi, > > This is starting to look great, thanks a lot of all the work. :-) However, I > still see a few issues with it: > > - the references to C-BIOS in the XML configuration files should not be > removed. When running, they are usually

Bug#1056780: openmsx: Source-less Windows binary in source package (and other packaging issues)

2023-12-03 Thread Dr. Bas Wijnen
Hi, This is starting to look great, thanks a lot of all the work. :-) However, I still see a few issues with it: - the references to C-BIOS in the XML configuration files should not be removed. When running, they are usually availably from the cbios package. And if the user didn't install

Bug#1056780: openmsx: Source-less Windows binary in source package (and other packaging issues)

2023-11-29 Thread Aaron Rainbolt
Alright, here's the latest openMSX package with all C-BIOS binaries patched out. Now that there's no new binaries, I can just send this as a debdiff attachment. Keep in mind all the binary files mentioned in the diff have to be deleted from the source tree. Thanks for collaborating with me so

Bug#1056780: openmsx: Source-less Windows binary in source package (and other packaging issues)

2023-11-29 Thread Aaron Rainbolt
On 11/29/23 14:40, Bas Wijnen wrote: On Wed, Nov 29, 2023 at 01:52:46PM -0600, Aaron Rainbolt wrote: It appears that the C-BIOS package in Debian only ships the most recent C-BIOS files. I think we can't just depend on it for this reason, since the older C-BIOS ROMs are needed to avoid save

Bug#1056780: openmsx: Source-less Windows binary in source package (and other packaging issues)

2023-11-29 Thread Bas Wijnen
On Wed, Nov 29, 2023 at 01:52:46PM -0600, Aaron Rainbolt wrote: > It appears that the C-BIOS package in Debian only ships the most recent > C-BIOS files. I think we can't just depend on it for this reason, since the > older C-BIOS ROMs are needed to avoid save state breakage. See >

Bug#1056780: openmsx: Source-less Windows binary in source package (and other packaging issues)

2023-11-29 Thread Aaron Rainbolt
It appears that the C-BIOS package in Debian only ships the most recent C-BIOS files. I think we can't just depend on it for this reason, since the older C-BIOS ROMs are needed to avoid save state breakage. See Contrib/cbios-old/README in the openMSX package. -- Aaron Rainbolt Lubuntu

Bug#1056780: openmsx: Source-less Windows binary in source package (and other packaging issues)

2023-11-29 Thread Aaron Rainbolt
On Wed, Nov 29, 2023 at 5:17 AM Dr. Bas Wijnen wrote: > > Hi, > > Thanks a lot for not just finding those issues, but also fixing them! That is > much appreciated. > > As for the license, Manuel (who is upstream) pointed out that the entire > source > code is (and always has been) GPL-2 only.

Bug#1056780: openmsx: Source-less Windows binary in source package (and other packaging issues)

2023-11-29 Thread Dr. Bas Wijnen
Hi, Thanks a lot for not just finding those issues, but also fixing them! That is much appreciated. As for the license, Manuel (who is upstream) pointed out that the entire source code is (and always has been) GPL-2 only. The only issue with that is the packaging, which is GPL-3+. But that was

Bug#1056780: openmsx: Source-less Windows binary in source package (and other packaging issues)

2023-11-27 Thread Aaron Rainbolt
I had a Debian Developer review my packaging work. I got the package version string wrong and was slightly vague about the debhelper version update in the changelog. Both of those things are now fixed and I have the fixed files pushed to the same GitHub repo as last time,

Bug#1056780: openmsx: Source-less Windows binary in source package (and other packaging issues)

2023-11-27 Thread Aaron Rainbolt
On 11/27/23 15:02, Manuel Bilderbeek wrote: On 27-11-2023 02:11, Aaron Rainbolt wrote: Alright, I have fully rebuilt the copyright file. I also ended up adding the source code for several releases of C-BIOS into the packaging. As this code is in the form of zipped files for the sake of size,

Bug#1056780: openmsx: Source-less Windows binary in source package (and other packaging issues)

2023-11-27 Thread Manuel Bilderbeek
On 27-11-2023 02:11, Aaron Rainbolt wrote: Alright, I have fully rebuilt the copyright file. I also ended up adding the source code for several releases of C-BIOS into the packaging. As this code is in the form of zipped files for the sake of size, it's not exactly practical to provide the new

Bug#1056780: openmsx: Source-less Windows binary in source package (and other packaging issues)

2023-11-26 Thread Aaron Rainbolt
Alright, I have fully rebuilt the copyright file. I also ended up adding the source code for several releases of C-BIOS into the packaging. As this code is in the form of zipped files for the sake of size, it's not exactly practical to provide the new source package changes as a debdiff since

Bug#1056780: Fwd: Bug#1056780: openmsx: Source-less Windows binary in source package (and other packaging issues)

2023-11-26 Thread Aaron Rainbolt
Failed to reply to the right address, so forwarding. -- Forwarded message - From: Aaron Rainbolt Date: Sun, Nov 26, 2023 at 1:30 PM Subject: Re: Bug#1056780: openmsx: Source-less Windows binary in source package (and other packaging issues) To: Manuel Bilderbeek Thanks! I

Bug#1056780: openmsx: Source-less Windows binary in source package (and other packaging issues)

2023-11-26 Thread Manuel Bilderbeek
On 26-11-2023 18:39, Aaron Rainbolt wrote: Further investigation trying to rebuild the copyright file has revealed more binaries without source code (the C-BIOS ROMs for instance). So I'll have to find the sources for those also. Thanks for your patience. The C-BIOS ROMs have their source

Bug#1056780: openmsx: Source-less Windows binary in source package (and other packaging issues)

2023-11-26 Thread Aaron Rainbolt
Further investigation trying to rebuild the copyright file has revealed more binaries without source code (the C-BIOS ROMs for instance). So I'll have to find the sources for those also. Thanks for your patience. -- Aaron Rainbolt Lubuntu Developer Matrix: @arraybolt3:matrix.org IRC:

Bug#1056780: openmsx: Source-less Windows binary in source package (and other packaging issues)

2023-11-26 Thread Aaron Rainbolt
My reasoning here is that the openMSX code specifies "Some source files contain a license notice; all other source files are licensed under the GNU Public License (GPL), of which you can find a copy in the file 'GPL.txt'." That file contains a GPL-2 license, so the repository-wide license is

Bug#1056780: openmsx: Source-less Windows binary in source package (and other packaging issues)

2023-11-26 Thread Manuel Bilderbeek
Hi, The license of openMSX has always been GPL 2 only. Is there a problem somewhere? Op zo 26 nov. 2023 09:57 schreef Dr. Bas Wijnen : > Hi, > > First of all, thank you for the report and patch. I'll look in more detail > shortly. > > However, after quickly looking over it, I have one question:

Bug#1056780: openmsx: Source-less Windows binary in source package (and other packaging issues)

2023-11-26 Thread Dr. Bas Wijnen
Hi, First of all, thank you for the report and patch. I'll look in more detail shortly. However, after quickly looking over it, I have one question: you change the license from "GPL (any version)" to "GPL (version 2)". Why did you do that? The upstream license information is admittedly not very

Bug#1056780: openmsx: Source-less Windows binary in source package (and other packaging issues)

2023-11-25 Thread Aaron Rainbolt
Uh... ok so apparently either Gmail or the Debian BTS ate my patch, so here's a second attempt, this time as a file attachment. Also, it appears that the openMSX maintainer's debian.org email address must be pointing to an Apple support address since I've now gotten two "Thank you for

Bug#1056780: openmsx: Source-less Windows binary in source package (and other packaging issues)

2023-11-25 Thread Aaron Rainbolt
Here's a debdiff between the current version of the openMSX package and a proposed new version that fixes this bug. **Note**: It is necessary to also delete the Contrib/codec/Win32/zmbv.dll file in the source package tree (debdiffs don't seem to communicate deleted binary files very well).

Bug#1056780: openmsx: Source-less Windows binary in source package (and other packaging issues)

2023-11-25 Thread Aaron Rainbolt
Package: openmsx Version: 19.1-1 Severity: serious Justification: Policy 2.2.1 X-Debbugs-Cc: arraybo...@ubuntu.com Packages in the Debian `main` archive area *must* comply with the DFSG, of which section 2 states "The program must include source code, and must allow distribution in source code as