Bug#1066831: marked as done (nbd-server: Crash on -C /dev/null or -C /missing/file)

[Debian Bug Tracking System]

Your message dated Fri, 17 May 2024 10:54:16 +0200
with message-id <zkcbod188emay...@pc220518.home.grep.be>
and subject line This was fixed in experimental, tag
has caused the Debian Bug report #1066831,
regarding nbd-server: Crash on -C /dev/null or -C /missing/file
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
1066831: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1066831
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

--- Begin Message ---

Package: nbd-client
Version: 1:3.26.1-1
Severity: serious
Tags: patch
X-Debbugs-Cc: none, Hilko Bengen <ben...@debian.org>

Dear Maintainer,

While investigating libnbd build failures (see ##1066766), I stumbled
across a bug that makes nbd-server crash without an error message when
trying to read its configuration from /dev/null or any non-existing
file:

$ ./nbd-server -C /dev/null 
Segmentation fault

It turns out that one g_key_file_free() call was left in the code when
auto-freeing was introduced in upstream commit
ab41c4f5a91857d9466d83ea062ec60435f7eaa0. The attached patch fixes this.

Cheers,
-Hilko

Index: nbd-3.26.1/nbd-server.c
===================================================================
--- nbd-3.26.1.orig/nbd-server.c
+++ nbd-3.26.1/nbd-server.c
@@ -881,7 +881,6 @@ GArray* parse_cfile(gchar* f, struct gen
 			G_KEY_FILE_KEEP_TRANSLATIONS, &err)) {
 		g_set_error(e, NBDS_ERR, NBDS_ERR_CFILE_NOTFOUND, "Could not open config file %s: %s",
 				f, err->message);
-		g_key_file_free(cfile);
 		return retval;
 	}
 	startgroup = g_key_file_get_start_group(cfile);

--- End Message ---

--- Begin Message ---

Package: nbd
Version: 1:3.26.1-2~exp0

This was fixed in an upload to experimental, but that upload was
rejected and then we created a new changelog entry rather than uploading
a fixed changelog entry... oops

-- 
     w@uter.{be,co.za}
wouter@{grep.be,fosdem.org,debian.org}

I will have a Tin-Actinium-Potassium mixture, thanks.

--- End Message ---