On Sat, 2006-02-18 at 08:06 +0100, Javier Fernández-Sanguino Peña wrote:
Should the check
[ ! -f $PIDFILE ] return 1
cover that? I don't see why that should fail, if the PIDFILE does not exist
it should not go ahead and try to read from it.
It will cover it for most cases, but
On Thu, 2006-02-16 at 12:24 +0100, Javier Fernández-Sanguino Peña wrote:
- run 'portreserve start' twice, check # of portreserve instances. Stop
port reserve.
- run 'portreserve start' once, run 'portreserve', check # of instances and
pidfile contents. Stop port reserve.
Handles both
On Sat, Feb 18, 2006 at 02:47:33PM +1300, Matt Brown wrote:
I did however discover one minor bug that occurred when the stop target
of the init script was run twice in a row and resulted in some ugly
error output from trying to read the non-existant pidfile. The
functionality was still
On Wed, 2006-02-15 at 15:14 +0100, Javier Fernández-Sanguino Peña wrote:
Hi there. I hope you don't mind me being a little bit picky, but I think it
helps you hone your skills :-)
I've certainly picked up a couple of pointers.
I'm pretty sure there are libraries that do implement that
On Thu, Feb 16, 2006 at 09:52:24PM +1300, Matt Brown wrote:
On Wed, 2006-02-15 at 15:14 +0100, Javier Fernández-Sanguino Peña wrote:
The patch is now back down to the size/scope that I consider appropriate
for a NMU, I agree that the previous patch was getting a little unwieldy
and rough, my
On Thu, Feb 16, 2006 at 01:22:20AM +1300, Matt Brown wrote:
Hi Javier,
Hi there. I hope you don't mind me being a little bit picky, but I think it
helps you hone your skills :-)
* there's a buffer overflow if 'fname' is longer than 512 chars. buf should
*not* be of a static size
Hi Javier,
Please find attached a revised patch that I propose for this NMU. It's a
bit more invasive that what I would usually feel comfortable including
in an NMU, so I won't upload without your approval.
On Tue, 2006-02-14 at 12:42 +0100, Javier Fernández-Sanguino Peña wrote:
Why doesn't
Hi,
I have prepared a NMU patch to fix this bug as a part of the T S
portion of my NM application.
As described in the original problem report there were several fairly
trivial fixes required to to the init script.
1) Incorrect test when checking for valid service files - fixed by using
-z
On Wed, Feb 15, 2006 at 12:09:43AM +1300, Matt Brown wrote:
Hi,
I have prepared a NMU patch to fix this bug as a part of the T S
portion of my NM application.
Thanks for doing this.
Additionally the running function never succeeded because portreserve
doesn't create a pid file. This is
9 matches
Mail list logo
