Bug#987332: aprx automatically starts up with really bad default config

2021-05-06 Thread Apostolos Kefalas
Hello Hibby, Please review the below patch --- a/config.c +++ b/config.c @@ -340,6 +340,9 @@ config_STRUPPER(param1); // Store these always, it helps with latter error diagnostics mycall = strdup(param1); + if (strcmp(mycall,

Bug#987332: aprx automatically starts up with really bad default config

2021-05-05 Thread Hibby
Hi all, I had a quick look at the code - config.c carries a validate_callsign_input() function, which I think we could patch a check in to cause the program to exit with an incorrect callsign for APRS-IS error. Alternatively, it’s checking for a 6 character callsign, so we could make N0CALL-1

Bug#987332: aprx automatically starts up with really bad default config

2021-05-05 Thread Dave Hibberd
Hi all, I'm filing a report upstream currently, but there's a lack of activity so let's not hold our collective breath. I'll take a wee dig into the program and see if I can find a point where it parses the config file to exit on N0CALL-1. Couple of questions: * Debian Janitor has given us

Bug#987332: aprx automatically starts up with really bad default config

2021-04-25 Thread Apostolos Kefalas
On Sun, 2021-04-25 at 17:54 +0300, Heikki Hannikainen wrote: > > > > I think it should be possible to detect the "N0CALL" configurations on > > upgrade and disable the service, thus reaching the same state as with my > > above change for new installs. > > Right, something like a grep for the

Bug#987332: aprx automatically starts up with really bad default config

2021-04-25 Thread Heikki Hannikainen
On Sun, 25 Apr 2021, Evgeni Golov wrote: On Sun, Apr 25, 2021 at 03:41:38PM +0300, Heikki Hannikainen wrote: This would be very important to make this happen. Shipping a config with the "mycall N0CALL-1" line commented out would probably work. If we change the default config, but let the

Bug#987332: aprx automatically starts up with really bad default config

2021-04-25 Thread Evgeni Golov
On Sun, Apr 25, 2021 at 03:41:38PM +0300, Heikki Hannikainen wrote: > On Sun, 25 Apr 2021, Evgeni Golov wrote: > > > On Thu, Apr 22, 2021 at 12:19:57AM +0300, Heikki Hannikainen wrote: > > > > > - Remove N0CALL-1 from the default configuration (comment the line out) so > > > that it will refuse

Bug#987332: aprx automatically starts up with really bad default config

2021-04-25 Thread Heikki Hannikainen
On Sun, 25 Apr 2021, Evgeni Golov wrote: On Thu, Apr 22, 2021 at 12:19:57AM +0300, Heikki Hannikainen wrote: - Remove N0CALL-1 from the default configuration (comment the line out) so that it will refuse to start up before configured with the callsign of the user Is N0CALL-1 part of the

Bug#987332: aprx automatically starts up with really bad default config

2021-04-25 Thread Evgeni Golov
Hi, On Thu, Apr 22, 2021 at 12:19:57AM +0300, Heikki Hannikainen wrote: > - Have it not start up by default after installation, before it is configured This should be doable by the following patch: diff -Nru aprx-2.9.0+dfsg/debian/rules aprx-2.9.0+dfsg/debian/rules ---