Re: Bug#995722: Not running tests because tests miss source code is not useful

2021-10-14 Thread Thomas Goirand
On 10/11/21 11:20 AM, Yadd wrote: > For now: > > $ cat tags/s/source-contains-prebuilt-javascript-object.tag > Tag: source-contains-prebuilt-javascript-object > Severity: pedantic > Check: cruft > Explanation: The source tarball contains a prebuilt (minified) >JavaScript object. >

Re: Bug#995722: Not running tests because tests miss source code is not useful

2021-10-11 Thread Jeremy Stanley
On 2021-10-11 11:20:03 +0200 (+0200), Yadd wrote: [...] > For now: > > $ cat tags/s/source-contains-prebuilt-javascript-object.tag > Tag: source-contains-prebuilt-javascript-object > Severity: pedantic > Check: cruft > Explanation: The source tarball contains a prebuilt (minified) >

Re: Bug#995722: Not running tests because tests miss source code is not useful

2021-10-11 Thread Yadd
Le 10/10/2021 à 15:36, Kristian Nielsen a écrit : > Julien Puydt writes: > >> There was the case years ago of the smarteiffel compiler. It was supposed >> to be open source, but upstream only released C code. And that was bad, >> because it wasn't what *they* worked with: they had eiffel

Re: Bug#995722: Not running tests because tests miss source code is not useful

2021-10-10 Thread Kristian Nielsen
Julien Puydt writes: > There was the case years ago of the smarteiffel compiler. It was supposed > to be open source, but upstream only released C code. And that was bad, > because it wasn't what *they* worked with: they had eiffel sources, and the > C code was preprocessed and didn't

Re: Bug#995722: Not running tests because tests miss source code is not useful

2021-10-10 Thread Jonas Smedegaard
Quoting Julien Puydt (2021-10-10 14:34:34) > Le sam. 9 oct. 2021 à 18:52, Jonas Smedegaard a écrit : > > Quoting Julien Puydt (2021-10-09 18:48:07) > > > Le sam. 9 oct. 2021 à 17:40, Jeremy Stanley a > > > écrit > > > > On 2021-10-09 08:53:57 +0200 (+0200), Yadd wrote: [...] > > > > > If you

Re: Bug#995722: Not running tests because tests miss source code is not useful

2021-10-10 Thread Jonas Smedegaard
Quoting Stephan Verbücheln (2021-10-10 14:03:51) > On Sat, 2021-10-09 at 18:52 +0200, Jonas Smedegaard wrote: > > It is not source code. > > > > It is not binary code. > > > > It is not... > > > > The appropriate question is how it fits Debian Free Software > > Guidelines. > > Programs with a

Re: Bug#995722: Not running tests because tests miss source code is not useful

2021-10-10 Thread Julien Puydt
Hi Le sam. 9 oct. 2021 à 18:52, Jonas Smedegaard a écrit : > Quoting Julien Puydt (2021-10-09 18:48:07) > > Hi > > > > Le sam. 9 oct. 2021 à 17:40, Jeremy Stanley a écrit > : > > > > > On 2021-10-09 08:53:57 +0200 (+0200), Yadd wrote: > > > [...] > > > > If you really consider minified files

Re: Bug#995722: Not running tests because tests miss source code is not useful

2021-10-10 Thread Stephan Verbücheln
On Sat, 2021-10-09 at 18:52 +0200, Jonas Smedegaard wrote: > It is not source code. > > It is not binary code. > > It is not... > > The appropriate question is how it fits Debian Free Software > Guidelines. Programs with a license on the one hand which demands the right to study and modify the

Re: Bug#995722: Not running tests because tests miss source code is not useful

2021-10-09 Thread Jonas Smedegaard
Quoting Julien Puydt (2021-10-09 18:48:07) > Hi > > Le sam. 9 oct. 2021 à 17:40, Jeremy Stanley a écrit : > > > On 2021-10-09 08:53:57 +0200 (+0200), Yadd wrote: > > [...] > > > If you really consider minified files as binary, there's a room > > > for creating a lot of RC bugs > > > > The more

Re: Bug#995722: Not running tests because tests miss source code is not useful

2021-10-09 Thread Julien Puydt
Hi Le sam. 9 oct. 2021 à 17:40, Jeremy Stanley a écrit : > On 2021-10-09 08:53:57 +0200 (+0200), Yadd wrote: > [...] > > If you really consider minified files as binary, there's a room for > > creating a lot of RC bugs > > The more appropriate question is whether Debian considers minified >

Re: Bug#995722: Not running tests because tests miss source code is not useful

2021-10-09 Thread Jeremy Stanley
On 2021-10-09 08:53:57 +0200 (+0200), Yadd wrote: [...] > If you really consider minified files as binary, there's a room for > creating a lot of RC bugs The more appropriate question is whether Debian considers minified files to be source code, or a compiled form. To needlessly quote DFSG §2:

Re: Bug#995722: Not running tests because tests miss source code is not useful

2021-10-09 Thread Yadd
Le 08/10/2021 à 22:54, Thomas Goirand a écrit : > On 10/8/21 10:20 AM, Yadd wrote: >> Take a look, most of them embed a minified version (jquery* for example) > Yeah ... Everyone upstream thinks it's ok to have 15907152438 copies of > jquery floating around... There's room for improvement for

Re: [Pkg-javascript-devel] Bug#995722: Not running tests because tests miss source code is not useful

2021-10-08 Thread Thomas Goirand
On 10/8/21 10:20 AM, Yadd wrote: > Take a look, most of them embed a minified version (jquery* for example) Yeah ... Everyone upstream thinks it's ok to have 15907152438 copies of jquery floating around... There's room for improvement for sure! :) Thomas Goirand (zigo)

Re: Not running tests because tests miss source code is not useful

2021-10-08 Thread Thomas Goirand
On 10/8/21 7:51 PM, Pirate Praveen wrote: > Draft text for the GR (this is my first time proposing a GR text, so > help is welcome to make the text clearer). > > We should not worry about minified files in main that are (a) only in > the source package and not in any binary package, and (b) only

Re: Not running tests because tests miss source code is not useful

2021-10-08 Thread Thomas Goirand
On 10/8/21 7:30 PM, Pirate Praveen wrote: >>>  This is used only during tests. I don't think we are not gaining >>> anything by removing tests here. Just making it harder for the >>> package maintainer to run tests. >> >> You would not gain anything by removing tests, but you would win by >>

Re: Not running tests because tests miss source code is not useful

2021-10-08 Thread Jonas Smedegaard
Quoting Pirate Praveen (2021-10-08 19:51:44) > Draft text for the GR (this is my first time proposing a GR text, so > help is welcome to make the text clearer). > > We should not worry about minified files in main that are (a) only in > the source package and not in any binary package, and (b)

Re: Not running tests because tests miss source code is not useful

2021-10-08 Thread Pirate Praveen
Draft text for the GR (this is my first time proposing a GR text, so help is welcome to make the text clearer). We should not worry about minified files in main that are (a) only in the source package and not in any binary package, and (b) only used to run tests, not to build the binary

Re: Not running tests because tests miss source code is not useful

2021-10-08 Thread Pirate Praveen
On വെ, ഒക്ടോ 8 2021 at 10:31:16 രാവിലെ +0200 +0200, Thomas Goirand wrote: On 10/7/21 11:40 AM, Pirate Praveen wrote: On 7 October 2021 3:02:55 am IST, Thomas Goirand wrote: On 10/6/21 6:53 PM, Pirate Praveen wrote: [adding -devel] On ബു, ഒക്ടോ 6 2021 at 12:16:07 വൈകു +0200

Re: Not running tests because tests miss source code is not useful

2021-10-08 Thread Pirate Praveen
On വ്യാ, ഒക്ടോ 7 2021 at 11:43:52 രാവിലെ -0700 -0700, Russ Allbery wrote: Jonas Smedegaard writes: Right: It is ok to use upstream-provided pre-minified code, as long as that code is DFSG-free, which requires the source of that code must exist in Debian. ...and because that is

Re: Not running tests because tests miss source code is not useful

2021-10-08 Thread Thomas Goirand
On 10/7/21 11:40 AM, Pirate Praveen wrote: > > > On 7 October 2021 3:02:55 am IST, Thomas Goirand wrote: >> On 10/6/21 6:53 PM, Pirate Praveen wrote: >>> [adding -devel] >>> >>> On ബു, ഒക്ടോ 6 2021 at 12:16:07 വൈകു +0200 +0200, Jonas Smedegaard >>> wrote: Quoting Yadd (2021-10-06

Re: [Pkg-javascript-devel] Bug#995722: Not running tests because tests miss source code is not useful

2021-10-08 Thread Yadd
Le 08/10/2021 à 10:18, Thomas Goirand a écrit : > On 10/7/21 7:06 AM, Yadd wrote: >> Le 06/10/2021 à 23:32, Thomas Goirand a écrit : >>> On 10/6/21 6:53 PM, Pirate Praveen wrote: [adding -devel] On ബു, ഒക്ടോ 6 2021 at 12:16:07 വൈകു +0200 +0200, Jonas Smedegaard wrote: >

Re: [Pkg-javascript-devel] Bug#995722: Not running tests because tests miss source code is not useful

2021-10-08 Thread Thomas Goirand
On 10/7/21 7:06 AM, Yadd wrote: > Le 06/10/2021 à 23:32, Thomas Goirand a écrit : >> On 10/6/21 6:53 PM, Pirate Praveen wrote: >>> [adding -devel] >>> >>> On ബു, ഒക്ടോ 6 2021 at 12:16:07 വൈകു +0200 +0200, Jonas Smedegaard >>> wrote: Quoting Yadd (2021-10-06 11:43:40) >  On Lu, 04 oct 21,

Re: Not running tests because tests miss source code is not useful

2021-10-07 Thread Russ Allbery
Jonas Smedegaard writes: > Right: It is ok to use upstream-provided pre-minified code, as long as > that code is DFSG-free, which requires the source of that code must > exist in Debian. > ...and because that is often complicated to ensure (not because it > violates DFSG in itself), it is

Re: Not running tests because tests miss source code is not useful

2021-10-07 Thread Jonas Smedegaard
Quoting Richard Laager (2021-10-07 19:49:56) > On 10/7/21 11:35 AM, Russ Allbery wrote: > > Richard Laager writes: > > > >> I haven't looked into the specifics of this situation, but in > >> general, tests should be run against the same versions of > >> dependencies that the actual code will

Re: Not running tests because tests miss source code is not useful

2021-10-07 Thread Richard Laager
On 10/7/21 11:35 AM, Russ Allbery wrote: Richard Laager writes: I haven't looked into the specifics of this situation, but in general, tests should be run against the same versions of dependencies that the actual code will use, for what should be obvious reasons. If Debian has the

Re: Not running tests because tests miss source code is not useful

2021-10-07 Thread Russ Allbery
Richard Laager writes: > I haven't looked into the specifics of this situation, but in general, > tests should be run against the same versions of dependencies that the > actual code will use, for what should be obvious reasons. If Debian has > the dependencies with different API versions, then

Re: Not running tests because tests miss source code is not useful

2021-10-07 Thread Richard Laager
On 10/7/21 4:40 AM, Pirate Praveen wrote: What you are proposing would require the package maintainer to adapt these tests to versions available (many times with different API versions) in Debian and the easier choice is disabling tests. I haven't looked into the specifics of this situation,

Re: Not running tests because tests miss source code is not useful

2021-10-07 Thread Marvin Renich
* Pirate Praveen [211007 05:41]: > On 7 October 2021 3:02:55 am IST, Thomas Goirand wrote: > >On 10/6/21 6:53 PM, Pirate Praveen wrote: > >> On ബു, ഒക്ടോ 6 2021 at 12:16:07 വൈകു +0200 +0200, Jonas Smedegaard > > >> wrote: > >>> Quoting Yadd (2021-10-06 11:43:40) >  On Lu, 04 oct 21,

Re: [Pkg-javascript-devel] Bug#995722: Not running tests because tests miss source code is not useful

2021-10-07 Thread Jonas Smedegaard
Quoting Yadd (2021-10-07 07:06:42) > Le 06/10/2021 à 23:32, Thomas Goirand a écrit : >> On 10/6/21 6:53 PM, Pirate Praveen wrote: >>> On ബു, ഒക്ടോ 6 2021 at 12:16:07 വൈകു +0200 +0200, Jonas Smedegaard >>> wrote: Quoting Yadd (2021-10-06 11:43:40) >  On Lu, 04 oct 21, 16:40:48, Bastien

Re: Not running tests because tests miss source code is not useful

2021-10-07 Thread Pirate Praveen
On 7 October 2021 3:02:55 am IST, Thomas Goirand wrote: >On 10/6/21 6:53 PM, Pirate Praveen wrote: >> [adding -devel] >> >> On ബു, ഒക്ടോ 6 2021 at 12:16:07 വൈകു +0200 +0200, Jonas Smedegaard >> wrote: >>> Quoting Yadd (2021-10-06 11:43:40)  On Lu, 04 oct 21, 16:40:48, Bastien Roucari�s

Re: [Pkg-javascript-devel] Bug#995722: Not running tests because tests miss source code is not useful

2021-10-06 Thread Yadd
Le 06/10/2021 à 23:32, Thomas Goirand a écrit : > On 10/6/21 6:53 PM, Pirate Praveen wrote: >> [adding -devel] >> >> On ബു, ഒക്ടോ 6 2021 at 12:16:07 വൈകു +0200 +0200, Jonas Smedegaard >> wrote: >>> Quoting Yadd (2021-10-06 11:43:40)  On Lu, 04 oct 21, 16:40:48, Bastien Roucari�s wrote:  

Re: Not running tests because tests miss source code is not useful

2021-10-06 Thread Thomas Goirand
On 10/6/21 6:53 PM, Pirate Praveen wrote: > [adding -devel] > > On ബു, ഒക്ടോ 6 2021 at 12:16:07 വൈകു +0200 +0200, Jonas Smedegaard > wrote: >> Quoting Yadd (2021-10-06 11:43:40) >>>  On Lu, 04 oct 21, 16:40:48, Bastien Roucari�s wrote: >>>  > Source: src:node-lodash >>>  > Version:

Not running tests because tests miss source code is not useful

2021-10-06 Thread Pirate Praveen
[adding -devel] On ബു, ഒക്ടോ 6 2021 at 12:16:07 വൈകു +0200 +0200, Jonas Smedegaard wrote: Quoting Yadd (2021-10-06 11:43:40) On Lu, 04 oct 21, 16:40:48, Bastien Roucari�s wrote: > Source: src:node-lodash > Version: 4.17.21+dfsg+~cs8.31.173-1 > Severity: serious > Justification: do not