This is an automated email from the git hooks/post-receive script.

guillem pushed a commit to branch main
in repository dpkg.

View the commit online:
https://git.dpkg.org/cgit/dpkg/dpkg.git/commit/?id=d583f4846c26b421c8bc7b833925da7af986f71f

commit d583f4846c26b421c8bc7b833925da7af986f71f
Author: Nicolas Boulenguez <nico...@debian.org>
AuthorDate: Wed Apr 10 00:09:43 2024 +0200

    test: Use loops instead of repetitions in mk fragment tests
    
    [guil...@debian.org:
     - Wrap line at foreach. ]
    
    Signed-off-by: Guillem Jover <guil...@debian.org>
---
 scripts/t/mk/architecture.mk | 54 ++++++++++++++++----------------------------
 scripts/t/mk/buildflags.mk   | 39 +++++++++++++++-----------------
 scripts/t/mk/buildtools.mk   | 54 +++++++++++++++++++-------------------------
 3 files changed, 61 insertions(+), 86 deletions(-)

diff --git a/scripts/t/mk/architecture.mk b/scripts/t/mk/architecture.mk
index 2ac0222ca..d15cdf603 100644
--- a/scripts/t/mk/architecture.mk
+++ b/scripts/t/mk/architecture.mk
@@ -1,36 +1,22 @@
 include $(srcdir)/mk/architecture.mk
 
-test:
-       test "$(DEB_BUILD_ARCH)" = "$(TEST_DEB_BUILD_ARCH)"
-       test "$(DEB_BUILD_ARCH_ABI)" = "$(TEST_DEB_BUILD_ARCH_ABI)"
-       test "$(DEB_BUILD_ARCH_BITS)" = "$(TEST_DEB_BUILD_ARCH_BITS)"
-       test "$(DEB_BUILD_ARCH_CPU)" = "$(TEST_DEB_BUILD_ARCH_CPU)"
-       test "$(DEB_BUILD_ARCH_ENDIAN)" = "$(TEST_DEB_BUILD_ARCH_ENDIAN)"
-       test "$(DEB_BUILD_ARCH_LIBC)" = "$(TEST_DEB_BUILD_ARCH_LIBC)"
-       test "$(DEB_BUILD_ARCH_OS)" = "$(TEST_DEB_BUILD_ARCH_OS)"
-       test "$(DEB_BUILD_GNU_CPU)" = "$(TEST_DEB_BUILD_GNU_CPU)"
-       test "$(DEB_BUILD_GNU_SYSTEM)" = "$(TEST_DEB_BUILD_GNU_SYSTEM)"
-       test "$(DEB_BUILD_GNU_TYPE)" = "$(TEST_DEB_BUILD_GNU_TYPE)"
-       test "$(DEB_BUILD_MULTIARCH)" = "$(TEST_DEB_BUILD_MULTIARCH)"
-       test "$(DEB_HOST_ARCH)" = "$(TEST_DEB_HOST_ARCH)"
-       test "$(DEB_HOST_ARCH_ABI)" = "$(TEST_DEB_HOST_ARCH_ABI)"
-       test "$(DEB_HOST_ARCH_BITS)" = "$(TEST_DEB_HOST_ARCH_BITS)"
-       test "$(DEB_HOST_ARCH_CPU)" = "$(TEST_DEB_HOST_ARCH_CPU)"
-       test "$(DEB_HOST_ARCH_ENDIAN)" = "$(TEST_DEB_HOST_ARCH_ENDIAN)"
-       test "$(DEB_HOST_ARCH_LIBC)" = "$(TEST_DEB_HOST_ARCH_LIBC)"
-       test "$(DEB_HOST_ARCH_OS)" = "$(TEST_DEB_HOST_ARCH_OS)"
-       test "$(DEB_HOST_GNU_CPU)" = "$(TEST_DEB_HOST_GNU_CPU)"
-       test "$(DEB_HOST_GNU_SYSTEM)" = "$(TEST_DEB_HOST_GNU_SYSTEM)"
-       test "$(DEB_HOST_GNU_TYPE)" = "$(TEST_DEB_HOST_GNU_TYPE)"
-       test "$(DEB_HOST_MULTIARCH)" = "$(TEST_DEB_HOST_MULTIARCH)"
-       test "$(DEB_TARGET_ARCH)" = "$(TEST_DEB_TARGET_ARCH)"
-       test "$(DEB_TARGET_ARCH_ABI)" = "$(TEST_DEB_TARGET_ARCH_ABI)"
-       test "$(DEB_TARGET_ARCH_BITS)" = "$(TEST_DEB_TARGET_ARCH_BITS)"
-       test "$(DEB_TARGET_ARCH_CPU)" = "$(TEST_DEB_TARGET_ARCH_CPU)"
-       test "$(DEB_TARGET_ARCH_ENDIAN)" = "$(TEST_DEB_TARGET_ARCH_ENDIAN)"
-       test "$(DEB_TARGET_ARCH_LIBC)" = "$(TEST_DEB_TARGET_ARCH_LIBC)"
-       test "$(DEB_TARGET_ARCH_OS)" = "$(TEST_DEB_TARGET_ARCH_OS)"
-       test "$(DEB_TARGET_GNU_CPU)" = "$(TEST_DEB_TARGET_GNU_CPU)"
-       test "$(DEB_TARGET_GNU_SYSTEM)" = "$(TEST_DEB_TARGET_GNU_SYSTEM)"
-       test "$(DEB_TARGET_GNU_TYPE)" = "$(TEST_DEB_TARGET_GNU_TYPE)"
-       test "$(DEB_TARGET_MULTIARCH)" = "$(TEST_DEB_TARGET_MULTIARCH)"
+vars := \
+  ARCH \
+  ARCH_ABI \
+  ARCH_BITS \
+  ARCH_CPU \
+  ARCH_ENDIAN \
+  ARCH_LIBC \
+  ARCH_OS \
+  GNU_CPU \
+  GNU_SYSTEM \
+  GNU_TYPE \
+  MULTIARCH \
+  # EOL
+loop_targets := $(foreach machine,BUILD HOST TARGET,\
+                  $(foreach var,$(vars),DEB_$(machine)_$(var)))
+
+test: $(loop_targets)
+
+$(loop_targets):
+       test "$($@)" = "$(TEST_$@)"
diff --git a/scripts/t/mk/buildflags.mk b/scripts/t/mk/buildflags.mk
index 7cf798f73..3289a7557 100644
--- a/scripts/t/mk/buildflags.mk
+++ b/scripts/t/mk/buildflags.mk
@@ -6,24 +6,21 @@ TEST_CPPFLAGS_FOR_BUILD            += -DTEST_MK=test-build
 
 include $(srcdir)/mk/buildflags.mk
 
-test:
-       test "$(ASFLAGS)" = "$(TEST_ASFLAGS)"
-       test "$(ASFLAGS_FOR_BUILD)" = "$(TEST_ASFLAGS_FOR_BUILD)"
-       test "$(CFLAGS)" = "$(TEST_CFLAGS)"
-       test "$(CFLAGS_FOR_BUILD)" = "$(TEST_CFLAGS_FOR_BUILD)"
-       test "$(CPPFLAGS)" = "$(TEST_CPPFLAGS)"
-       test "$(CPPFLAGS_FOR_BUILD)" = "$(TEST_CXXFLAGS_FOR_BUILD)"
-       test "$(CXXFLAGS)" = "$(TEST_CXXFLAGS)"
-       test "$(CXXFLAGS_FOR_BUILD)" = "$(TEST_CXXFLAGS_FOR_BUILD)"
-       test "$(DFLAGS)" = "$(TEST_DFLAGS)"
-       test "$(DFLAGS_FOR_BUILD)" = "$(TEST_DFLAGS_FOR_BUILD)"
-       test "$(FCFLAGS)" = "$(TEST_FCFLAGS)"
-       test "$(FCFLAGS_FOR_BUILD)" = "$(TEST_FCFLAGS_FOR_BUILD)"
-       test "$(FFLAGS)" = "$(TEST_FFLAGS)"
-       test "$(FFLAGS_FOR_BUILD)" = "$(TEST_FFLAGS_FOR_BUILD)"
-       test "$(LDFLAGS)" = "$(TEST_LDFLAGS)"
-       test "$(LDFLAGS_FOR_BUILD)" = "$(TEST_LDFLAGS_FOR_BUILD)"
-       test "$(OBJCFLAGS)" = "$(TEST_OBJCFLAGS)"
-       test "$(OBJCFLAGS_FOR_BUILD)" = "$(TEST_OBJCFLAGS_FOR_BUILD)"
-       test "$(OBJCXXFLAGS)" = "$(TEST_OBJCXXFLAGS)"
-       test "$(OBJCXXFLAGS_FOR_BUILD)" = "$(TEST_OBJCXXFLAGS_FOR_BUILD)"
+vars := \
+  ASFLAGS \
+  CFLAGS \
+  CPPFLAGS \
+  CXXFLAGS \
+  DFLAGS \
+  FCFLAGS \
+  FFLAGS \
+  LDFLAGS \
+  OBJCFLAGS \
+  OBJCXXFLAGS \
+  # EOL
+loop_targets := $(vars) $(vars:=_FOR_BUILD)
+
+test: $(loop_targets)
+
+$(loop_targets):
+       test "$($@)" = "$(TEST_$@)"
diff --git a/scripts/t/mk/buildtools.mk b/scripts/t/mk/buildtools.mk
index 6c27c5cf2..c104ef62e 100644
--- a/scripts/t/mk/buildtools.mk
+++ b/scripts/t/mk/buildtools.mk
@@ -1,33 +1,25 @@
 include $(srcdir)/mk/buildtools.mk
 
-test:
-       test "$(AS)" = "$(TEST_AS)"
-       test "$(AS_FOR_BUILD)" = "$(TEST_AS_FOR_BUILD)"
-       test "$(CC)" = "$(TEST_CC)"
-       test "$(CC_FOR_BUILD)" = "$(TEST_CC_FOR_BUILD)"
-       test "$(CXX)" = "$(TEST_CXX)"
-       test "$(CXX_FOR_BUILD)" = "$(TEST_CXX_FOR_BUILD)"
-       test "$(OBJC)" = "$(TEST_OBJC)"
-       test "$(OBJC_FOR_BUILD)" = "$(TEST_OBJC_FOR_BUILD)"
-       test "$(OBJCXX)" = "$(TEST_OBJCXX)"
-       test "$(OBJCXX_FOR_BUILD)" = "$(TEST_OBJCXX_FOR_BUILD)"
-       test "$(F77)" = "$(TEST_F77)"
-       test "$(F77_FOR_BUILD)" = "$(TEST_F77_FOR_BUILD)"
-       test "$(FC)" = "$(TEST_FC)"
-       test "$(FC_FOR_BUILD)" = "$(TEST_FC_FOR_BUILD)"
-       test "$(LD)" = "$(TEST_LD)"
-       test "$(LD_FOR_BUILD)" = "$(TEST_LD_FOR_BUILD)"
-       test "$(STRIP)" = "$(TEST_STRIP)"
-       test "$(STRIP_FOR_BUILD)" = "$(TEST_STRIP_FOR_BUILD)"
-       test "$(OBJCOPY)" = "$(TEST_OBJCOPY)"
-       test "$(OBJCOPY_FOR_BUILD)" = "$(TEST_OBJCOPY_FOR_BUILD)"
-       test "$(OBJDUMP)" = "$(TEST_OBJDUMP)"
-       test "$(OBJDUMP_FOR_BUILD)" = "$(TEST_OBJDUMP_FOR_BUILD)"
-       test "$(NM)" = "$(TEST_NM)"
-       test "$(NM_FOR_BUILD)" = "$(TEST_NM_FOR_BUILD)"
-       test "$(AR)" = "$(TEST_AR)"
-       test "$(AR_FOR_BUILD)" = "$(TEST_AR_FOR_BUILD)"
-       test "$(RANLIB)" = "$(TEST_RANLIB)"
-       test "$(RANLIB_FOR_BUILD)" = "$(TEST_RANLIB_FOR_BUILD)"
-       test "$(PKG_CONFIG)" = "$(TEST_PKG_CONFIG)"
-       test "$(PKG_CONFIG_FOR_BUILD)" = "$(TEST_PKG_CONFIG_FOR_BUILD)"
+tools := \
+  AR \
+  AS \
+  CC \
+  CXX \
+  F77 \
+  FC \
+  LD \
+  NM \
+  OBJC \
+  OBJCOPY \
+  OBJCXX \
+  OBJDUMP \
+  PKG_CONFIG \
+  RANLIB \
+  STRIP \
+  # EOL
+loop_targets := $(tools) $(tools:=_FOR_BUILD)
+
+test: $(loop_targets)
+
+$(loop_targets):
+       test "$($@)" = "$(TEST_$@)"

-- 
Dpkg.Org's dpkg

Reply via email to