Re: [PATCH] Added a check to see if user is running lh_clean from a sane location (i.e. not config/)

2007-11-13 Thread Daniel Baumann
Trent W. Buck wrote: Probably these should be read dontcare and /bin/echo -e. yep, all fixed. thanks. -- Address:Daniel Baumann, Burgunderstrasse 3, CH-4562 Biberist Email: [EMAIL PROTECTED] Internet: http://people.panthera-systems.net/~daniel-baumann/

Re: [PATCH] Added a check to see if user is running lh_clean from a sane location (i.e. not config/)

2007-11-13 Thread Trent W. Buck
On Tue, Nov 13, 2007 at 09:00:46AM +0100, Daniel Baumann wrote: Trent W. Buck wrote: Probably these should be read dontcare and /bin/echo -e. yep, all fixed. thanks. If there isn't already one, perhaps this (checkbashisms) could form the basis of a regression `test' build target. This

Re: [PATCH] Added a check to see if user is running lh_clean from a sane location (i.e. not config/)

2007-11-13 Thread Daniel Baumann
Trent W. Buck wrote: If there isn't already one, perhaps this (checkbashisms) could form the basis of a regression `test' build target. This target could then be set up to run automatically when importing new changesets, to reduce the likelihood of accidentally commiting code with bashisms.

Re: [PATCH] Added a check to see if user is running lh_clean from a sane location (i.e. not config/)

2007-11-12 Thread Kai Hendry
also s/were/where I tried to avoid a bashism in my first git-patch there! == caught me Should I prepare a new patch in such screwup situations? Thanks, ___ debian-live-devel mailing list debian-live-devel@lists.alioth.debian.org

Re: [PATCH] Added a check to see if user is running lh_clean from a sane location (i.e. not config/)

2007-11-12 Thread Daniel Baumann
Justin Pryzby wrote: == is a bashism which is for regexes, for posix compatibility use just [ a = b ] ...and if there is the possibility to have a whitespace in it (which is possible in ${PWD}), use: [ a = b ]. commited a slightely changed version, thanks Kai. -- Address:Daniel