Re: Patch for PLink to build using gcc-4.7 - please confirm that it is correct

2012-04-23 Thread Shaun Jackman
Hi Andreas, I'd suggest using a scoped for loop rather than the original while loop. Cheers, Shaun On 2012-04-23, at 1:30 AM, Andreas Tille wrote: Hi Shaun, as you know the Debian Med team has packaged plink for Debian. Recently we received a bug report that the package does not build

Re: Patch for PLink to build using gcc-4.7 - please confirm that it is correct

2012-04-23 Thread Andreas Tille
Hi Shaun, On Mon, Apr 23, 2012 at 08:43:22AM -0700, Shaun Jackman wrote: I'd suggest using a scoped for loop rather than the original while loop. Hi guess for a C++ programmer this hint is perfectly simple to implement however, for me this does not ring a bell without a patch. Thanks for the

Re: Patch for PLink to build using gcc-4.7 - please confirm that it is correct

2012-04-23 Thread Shaun Jackman
No worries, Andreas. It's just a coding style suggestion. Your solution is perfectly fine. Cheers, Shaun On 23 April 2012 11:48, Andreas Tille ti...@debian.org wrote: Hi Shaun, On Mon, Apr 23, 2012 at 08:43:22AM -0700, Shaun Jackman wrote: I'd suggest using a scoped for loop rather than the