[Desktop-packages] [Bug 583797]

2019-01-31 Thread Gingerbread-man-2
*** Bug 1492598 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/583797 Title: "Warn on closing with multiple tabs open" not honored

[Desktop-packages] [Bug 583797] Re: "Warn on closing with multiple tabs open" not honored

2019-01-06 Thread Mathew Hodson
** Changed in: firefox (Ubuntu) Status: Invalid => Fix Released ** Bug watch removed: Mozilla Bugzilla #1515061 https://bugzilla.mozilla.org/show_bug.cgi?id=1515061 ** Bug watch removed: Mozdev Bugzilla #26384 https://www.mozdev.org/bugs/show_bug.cgi?id=26384 ** Bug watch removed:

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Ben-bucksch
Yay, thanks so much! -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/583797 Title: "Warn on closing with multiple tabs open" not honored Status in Mozilla Firefox: Fix Released

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Siddhartha Sahu
Hi. Does the fix not consider pinned tabs? I use multiple windows with many pinned tabs of websites I regularly use (mail, etc). Ctrl+Q only warns before quitting if there are at least 2 *unpinned* open tabs. Should it not consider pinned tabs in the count as well? I'm using FF Developer edition

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Amlee
Comment on attachment 9021147 Bug 550559 - also show close warnings when session restore is active, r?jaws Checked and looks good. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/583797

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Bugzilla-tf
*** Bug 1505729 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/583797 Title: "Warn on closing with multiple tabs open" not honored

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Liquido2
Thanks a lot for fixing this at last! I am gladly verifying that this is implemented in latest Nightly 65 on Linux (x86_64) Build ID20181205102000 User Agent Mozilla/5.0 (X11; Linux x86_64; rv:65.0) Gecko/20100101 Firefox/65.0 -- You received this bug notification because you are

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Rgurzau
https://hg.mozilla.org/mozilla-central/rev/fd42da5a8e1a -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/583797 Title: "Warn on closing with multiple tabs open" not honored Status in

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Mbeltzner
This still doesn't block; existed in 3.6, will continue to exist in 4.0. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/583797 Title: "Warn on closing with multiple tabs open" not

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Pascalc
Added to 65 nightly release notes with this wording: The "Warn you when quitting and closing multiple tabs" warning now applies to quitting Firefox with automatic session restore turned on We are keeping the 'relnote?' flag set as this is for now a nightly only note and the final wording may be

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Gijskruitbosch+bugs
(In reply to sh.siddhartha from comment #81) > Does the fix not consider pinned tabs? I use multiple windows with many > pinned tabs of websites I regularly use (mail, etc). Ctrl+Q only warns > before quitting if there are at least 2 *unpinned* open tabs. Should it not > consider pinned tabs in

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Amlee
(In reply to Amy Lee [:amylee] UX from comment #65) > Comment on attachment 9021147 > Bug 550559 - also show close warnings when session restore is active, r?jaws > > Hi, > > I installed the mac version and I don't see an update to about:preferences > under the Tabs section (“Warn you when

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Gijskruitbosch+bugs
Note: we're tweaking this in bug 1506173, so subject to change, but: Release Note Request (optional, but appreciated) [Why is this notable]: long-standing behavior changes subtly [Affects Firefox for Android]: no [Suggested wording]: The "You're closing multiple tabs" warning now applies to

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Pascalc
Gijs, could you request an addition to our release notes? Thanks! -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/583797 Title: "Warn on closing with multiple tabs open" not honored

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Siddhartha Sahu
Thanks for the reply. I opened https://bugzilla.mozilla.org/show_bug.cgi?id=1515061. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/583797 Title: "Warn on closing with multiple tabs

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Gijskruitbosch+bugs
Amy, have you had a chance to check the build again? These changes otherwise have r+ and are ready to land. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/583797 Title: "Warn on

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Gijskruitbosch+bugs
Created attachment 9021147 Bug 550559 - also show close warnings when session restore is active, r?jaws -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/583797 Title: "Warn on closing

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Mdeboer
I think :Gijs is a good mentor for this as well. I think we'd both happily take review and feedback requests! -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/583797 Title: "Warn on

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Gijskruitbosch+bugs
(In reply to Amy Lee [:amylee] UX from comment #65) > Comment on attachment 9021147 > Bug 550559 - also show close warnings when session restore is active, r?jaws > > Hi, > > I installed the mac version and I don't see an update to about:preferences > under the Tabs section (“Warn you when

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Gijskruitbosch+bugs
(In reply to Amy Lee [:amylee] UX from comment #69) > (In reply to :Gijs (he/him) from comment #68) > > (In reply to :Gijs (he/him) from comment #67) > > > (In reply to Amy Lee [:amylee] UX from comment #65) > > > > Comment on attachment 9021147 > > > > Bug 550559 - also show close warnings when

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Amlee
Created attachment 8995330 Preferences - Close Tab Warning.png Spec for Restore Previous Session Setting in Preferences -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/583797 Title:

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Linas-fi
Despite having browser.showQuitWarning and browser.warnOnQuit set to true (as well as browser.tabs.warnOnClose), pressing Ctrl+Q (or using File → Exit) closes the program with no confirmation. This is very annoying when you were using the browser and just intended to close a tab instead

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Jgilbert
I don't know. Matt? Can you route this to someone to provide direction towards a solution, or establish WONTFIX? -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/583797 Title: "Warn on

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Amlee
(In reply to :Gijs (Not available 3-19 Aug; he/him) from comment #48) > (In reply to Meridel from comment #46) > > Prefs copy looks good and hasn't changed from what we have currently. > > > > Edits to close warning dialogue: > > -Numbers less than ten should be spelled out. So if the user is

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Gijskruitbosch+bugs
(In reply to :Gijs (he/him) from comment #67) > (In reply to Amy Lee [:amylee] UX from comment #65) > > Comment on attachment 9021147 > > Bug 550559 - also show close warnings when session restore is active, r?jaws > > > > Hi, > > > > I installed the mac version and I don't see an update to

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Amlee
I've attached a spec for Preferences when Session Restore is Enabled and Disabled. The warning will not show up by default if Session Restore is enabled but I've added a pref that allows users to turn the warning message on when Session Restore is enabled if desired. NI Meridel to review the

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Limi-mozilla
Comment on attachment 594363 Don't disable warn-on-quit when session restore is enabled You probably want Gavin to review the code; +1 from a UI standpoint from me. If there's a tryserver build attached, I can help test and see if there are any edge cases, since I can't read the code changes that

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Gijskruitbosch+bugs
*** Bug 1025847 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/583797 Title: "Warn on closing with multiple tabs open" not honored

[Desktop-packages] [Bug 583797]

2019-01-02 Thread 2-gene
If you'd like to implement what Paul is talking about in Comment 38 you can do this : > The workaround that I've been using is to leave a tab pinned at all times > with code that uses the "onbeforeunload" javascript function. > >

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Pulsebot
Pushed by gijskruitbo...@gmail.com: https://hg.mozilla.org/integration/autoland/rev/fd42da5a8e1a also show close warnings when session restore is active, r=jaws,flod -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu.

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Rik
PS: are you sure this bug is the same that hide the dialog "Do you want Firefox to save your tabs for the next time it starts?"? Because I still see the question "You are about to close 2 tabs. Are you sure you want to continue?" but I don't see the other dialog that once allowed to save the

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Gijskruitbosch+bugs
(In reply to Meridel from comment #46) > Prefs copy looks good and hasn't changed from what we have currently. > > Edits to close warning dialogue: > -Numbers less than ten should be spelled out. So if the user is closing 2 - > 9 tabs, spell out the number of tabs. This is really annoying to

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Jgilbert
Created attachment 594216 Don't disable warn-on-quit when using session restore I'm not that comfortable with this part of the codebase, but this seems like a fairly trivial fix. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox

[Desktop-packages] [Bug 583797]

2019-01-02 Thread A-c-li
In fact, session restore won't do the user any good if Firefox is running in Private Browsing mode. So the assumption that the warning can be turned off if we do session restores is inherently flawed. -- You received this bug notification because you are a member of Desktop Packages, which is

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Amlee
Created attachment 8999195 Preferences - Close Tab Warning.png -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/583797 Title: "Warn on closing with multiple tabs open" not honored

[Desktop-packages] [Bug 583797]

2019-01-02 Thread M-wada-7
(In reply to Linas from comment #27) If Mac OS X, because bug 938303 is fixed now, Command+Q is killed by "other shortcut assignment to Quit Firefox by OS" from Firefox 32, as it was possible unill Firefox 2. So, Mac OS X/Firefox user can freely press Command+W pretty safely. User can press

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Linas-fi
Seems I don't have appropiate permissions. Someone able to do it may like to dupe here bug 565567, bug 633504, bug 691297 and bug 702478. Related but a bit different, there are also bug 298802 and bug 298803. -- You received this bug notification because you are a member of Desktop Packages,

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Amlee
Comment on attachment 9021147 Bug 550559 - also show close warnings when session restore is active, r?jaws Hi, I installed the mac version and I don't see an update to about:preferences under the Tabs section (“Warn you when quitting and closing multiple tabs”) -- You received this bug

[Desktop-packages] [Bug 583797]

2019-01-02 Thread skierpage
(In reply to Linas from comment #27) > Listed on bug 565567, there is > https://addons.mozilla.org/en-US/firefox/addon/always-ask/ as workaround. There's also https://addons.mozilla.org/en-US/firefox/addon/warn-before- quit/ , they both work for me in Firefox 41 on Ubuntu 15.04 I have

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Gavin Sharp
Comment on attachment 594363 Don't disable warn-on-quit when session restore is enabled I think Paul gets to handle this one, since he really loves quitting/prompting code. (I apologize for the unreasonable delay in getting to this) -- You received this bug notification because you are a

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Graham Perrin
For the Session Manager extension: Bug 26384 – Not compatible with firefox 57+? -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu.

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Amlee
(In reply to :Gijs (Not available 3-19 Aug; he/him) from comment #50) > (In reply to Amy Lee [:amylee] UX from comment #49) > > (In reply to :Gijs (Not available 3-19 Aug; he/him) from comment #48) > > > Second, users who are used to the current behavior with session restore > > > enabled (esp. on

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Gavin Sharp
I don't think we want to show a quit warning when we're restarting, e.g. for an extension install. I think that case is covered by browser.sessionstore.resume_session_once==true, which you're removing. -- You received this bug notification because you are a member of Desktop Packages, which is

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Paul-oshannessy
I think the keyboard stuff is relevant, but the dialog stuff less so. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/583797 Title: "Warn on closing with multiple tabs open" not

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Amlee
(In reply to :Gijs (he/him) from comment #68) > (In reply to :Gijs (he/him) from comment #67) > > (In reply to Amy Lee [:amylee] UX from comment #65) > > > Comment on attachment 9021147 > > > Bug 550559 - also show close warnings when session restore is active, > > > r?jaws > > > > > > Hi, > >

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Jakub-g-opensource
Let me add my two cents (scroll down for TLDR) (I'm a Windows user BTW). I'm very close to @Ian Stirling opinion from #comment 8. I want to have an option to *absolutely* ask on quit, whatever makes me do so (shortcut, click, menu item); isn't there any 'onbeforequit'-like hook in the codebase,

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Amlee
(In reply to :Gijs (he/him) from comment #59) > Amy, this bug is still assigned to you - is there more that needs to happen > design-wise or is this ready to be implemented? The design is ready to be implemented. Can you please reassign the bug to someone that implement? -- You received this

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Gijskruitbosch+bugs
Amy, this bug is still assigned to you - is there more that needs to happen design-wise or is this ready to be implemented? -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/583797 Title:

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Gijskruitbosch+bugs
Comment on attachment 9021147 Bug 550559 - also show close warnings when session restore is active, r?jaws (In reply to Amy Lee [:amylee] UX from comment #61) > (In reply to :Gijs (he/him) from comment #59) > > Amy, this bug is still assigned to you - is there more that needs to happen > >

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Gijskruitbosch+bugs
(In reply to Amy Lee [:amylee] UX from comment #49) > (In reply to :Gijs (Not available 3-19 Aug; he/him) from comment #48) > > Second, users who are used to the current behavior with session restore > > enabled (esp. on Windows, where mis-hitting ctrl-shift-q is also not a major > > concern) will

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Mozilla-org-8
Firefox warns on quit just fine if you have at least one active tab with an unsubmitted form. That dialog lets the user abort a quit. Could we use the same mechanism for this? -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Rik
How is it going? In the meantime I've installed an add on to restore tabs. :-( Hope this is not going to be passed into the standard version of FF, because at the moment the problem is only in the Developer Edition. -- You received this bug notification because you are a member of Desktop

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Rik
This bug is going to hit the standard edition... as soon as it become v63... and there is only 1 number left :-/ I think when the bug will hit the standard edition, support.mozilla.org will explode :-) -- You received this bug notification because you are a member of Desktop Packages, which is

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Gijskruitbosch+bugs
*** Bug 1499401 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/583797 Title: "Warn on closing with multiple tabs open" not honored

[Desktop-packages] [Bug 583797]

2019-01-02 Thread 9-wojtek
While the add-ons work, this should be build-in to in the browser as it's highly annoying! -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/583797 Title: "Warn on closing with multiple

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Mwalkington
@Gijs Okay, we can use the numerical version of numbers and NOT spell them out. **Confirm close** You are about to close 7 tabs. Are you sure you want to continue? Warn me when closing multiple tabs Cancel Close Tabs -- You received this bug notification because you are a member of Desktop

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Amlee
Great! Thanks Meridel. Can we reassign this bug to someone that can implement the changes? Currently this bug is assigned to me. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/583797

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Jakub-g-opensource
*in the previous post, it should be: 'Default Firefox behavior (*without* All-in-One Sidebar)' -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/583797 Title: "Warn on closing with

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Amlee
After going through the thread and related bugs, it seems to make sense to have a confirmation dialogue when quitting the browser. Also it looks like a confirmation dialogue does appear in Windows/Linux when "closing" multiple tabs and not when "quitting" which is confusing. There is no

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Amlee
Created attachment 8989553 Linux_Windows_Close.png Reference for above comment -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/583797 Title: "Warn on closing with multiple tabs open"

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Mwalkington
Prefs copy looks good and hasn't changed from what we have currently. Edits to close warning dialogue: -Numbers less than ten should be spelled out. So if the user is closing 2 - 9 tabs, spell out the number of tabs. -Button copy should be capitalized -The checkbox string should be in second

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Beneficentone
(In reply to Ambrose Li from comment #31) > In fact, session restore won't do the user any good if Firefox is running in > Private Browsing mode. So the assumption that the warning can be turned off > if we do session restores is inherently flawed. Yes, that's true. And Private Browsing mode is

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Yumekui Neru
why is this taking a decade to fix? -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/583797 Title: "Warn on closing with multiple tabs open" not honored Status in Mozilla Firefox:

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Paul-oshannessy
Created attachment 621206 WIP for keyboard quit This just adds a notification for when we quit via the keyboard. This could be used to popup a new window & presumably spin the event loop or something. We can't quite do what (for example) Chrome is doing and capture everything down in Cocoa-land

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Mjd+mozilla-org
(In reply to wojtek from comment #34) > this should be build-in to in the browser as it's highly annoying! Stopped using Firefox, moved to Chromium. That this issue should go nowhere for 6½ years was one issue of many behind my reason to switch. -- You received this bug notification because

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Amlee
To clarify this confirmation should exist when quitting the browser in all menus (not only when using shortcut keys) -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/583797 Title:

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Gijskruitbosch+bugs
*** Bug 502908 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/583797 Title: "Warn on closing with multiple tabs open" not honored

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Mbeltzner
This still relevant now that we've changed the quit dialog to be ... not so much there ...? -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/583797 Title: "Warn on closing with

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Paul-oshannessy
Comment on attachment 594363 Don't disable warn-on-quit when session restore is enabled Review of attachment 594363: - Sorry for the delay. I've had this on my mind for a while though. My main problem here is that this doesn't

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Mars-martian+bugmail
Limi: should we also change the behaviour in Private Browsing Mode? Currently if you cmd+Q while in PBM, no quit dialog is ever shown. Based on http://blog.mozilla.com/metrics/2010/08/23/understanding-private-browsing/ it doesn't seem like the user would be losing much data if we preserved the

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Mozbugz-z
(In reply to comment #14) > " Quitting the application by using the menu or using the window close button > (Windows & Linux only) will not trigger any warning." > > Absolute. garbage. > > This has made FF4 unusable for me. This bug is not about the feature change. Your looking for bug

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Jgilbert
Comment on attachment 594216 Don't disable warn-on-quit when using session restore This seems fairly simple, but I can currently only test on Windows. The concerned platforms for this bug (IIRC) are mac and linux, so those need a brief test. Try push at:

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Jgilbert
Huh, I guess I hadn't CC'd myself here. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/583797 Title: "Warn on closing with multiple tabs open" not honored Status in Mozilla Firefox:

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Mickrussom
" Quitting the application by using the menu or using the window close button (Windows & Linux only) will not trigger any warning." Absolute. garbage. This has made FF4 unusable for me. Good luck keeping up with the competition by de-feature-izing this browser into yet another Chrome clone. At

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Jgilbert
Created attachment 594363 Don't disable warn-on-quit when session restore is enabled Thanks Gavin. That looks like the case. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/583797

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Bugzilla-mauve
It existed in 3.6, yes. But for users who are trying migrating from multiple windows to tab groups, it will hit for the first time (as it did for me) -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu.

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Limi-mozilla
Refining title, Ctrl-Q is present on Mac, Cmd-Q on OS X. As far as I know, Ctrl-Q doesn't work on Windows, so it's not a problem there. Alt-F4 closes a window on Windows, so it's not going to be accidentally triggered when closing a tab (Ctrl-W) — so we don't need to handle that in any way

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Limi-mozilla
This is especially noticable on a Mac since ⌘Q and ⌘W are right next to each other, but in general it violates the principle of least surprise: We currently ask when you quit your browser whether that's what you wanted to do, and give you an option to "never ask again". However, when turning on

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Limi-mozilla
OK, I guess I changed my mind slightly here after living with it for a while — I now think we should ask when trying to quit using the keyboard (still with the "Do not ask me again" shortcut, but not when quitting using the menu or (on Windows) the close button. -- You received this bug

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Limi-mozilla
Should probably be a softblocker if so. (Adding d? to get driver input, let me know if this isn't the way to go about this :) -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/583797

[Desktop-packages] [Bug 583797] Re: "Warn on closing with multiple tabs open" not honored

2019-01-02 Thread Bug Watch Updater
** Changed in: firefox Status: Invalid => Fix Released ** Bug watch added: Mozdev Bugzilla #26384 https://www.mozdev.org/bugs/show_bug.cgi?id=26384 ** Bug watch added: Mozilla Bugzilla #52821 https://bugzilla.mozilla.org/show_bug.cgi?id=52821 ** Bug watch added: Mozilla Bugzilla

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Chofmann
paul, can you also make a call here on difficulty of a possible fix. that would play into the possibility of this becoming a blocker. It needs to get out of the nomination queue, one way or the other. -- You received this bug notification because you are a member of Desktop Packages, which is

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Paul-oshannessy
My current guess is not easy. That's just going off what I remember when I looked into this briefly before. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/583797 Title: "Warn on

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Bugzilla-mauve
Echoing comment 3. (I'm on linux) On comment 4 - '* Quitting the application by using the menu or using the window close button (Windows & Linux only) will not trigger any warning. (Restoring your previous session should be even more discoverable once the new about:home design lands, which seems

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Limi-mozilla
To reduce confusion (people on IRC said it was still a bit unclear), here's what we're proposing: * On Mac & Linux, since they have the Cmd-Q shortcut to quit the browser, we want to warn users that they're about to close all their tabs (or quit) when they do it using the keyboard shortcut

[Desktop-packages] [Bug 583797]

2019-01-02 Thread Hskupin
With the removal of the Quit warning dialog on OS X this bug is kinda annoying because shortcuts to close tabs and the browser itself are directly beneath each other. It happens so often for me that I accidentally close the whole browser when I'm trying to close a tab. With a lot of tabs open it

[Desktop-packages] [Bug 583797] Re: "Warn on closing with multiple tabs open" not honored

2018-12-28 Thread Mathew Hodson
** Bug watch removed: github.com/nigelbabu/warn-before-quit/issues #16 https://github.com/nigelbabu/warn-before-quit/issues/16 ** Bug watch added: Mozilla Bugzilla #550559 https://bugzilla.mozilla.org/show_bug.cgi?id=550559 -- You received this bug notification because you are a member of

[Desktop-packages] [Bug 583797]

2018-12-14 Thread Shtetldik
I can confirm, that setting browser.sessionstore.warnOnQuit = true fixes this for me. The browser won't close down without a warning when hitting Ctrl+Q! Thanks for finally fixing it. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to

[Desktop-packages] [Bug 583797] Re: "Warn on closing with multiple tabs open" not honored

2018-12-12 Thread Bug Watch Updater
** Changed in: firefox Status: Confirmed => Invalid ** Bug watch added: github.com/nigelbabu/warn-before-quit/issues #16 https://github.com/nigelbabu/warn-before-quit/issues/16 -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to

[Desktop-packages] [Bug 583797] Re: "Warn on closing with multiple tabs open" not honored

2018-12-12 Thread Olivier Tilloy
Closing as invalid to reflect upstream bug report. ** Changed in: firefox (Ubuntu) Status: Triaged => Invalid -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/583797 Title:

[Desktop-packages] [Bug 583797]

2018-12-12 Thread Virtual-q
*** Bug 1378652 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/583797 Title: "Warn on closing with multiple tabs open" not honored

[Desktop-packages] [Bug 583797]

2018-12-12 Thread Andrew Travneff
Have all of this set to true and still no warning on quit by ctrl+q, Firefox 60.0.2 browser.warnOnRestart browser.warnOnQuit browser.tabs.warnOnOpen browser.tabs.warnOnCloseOtherTabs browser.tabs.warnOnClose browser.showQuitWarning "Warn you when closing multiple tabs" in preferences tab --

[Desktop-packages] [Bug 583797]

2018-12-12 Thread Plurtu
The fix for Bug 550559 did not end up resolving this issue, browser.warnOnQuit = true still does not work with browser.tabs.warnOnClose = false. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu.

[Desktop-packages] [Bug 583797]

2018-12-12 Thread Soupdragon90
Really? This bug is still present 8 years after I quit when it wasn't fixed? Why am I not surprised? Glad I switched but am tired of getting emails related to this bug. I thought I unsubbed to them all but I guess there's more. -- You received this bug notification because you are a member of

[Desktop-packages] [Bug 583797]

2018-12-12 Thread Grgoffe
Yumekui, You are the master! I look forward to testing this fix when it hits "production". THANKS for all your efforts, George... -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu.

[Desktop-packages] [Bug 583797]

2018-12-12 Thread Grgoffe
Hi, I reported this problem a few days ago. It appears on the released version AND the beta version of FF. I don't understand why it's still happening. I HAVE seen it work properly several times yet, here we are again with a failure. It usually happens when I'm in a hurry and hit the wrong key

[Desktop-packages] [Bug 583797]

2018-12-12 Thread Virtual-q
*** Bug 1138054 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/583797 Title: "Warn on closing with multiple tabs open" not honored

[Desktop-packages] [Bug 583797]

2018-12-12 Thread Yuri Khan
(In reply to YumekuiNeru from comment #57) > one of the mozilla maintainers would have to accept and/or apply the patch > first I guess You might want to identify the appropriate maintainer and tag them as a review request. Take the “hg log” for the file you touched, look for a name that is

[Desktop-packages] [Bug 583797]

2018-12-12 Thread Dolske
*** Bug 1397605 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/583797 Title: "Warn on closing with multiple tabs open" not honored

[Desktop-packages] [Bug 583797]

2018-12-12 Thread Gabe25
we need to save on close (In some cases, not always) We are not interested to turn in the options and each time select or deselect the option. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu.

  1   2   >