michaelandrepearce commented on a change in pull request #2490: V2 196
URL: https://github.com/apache/activemq-artemis/pull/2490#discussion_r246659197
##
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueConsumersImpl.java
##
@@
michaelandrepearce commented on a change in pull request #2490: V2 196
URL: https://github.com/apache/activemq-artemis/pull/2490#discussion_r246659197
##
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueConsumersImpl.java
##
@@
Hi,
Following this, the migration of all of our repositories started.
I will keep you posted soon.
Regards
JB
On 07/01/2019 20:54, Jean-Baptiste Onofré wrote:
> Hi,
>
> as mentioned in the other thread, and in order to give visibility to
> everyone, I would like to do the move to gitbox on
franz1981 commented on a change in pull request #2490: V2 196
URL: https://github.com/apache/activemq-artemis/pull/2490#discussion_r246646728
##
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueConsumersImpl.java
##
@@ -0,0 +1,124
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2494#discussion_r246602226
--- Diff:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/ConcurrentAppendOnlyChunkedList.java
---
@@ -0,0 +1,291
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2494#discussion_r246602031
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/LivePageCacheImpl.java
---
@@ -48,54 +82,228 @@
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2494#discussion_r246601217
--- Diff:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/ConcurrentAppendOnlyChunkedList.java
---
@@ -0,0
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2494#discussion_r246601169
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/LivePageCacheImpl.java
---
@@ -48,54 +82,228
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2494
Thanks for the review guys, without these comments I was lefting the work
really not as good as it could be :100:
Re the logic, please tell me if anything is unclear, not commented
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2494#discussion_r24662
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/LivePageCacheImpl.java
---
@@ -28,15 +28,49 @@
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2494#discussion_r246599701
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/LivePageCacheImpl.java
---
@@ -48,54 +82,228 @@
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2494#discussion_r246578304
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/LivePageCacheImpl.java
---
@@ -48,54
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2494#discussion_r246577156
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/LivePageCacheImpl.java
---
@@ -48,54
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r246574781
--- Diff:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/PriorityCollection.java
---
@@ -0,0 +1,319 @@
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2494#discussion_r246574775
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/LivePageCacheImpl.java
---
@@ -48,54 +82,228 @@
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2494#discussion_r246570552
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageSubscriptionImpl.java
---
@@ -864,21 +875,32 @@
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2494#discussion_r246570293
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageSubscriptionImpl.java
---
@@ -864,21
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2483
---
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2494#discussion_r246569626
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/LivePageCacheImpl.java
---
@@ -48,54 +82,228 @@
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2494#discussion_r246569523
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/LivePageCacheImpl.java
---
@@ -48,54
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2494#discussion_r246568743
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/LivePageCacheImpl.java
---
@@ -48,54
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2494#discussion_r246568579
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/LivePageCacheImpl.java
---
@@ -48,54
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2494#discussion_r246568552
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/LivePageCacheImpl.java
---
@@ -48,54 +82,228 @@
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2494#discussion_r246568367
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/LivePageCacheImpl.java
---
@@ -48,54 +82,228 @@
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2494#discussion_r246567995
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/LivePageCacheImpl.java
---
@@ -48,54
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2494#discussion_r246567905
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/LivePageCacheImpl.java
---
@@ -28,15 +28,49 @@
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2494#discussion_r246566042
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/LivePageCacheImpl.java
---
@@ -48,54
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2494#discussion_r246563763
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/LivePageCacheImpl.java
---
@@ -28,15
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2466#discussion_r246563323
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/mqtt/imported/MQTTQueueCleanTest.java
---
@@ -0,0
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2466#discussion_r246562512
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java
---
@@ -3604,4 +3605,14 @@ private
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2489
---
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2490
@franz1981 pushed following changes based on your comments that agree with,
for others i have left comment for us to discuss.
Changes:
1) Ensured total size of the
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2491
---
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2494#discussion_r246558406
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/LivePageCacheImpl.java
---
@@ -28,15 +28,49 @@
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r246558298
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueConsumersImpl.java
---
@@ -0,0 +1,124 @@
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r246557671
--- Diff:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/PriorityCollection.java
---
@@ -0,0 +1,319 @@
+/*
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2490
@gemmellr pushed changes based on latest comments, thanks.
---
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r246555304
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueConsumersImpl.java
---
@@ -0,0 +1,124 @@
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2492
---
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r246551345
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueConsumersImpl.java
---
@@ -0,0 +1,124 @@
+/*
I bet you have a service that interacts with a Journal, and where you
store, delete TX your messages into your broker.
I would put the journal a level upper on the implementation, and deal
directly with messages, and let Artemis deal with storage on paging
and journal.
I feel like doing what
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2492#discussion_r246538095
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageSubscriptionImpl.java
---
@@ -1315,9
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r246525755
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueConsumersImpl.java
---
@@ -0,0 +1,124 @@
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2490
@franz1981 good point around adding further tests to the extracted out
bits. Agree it will make everything more robust
---
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r246523218
--- Diff:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/MultiIterator.java
---
@@ -0,0 +1,78 @@
+/*
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2490
@gemmellr ok will reduce back down the extra tests i added. To those you
suggest.
Also re activemq5. Fair enough, ill reduce / alter this then.
---
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r246521520
--- Diff:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/MultiIterator.java
---
@@ -0,0 +1,78 @@
+/*
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r246520970
--- Diff:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/MultiResettableIterator.java
---
@@ -0,0 +1,44
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r246520411
--- Diff:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/PriorityCollection.java
---
@@ -0,0 +1,319 @@
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r246520138
--- Diff:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/PriorityCollection.java
---
@@ -0,0 +1,319 @@
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r246520110
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueConsumersImpl.java
---
@@ -0,0 +1,124 @@
+/*
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r246520121
--- Diff:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/PriorityCollection.java
---
@@ -0,0 +1,319 @@
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r246518747
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueConsumersImpl.java
---
@@ -0,0 +1,124 @@
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r246518669
--- Diff:
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r246518313
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueConsumersImpl.java
---
@@ -0,0 +1,124 @@
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r246516870
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueConsumersImpl.java
---
@@ -0,0 +1,124 @@
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r246516479
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueConsumersImpl.java
---
@@ -0,0 +1,124 @@
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r246515810
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
---
@@ -2409,14 +2410,10 @@
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r246515455
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
---
@@ -2497,45 +2484,36 @@
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r246513536
--- Diff:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/PriorityCollection.java
---
@@ -0,0 +1,319 @@
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2467
@michaelandrepearce / @franz1981 all done.
I squashed my commits. It was hard to keep them separated due to these
changes being inter-related.
---
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2480
@michaelandrepearce @clebertsuconic I have taken a better look to the code
and seems that `deliveringRefs` is being limited (if set) by both
`consumerWindowSize`and TCP-flow control
Thanks for clarification.
> Am 09.01.2019 um 18:18 schrieb Christopher Shannon
> :
>
> Messages are processed in order, selectors work by skipping over messages
> that a consumer can't consume. In fact this is a major issue with
> selectors and a consumer. If a consumer is online with a
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/commit/0f9bf15788096ad9dc795954174c3b496861932c#commitcomment-31886537
In
artemis-ra/src/main/java/org/apache/activemq/artemis/ra/inflow/ActiveMQMessageHandler.java:
In
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2494
Most of the benefits on memory footprint are already explained on
https://github.com/qihongxu/activemq-artemis/pull/1, while about the contention
I have already built several contention
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2485
@onlyMIT, I put the `getSessionState` method back onto #2491, but #2466
will still have conflicts which you'll need to resolve once the merge on #2491
is done.
---
Messages are processed in order, selectors work by skipping over messages
that a consumer can't consume. In fact this is a major issue with
selectors and a consumer. If a consumer is online with a selector and all
of the paged in messages into memory don't match that selector then that
consumer
I meant to add to my previous response that if a consumer with a selector
is stuck because no paged in messages match that selector then the only way
for that consumer to get more messages is if other consumers come online
and process those messages that are paged in. At that point more messages
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2479
@michaelandrepearce @clebertsuconic I have added some unit tests quite
strict, given that these classes are used almost everywhere :+1:
---
Github user onlyMIT commented on the issue:
https://github.com/apache/activemq-artemis/pull/2485
@jbertram OKï¼I will close this RPãThere is a small suggestion, can you
keep the "getSessionState" methodï¼because the RP #2466 has used this methodã
In the case of not sure if
Github user onlyMIT closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2485
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2485
@onlyMIT, can you close this PR since #2491 is in good shape now?
---
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r246416127
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/AmqpReceiverPriorityTest.java
---
@@ -0,0
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r246398611
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/SessionCreateConsumerMessage.java
---
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r246403272
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/openwire/amq/QueueConsumerPriorityTest.java
---
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r246383235
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/SessionCreateConsumerMessage.java
---
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r246382311
--- Diff:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/PriorityCollection.java
---
@@ -0,0 +1,319 @@
+/*
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r246337126
--- Diff:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/PriorityCollection.java
---
@@ -0,0 +1,319 @@
+/*
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r246338675
--- Diff:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/PriorityCollection.java
---
@@ -0,0 +1,319 @@
+/*
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r246377289
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
---
@@ -2409,14 +2410,10 @@ private void
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r246374340
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueConsumersImpl.java
---
@@ -0,0 +1,124 @@
+/*
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r246313269
--- Diff:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/MultiIterator.java
---
@@ -0,0 +1,78 @@
+/*
+ *
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r246323500
--- Diff:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/MultiIterator.java
---
@@ -0,0 +1,78 @@
+/*
+ *
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r246375651
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueConsumersImpl.java
---
@@ -0,0 +1,124 @@
+/*
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r246323998
--- Diff:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/MultiResettableIterator.java
---
@@ -0,0 +1,44 @@
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r246376376
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueConsumersImpl.java
---
@@ -0,0 +1,124 @@
+/*
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r246323602
--- Diff:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/MultiIterator.java
---
@@ -0,0 +1,78 @@
+/*
+ *
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r246322551
--- Diff:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/MultiIterator.java
---
@@ -0,0 +1,78 @@
+/*
+ *
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r246344280
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/SessionCreateConsumerMessage.java
---
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r246377787
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
---
@@ -2497,45 +2484,36 @@ private void
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r246321398
--- Diff:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/MultiIterator.java
---
@@ -0,0 +1,78 @@
+/*
+ *
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r246376356
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueConsumersImpl.java
---
@@ -0,0 +1,124 @@
+/*
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r246323811
--- Diff:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/MultiResettableIterator.java
---
@@ -0,0 +1,44 @@
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r246376178
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueConsumersImpl.java
---
@@ -0,0 +1,124 @@
+/*
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2492
Point being if this is a bug, please can there be a test that exposes the
issues, so a) this can be reviewed b) we can validate the fix c) ensure there
is no regression.
---
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2445
Can we have some tests here please, a) to show the issue ensuring the fix
does fix it, and b) to ensure no regression.
---
> On 8. Jan 2019, at 19:32, Arthur Naseef wrote:
>
> With all of that said, I am curious to know what motivations exist to drive
> this request.
Well, this is the engine:
https://www.swiftmq.com/landing/streams/index.html
More details here:
Github user RaiSaurabh closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1793
---
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2494
@michaelandrepearce @wy96f @qihongxu Please review and test :+1:
---
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2494
The effects of the contention on `LivePageCacheImpl` are more visible after
applying https://github.com/apache/activemq-artemis/pull/2484
---
1 - 100 of 101 matches
Mail list logo
