Re: [DISCUSS] indexes for API calls

2024-05-31 Thread Vincent Beck
Interesting thread. I think what makes this discussion complex is that Airflow makes a lot of different queries (API, Scheduler, ...). I think it is even harder to keep track of all the different queries Airflow makes and thus, hard to figure if such index is needed. Also, Airflow evolves (and

Re: [VOTE] Airflow Providers prepared on May 26, 2024

2024-05-27 Thread Vincent Beck
+1 non binding. All AWS system tests are running successfully against apache-airflow-providers-amazon==8.23.0rc1. You can see the results here: https://aws-mwaa.github.io/#/open-source/system-tests/version/98c5a3a2c6d1df722d56bb3748dfbc810d5952aa_8.23.0rc1.html On 2024/05/27 14:01:48 Rahul Vats

Re: [VOTE] Airflow Providers prepared on May 12, 2024

2024-05-14 Thread Vincent Beck
+1 non binding. All AWS system tests are running fine against apache-airflow-providers-amazon==8.22.0rc1. You can see the results here: https://aws-mwaa.github.io/#/open-source/system-tests/version/1e4663f34c2fb42b87cf75e4776650620eb2baa4_8.22.0rc1.html On 2024/05/14 08:21:12 Phani Kumar wrote:

Re: [DISCUSS] simplifying try_number handling

2024-05-02 Thread Vincent Beck
I am all +1 on this one. This thing gave me headaches when working on AIP-44 and I could not understand the difference between the private "_try_number" and the public "try_number". Thanks for simplifying it! This is obviously assuming it does not break anything I am not aware of :) On

Re: [VOTE] Airflow Providers prepared on May 01, 2024

2024-05-01 Thread Vincent Beck
+1 non binding. All AWS system tests are working successfully against apache-airflow-providers-amazon==8.21.0rc1. You can see the results here: https://aws-mwaa.github.io/#/open-source/system-tests/version/fe4605a10e26f1b8a180979ba5765d1cb7fb0111_8.21.0rc1.html. The only failure

Re: [VOTE] AIP-67 Multi-team deployment of Airflow components

2024-04-18 Thread Vincent Beck
+1 binding On 2024/04/18 11:10:32 Jarek Potiuk wrote: > Hello here. > > I have not not heard a lot of feedback after my last update, so let me > start a vote, hoping that the last changes proposed addressed most of the > concerns. > > Just to recap. the proposal is here: >

Re: [VOTE] Airflow Providers prepared on April 10, 2024

2024-04-10 Thread Vincent Beck
+1 non binding. All AWS system tests are running successfully against apache-airflow-providers-amazon==8.20.0rc1 with the exception of example_bedrock that is failing due to a bug in the test itself (fix here: https://github.com/apache/airflow/pull/38887). You can see the results here:

Re: [ANNOUNCE] New committer: Wei Lee

2024-04-08 Thread Vincent Beck
Congrats Wei! Well deserved! On 2024/04/08 13:03:50 Hemkumar Chheda wrote: > Congratulations Wei! Best news ever 朗拾 > > > On 8 Apr 2024, at 6:10 PM, Bishundeo, Rajeshwar > > wrote: > > > > Congratulations Wei!! Good job and well deserved!! > > > > -- Rajesh > > > > > > > > > > > > > >

Re: [DISCUSS] Applying D105 rule for our codebase ("undocumented magic methods") ?

2024-03-20 Thread Vincent Beck
+1 for not enforcing as well. Let's leave to maintainers the flexibility to chose whether a given method should be documented. On 2024/03/20 08:28:51 Ash Berlin-Taylor wrote: > I'm for not enforcing this rule - as others have said its very unlikely to > result in more useful docs for

RE: [VOTE] AIP-59 Performance testing framework

2024-03-13 Thread Vincent Beck
+1 (binding) On 2024/03/13 10:26:31 "Scheffler Jens (XC-AS/EAE-ADA-T)" wrote: > +1 (binding) > > Mit freundlichen Grüßen / Best regards > > Jens Scheffler > > Alliance: Enabler - Tech Lead (XC-AS/EAE-ADA-T) > Robert Bosch GmbH | Hessbruehlstraße 21 | 70565 Stuttgart-Vaihingen | GERMANY > |

Re: [VOTE] Release Airflow 2.8.3 from 2.8.3rc1

2024-03-08 Thread Vincent Beck
+1 non binding. I check my change and it works as expected. I also ran few testing DAGs and they ran fine. On 2024/03/08 00:14:12 Jarek Potiuk wrote: > +1 (binding): checked reproducibility, sources, licences, checksums, > run a few dags, tested all my changes, all looks good. > > One caveat. I

Re: [VOTE] Airflow Providers prepared on March 04, 2024

2024-03-05 Thread Vincent Beck
+1 non binding. All AWS system tests are running successfully against apache-airflow-providers-amazon==8.19.0rc1. You can see the results here: https://aws-mwaa.github.io/#/open-source/system-tests/version/2852976ea6321b152ebc631d30d5526703bc6590_8.19.0rc1.html On 2024/03/04 21:34:04 Elad Kalif

Re: [VOTE] Release Airflow 2.8.2 from 2.8.2rc2

2024-02-23 Thread Vincent Beck
+1 non binding. I ran successfully my testing DAGs. On 2024/02/23 18:14:21 Elad Kalif wrote: > +1 (binding) > checked some of my dags. Looks good > > On Fri, Feb 23, 2024 at 6:25 PM Jarek Potiuk wrote: > > > +1 (binding) > > > > * Installed and ran it locally. Ran a few DAGs, inspected the

Re: [VOTE] Airflow Providers prepared on February 12, 2024

2024-02-13 Thread Vincent Beck
+1 non binding. All AWS system tests are working fine against 8.18.0rc1. You can the results here: https://aws-mwaa.github.io/#/open-source/system-tests/version/2e1561015c44a0acfd86b63360fc17ad477a8d3b_8.18.0rc1.html On 2024/02/13 05:08:17 Wei Lee wrote: > -1 (non-binding) for amazon:

Re: [DISCUSS] Rename channels on slack

2024-02-12 Thread Vincent Beck
l? Any > > > ideas? > > > > > > > > > > > > Why not just #first-pr > > > > > > > > > > > > Or maybe someone can propose a better name for #contributing that > > is > > > > less > > &g

Re: [DISCUSS] Rename channels on slack

2024-02-08 Thread Vincent Beck
S/EAE-ADA-T) > wrote: > > > I was +1 to Jarek first but reading the counter proposal from Vicent I > > change to +1 like Vincent proposes. Also not against Jarek but shorter is > > better. > > > > Sent from Outlook for iOS<https://aka.ms/o0ukef> &

Re: [DISCUSS] Rename channels on slack

2024-02-08 Thread Vincent Beck
I am +1 in renaming these channels because, as said, most of messages in @development are nothing to do there. Though, I would just rename #development to #contributing. To me, #troubleshooting is already a good name and clear. But this is only my personal opinion. I am not against the names

Re: [VOTE] New Airflow Community Provider: Teradata

2024-01-16 Thread Vincent Beck
+1 binding. Makes sense to me. On 2024/01/16 18:21:39 Jarek Potiuk wrote: > +1 binding > > On Tue, Jan 16, 2024 at 6:20 PM Phani Kumar > wrote: > > > +1 non binding > > > > On Tue, Jan 16, 2024 at 10:43 PM K Mallam, Sunil > > wrote: > > > > > Hello Airflow Community, > > > > > > Thank you

Re: [ANNOUNCE] New PMC member: Andrey Anshin (taragolis)

2024-01-15 Thread Vincent Beck
Congrats Andrey! On 2024/01/15 18:46:32 ambika garg wrote: > Congrats Andrey!! > > On Mon, Jan 15, 2024 at 1:44 PM Amogh Desai > wrote: > > > Congrats Andrey!! > > > > On Tue, 16 Jan 2024 at 12:08 AM, Hussein Awala wrote: > > > > > Congratulations Andrey, very well deserved! > > > > > > On

Re: [VOTE] Airflow Providers prepared on January 07, 2024

2024-01-08 Thread Vincent Beck
+1 non binding. All AWS system tests are running successfully against apache-airflow-providers-amazon==8.16.0rc1. You can see the results here: https://aws-mwaa.github.io/#/open-source/system-tests/version/3dc99d8a285aaadeb83797e691c9f6ec93ff9c93_8.16.0rc1.html On 2024/01/08 15:14:34 Amogh

Re: [DISCUSSION] Enabling `pre-commit.ci` application for Airflow

2024-01-02 Thread Vincent Beck
I like the concept! +1 On 2023/12/30 11:16:35 Amogh Desai wrote: > I am aligning here with Pierre, but I am not against the idea of enabling > the pre commit ci application. > > I’d rather have myself fix the issue as it sometimes also lets me have > second,third or multiple passes at my code

Re: [DISCUSS] "Require conversation resolution" in our PRs before merge?

2023-12-19 Thread Vincent Beck
I am wondering too if this is not something that gives more work to maintainer without real benefits. A maintainer can still mark all conversations as resolved and merge the PR if he wants. Though, I understand there is the intention here as oppose as today where a maintainer can just miss some

Re: Making Listeners API non-experimental

2023-12-15 Thread Vincent Beck
+1 On 2023/12/15 12:51:26 Jarek Potiuk wrote: > +1. ESPECIALLY if there will be issues found that we will fix in 2.8.x :D > > On Fri, Dec 15, 2023 at 1:47 PM Elad Kalif wrote: > > > If There were no issues discovered so far I am +1 in making it non > > experimental for 2.9 > > > > On Fri, Dec

Re: [ANNOUNCE] New committer: Utkarsh Sharma

2023-12-04 Thread Vincent Beck
Congrats! On 2023/12/04 16:43:09 Jarek Potiuk wrote: > Hello everyone, > > [filling-in for Kaxil who is less available nowadays and travelling without > much access to computer] > > The Project Management Committee (PMC) for Apache Airflow > has invited Utkarsh Sharma to become a committer and

Re: [DISCUSS] Capturing Architectural decisions (ADRS?)

2023-12-04 Thread Vincent Beck
I love this idea. I definitely think it can improve a lot the knowledge sharing across Airflow. Given the history and the number of components in Airflow, it is hard to keep up with everything, so having these ADRs would help a lot I think! On 2023/12/03 23:57:11 Jarek Potiuk wrote: > Hey

Re: [LAZY CONSENSUS] Add fab provider

2023-11-28 Thread Vincent Beck
As a result of the discussion and lazy consensus, I created the PR to create the new provider Fab and move the fab auth manager in it: https://github.com/apache/airflow/pull/35926 On 2023/11/22 00:40:08 Jarek Potiuk wrote: > Oh Fully. agre. It's a bit too late to do it for 2.8 :) . But yeah no

Re: [DISCUSS] Suspend/Remove Apache Scoop provider

2023-11-23 Thread Vincent Beck
+1 On 2023/11/23 13:08:09 Jarek Potiuk wrote: > +1 > > czw., 23 lis 2023, 12:39 użytkownik Aritra Basu > napisał: > > > +1 sounds like a good reason to suspend it and eventually remove it. > > > > -- > > Regards, > > Aritra Basu > > > > On Thu, Nov 23, 2023, 4:45 PM Bolke de Bruin wrote: > >

Re: [PrOPOSAL] Change default docker image to point to "latest supported"

2023-11-16 Thread Vincent Beck
I agree, by default we should use the latest python version. Like any package manager, if the user does not explicitly specify a version, the latest should be used. If the user wants to use a lower version, he can always pin it. On 2023/11/16 12:06:17 Jarek Potiuk wrote: > Hello everyone, > >

Re: [DISCUSS] Suspend (Remove?) Daskexecutor provider

2023-11-16 Thread Vincent Beck
+1 for removal On 2023/11/16 18:54:15 Jarek Potiuk wrote: > More detailed comparison: > > apache-airflow 2.7.* ~ 255.000 downloads/day > apache-aurflow-provider-dask-executor ~ 900/ day > > This means that *apache-airflow-providers-daskexecutor * is downloaded in > less of *0.3 %* cases,

Re: [VOTE] Airflow Providers prepared on November 08, 2023

2023-11-09 Thread Vincent Beck
+1 non binding. All AWS system tests ran successfully against apache-airflow-providers-amazon==8.11.0rc1. You can see the results here: https://aws-mwaa.github.io/#/open-source/system-tests/version/0d7fe471d428cd49b1eacaf84c8067796ca57fa7_8.11.0rc1.html On 2023/11/08 21:09:59 Elad Kalif wrote:

Re: [ANNOUNCE] New committer: Jens Scheffler

2023-11-07 Thread Vincent Beck
Welcome onboard Jens! On 2023/11/07 19:24:04 Jarek Potiuk wrote: > The Project Management Committee (PMC) for Apache Airflow > has invited Jens Scheffler to become a committer and we are pleased > to announce that they have accepted. > > Jens has been contributing for a number of months > he

Re: [VOTE] Airflow Providers prepared on October 28, 2023

2023-10-30 Thread Vincent Beck
+1 (non binding). All AWS system tests are working fine against apache-airflow-providers-amazon==8.10.0rc1. You can see the results here: https://aws-mwaa.github.io/#/open-source/system-tests/version/ba4b55a1941d886b752025d3fc89bf1e7902b262_8.10.0rc1.html On 2023/10/28 20:27:37 Jarek Potiuk

Re: [DISCUSS] Removing Qubole provider (and adding removal process)

2023-10-27 Thread Vincent Beck
I like that. I also think it is important to have a process to remove provider if needed. +1 On 2023/10/27 09:00:25 Jarek Potiuk wrote: > > I think in the case of Qubole it is pretty easy to remove it from the > provider codebase. I'm pretty sure that almost no one even noticed this > removal. >

Re: [VOTE] Add providers for Pinecone, OpenAI & Cohere to enable first-class LLMOps

2023-10-25 Thread Vincent Beck
+1 binding On 2023/10/25 13:32:49 Pierre Jeambrun wrote: > +1 (binding) > > Le mer. 25 oct. 2023 à 13:29, Pankaj Singh a > écrit : > > > +1 (binding) > > > > On Wed, Oct 25, 2023 at 4:52 PM Amogh Desai > > wrote: > > > > > +1 (binding) > > > > > > On Wed, Oct 25, 2023 at 4:41 PM Phani Kumar >

Re: [PROPOSAL] (likely) significantly shorten CI test time: splitting to db/non-db tests

2023-10-24 Thread Vincent Beck
+1 I like this one. I think it is totally worth it adding this decorator, mostly because I think the effort is not huge. I also think, as a contributor, it is a good exercise to, when writing tests, figure out whether the tests I am writing is using the DB. On 2023/10/24 16:31:57 Jarek Potiuk

Re: [VOTE] Airflow Providers prepared on October 13, 2023

2023-10-16 Thread Vincent Beck
+1 non binding. I successfully ran testing DAGs against Amazon provider package. I also ran all system tests within the Amazon provider package against this RC. They all succeeded. You can see the results here:

Re: [ANNOUNCE] Pankaj Koti and Amogh Desai as committers

2023-09-21 Thread Vincent Beck
Congrats to both of you!! On 2023/09/21 05:43:40 Bowrna Prabhakaran wrote: > Congratulations Amogh and Pankaj :) Well deserved :) > > On Wed, Sep 20, 2023 at 9:21 AM Dev FizzBuzz wrote: > > > Congrats guys!! We'll deserved. > > > > On Wed, 20 Sept, 2023, 9:12 am Rohith Sharma K S, < > >

Re: [VOTE] Airflow Providers prepared on September 08, 2023

2023-09-08 Thread Vincent Beck
+1 (non-binding) I tested successfully the Amazon provider package by running some testing DAGs and it looks good. On 2023/09/08 15:55:38 Elad Kalif wrote: > Hey all, > > I have just cut the new wave Airflow Providers packages. This email is > calling a vote on the release, > which will last

Re: [DISCUSS] Executors docs should be published in Airflow core or providers?

2023-09-08 Thread Vincent Beck
+1 On 2023/09/08 16:24:10 "Ferruzzi, Dennis" wrote: > I like it. > > > - ferruzzi > > > > From: Jarek Potiuk > Sent: Friday, September 8, 2023 9:19 AM > To: dev@airflow.apache.org > Subject: RE: [EXTERNAL] [COURRIEL EXTERNE] [DISCUSS] Executors docs should

Re: [VOTE] Airflow Providers prepared on August 26, 2023

2023-08-28 Thread Vincent Beck
+1 non binding. I tested my changes and it works as expected. I also run som testing DAGs and everything looks good. I ran AWS system tests against Amazon provider package 8.6.0rc1 and they all succeeded. You can see the results here:

Re: [VOTE] Drop MsSQL as supported backend

2023-08-28 Thread Vincent Beck
+1 binding On 2023/08/28 07:55:17 Jarek Potiuk wrote: > (just add that my voice is binding :) ) > > On Mon, Aug 28, 2023 at 9:35 AM Amogh Desai > wrote: > > > +1 non binding > > Based on previous discussions. > > > > Thanks & Best Regards, > > Amogh Desai > > > > On Mon, Aug 28, 2023, 13:03

Re: [VOTE] Release Airflow 2.7.0 from 2.7.0rc1

2023-08-11 Thread Vincent Beck
+1 non-binding. I ran successfully Airflow using Breeze. I ran several testing DAGs using primarily Amazon provider package. On 2023/08/11 14:26:39 Pankaj Koti wrote: > +1 (non-binding) > > Ran the RC with breeze, ran some example DAGs. Tested my change in #32052, > works as expected > We also

Re: [VOTE] Airflow Providers prepared on August 11, 2023

2023-08-11 Thread Vincent Beck
+1 non-binding. I tested successfully the Amazon provider package using my testing DAGs. I also tested my changes and it looks good. On 2023/08/11 12:29:48 Utkarsh Sharma wrote: > +1 non-biding > > Thanks, > Utkarsh > > > On Fri, Aug 11, 2023 at 5:48 PM Pankaj Koti > wrote: > > > > +1

Re: [VOTE] Airflow Providers prepared on August 05, 2023

2023-08-07 Thread Vincent Beck
+1 non binding. I tested the Amazon provider package by running successfully my testing DAGs On 2023/08/07 13:09:13 Amogh Desai wrote: > +1 non binding > Tested a few example DAGs - mostly on CNCF providers. Works as expected. > > Thanks & Regards, > Amogh Desai > > On Mon, Aug 7, 2023 at 4:34 

Re: [VOTE] Airflow Providers prepared on July 09, 2023

2023-07-10 Thread Vincent Beck
+1 (non-binding). I ran successfully my testing DAGs from Amazon provider package On 2023/07/10 10:17:29 Jarek Potiuk wrote: > +1 (binding) - Checked signatures, licences, checksums, compared the > sources with the ones in the repository (both in whl and sdist). > > On Mon, Jul 10, 2023 at 9:28 

Re: [VOTE] Airflow Providers prepared on July 06, 2023

2023-07-07 Thread Vincent Beck
+1 (non binding) I tested the amazon provider package by running my testing dags On 2023/07/07 12:48:07 Pankaj Koti wrote: > *Change of vote: +1 (non-binding)* > Since ES RC is being excluded I have no other reservations. > Thank you Elad for all the efforts! > > Regards, > > > > Pankaj Koti

Re: [ANNOUNCE] New committer: Dennis Ferruzzi

2023-07-04 Thread Vincent Beck
Congrats!! On 2023/07/04 17:19:15 Hussein Awala wrote: > Congratulations Dennis  > > On Tue 4 Jul 2023 at 19:17, Jarek Potiuk wrote: > > > Hello Everyone: > > > > I am happy to announce that the Project Management Committee (PMC) for > > Apache Airflow has invited Dennis Ferruzzi (Github: