Re: [VOTE] Move Apache Ambari to Attic

2022-01-10 Thread Nate Cole
+1 for moving Ambari to the attic. On Mon, Jan 10, 2022 at 1:37 PM Jayush Luniya wrote: > Hi all, > > Following the process outlined here, https://attic.apache.org/process.html > , > I'm calling a vote to move Apache Ambari to the Attic. Over the past 2 > years we were only able to make one

Re: [VOTE] Apache Ambari 2.7.3 RC2

2018-11-16 Thread Nate Cole
+1 for RC2 On 11/13/18, 1:33 PM, "Olivér Szabó" wrote: Hi All, I have created an apache-ambari-2.7.3 release candidate. (3rd RC) GIT source tag: (release-2.7.3-rc2) : https://github.com/apache/ambari/commits/release-2.7.3-rc2 Staging site:

Re: Ambari trunk Snapshot Versioning

2018-10-18 Thread Nate Cole
I agree that #2 is a good option. Version parsing is used in various places, so I think we should still use a number. It also makes it clearer to consumers of the spi to know where to pull in dependencies. -Nate On 10/17/18, 4:10 PM, "Jonathan Hurley" wrote: It looks like Ambari’s

Re: [VOTE] Apache Ambari 2.7.1 RC0

2018-08-23 Thread Nate Cole
+1 for rc0 On 8/21/18, 3:25 PM, "Olivér Szabó" wrote: Hi All, I have created an apache-ambari-2.7.1 release candidate. GIT source tag: (release-2.7.1-rc0) : https://github.com/apache/ambari/commits/release-2.7.1-rc0 Staging site:

Re: [VOTE] Apache Ambari 2.7.0 RC0

2018-07-10 Thread Nate Cole
+1 for rc0. Just one comment - since you used sha512 for hashing, we probably should use sha512 as the extension. I had a mismatch at first because I was checking against sha1, and had to actually open the file to figure that out. -Nate On 7/9/18, 11:30 PM, "Ishan Bhatt" wrote: Hi

Re: [VOTE] Apache Ambari 2.6.2 RC0

2018-04-27 Thread Nate Cole
+1 for 2.6.2. On 4/27/18, 1:01 AM, "Swapan Shridhar" wrote: Hi All, I have created an apache-ambari-2.6.2 release candidate. GIT source tag (release-2.6.2-rc0) : https://github.com/apache/ambari/commits/release-2.6.2-rc0 Staging site:

Re: pull requests without description

2018-04-16 Thread Nate Cole
+1 for this extra exception by Attila. On 4/11/18, 1:57 PM, "Attila Magyar" wrote: I agree, however I think there is one more exception, if the same patch should go into multiple branches, and one of them was already reviewed. On 4/11/18, 5:37 PM,

Re: how to exec shell script and output its log

2018-03-27 Thread Nate Cole
If your invoked script fails (in general, returns non-zero code) then you can raise an exception. That will get propagated to the backend as a failure. Thanks, Nate On 3/25/18, 9:32 PM, "Dai Xiang" wrote: On Fri, Mar 23, 2018 at 11:45:32AM -0400, Di Li wrote:

Re: trim Jenkins build logs

2018-03-09 Thread Nate Cole
Attila, I would also ask that you limit the packages that the weaver works on - like just the orm package. We shouldn't be doing the whole tree. On 3/8/18, 9:46 AM, "Doroszlai, Attila" wrote: Thanks, Yusaku. I have updated the Jenkins jobs with the

Re: New Branches Appearing

2018-03-06 Thread Nate Cole
I would say go ahead and remove them with no claims. On 3/5/18, 4:05 PM, "Jonathan Hurley" wrote: Anyone want to claim these branches? If not, I'd like to remove them. > On Feb 27, 2018, at 9:48 AM, Jonathan Hurley wrote: >

Re: [VOTE] add FreeBuilder to Ambari

2018-03-06 Thread Nate Cole
0 - I’m indifferent to this, but would like to understand the need. Is this to gain convenience for equals(), hashCode(), toString() and the like or does Ambari face a real problem that this is addressing? On 3/3/18, 7:17 AM, "Balazs Bence Sari" wrote: +1

Re: [VOTE] Remove Groovy Shell and Groovy Client Modules from Ambari

2018-03-01 Thread Nate Cole
+1 to remove On 2/26/18, 11:38 AM, "Robert Levas" wrote: Team… It appears that we have a few orphaned modules in the Ambari source code. I am currently concerned with the following modules: - Groovy Shell (ambari-shell/ambari-groovy-shell) [last

Re: IDE setup required on branch-feature-AMBARI-14714

2018-03-01 Thread Nate Cole
Was code generation discussed on an open thread? Will this make things even more difficult to contribute to Ambari? What boilerplate code are you referring and what is the precedent going forward? What should we boilerplating? Most developers won’t know or care unless forced to use it. On

Re: [DISCUSS] Splitting the repos - ambari-metrics and ambari-logsearch

2018-01-26 Thread Nate Cole
+1 On 1/26/18, 12:19 AM, "Siddharth Wagle" wrote: Hi devs, We had a brief discussion about the release management of Ambari w.r.t to the new work that is on-going with Mpacks and multi-services, amongst the developers working on the respective pieces.

Re: Removal of old/defunct branches

2018-01-24 Thread Nate Cole
+1 On 1/24/18, 1:59 PM, "Jonathan Hurley" wrote: Hi committers and contributors, Ambari seems to have a bunch of branches that are dead and don't seem to serve any useful purposes. These include: origin/AMBARI-12885 origin/trunk

Feature Branch Merging and PR

2018-01-18 Thread Nate Cole
What is the expected workflow when I need to merge from trunk to a feature branch to keep it up to date. - Do I use my own fork to merge trunk to feature, then create a PR? - Can I merge directly and push? - Other option? Thanks, Nate

New JIRA - Commit messages

2018-01-11 Thread Nate Cole
All, Previous to the fork/pull request framework, we used to use commit message variations like so: “AMBARI-XX. Great change for stack (ncole)”   (for committers) or “AMBARI-XX. Great change for stack (Joe Smith via ncole)”   (for contributors) Commits have

Re: [VOTE] Move ASF Github Bot comments to Worklog in JIRA

2018-01-09 Thread Nate Cole
+1 On 1/9/18, 11:56 AM, "Sandor Molnar" wrote: +1 I believe this is a really good idea. Sandor From: Vivek Ratnavel Reply-To: "dev@ambari.apache.org" Date: Tuesday, January 9, 2018

Re: [DISCUSS] Future code review and commit process

2018-01-04 Thread Nate Cole
Please also clarify the following scenario: I’m working on a fix for branch-2.6, and when I’m done, I need to merge to trunk. What is the flow? - Create a fork - Commit to branch-2.6 (on my fork) - Commit to trunk (on my fork) - Create pull request to bring changes to both branches? Or - Create

Re: [DISCUSS] Future code review and commit process

2018-01-04 Thread Nate Cole
We should make it very clear how these jira-feature-branches (“jira-branch”) are built. If you are working from a feature-branch (not trunk) then your jira-branch must come from that feature-branch. In addition, you cannot merge from trunk, bypassing your base feature-branch. When merging

Re: [VOTE] Migrate to gitbox

2017-12-11 Thread Nate Cole
+1 On 12/7/17, 6:48 PM, "Vivek Ratnavel" wrote: Hi all, I am starting this vote to migrate Apache Ambari project from git-wip repository to gitbox, which allows a deeper integration with github features. Moving to gitbox will allow committers to

Re: [VOTE] Apache Ambari 2.6.0 RC0

2017-10-24 Thread Nate Cole
+1 for RC0 On 10/23/17, 4:50 PM, "Swapan Shridhar" wrote: Hi All, I have created an apache-ambari-2.6.0 release candidate. GIT source tag (release-2.6.0-rc0)

Old Code Reviews

2017-10-10 Thread Nate Cole
All, Over the next couple of weeks I’ll be closing reviews that have been pushed. Some of these date over 3.5 years old! Please be aware, that if you see emails about reviews being submitted, that it’s not as if they were pushed recently, it’s just marking them as already submitted.

Re: [VOTE] Apache Ambari 2.5.2 RC1

2017-08-28 Thread Nate Cole
+1 for RC 1. On 8/28/17, 1:14 PM, "Mahadev Konar" wrote: +1 On 8/27/17, 9:18 AM, "Sumit Mohanty" wrote: Verified the release tag and tarball content. Verified the signature and hashes.

Re: [VOTE] Apache Ambari 2.5.1 RC0

2017-05-23 Thread Nate Cole
+1 for rc0 On 5/22/17, 2:54 PM, "Aravindan Vijayan" wrote: Hello all, I have created an apache-ambari-2.5.1 release candidate. GIT source tag (release-2.5.1-rc0)

Re: [VOTE] Apache Ambari 2.5.0 RC1

2017-03-27 Thread Nate Cole
+1 for RC1 On 3/23/17, 5:11 PM, "Aravindan Vijayan" wrote: Hello all, I have created an apache-ambari-2.5.0 release candidate. GIT source tag (release-2.5.0-rc1)

Re: Why RU doesn't run update Kerberos descriptors as the first step ?

2017-03-02 Thread Nate Cole
I don’t have specific details, but it was done likely to make sure the work happened before the core masters. Since for RU things are done in a rolling fashion, the descriptor change were made (largely) up front, and the services coming before it didn’t have any new descriptors to worry about.

Re: BIGTOP Stack

2017-03-01 Thread Nate Cole
Resend for visibility. BIGTOP stack will be removed in the next couple of weeks. Thanks, Nate From: Nate Cole <nc...@apache.org> Date: Tuesday, February 14, 2017 at 3:38 PM To: "u...@ambari.apache.org" <u...@ambari.apache.org>, "dev@ambari.apache.org" <dev

BIGTOP Stack

2017-02-14 Thread Nate Cole
All, In working on trunk, I noticed that changes are being backported to the BIGTOP stack in the source tree.  These changes appear to be changes to other stacks where a similar coding pattern is being followed in BIGTOP.  It is unclear if any of these changes are breaking the stack or not.

Re: [VOTE] Apache Ambari 2.4.2 RC1

2016-11-22 Thread Nate Cole
+1 On 11/19/16, 12:29 AM, "Jayush Luniya" wrote: Hello, I have created an apache-ambari-2.4.2 release candidate. GIT source tag (release-2.4.2-rc1)

Re: [VOTE] Apache Ambari 2.4.0 RC0

2016-08-24 Thread Nate Cole
+1 for RC0 On 8/22/16, 3:45 PM, "Jayush Luniya" wrote: Hello, I have created an apache-ambari-2.4.0 release candidate. GIT source tag (release-2.4.0-rc0)

Re: HDP upgrade failed on Finalize Upgrade Pre-Check using ambari.

2016-05-18 Thread Nate Cole
Continue the upgrade process with retry option. During the ambari-server restart, just want to confirm will I loose any information or ambari maintains all the state information in the table ? Thanks Anand On Wed, May 18, 2016 at 3:04 PM, Nate Cole <nc...@hortonworks.com<mailto:nc...@hortonwo

Re: HDP upgrade failed on Finalize Upgrade Pre-Check using ambari.

2016-05-18 Thread Nate Cole
Are all the services running on the correct version? If that is the case, you can set the actual version in the hostcomponentstate table. If you then restart Ambari, you should be able to retry the step and see if it succeeds. Thanks From: Anandha L Ranganathan

Re: [VOTE] Apache Ambari 2.2.2 RC1

2016-04-25 Thread Nate Cole
+1 for rc1 On 4/25/16, 8:37 PM, "Srimanth Gunturi" wrote: >Hello, > >I have created an ambari-2.2.2 release candidate RC1. > >GIT source tag (release-2.2.2-rc1) >https://git-wip-us.apache.org/repos/asf/ambari/repo?p=ambari.git;a=log;h=r >efs/tags/release-2.2.2-rc1 >

Re: [VOTE] Apache Ambari 2.2.2 RC0

2016-04-25 Thread Nate Cole
+1 for rc0 On 4/21/16, 11:28 PM, "Srimanth Gunturi" wrote: >Hello, > >I have created an ambari-2.2.2 release candidate. > >GIT source tag (release-2.2.2-rc0) >https://git-wip-us.apache.org/repos/asf/ambari/repo?p=ambari.git;a=log;h=r >efs/tags/release-2.2.2-rc0 >

New Concept: Version Definition File

2016-04-06 Thread Nate Cole
All, There has been steady work on a new concept in Ambari for 2.4.0 - the Version Definition File, or VDF. For some time, registering repositories for Rolling/Express upgrade involves specifying the version (by hand) and providing the base-urls for the repositories (by hand). This is not a

Re: Review Request 44178: Cluster Stack Version returning wrong state

2016-02-29 Thread Nate Cole
ed e-mail. To reply, visit: https://reviews.apache.org/r/44178/#review121296 --- On Feb. 29, 2016, 2:16 p.m., Nate Cole wrote: > > --- > This is an automatically

Review Request 44178: Cluster Stack Version returning wrong state

2016-02-29 Thread Nate Cole
/ClusterTest.java a89eb1b Diff: https://reviews.apache.org/r/44178/diff/ Testing --- Manual. Automated Pending. Thanks, Nate Cole

[jira] [Updated] (AMBARI-15231) Cluster Stack Version returning wrong state

2016-02-29 Thread Nate Cole (JIRA)
[ https://issues.apache.org/jira/browse/AMBARI-15231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nate Cole updated AMBARI-15231: --- Attachment: AMBARI-15231.patch > Cluster Stack Version returning wrong st

[jira] [Created] (AMBARI-15231) Cluster Stack Version returning wrong state

2016-02-29 Thread Nate Cole (JIRA)
Nate Cole created AMBARI-15231: -- Summary: Cluster Stack Version returning wrong state Key: AMBARI-15231 URL: https://issues.apache.org/jira/browse/AMBARI-15231 Project: Ambari Issue Type: Bug

[jira] [Resolved] (AMBARI-15196) Make PropertyProvider timeouts configurable and increase default values

2016-02-29 Thread Nate Cole (JIRA)
[ https://issues.apache.org/jira/browse/AMBARI-15196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nate Cole resolved AMBARI-15196. Resolution: Later Fix Version/s: (was: 2.2.2) > Make PropertyProvider timeo

Re: Review Request 44173: Atlas Integration : Atlas Server fails to properly start if Zookeeper isn't started first

2016-02-29 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44173/#review121291 --- Ship it! Ship It! - Nate Cole On Feb. 29, 2016, 11 a.m

Re: Review Request 44167: Express Upgrade config change files are in the wrong locations

2016-02-29 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44167/#review121290 --- Ship it! Ship It! - Nate Cole On Feb. 29, 2016, 8:09 a.m

Re: Review Request 43967: Express Upgrade Stuck At Manual Prompt Due To HRC Status Calculation Cache Problem

2016-02-29 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43967/#review121274 --- Ship it! Ship It! - Nate Cole On Feb. 29, 2016, 12:59 p.m

Re: Review Request 43944: AMBARI-15132 in upgrade.xml to support set/replace/transfer

2016-02-27 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43944/#review121089 --- Ship it! Ship It! - Nate Cole On Feb. 26, 2016, 5:28 p.m

Re: Review Request 43944: AMBARI-15132 in upgrade.xml to support set/replace/transfer

2016-02-26 Thread Nate Cole
531> remove commented dead-code - Nate Cole On Feb. 26, 2016, 4:47 p.m., Di Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 43967: Express Upgrade Stuck At Manual Prompt Due To HRC Status Calculation Cache Problem

2016-02-26 Thread Nate Cole
> On Feb. 26, 2016, 12:29 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/orm/AmbariJpaLocalTxnInterceptor.java, > > lines 284-287 > > <https://reviews.apache.org/r/43967/diff/5/?file=1272172#file1272172line284> > > > >

Re: Review Request 43967: Express Upgrade Stuck At Manual Prompt Due To HRC Status Calculation Cache Problem

2016-02-26 Thread Nate Cole
rceptor.java (lines 308 - 310) <https://reviews.apache.org/r/43967/#comment182419> If nested, will these unlock in the same order they were inserted? Maybe consider a LinkedHashSet to preserve it and iterate backwards such that you unlock the last one locked? - Nate Cole On Feb. 2

Re: Review Request 44066: Add pre-upgrade check that warns about components with VERSION_MISMATCH

2016-02-26 Thread Nate Cole
/ambari/server/checks/VersionMismatchCheck.java (line 65) <https://reviews.apache.org/r/44066/#comment182402> FailedOn should be a hostname. The fail message should contain the detail. - Nate Cole On Feb. 26, 2016, 10:30 a.m., Dmitro Lisnichenko

[jira] [Created] (AMBARI-15196) Make PropertyProvider timeouts configurable and increase default values

2016-02-25 Thread Nate Cole (JIRA)
Nate Cole created AMBARI-15196: -- Summary: Make PropertyProvider timeouts configurable and increase default values Key: AMBARI-15196 URL: https://issues.apache.org/jira/browse/AMBARI-15196 Project

Re: Review Request 43944: AMBARI-15132 in upgrade.xml to support set/replace/transfer

2016-02-25 Thread Nate Cole
<https://reviews.apache.org/r/43944/#comment182316> See above - Nate Cole On Feb. 25, 2016, 4:34 p.m., Di Li wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 43944: AMBARI-15132 in upgrade.xml to support set/replace/transfer

2016-02-25 Thread Nate Cole
/upgrade/ConfigUpgradeChangeDefinition.java (lines 445 - 460) <https://reviews.apache.org/r/43944/#comment182218> These properties can all be abstracted to Masked - Transfer and ConfigurationKeyValue ("set") already extend that. Also, probably want to remove from XM

Re: Review Request 43967: Express Upgrade Stuck At Manual Prompt Due To HRC Status Calculation Cache Problem

2016-02-25 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43967/#review120715 --- Ship it! Ship It! - Nate Cole On Feb. 25, 2016, 10:51 a.m

Re: Review Request 44006: column "upgrade_id" does not exist upgrading to Ambari 2.4.0

2016-02-25 Thread Nate Cole
/UpgradeCatalog240.java (lines 583 - 586) <https://reviews.apache.org/r/44006/#comment182170> I think you misunderstood my comment. You have to add desired_version for servicecomponentdesiredstate in this method. The upgrade_id column can go where it was - Nate Cole On Feb. 25, 2016,

Re: Review Request 44006: column "upgrade_id" does not exist upgrading to Ambari 2.4.0

2016-02-25 Thread Nate Cole
patch": clusters.upgrade_id servicecomponentdesiredstate.desired_version with default 'UNKNOWN'. There is already a method called updateServiceComponentDesiredStateTable() that it can go in. - Nate Cole On Feb. 25, 2016, 10:19 a.m., Dmitro Lisnich

Re: Review Request 43967: Express Upgrade Stuck At Manual Prompt Due To HRC Status Calculation Cache Problem

2016-02-24 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43967/#review120629 --- Ship it! Ship It! - Nate Cole On Feb. 24, 2016, 6:53 p.m

Re: Review Request 43946: VERSION_MISMATCH Doesn't Change Back When Component Is Corrected

2016-02-24 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43946/#review120518 --- Ship it! Ship It! - Nate Cole On Feb. 24, 2016, 10:56 a.m

Re: Review Request 43944: AMBARI-15132 in upgrade.xml to support set/replace/transfer

2016-02-24 Thread Nate Cole
should support conditional attributes. The already supports this (see HDP/2.3/config-upgrade.xml for dfs.namenode.rpc-address). should not be used - Nate Cole On Feb. 24, 2016, 8:54 a.m., Di Li wrote: > > --- > This is an auto

Re: Review Request 43743: AMBARI-13424. Allow disabling RU/EU PreChecks

2016-02-23 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43743/#review120427 --- Ship it! Much cleaner! - Nate Cole On Feb. 23, 2016, 7:56

Re: Review Request 43425: Component should support a desired version

2016-02-23 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43425/#review120312 --- Ship it! Ship It! - Nate Cole On Feb. 23, 2016, 9:14 a.m

Re: Review Request 43425: Component should support a desired version

2016-02-23 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43425/#review120308 --- Ship it! Ship It! - Nate Cole On Feb. 23, 2016, 5:46 a.m

Re: Review Request 43837: Create Component/Service Upgrade History On Finalize

2016-02-22 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43837/#review120160 --- Ship it! Ship It! - Nate Cole On Feb. 22, 2016, 11:10 a.m

Re: Review Request 43425: [preview] Component should support a desired version

2016-02-19 Thread Nate Cole
(line 180) <https://reviews.apache.org/r/43425/#comment181340> we need DEFAULT 'UNKNOWN' in the .sql files - Nate Cole On Feb. 19, 2016, 12:36 p.m., Dmitro Lisnichenko wrote: > > --- > This is an automatically generated e

Re: Review Request 43743: AMBARI-13424. Allow disabling RU/EU PreChecks

2016-02-19 Thread Nate Cole
-- > > (Updated Feb. 18, 2016, 6:10 p.m.) > > > Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Nate Cole, > Richard Zang, and Xi Wang. > > > Bugs: AMBARI-13424 > https://issues.apache.org/jira/browse/AMBARI-1342

Re: Review Request 43743: AMBARI-13424. Allow disabling RU/EU PreChecks

2016-02-19 Thread Nate Cole
ds to be documented, javadoc it (and the others too i suppose) - Nate Cole On Feb. 18, 2016, 6:10 p.m., Alejandro Fernandez wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Re: Review Request 43727: Patch Upgrade UpgradeCatalog Changes

2016-02-19 Thread Nate Cole
ed? I guess it must be working or someone would have complained. - Nate Cole On Feb. 19, 2016, 8:18 a.m., Jonathan Hurley wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

[jira] [Resolved] (AMBARI-15097) Remove targeted orchestration for patches

2016-02-19 Thread Nate Cole (JIRA)
[ https://issues.apache.org/jira/browse/AMBARI-15097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nate Cole resolved AMBARI-15097. Resolution: Fixed > Remove targeted orchestration for patc

Re: Review Request 43733: Remove targeted orchestration for patches

2016-02-18 Thread Nate Cole
] Thanks, Nate Cole

Re: Review Request 43733: Remove targeted orchestration for patches

2016-02-18 Thread Nate Cole
] [INFO] Total time: 33:05.125s [INFO] Finished at: Thu Feb 18 16:27:14 EST 2016 [INFO] Final Memory: 32M/658M [INFO] Thanks, Nate Cole

Re: Review Request 43425: [preview] Component should support a desired version

2016-02-18 Thread Nate Cole
apache.org/r/43425/#comment181072> not sure if NOT NULL is appropriate here. what happens with the new Ambari and this information isn't available? Comment applies to all these .sql files. - Nate Cole On Feb. 18, 2016,

Review Request 43733: Remove targeted orchestration for patches

2016-02-18 Thread Nate Cole
4ba5967 ambari-server/src/test/resources/version_definition_test_all_services.xml PRE-CREATION Diff: https://reviews.apache.org/r/43733/diff/ Testing --- Manual. Automated pending. Thanks, Nate Cole

[jira] [Created] (AMBARI-15097) Remove targeted orchestration for patches

2016-02-18 Thread Nate Cole (JIRA)
Nate Cole created AMBARI-15097: -- Summary: Remove targeted orchestration for patches Key: AMBARI-15097 URL: https://issues.apache.org/jira/browse/AMBARI-15097 Project: Ambari Issue Type: Task

Re: Review Request 43425: [preview] Component should support a desired version

2016-02-18 Thread Nate Cole
425/#comment180975> What is this? - Nate Cole On Feb. 18, 2016, 11:10 a.m., Dmitro Lisnichenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 43683: RU/EU from HDP 2.2 to 2.3 or 2.4 to remove deprecated kafka-broker port property

2016-02-17 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43683/#review119554 --- Ship it! Ship It! - Nate Cole On Feb. 17, 2016, 6:34 p.m

Re: Review Request 43609: Return privilege information with results from GroupResourceProvider

2016-02-17 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43609/#review119479 --- Ship it! Ship It! - Nate Cole On Feb. 17, 2016, 8:58 a.m

Re: Review Request 43254: [Patch upgrade ] Remove old unused component version/status staff

2016-02-17 Thread Nate Cole
this change any time soon. - Nate Cole On Feb. 5, 2016, 10:29 a.m., Dmitro Lisnichenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 43640: RU/EU can't start if hosts have name in MixedCASE in configs for NameNode, HBASE Master, ResourceManager

2016-02-17 Thread Nate Cole
/JmxQuery.java (lines 33 - 37) <https://reviews.apache.org/r/43640/#comment180843> A whole new class for one method? Could just change the methods from MasterHostResolver. You can even make the methods protected and extend it for mocking out test cases. - Nate Cole On Feb. 16, 2016, 7:

Re: Review Request 43605: Schema changes for component history

2016-02-16 Thread Nate Cole
/orm/entities/ServiceComponentHistoryEntity.java (line 153) <https://reviews.apache.org/r/43605/#comment180654> m_id.hashCode() ? I've come to find ObjectUtils.hashCode(Object) is a nice alternative - Nate Cole On Feb. 16, 2016, 10:56 a.m., Jonathan Hurley

Re: Review Request 43537: KerberosDescriptorTest failed due to moved/missing test directory

2016-02-16 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43537/#review119316 --- Ship it! Ship It! - Nate Cole On Feb. 12, 2016, 2:38 p.m

Re: Review Request 30862: AMBARI-9098 Cannot install new secure services to existing secure HDFS cluster

2016-02-12 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30862/#review119019 --- Please close this review: it's over a year old. - Nate Cole

Re: Review Request 42818: Register Version: add ability to load new version definition file

2016-02-12 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42818/#review119017 --- If this change is pushed, please close this review. - Nate Cole

Re: Review Request 41397: AMBARI-14383 Add support for Ranger TagSync process as a component under RANGER

2016-02-12 Thread Nate Cole
. You can abort the review if it's not going to happen. Thanks. - Nate Cole On Dec. 15, 2015, 11:46 a.m., Gautam Borad wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 41397: AMBARI-14383 Add support for Ranger TagSync process as a component under RANGER

2016-02-12 Thread Nate Cole
> On Feb. 12, 2016, 9:28 a.m., Nate Cole wrote: > > What's the status of this review? If it's pushed, please close. You can > > abort the review if it's not going to happen. Thanks. > > Velmurugan Periasamy wrote: > Most likely, tagsync will need to be

Re: Review Request 43425: [preview] Component should support a desired version

2016-02-11 Thread Nate Cole
bari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java (line 145) <https://reviews.apache.org/r/43425/#comment180171> Failed? - Nate Cole On Feb. 10, 2016, 1:55 p.m., Dmitro Lisnichenko wrote: > > ---

[jira] [Resolved] (AMBARI-14978) Create Upgrade Packs for Patch Upgrades

2016-02-11 Thread Nate Cole (JIRA)
[ https://issues.apache.org/jira/browse/AMBARI-14978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nate Cole resolved AMBARI-14978. Resolution: Fixed > Create Upgrade Packs for Patch Upgra

Re: Review Request 43501: RU/EU: Upgrading Oozie database fails since new configs are not yet written to /usr/hdp/current/oozie-server/conf

2016-02-11 Thread Nate Cole
/nonrolling-upgrade-2.3.xml (line 808) <https://reviews.apache.org/r/43501/#comment180238> No hosts="first" - Nate Cole On Feb. 11, 2016, 4:19 p.m., Alejandro Fernandez wrote: > > --- > This is an automatically g

Re: Review Request 43501: RU/EU: Upgrading Oozie database fails since new configs are not yet written to /usr/hdp/current/oozie-server/conf

2016-02-11 Thread Nate Cole
appropriate. - Nate Cole On Feb. 11, 2016, 4:19 p.m., Alejandro Fernandez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 43501: RU/EU: Upgrading Oozie database fails since new configs are not yet written to /usr/hdp/current/oozie-server/conf

2016-02-11 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43501/#review118928 --- Ship it! Ship It! - Nate Cole On Feb. 11, 2016, 4:19 p.m

Re: Review Request 43377: Create Upgrade Packs for Patch Upgrades

2016-02-10 Thread Nate Cole
istence of targeted services. If there are no targeted services, that means ALL services and regular RU/EU should be used. - Nate --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43

Re: Review Request 43377: Create Upgrade Packs for Patch Upgrades

2016-02-10 Thread Nate Cole
f null or empty, should raise exception. > > Nate Cole wrote: > Untrue. A repo_version without these elements is 1) backwards compatible > and 2) can be a STANDARD repository instead of a PATCH one. In addition, > we're checking for the existence of targeted services. If ther

Re: Review Request 43377: Create Upgrade Packs for Patch Upgrades

2016-02-10 Thread Nate Cole
t: https://reviews.apache.org/r/43377/#review118635 ------- On Feb. 9, 2016, 6:01 p.m., Nate Cole wrote: > > --- > This is an automatically generated e

Re: Review Request 43377: Create Upgrade Packs for Patch Upgrades

2016-02-10 Thread Nate Cole
generated e-mail. To reply, visit: https://reviews.apache.org/r/43377/#review118663 --- On Feb. 9, 2016, 6:01 p.m., Nate Cole wrote: > > --- > Thi

Re: Review Request 43377: Create Upgrade Packs for Patch Upgrades

2016-02-10 Thread Nate Cole
SUCCESS [INFO] [INFO] Total time: 33:52.026s [INFO] Finished at: Tue Feb 09 17:08:46 EST 2016 [INFO] Final Memory: 33M/677M [INFO] Thanks, Nate Cole

Re: Review Request 43360: Add PK to servicecomponentdesiredstate Table To Support FK Relationships

2016-02-09 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43360/#review118411 --- Ship it! Ship It! - Nate Cole On Feb. 9, 2016, 9:41 a.m

[jira] [Updated] (AMBARI-14978) Create Upgrade Packs for Patch Upgrades

2016-02-09 Thread Nate Cole (JIRA)
[ https://issues.apache.org/jira/browse/AMBARI-14978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nate Cole updated AMBARI-14978: --- Attachment: AMBARI-14978.patch > Create Upgrade Packs for Patch Upgra

Review Request 43377: Create Upgrade Packs for Patch Upgrades

2016-02-09 Thread Nate Cole
/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_partial.xml PRE-CREATION Diff: https://reviews.apache.org/r/43377/diff/ Testing --- Manual. Automated pending. Thanks, Nate Cole

[jira] [Created] (AMBARI-14978) Create Upgrade Packs for Patch Upgrades

2016-02-09 Thread Nate Cole (JIRA)
Nate Cole created AMBARI-14978: -- Summary: Create Upgrade Packs for Patch Upgrades Key: AMBARI-14978 URL: https://issues.apache.org/jira/browse/AMBARI-14978 Project: Ambari Issue Type: Task

Re: Review Request 43377: Create Upgrade Packs for Patch Upgrades

2016-02-09 Thread Nate Cole
] Thanks, Nate Cole

Re: Review Request 43277: EU: Oozie service check failed after downgrade with multiple Oozie servers since rerunning prepare-war removes webapps/oozie folder

2016-02-08 Thread Nate Cole
<https://reviews.apache.org/r/43277/#comment179455> Feels dangerous to rely on console output. Can check for file existence or something a bit more concrete here? - Nate Cole On Feb. 5, 2016, 7:34 p.m., Alejandro Fer

Re: Review Request 42610: MapReduce, Oozie service check failures after upgrade finished

2016-02-05 Thread Nate Cole
;, ") ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FixLzoCodecPath.java (lines 98 - 99) <https://reviews.apache.org/r/42610/#comment179307> Ouch. I hope this is tested. :) - Nate Co

  1   2   3   4   5   6   7   8   9   10   >