Re: Incomplete r1667900 -

On Wed, Mar 20, 2019 at 1:18 AM Yann Ylavic wrote: > > On Tue, Mar 19, 2019 at 5:34 PM William A Rowe Jr wrote: > > > > APR has a number of apr.h templates for non-./configure platforms. > > > > It looks like the introduction of timedlocks overlooks these, this needs to > > be fixed before

Re: Incomplete r1667900 -

On Tue, Mar 19, 2019 at 5:34 PM William A Rowe Jr wrote: > > APR has a number of apr.h templates for non-./configure platforms. > > It looks like the introduction of timedlocks overlooks these, this needs to > be fixed before 1.7.0 is tagged. > > Yann, would you like to fix? What is to fix

Re: Verifying printf() formatting of types

On Tue, Mar 19, 2019 at 6:35 PM Stefan Sperling wrote: > On Tue, Mar 19, 2019 at 02:09:51PM -0500, William A Rowe Jr wrote: > > I find no errors in our APR_TIME -> APR_INT64 determination, and > > made no such changes. > > > > But I note httpd 2.4.x commit r1824504 by Yann made a correction in >

Re: Verifying printf() formatting of types

On Tue, Mar 19, 2019 at 02:09:51PM -0500, William A Rowe Jr wrote: > I find no errors in our APR_TIME -> APR_INT64 determination, and > made no such changes. > > But I note httpd 2.4.x commit r1824504 by Yann made a correction in > this sphere. Are you testing the current code or an old 2.4

Re: Showstoppers to 1.7.0?

Yep, all good. Thx! > On Mar 19, 2019, at 3:12 PM, William A Rowe Jr wrote: > > On Tue, Mar 19, 2019 at 1:51 PM Jim Jagielski > wrote: > Under OSX/macOS, whether off_t and/or size_t are long long or long > depends on compile time and the actual platform being compiled

Re: Showstoppers to 1.7.0?

On Tue, Mar 19, 2019 at 1:51 PM Jim Jagielski wrote: > Under OSX/macOS, whether off_t and/or size_t are long long or long > depends on compile time and the actual platform being compiled for. > To have a universal *.h file, you need those checks for __LP64__ > that are determined during the

Re: Verifying printf() formatting of types

On Tue, Mar 19, 2019 at 5:18 AM Stefan Sperling wrote: > I don't believe your diff attempts to address this, but I am stilling > seeing a problem with APR_TIME_T_FMT when compiling httpd: > > proxy_util.c:3179: warning: format '%ld' expects type 'long int', but > argument 9 has type 'long long

Re: Showstoppers to 1.7.0?

Under OSX/macOS, whether off_t and/or size_t are long long or long depends on compile time and the actual platform being compiled for. To have a universal *.h file, you need those checks for __LP64__ that are determined during the build of whatever is *using* APR, and not so much during when APR

Re: Showstoppers to 1.7.0?

On Tue, Mar 19, 2019 at 12:58 PM Jim Jagielski wrote: > > Hi Bill, can you let me know what issues you saw? Last I checked, the > Darwin stuff in configure.in and apr.h.in hasn't been touched, nor an > issue, > in ages, except for the recent DARWIN pre-defined cpp macro hiccup. > Hi Jim - see

Re: Showstoppers to 1.7.0?

Hi Greg, On Tue, Mar 12, 2019 at 6:42 PM Gregg Smith wrote: > I finally got time to give this 1.7.0 a try and utterly failed :) > > r1839494 fixed a problem run into on VC when r1816608 added support for > IPv6 link-local address scope/zone mapping. r1839494 requires NT6. > > Our apr.hw is

Incomplete r1667900 -

APR has a number of apr.h templates for non-./configure platforms. It looks like the introduction of timedlocks overlooks these, this needs to be fixed before 1.7.0 is tagged. Yann, would you like to fix? Index: include/apr.hnw ===

Re: APR thread_mutex_cleanup on windows mishandles being called twice

On Tue, Mar 19, 2019 at 12:12 PM William A Rowe Jr wrote: > >>> >>> The proper reset value wouldn't be NULL but INVALID_HANDLE_VALUE, which >>> is defined like: >>> >>> >>> >>> #define INVALID_HANDLE_VALUE ((HANDLE)(LONG_PTR)-1) >>> >>> >>> Trying this again... we patch this; > > @@ -61,10

Re: APR thread_mutex_cleanup on windows mishandles being called twice

On Tue, Mar 19, 2019 at 12:10 PM William A Rowe Jr wrote: > On Tue, Mar 19, 2019 at 11:41 AM Michael Schlenker < > michael.schlen...@contact-software.com> wrote: > >> *Von:* William A Rowe Jr [mailto:wr...@rowe-clan.net] >> *Gesendet:* Dienstag, 19. März 2019 16:36 >> *An:* Michael Schlenker >>

Re: APR thread_mutex_cleanup on windows mishandles being called twice

On Tue, Mar 19, 2019 at 11:41 AM Michael Schlenker < michael.schlen...@contact-software.com> wrote: > *Von:* William A Rowe Jr [mailto:wr...@rowe-clan.net] > *Gesendet:* Dienstag, 19. März 2019 16:36 > *An:* Michael Schlenker > *Cc:* Stefan Sperling ; dev@apr.apache.org > *Betreff:* Re: APR

AW: APR thread_mutex_cleanup on windows mishandles being called twice

Von: William A Rowe Jr [mailto:wr...@rowe-clan.net] Gesendet: Dienstag, 19. März 2019 16:36 An: Michael Schlenker Cc: Stefan Sperling ; dev@apr.apache.org Betreff: Re: APR thread_mutex_cleanup on windows mishandles being called twice > > > > You're right that acting on a corrupt memory is bad. >

Re: APR thread_mutex_cleanup on windows mishandles being called twice

On Tue, Mar 19, 2019 at 10:01 AM Michael Schlenker < michael.schlen...@contact-software.com> wrote: > > > -Ursprüngliche Nachricht- > > Von: Stefan Sperling [mailto:s...@stsp.name] > > Gesendet: Dienstag, 19. März 2019 15:35 > > An: Michael Schlenker > > Cc: dev@apr.apache.org > >

AW: APR thread_mutex_cleanup on windows mishandles being called twice

> -Ursprüngliche Nachricht- > Von: Stefan Sperling [mailto:s...@stsp.name] > Gesendet: Dienstag, 19. März 2019 15:35 > An: Michael Schlenker > Cc: dev@apr.apache.org > Betreff: Re: APR thread_mutex_cleanup on windows mishandles being > called twice > > On Tue, Mar 19, 2019 at 11:12:25AM

Re: APR thread_mutex_cleanup on windows mishandles being called twice

On Tue, Mar 19, 2019 at 11:12:25AM +, Michael Schlenker wrote: > Hi, > > just filed https://bz.apache.org/bugzilla/show_bug.cgi?id=63271 > > (Patch attached) > > It seems to be the reason behind various crashes/restarts seen in Apache > httpd on Windows, especially when mod_cache_disk is

APR thread_mutex_cleanup on windows mishandles being called twice

Hi, just filed https://bz.apache.org/bugzilla/show_bug.cgi?id=63271 (Patch attached) It seems to be the reason behind various crashes/restarts seen in Apache httpd on Windows, especially when mod_cache_disk is in use. Basically when the mutex is cleaned up twice, it calls CloseHandle() on

Re: Verifying printf() formatting of types

On Mon, Mar 18, 2019 at 05:09:40PM -0500, William A Rowe Jr wrote: > Hi folks, > > please test the attached, it works for me on Fedora, but need to verify at > least BSD, Solaris, etc. mingw remains special-case so it shouldn't be > affected. This should force off_t_fmt to "ldd" in the cases