Re: [poll] Resolving readdir_r warning (Re: Showstoppers to 1.7.0?)

2019-03-29 Thread William A Rowe Jr
Sounds great, good observations. Absent any other opinions, with that resolved, I'm happy to tag and roll this afternoon to begin the release vote. On Fri, Mar 29, 2019, 04:26 Yann Ylavic wrote: > On Fri, Mar 29, 2019 at 5:01 AM William A Rowe Jr > wrote: > > > > Opinions? > > Anyway, our

Re: [poll] Resolving readdir_r warning (Re: Showstoppers to 1.7.0?)

2019-03-29 Thread Yann Ylavic
On Fri, Mar 29, 2019 at 5:01 AM William A Rowe Jr wrote: > > Opinions? Anyway, our usage of readdir_r() is no more thread-safe than with the non-_r() version, because of the (struct dirent *)thedir->entry we pass to it (should be either on the stack or allocated for each apr_dir_read() call), or