RE: Race condition in APR_DECLARE_LATE_DLL_FUNC() implementation

2013-12-11 Thread Bert Huijben
: RE: Race condition in APR_DECLARE_LATE_DLL_FUNC() implementation -Original Message- From: William A. Rowe Jr. [mailto:wr...@rowe-clan.net mailto:wr...@rowe-clan.net ] Sent: vrijdag 6 december 2013 18:24 To: Stefan Fuhrmann Cc: Bert Huijben; APR Developer List; Stefan Fuhrman

RE: Race condition in APR_DECLARE_LATE_DLL_FUNC() implementation

2013-12-07 Thread Bert Huijben
in APR_DECLARE_LATE_DLL_FUNC() implementation -Original Message- From: William A. Rowe Jr. [mailto:wr...@rowe-clan.net] Sent: vrijdag 6 december 2013 18:24 To: Stefan Fuhrmann Cc: Bert Huijben; APR Developer List; Stefan Fuhrman; Philip Martin; Subversion Development Subject: Re: Race condition

Re: Race condition in APR_DECLARE_LATE_DLL_FUNC() implementation

2013-12-07 Thread Daniel Lescohier
- From: Bert Huijben [mailto:b...@qqmail.nl] Sent: vrijdag 6 december 2013 19:14 To: 'William A. Rowe Jr.'; 'Stefan Fuhrmann' Cc: 'APR Developer List'; 'Stefan Fuhrman'; 'Philip Martin'; 'Subversion Development' Subject: RE: Race condition in APR_DECLARE_LATE_DLL_FUNC() implementation

Re: Race condition in APR_DECLARE_LATE_DLL_FUNC() implementation

2013-12-06 Thread William A. Rowe Jr.
On Fri, 6 Dec 2013 16:44:52 +0100 Stefan Fuhrmann stefan.fuhrm...@wandisco.com wrote: On Fri, Dec 6, 2013 at 6:05 AM, William A. Rowe Jr. wr...@rowe-clan.netwrote: On Thu, 5 Dec 2013 15:01:05 +0100 Bert Huijben b...@qqmail.nl wrote: I think the dll load function should be converted

RE: Race condition in APR_DECLARE_LATE_DLL_FUNC() implementation

2013-12-06 Thread Bert Huijben
-Original Message- From: William A. Rowe Jr. [mailto:wr...@rowe-clan.net] Sent: vrijdag 6 december 2013 18:24 To: Stefan Fuhrmann Cc: Bert Huijben; APR Developer List; Stefan Fuhrman; Philip Martin; Subversion Development Subject: Re: Race condition in APR_DECLARE_LATE_DLL_FUNC

Race condition in APR_DECLARE_LATE_DLL_FUNC() implementation

2013-12-05 Thread Bert Huijben
Hi, Someone in the Subversion team made our C tests run in parallel. With that our buildbot found a race condition in the Windows specific APR_DECLARE_LATE_DLL_FUNC() implementation. The current code is [[ #define APR_DECLARE_LATE_DLL_FUNC(lib, rettype, calltype, fn, ord, args, names) \

Re: Race condition in APR_DECLARE_LATE_DLL_FUNC() implementation

2013-12-05 Thread William A. Rowe Jr.
On Thu, 5 Dec 2013 15:01:05 +0100 Bert Huijben b...@qqmail.nl wrote: I think the dll load function should be converted to a more stable pattern, that properly handles multiple threads. And perhaps we should just assume a few more NT functions to be alsways there instead of loading them