Re: cvs access for httpd group

2000-12-01 Thread Roy T. Fielding
That should read: $ cvs -d :pserver:[EMAIL PROTECTED]:/home/cvspublic co apr That doesn't work with autocheckout of modules in subdirectories. The same problem would occur if you try and checkouit Xalan sources or whatever. Non-members simpy use the anonymous pserver. There is no

Re: cvs access for httpd group

2000-12-01 Thread Roy T. Fielding
That should read: $ cvs -d :pserver:[EMAIL PROTECTED]:/home/cvspublic co apr That doesn't work with autocheckout of modules in subdirectories. Um... so why has it been working for us in Subversion for the past five months? Because you aren't using autocheckout in Subversion.

Re: cvs access for httpd group

2000-12-04 Thread Roy T. Fielding
In Subversion, our analogue to buildconf checks for the foreign-project subdirectories. If they aren't there, an error message is printed out describing where/how to get that subdir and install it. If the auto-checkout modules thing doesn't work, then we can always have buildconf check for

Re: cvs commit: apr-util Makefile.in

2000-12-05 Thread Roy T. Fielding
WHAT!?!?!?! Distclean is meant to bring us back to what we had when we did a cvs checkout. If you just want to clean your directory use make clean, not make distclean. This is the exact same syntax and rules that Apache and APR have always used. AFAIK, this is basically a standard and we

Re: cvs commit: apr/include apr_general.h

2001-01-02 Thread Roy T. Fielding
Then write apr_file_get_pool(). Not a cast and an assumption. That also means that we have to write apr_socket_get_pool and apr_lock_get_pool and apr_mmap_get_pool, etc. Yup. That is ugly and just plain wrong. It is also standard design practice for use of incomplete types.

Re: cvs commit: apr/tables apr_tables.c

2001-01-21 Thread Roy T. Fielding
Greg did the right thing -- binary tables were obsoleted by the hash implemenation, and they need to be removed now so that they don't become yet another feature bloat that people insist on having around forever for backwards compatibility. Assuming that the table is ordered is forbidden by the

Re: [PATCH] allocate properly-sized buffer for header

2001-01-25 Thread Roy T. Fielding
Can you put in words and some simple examples what's wrong with the API? The problem is that it is impossible to do a lot of small writes to a brigade efficiently. Take as an example, code that needs to add 20 five byte buffers to brigade. There are two options: 1) bigbuff =

Re: [PATCH] allocate properly-sized buffer for header

2001-01-25 Thread Roy T. Fielding
Why write to the brigade instead of the top filter? Because we aren't always writing to the top filter. Sometimes, we are writing to a lower filter. This is the problem with current implementation. I meant the top from the perspective of the writer (i.e., a lower filter only knows about

Re: cvs commit: apr/include apr_xlate.h

2001-01-29 Thread Roy T. Fielding
That's a real PITA. How exactly are we supposed to handle platforms this? Linux is getting warnings right now, which I dislike. I am developing on Linux (RedHat 7) and was getting warnings with the old code. I don't know why you are getting warnings from the explicit cast. Are you using an

Re: cvs commit: apr CHANGES configure.in

2001-01-29 Thread Roy T. Fielding
Sure it can support multiple flags. If I do: ./configure --with-optim=-O2 -O2 It will work... Hmmm... it wasn't working for me -- something was stripping the double-quotes off the comand-line arguments, such that the command-line could not be reconstructed faithfully, and thus config.nice

build blues

2001-01-29 Thread Roy T. Fielding
I am getting really frustrated by the build system (again). I don't understand why it is so complicated, and I'm afraid that if I try to simplify it the whole thing will fall apart. This isn't because of autoconf -- I've seen far more complex packages use autoconf without any of these

Re: [PATCH] a somewhat different approach to the iconv() issue

2001-02-08 Thread Roy T. Fielding
. we *know* that versions of glibc 2.2 have const char ** instead of char ** so make that work without any hints.m4 stuff (which would have to look at the glibc version) Why not check for GCC and simply add -Werror to the compile? This should get RedHat 7.0 compiling cleanly, but I

Re: [PATCH] a somewhat different approach to the iconv() issue

2001-02-08 Thread Roy T. Fielding
well, in practice it isn't so excellent :( the template for AC_TRY_COMPILE() doesn't even compile without warnings int main() { configure:4111: warning: function declaration isn't a prototype So we write our own macro that does compile without warnings. What was checked in doesn't work

Re: [PATCH] a somewhat different approach to the iconv() issue

2001-02-09 Thread Roy T. Fielding
1) The #ifdef APR_ in xlate.c must be a #if Why is that? We generally use #ifdef FOO if FOO is sometimes defined and sometimes not (e.g., APR_ICONV_INBUF_CONST). We generally use #if FOO if FOO is always defined but sometimes to 1 and sometimes to 0 (e.g., APR_HAS_XLATE). Sorry, I

Re: cvs commit: apr CHANGES apr_common.m4

2001-02-09 Thread Roy T. Fielding
A key characteristic we need is to make sure that our assumption about const-ness compiles at all on the platform, whether or not gcc is being used. It is my understanding that certain platforms besides glibc-2.2+gcc-recent will fail the compile if the const-ness is wrong. IRIX was an

Re: build blues

2001-02-13 Thread Roy T. Fielding
Just a heads-up. I am still working on simplifying the build scripts. More changes are required for httpd than anything else, though I'd also like to streamline, name-protect, and make consistent the apr stuff. This is taking a lot longer than expected because the current setup has coupling

Re: build blues

2001-02-13 Thread Roy T. Fielding
On Tue, Feb 13, 2001 at 12:58:04AM -0800, Greg Stein wrote: Is it possible to get a partial checkin? That'll let us review pieces as they go (easier to do a small bit, than a huge one), and you won't have to worry about tracking other changes to the build system. The APR changes include

Re: [PATCH]: Use $(builddir)/build for @INCLUDE_RULES@

2001-02-20 Thread Roy T. Fielding
Just noticed that since the move of helper files to apr/build, vpath builds don't work anymore, since APR tries to include rules.mk from the srcdir, but it is generated in the builddir. This patch fixes that. Thanks, I've committed a variant of the patch. Roy

Re: [PATCH] allow using GNU make on BSDi

2001-02-20 Thread Roy T. Fielding
I think you need to use the special MAKE variable as defined by the AC_PROG_MAKE_SET macro, but otherwise it looks fine. The real test is to see if it works for Ben Laurie's machine. Roy On Mon, Feb 19, 2001 at 06:01:44PM -0500, Jeff Trawick wrote: will this work for Apache without making

Re: cvs commit: apr/build config.guess config.sub

2001-02-20 Thread Roy T. Fielding
On Sun, Feb 18, 2001 at 09:05:13PM -0800, Brian Behlendorf wrote: On Sun, 18 Feb 2001, Cliff Woolley wrote: I quote from config.guess (config.sub has the same block): As a special exception to the GNU General Public License, if you distribute this file as part of a program that

Re: httpd-2.0/apr/apr-util Code Freeze

2001-03-08 Thread Roy T. Fielding
I agree, the no-freeze model just doesn't work in this environment. The no-freeze model hasn't even been tested in this environment. It is necessary for the code to be in a stable state in order to do a release at any time, regardless of a freeze. At no time in the past six months has the code

Re: cvs commit: apr/build os2_libtool.m4

2001-03-31 Thread Roy T. Fielding
I have not tested this on OS/2, but it should work assuming that the emx environment is close enough to normal unix to run configure. This is basically what Jeff was saying we should do to support platforms that don't like libtool. Roy

Re: [PATCH] Libtool 1.3b detection

2001-04-12 Thread Roy T. Fielding
I just fixed this the right way. It should now work for all future versions, since it now excludes specific releases known to be bad rather than attempting to guess what future release numbers will look like. Roy

Re: Buckets destroy not cleaning up private structures?

2001-04-29 Thread Roy T. Fielding
All of the file descriptors should be closed when the connection closes. If you are not running multiple connections, you won't see the file descriptors closing correctly. Ummm, if a spider requests 100 different URLs on the same connection (one after another using persistent connection

Re: Buckets destroy not cleaning up private structures?

2001-04-29 Thread Roy T. Fielding
On Sat, Apr 28, 2001 at 09:12:16PM -0700, [EMAIL PROTECTED] wrote: the file is closed. We need a loop at the end of the core_output_filter that just does the conversion to a heap bucket. The logic should be that anything in the pipeline with a size greater than a minimum write (around 4KB I

Re: cvs commit: apr/test Makefile.in

2001-04-30 Thread Roy T. Fielding
Back out the last change to the Makefile in the test directory. Those changes broke the build in that directory. By backing them out, we can continue to build the test programs. Backing the changes out is fine, but those programs don't build now either. They haven't been buildable

Re: cvs commit: apr/test Makefile.in

2001-05-01 Thread Roy T. Fielding
I can build the test directory just fine on my machine. In fact, that is why I made the change. I needed to be able to run those test programs, and I couldn't. I wouldn't have checked it back in unless I could run the tests on my machine. Ah, my fault -- evidently, the three times I tried

Re: cvs commit: apr/test Makefile.in

2001-05-02 Thread Roy T. Fielding
Basically, the LINK macro would use LOCAL_LIBS and ALL_LIBS. The Makefile would just need to set LOCAL_LIBS. It may have been that I did the set after including rules.mk, so it didn't take. I don't think that would make any difference since the variables aren't evaluated until they are used.

Re: cvs commit: apr/test Makefile.in

2001-05-02 Thread Roy T. Fielding
I dislike that we are building the the test directory automatically now, but that's just my own personal opinion. Like I said in the commit, it may be a bad idea. I did it to be sure that it was building correctly and to get the clean done right. I can change it so that test is only done for

Re: cvs commit: apr/strings apr_snprintf.c

2001-05-04 Thread Roy T. Fielding
diff -u -r1.14 -r1.15 --- apr_snprintf.c 2001/04/27 18:36:06 1.14 +++ apr_snprintf.c 2001/05/03 16:51:05 1.15 @@ -807,7 +807,13 @@ /* * Modifier check */ - if (*fmt == 'q') { +if (strncmp(fmt, APR_INT64_T_FMT, +

Re: cvs commit: apr/network_io/unix sendrecv.c

2001-05-04 Thread Roy T. Fielding
We have asserts throughout the server these days. Do we want to remove them all? I want to remove them all, but won't do so until I've done all of the other things I want to do. The problem with asserts is that causing the server process to core dump is never a good idea, even when a person

Re: LIBS in apr-util

2001-05-07 Thread Roy T. Fielding
On Sun, May 06, 2001 at 02:46:44PM +0100, David Reid wrote: After all the work that Jeff has done on the OS/390 libtool, I've hacked it to death and have it running on BeOS:) It actually allows us to build APR as a shared object, and should allow us to also build apr-util as a shared object,

Re: A question about global pools

2001-05-09 Thread Roy T. Fielding
On Wed, May 09, 2001 at 02:45:34PM -0400, Christian Gross wrote: Hi I was experimenting with some code... Consider the following. apr_initialize(); if (apr_pool_create(context, NULL) != APR_SUCCESS) { printf( Could not allocate context\n); exit(

Re: APR shared memory requirements.

2001-05-09 Thread Roy T. Fielding
that may be the case, however when you don't enable POOL_DEBUG, it doesn't _do_ anything! the guarantees, esp. if the behaviour of the program is affected _by_ enabling POOL_DEBUG, are almost worthless. They only do one thing -- they tell the maintainer that someone just committed something

Re: cvs commit: apr/build mkdep.sh

2001-05-11 Thread Roy T. Fielding
Hum. On systems that don't necessarily have gcc, this is a breakage. However, this doesn't seem quite clean. Anyone have any better ideas? Yeah, just delete the file and move it into the Makefile depend: rule so that you can use $(CC) directly. Better yet, just figure out what the real

Re: libaprutil.la, libexpat.la, APRUTIL_EXPORT_LIBS

2001-05-16 Thread Roy T. Fielding
My opinion is that expat should not be included in apr-util because it is not dependent on apr or apr-util. It should be a --with-expat option instead. Roy

Re: libaprutil.la, libexpat.la, APRUTIL_EXPORT_LIBS

2001-05-16 Thread Roy T. Fielding
- Original Message - From: Roy T. Fielding [EMAIL PROTECTED] To: Jeff Trawick [EMAIL PROTECTED] Cc: dev@apr.apache.org Sent: Wednesday, May 16, 2001 2:17 PM Subject: Re: libaprutil.la, libexpat.la, APRUTIL_EXPORT_LIBS My opinion is that expat should not be included in apr-util

Re: Pools locking?

2001-05-17 Thread Roy T. Fielding
On Thu, May 17, 2001 at 05:03:29PM +0100, David Reid wrote: Did we ever do anything about the locking issue that Justin (ISTR) threw up when we build apr using threads? ISTR some emails but wasn't sure we ever actually fixed it, hence the question... Not yet. The fix is to remove the locking

Re: [PATCH] First pass at moving util_uri to apr-util...

2001-05-22 Thread Roy T. Fielding
I'm about to work on this. Give me a yell if someone else is already doing the moves of util_uri to apr-util. The plan is as Greg described. Roy

Re: [PATCH] First pass at moving util_uri to apr-util...

2001-05-22 Thread Roy T. Fielding
On Sun, May 20, 2001 at 06:52:18PM -0700, Greg Stein wrote: Since gen_uri_delims.lo is not destined for a library (.la), then it can/should simply use the .o suffix. That will also prevent the object from appearing within libaprutil.la. I committed it with the .o suffix, but that auto-slurping

Re: cvs commit: apr-util/test testdate.c

2001-05-31 Thread Roy T. Fielding
On Thu, May 31, 2001 at 05:14:42AM -, [EMAIL PROTECTED] wrote: jerenkrantz01/05/30 22:14:41 Modified:test testdate.c Log: APRized version of testdate. This is from my patch from a long time ago posted to new-httpd. There seems to be some subtle bugs that need to

Re: file/mmap buckets, subrequests, pools, 2.0.18

2001-06-08 Thread Roy T. Fielding
Bugger... wish I could avoid sending this to two lists, but I guess it does overlap. On Wed, Jun 06, 2001 at 01:04:29AM -0700, Greg Stein wrote: On Tue, Jun 05, 2001 at 11:25:43PM -0400, Cliff Woolley wrote: On Tue, 5 Jun 2001, Greg Stein wrote: ... The basic problem with the current

Re: cvs commit: apr/threadproc/unix thread.c

2001-06-09 Thread Roy T. Fielding
Argh! I also thought that the purpose of SMS was to replace malloc/free and not pools. If you want to replace pools, then the code should not be called apr_sms_blah. Pool is the name for our memory system -- pool does not, and never has, defined the type of memory behind it. pool is

Re: APR file_io/win32/readwrite.c

2001-06-20 Thread Roy T. Fielding
On Tue, Jun 19, 2001 at 08:30:13PM -0400, Cliff Woolley wrote: In the following lines from readwrite.c line 90, should the if() conditional clause really be an assignment, or is it a typo? It really seems like it should be an equality test to me... rv = apr_get_os_error();

Re: multithreaded pools?

2001-07-09 Thread Roy T. Fielding
ok studying the mpm threaded.c code i see that we give each thread a sub_pool of pchild. but i think the following patch would be safe, because each thread won't exit until it has done its own cleanup. The last time I looked at the pool code it was bogus because clean_child_exit assumed every

Re: multithreaded pools?

2001-07-09 Thread Roy T. Fielding
On Sun, Jul 08, 2001 at 11:23:56PM -0700, dean gaudet wrote: On Sun, 8 Jul 2001, Roy T. Fielding wrote: The last time I looked at the pool code it was bogus because clean_child_exit how can clean_child_exit ever hope to work in a multithreaded server without async notification

Re: Why host_alias?

2001-07-09 Thread Roy T. Fielding
I agree that $host should be used, but $OS is not the same as $host. I'll try replacing host_alias when I get a chance. Looking at the autoconf code, though, I am wondering if we should be using $target instead. Roy

Re: Upgrading apr to autoconf 2.50 and libtool 1.4

2001-07-17 Thread Roy T. Fielding
Humm, I don't seem to be having much luck getting this autoconf and libtool upgrade patch accepted. Is there a specific reason this patch was not added? It does not require anything new Yes, the patch makes a whole bunch of changes to the MM configure, which only Ralf wants to maintain and he

Re: [PATCH] Add reentrant gethostbyname call

2001-07-20 Thread Roy T. Fielding
The only possible optimization would be the size of the temporary buffer (currently 256). Roy mentioned that the address array in hostent has a maximum of 10 entries. If so, the size of the structure plus the maximum size of the array (10 entries) may be sufficient. If we send in a too

Re: [PATCH] Allow use of pthread related code without threads.

2001-07-27 Thread Roy T. Fielding
On Thu, Jul 26, 2001 at 04:31:53PM -0700, Aaron Bannert wrote: Does having threads mean we require _REENTRANT to be defined (on Solaris)? My followup to that question is: does having _REENTRANT defined change the way anything operates in a way that we aren't expecting? It must be defined

Re: Conditionals...

2001-08-03 Thread Roy T. Fielding
Simply reading from a shared variable is not atomic. All accesses to a shared variable must be synchronized (or serialized, if you prefer) with some form of mutual exclusion. (An example of this is on Solaris/Sparc, where a context switch can occur half-way through an update to a longword (or

Re: FW: [Bug 2991] New: - -lsendfile not used when building mod_webapp.so on Solaris 8 7/01

2001-08-06 Thread Roy T. Fielding
Oh, apxs doesn't know about this file. Yuck. I think that apache-1.3 As I've mentioned maybe a dozen times over the past six months, apxs does not work in 2.0. It needs to be taught how to use config_vars.mk or, at the very least, all of its current symbols need to be replaced with those used

Re: apr_bucket_destroy APR memory management

2001-08-08 Thread Roy T. Fielding
On Sat, Aug 04, 2001 at 12:14:28AM -0400, Cliff Woolley wrote: On Fri, 3 Aug 2001, Roy T. Fielding wrote: If you can morph a bucket type to another bucket type, then you already know what the two types are and hence whether or not they will have the same free function. Otherwise, the act

Re: apr_bucket_destroy APR memory management

2001-08-08 Thread Roy T. Fielding
I would think that the bucket memory allocator and the bucket memory deallocator would have to be consistent. Put it in the pool. Huh? What pool? The pool that would need to be in the bucket structure if you want to support morphing of buckets. Never mind. The short answer is: don't

Re: [PATCH] LDAP extension to apr-util (take 2)

2001-08-13 Thread Roy T. Fielding
I'm all for a new apr-ldap CVS module / library. But its presence in APRUTIL feels very questionable to me. Well, since I feel the same way about everything in apr-util, I'm not sure if I agree or disagree with Greg. I think it belongs in httpd-ldap, for the same reason, but if apr-util is

Re: Handholding: shared memory

2001-08-13 Thread Roy T. Fielding
shouldn't this wait until we roll out a beta/GA? No. MM must be removed before GA or it cannot ever be removed. 2.0.23 can go out as beta right now. This should be committed right now so that I can remove MM and cut our configure processing time in half. Roy

Re: [PATCH] LDAP extension to apr-util (take 2)

2001-08-13 Thread Roy T. Fielding
Ok, I propose this: - The linking-to-miriad-of-different-ldap-libraries function, and the small bit in apr_ldap_compat.c that smooths out differences between functions in LDAP v2 and v3 should go in APR-util (or APR?). (This patch is small and easy to review.) +1 - The LDAP

Re: cvs commit: httpd-test/flood config.h.in configure.in flood.c flood_round_robin.c

2001-08-24 Thread Roy T. Fielding
I don't see a problem adding a PRNG into APR as long as we have a by default good one available with known characteristics. -- justin Um... APR *already* has random stuff in there. It can build against the truerand library, and it can use the /dev/random device. If we have a small hunk

Re: [Fwd: brianp patch Quantify results] (was thread-specific freelistfor pools patch )

2001-08-25 Thread Roy T. Fielding
For the pools code, it can only be patched. It is unacceptable to toss a completely written-from-scratch replacement into the code base. If it takes a sequence of 20 patches to reach the written-from-scratch stage, then fine... but that means each step has been reviewable as you go along.

Re: Pools, possible replacement, WAS: RE: [Fwd: brianp patch Quantify results]

2001-08-25 Thread Roy T. Fielding
BTW can flood simulate a steady # of requests being attempted per second? or does it just fire up N threads/processes and whack away. ( check out http://www.cs.rice.edu/CS/Systems/Web-measurement/ for more info) Heh, nice coincidence -- I printed that paper out earlier today and gave Justin

Re: apr_bucket_simple_split

2001-08-27 Thread Roy T. Fielding
No. There really aren't many sendfile implementations that allow you to transmit more than an apr_size_t, if you start digging the man pages. Afraid this was a concensus decision make while you were on holiday. Ummm, no it wasn't. You mentioned it on the mailing list and both Bill and I said

Re: apr_bucket_simple_split

2001-08-27 Thread Roy T. Fielding
As with Roy, I am entirely for consistency of the API, and the work that you did to clean it up is Good. But apr_off_t is the real, potential size of a bucket's data. In other words, if the portability library isn't abstracting this under the covers, then it isn't much of a portability

Re: [PATCH] performance fix for time offset computation

2001-08-28 Thread Roy T. Fielding
On Tue, Aug 28, 2001 at 11:15:41AM -0700, Brian Pane wrote: Here's a new version of the get_offset patch that initializes the TZ offset from apr_initialize. I've attached the new include file that it uses, apr/include/arch/unix/internal_time.h Out of curiosity, what happens when we switch

Re: [PATCH] performance fix for time offset computation

2001-08-29 Thread Roy T. Fielding
On Tue, Aug 28, 2001 at 03:16:42PM -0700, Brian Pane wrote: Roy T. Fielding wrote: On Tue, Aug 28, 2001 at 11:15:41AM -0700, Brian Pane wrote: Here's a new version of the get_offset patch that initializes the TZ offset from apr_initialize. I've attached the new include file that it uses

Re: [PATCH] performance fix for time offset computation

2001-08-29 Thread Roy T. Fielding
On Wed, Aug 29, 2001 at 10:19:40AM -0400, Greg Marr wrote: At 10:05 AM 08/29/2001, William A Rowe wrote: At 07:36 PM 08/28/2001, Roy T. Fielding wrote: On Tue, Aug 28, 2001 at 03:16:42PM -0700, Brian Pane wrote: As far as I can tell, the result of the calculation should be independent

Re: cvs commit: apr/build apr_hints.m4

2001-09-26 Thread Roy T. Fielding
On Sat, Sep 22, 2001 at 08:23:21PM -, [EMAIL PROTECTED] wrote: gstein 01/09/22 13:23:21 Modified:.configure.in buildapr_hints.m4 Log: AC_PROG_CC can only be used once within a configure script (at least with autoconf 2.52). Shift the

Re: [PROPOSAL] apr-client

2001-09-27 Thread Roy T. Fielding
And, in discussions with Roy, I think he was thinking a client library should be a part of httpd not APR. But, I don't care one way or another. -- justin Nah. This has utility outside of httpd. Specifically, Subversion is an excellent candidate. I also know that Covalent has a similar

Re: [PROPOSAL] apr-client

2001-09-27 Thread Roy T. Fielding
Independent of httpd effectively means APR. I guess you could be an httpd subproject, but this has nothing to do with an HTTP server. [ there is no way the board would establish a new PMC for this, speaking as one of those board members :-) ] I don't see why. I don't believe umbrella

Re: Granularity of mtime

2001-10-13 Thread Roy T. Fielding
On Fri, Oct 12, 2001 at 05:22:04PM -0700, Dirk-Willem van Gulik wrote: Is there a way to ask APR what the granularity is ? Is it right to assume that the reason you need this is so that the httpd will mark a message with a Date that is later than the Last-Modified, hence avoiding problems

Re: [PATCH] APR Socket IOL

2001-11-08 Thread Roy T. Fielding
What you are suggesting will not work at all. There are apr_socket(and related) calls in places other than the core_*_filters. And it is not safe to make these calls (which will call BSD socket network io system calls) using descriptors from a different network interface. Then I would

Re: [PATCH] APR Socket IOL

2001-11-09 Thread Roy T. Fielding
I have an socket-like API. I need to issue my_accept(), my_setsockopt(), my_recv(), my_send(), my_sendfile(), et. al. These calls are scattered all across httpd. Are you saying I need an accept() filter, a recv() filter, et. al? Or that there needs to be a set of generic filter APIs

Re: random number generation

2001-12-31 Thread Roy T. Fielding
Just to back up what Ben said (but with a little more explanation for those of us who don't work in bomb shelters for a living), the true randomness of the initialization function is necessary to maintain the strong encryption characteristics of SSL. If we make any attempt to reduce the entropy

Re: cvs commit: apr/misc/win32 rand.c

2001-12-31 Thread Roy T. Fielding
On Sun, Dec 30, 2001 at 07:50:47PM -, [EMAIL PROTECTED] wrote: --- rand.c 29 Dec 2001 03:33:49 - 1.11 +++ rand.c 30 Dec 2001 19:50:46 - 1.12 @@ -62,8 +62,10 @@ HCRYPTPROV hProv; apr_status_t res = APR_SUCCESS; +/* 0x40 bit =

fails to compile dbm

2002-01-17 Thread Roy T. Fielding
The build on Linux is broken at make[4]: Entering directory `/home/fielding/ws/httpd-2.0/srclib/apr-util/dbm' /bin/sh /home/fielding/ws/httpd-2.0/srclib/apr/libtool --silent --mode=compile gcc -g -O2 -Wall -Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -pthread -Werror

Re: fails to compile dbm

2002-01-18 Thread Roy T. Fielding
(rd)); dberr = 0; } I've also attached it. Cheers, -g On Thu, Jan 17, 2002 at 03:42:38PM -0800, Roy T. Fielding wrote: The build on Linux is broken at make[4]: Entering directory `/home/fielding/ws/httpd-2.0/srclib/apr-util/dbm' /bin/sh /home/fielding/ws/httpd

Re: expat config.*

2002-04-19 Thread Roy T. Fielding
If the copyright holders of those files are content to let us make those changes (clearly marked as with apr's copy of these files) and then distribute the modified files with an exception to the GPL, that is one thing. However, in the new config.guess/config.sub files checked in for expat I'm not

libtool fails version check in expat

2002-04-27 Thread Roy T. Fielding
Making all in expat /bin/sh ../libtool --mode=compile cc -DHAVE_CONFIG_H -DPACKAGE='expat' -DVERSION='expat_1.95.2' -I/Users/fielding/ws/httpd-2.0/srclib/apr-util/ xml/expat/lib -I.. -I/Users/fielding/ws/httpd-2.0/srclib/apr- util/xml/expat/lib -g -O2 -c xmlparse.c libtool: ltconfig version `'

Darwin strangeness on apr_exports.h

2002-04-27 Thread Roy T. Fielding
I have no idea what this is supposed to be doing, but it is doing it wrong. During make, after building apr, using vanilla awk: ~/ws/httpd-2.0/srclib/apr/.libs ~/ws/httpd-2.0/srclib/apr/.libs ~/ws/httpd-2.0/srclib/apr/.libs awk -f /Users/fielding/ws/httpd-2.0/srclib/apr/build/make_var_export.awk

Darwin strangeness on export_vars.h (what I meant)

2002-04-27 Thread Roy T. Fielding
I have no idea what this is supposed to be doing, but it is doing it wrong. During make, after building apr, using vanilla awk: ~/ws/httpd-2.0/srclib/apr/.libs ~/ws/httpd-2.0/srclib/apr/.libs ~/ws/httpd-2.0/srclib/apr/.libs awk -f /Users/fielding/ws/httpd-2.0/srclib/apr/build/make_var_export.awk

Re: libtool fails version check in expat

2002-04-27 Thread Roy T. Fielding
ltmain.sh is not in the repository for expat - this comes from (g)libtoolize when running apr-util/xml/expat/buildconf.sh. I bet you ran buildconf with 1.3.5, tried to build APR, it failed, you installed Pier's stuff to get 1.4+, reran buildconf and then ran into this. Hmmm, I'm pretty sure I was

apr_time_t -- apr_time_usec_t

2002-06-10 Thread Roy T. Fielding
I am tired of seeing this stupid change to the semantics of time_t under Unix continue to cause bugs in every project that uses APR. apr_time_t must be in seconds. If folks want APR to keep time in microseconds, then they had bloody well change the type name accordingly. I know of one existing

Re: apr_time_t -- apr_time_usec_t

2002-06-11 Thread Roy T. Fielding
On Monday, June 10, 2002, at 04:11 PM, William A. Rowe, Jr. wrote: At 05:04 PM 6/10/2002, you wrote: I am tired of seeing this stupid change to the semantics of time_t under Unix continue to cause bugs in every project that uses APR. I must have missed that discussion traveling. Pointers please?

Re: cvs commit: apr/include apr_time.h

2002-06-12 Thread Roy T. Fielding
There is no reason for them to be all-uppercase. I hate it when people use uppercase for functions, including macro functions. All-uppercase is a convention for symbolic constants, not functions. Roy

Re: [PATCH] speed up network timeout processing

2002-07-06 Thread Roy T. Fielding
If that was all we were doing, I would agree with you. But `Jeff's patch implements BOTH select and poll with an #ifdef, because not every platform has poll(). This is exactly the reason for having apr_poll(), and not using it is stupid. If the argument is performance, then back it up with

why apr_size_t?

2002-07-12 Thread Roy T. Fielding
As near as I can tell from looking at the code and cvs logs, the only reason we have apr_size_t and apr_ssize_t is because win32 wants to define apr_ssize_t. Is that because win32 doesn't have ssize_t? Is there a reason why we don't simply define ssize_t on that platform? Roy

Re: cvs commit: apr STATUS

2002-07-12 Thread Roy T. Fielding
I will say the very same thing Ryan did several weeks [months?] ago. Where were you for the last two years? Complaining about how fucked up the design decisions were for apr_time_t. Its in the archives. People didn't want to deal with it before due to more pressing concerns. 2.0 is now out, so

Re: cvs commit: apr STATUS

2002-07-12 Thread Roy T. Fielding
Um, Roy? WTF are you talking about? From apr/time/unix/time.c: APR_DECLARE(apr_time_t) apr_time_now(void) { struct timeval tv; gettimeofday(tv, NULL); return tv.tv_sec * APR_USEC_PER_SEC + tv.tv_usec; } And as for demonstrated needs, you're thinking too Apache-centric by a longshot.

Re: cvs commit: apr STATUS

2002-07-12 Thread Roy T. Fielding
Irrelevant. If you want httpd to use APR, then it had better not make httpd worse for no good reason. If there is a reason, then I want it documented in the code. If not, if it is just the whim of some folks using APR, then I will fork the httpd project away from APR. Roy, isn't this a bit of

Re: cvs commit: apr STATUS

2002-07-13 Thread Roy T. Fielding
On Friday, July 12, 2002, at 07:05 PM, William A. Rowe, Jr. wrote: At 08:49 PM 7/12/2002, [EMAIL PROTECTED] wrote: 2) Renaming the function to get rid of apr_time_t vs time_t confusion, but keep it ambigious and make no contract with the user about the units

Re: [SUMMARY] time discussion

2002-07-13 Thread Roy T. Fielding
A fine summary of the situation. On Friday, July 12, 2002, at 12:42 PM, William A. Rowe, Jr. wrote: I. We represent all time quantum in the same scale throughout APR. That scale is in microseconds. Which is goodness, because we don't ever have to go back to docs and ask, Does that function

Re: cvs commit: apr-util/include apr_xlate.h apu.h.in apu.hnw apu.hw

2002-07-19 Thread Roy T. Fielding
Ugh. Is there some reason we don't use normal symbol wrappers instead of this macro argument name replacement stuff? Roy On Friday, July 19, 2002, at 01:32 AM, [EMAIL PROTECTED] wrote: +#if APR_HAS_APR_ICONV +#define HAVE_ICONV +#define iconv_(n) apr_iconv_##n +#else +#define

Re: [PATCH] Re: 2.0 performance Re: Breaking something? Now is the time?

2002-07-01 Thread Roy T. Fielding
A better optimization might be to reduce the number of calls to brigade_puts. That's how much of 1.3 was improved. Roy

[PATCH] fix a bogus warning in poll.c

2002-08-10 Thread Roy T. Fielding
The warning is simply because gcc can't follow conditionals, but this should be a safe fix if nobody minds. Roy Index: poll.c === RCS file: /home/cvs/apr/poll/unix/poll.c,v retrieving revision 1.28 diff -u -r1.28 poll.c --- poll.c

Re: Versioning before time please

2002-08-14 Thread Roy T. Fielding
Oh, for crying out loud. Apps do not need microsecond resolution for time since epoch. None of them do. They need microsecond resolution for small interval timers. The vast majority of APR time usages are for epoch times or intervals in seconds. There is nothing that the app can do to work

Re: cvs commit: apr/build get-version.sh

2002-08-16 Thread Roy T. Fielding
On Wednesday, August 14, 2002, at 10:34 PM, [EMAIL PROTECTED] wrote: if test $1 = all; then echo ${major}.${minor}.${patch} elif test $1 = major; then echo ${major} +elif test $1 = libtool; then + echo ${minor}:${patch}:${minor} I don't think that's what you meant to do.

exports.c dependencies

2003-04-01 Thread Roy T. Fielding
I have been trying to fix a simple warning in httpd 2.1 and am getting stuck in spaghetti. apr_sendfile is being exported even when it is not usable, and as a result there is no declaration prior to implementation of the function in network_io. So, I fix that and find that it won't build because

Re: cvs commit: apr/atomic/solaris_sparc apr_atomic_sparc.s

2003-04-30 Thread Roy T. Fielding
This code was licensed under version 1.0 of the Mozilla Public License (which is a copyleft and a lot more restrictive than the ASL). And not approved for distribution by Apache projects. You will need to get the version that is released as MPL 1.1 or a new license from Mike Bennett, or

Re: [PATCH] Convenience macros for apr array manipulation

2003-12-13 Thread Roy T. Fielding
+#define APR_ARRAY_PUSH(arr, type, item) \ A macro that is intended to mimic the behavior of a function call should always be named in the same way as function calls, not with all-uppercase names. Stuff like the above makes the interface entirely dependent on the implementation, and makes the

Re: apr/apr-util python dependence

2004-02-20 Thread Roy T. Fielding
However I completely disagree that Python (or Perl or PHP) is a good choice for use in build systems. As part of the configure process, I would agree with you, but as part of buildconf, I disagree--not everyone needs to run buildconf--only developers, and if you're a developer, it's

Re: gdbm licence issue

2004-02-26 Thread Roy T. Fielding
Use of the API is usually interpreted as forming a derivative work under copyright law, and I'm certain it's the FSF's interpretation, which is what counts here. Actually, no, the FSF is the only legal entity known to mankind that interprets copyright law in that fashion, and has so far avoided

  1   2   >